114596 2013-04-14 15:57:13 -0700 Do not generate parameter names in WebKitIDL C++ bindings 2014-02-05 11:23:29 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 0 costan webkit-unassigned alecflett cdumez commit-queue dgrogan eric.carlson jer.noble jsbell kling tonikitoo oldest_to_newest 875411 0 costan 2013-04-14 15:57:13 -0700 Currently, the C++ WebKitIDL code generator adds parameter names to the function declarations in headers. This upsets the WebKit style checker, so WebKitIDL changes that re-generate the bindings (as they should) automatically fail the style checks. This bug will receive a patch that removes the parameter names, to make life easier for future WebKitIDL changes. 875413 1 198013 costan 2013-04-14 16:05:39 -0700 Created attachment 198013 Patch 875415 2 costan 2013-04-14 16:10:49 -0700 Sorry, my initial description is incorrect. Only the test cases for the WebKitIDL code generator are checked in, which means only patches that change the generators, like [20141], will get flagged by the style checker. Nevertheless, it would be nice to not have this problem. [20141] https://bugs.webkit.org/show_bug.cgi?id=20141 876001 3 198013 bfulgham 2013-04-15 12:34:35 -0700 Comment on attachment 198013 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198013&action=review I like the intent behind this change, but I'm wondering if we might need something more sophisticated. When we have multiple arguments of the same type, it seems like we SHOULD have an argument name to document what the different parameters are meant to do. Although the current labels are not all that helpful, some of them could be changed to be more descriptive. If the IDL does not provide an argument name, will the generator produce the desired output? Maybe fixing/adjusting the IDL would be a good thing to do instead/in addition? > Source/WebCore/bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:-56 > - void multiTransferList(const WebDOMString& first, const WebDOMArray& tx, const WebDOMString& second, const WebDOMArray& txx); Is it really improper to have some context for these arguments? How do we know what the first and second WebDOMStrings are supposed to represent? Maybe it's not always improper to have a label (although these labels are not very helpful!) 977001 4 kling 2014-02-05 11:23:29 -0800 The C++ bindings have been removed. 198013 2013-04-14 16:05:39 -0700 2014-02-05 11:23:13 -0800 Patch bug-114596-20130414190514.patch text/plain 13911 costan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODQxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA0LTE0ICBWaWN0b3Ig Q29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KKworICAgICAgICBEbyBub3QgZ2VuZXJhdGUgcGFy YW1ldGVyIG5hbWVzIGluIFdlYktpdElETCBDKysgYmluZGluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDU5NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RlZCBieSBydW5uaW5nIC4vVG9vbHMv U2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMgLS1yZXNldC1yZXN1bHRzIGFuZCBjaGVja2luZyBz dm4gZGlmZiwgdGhlbiBidWlsZGluZyBXZWJLaXQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JDUFAucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6IHJlbW92 ZWQgdGhlIGNvZGUgdGhhdCBnZW5lcmF0ZWQgbmFtZXMgZm9yIGZ1bmN0aW9uIHBhcmFtZXRlcnMK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTUZsb2F0NjRBcnJheS5o OiByZS1nZW5lcmF0ZWQgd2l0aG91dCBmdW5jdGlvbiBwYXJhbWV0ZXIgbmFtZXMKKyAgICAgICAg KiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRlc3RBY3RpdmVET01PYmplY3QuaDog cmUtZ2VuZXJhdGVkIHdpdGhvdXQgZnVuY3Rpb24gcGFyYW1ldGVyIG5hbWVzCisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suaDogcmUtZ2VuZXJh dGVkIHdpdGhvdXQgZnVuY3Rpb24gcGFyYW1ldGVyIG5hbWVzCisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q3VzdG9tTmFtZWRHZXR0ZXIuaDogcmUtZ2VuZXJh dGVkIHdpdGhvdXQgZnVuY3Rpb24gcGFyYW1ldGVyIG5hbWVzCisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0RXZlbnRUYXJnZXQuaDogcmUtZ2VuZXJhdGVkIHdp dGhvdXQgZnVuY3Rpb24gcGFyYW1ldGVyIG5hbWVzCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0NQUC9XZWJET01UZXN0TWVkaWFRdWVyeUxpc3RMaXN0ZW5lci5oOiByZS1nZW5lcmF0 ZWQgd2l0aG91dCBmdW5jdGlvbiBwYXJhbWV0ZXIgbmFtZXMKKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRlc3RPYmouaDogcmUtZ2VuZXJhdGVkIHdpdGhvdXQgZnVu Y3Rpb24gcGFyYW1ldGVyIG5hbWVzCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQ UC9XZWJET01UZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlLmg6IHJlLWdlbmVyYXRl ZCB3aXRob3V0IGZ1bmN0aW9uIHBhcmFtZXRlciBuYW1lcworICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdFR5cGVkZWZzLmg6IHJlLWdlbmVyYXRlZCB3aXRob3V0 IGZ1bmN0aW9uIHBhcmFtZXRlciBuYW1lcworCiAyMDEzLTA0LTE0ICBBbmRyZWFzIEtsaW5nICA8 YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBIYXd0Zml4IE1hYyBidWlsZC4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckNQUC5wbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JDUFAu cG0JKHJldmlzaW9uIDE0ODQxMikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckNQUC5wbQkod29ya2luZyBjb3B5KQpAQCAtNDg1LDEyICs0ODUsMTEgQEAg c3ViIEdlbmVyYXRlSGVhZGVyCiAgICAgICAgICAgICBteSAkZnVuY3Rpb25TaWcgPSAiJHJldHVy blR5cGUgJGZ1bmN0aW9uTmFtZSgiOwogICAgICAgICAgICAgbXkgJG1ldGhvZE5hbWUgPSAkZnVu Y3Rpb25OYW1lOwogICAgICAgICAgICAgZm9yZWFjaCBteSAkcGFyYW0gKEB7JGZ1bmN0aW9uLT5w YXJhbWV0ZXJzfSkgewotICAgICAgICAgICAgICAgIG15ICRwYXJhbU5hbWUgPSAkcGFyYW0tPm5h bWU7CiAgICAgICAgICAgICAgICAgbXkgJHBhcmFtVHlwZSA9IEdldENQUFR5cGUoJHBhcmFtLT50 eXBlLCAxKTsKICAgICAgICAgICAgICAgICAkdHlwZXNUb0ZvcndhcmREZWNsYXJleyRwYXJhbS0+ dHlwZX0gPSAxOwogCiAgICAgICAgICAgICAgICAgJGZ1bmN0aW9uU2lnIC49ICIsICIgaWYgJHBh cmFtZXRlckluZGV4ID49IDE7Ci0gICAgICAgICAgICAgICAgJGZ1bmN0aW9uU2lnIC49ICIkcGFy YW1UeXBlICRwYXJhbU5hbWUiOworICAgICAgICAgICAgICAgICRmdW5jdGlvblNpZyAuPSAkcGFy YW1UeXBlOwogICAgICAgICAgICAgICAgICRwYXJhbWV0ZXJJbmRleCsrOwogICAgICAgICAgICAg fQogICAgICAgICAgICAgJGZ1bmN0aW9uU2lnIC49ICIpIjsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NRmxvYXQ2NEFycmF5LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01GbG9h dDY0QXJyYXkuaAkocmV2aXNpb24gMTQ4NDEyKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy90ZXN0L0NQUC9XZWJET01GbG9hdDY0QXJyYXkuaAkod29ya2luZyBjb3B5KQpAQCAt MzksNyArMzksNyBAQCBwdWJsaWM6CiAgICAgZXhwbGljaXQgV2ViRE9NRmxvYXQ2NEFycmF5KFdU Rjo6RmxvYXQ2NEFycmF5Kik7CiAgICAgdmlydHVhbCB+V2ViRE9NRmxvYXQ2NEFycmF5KCkgeyB9 CiAKLSAgICBXZWJET01JbnQzMkFycmF5IGZvbyhjb25zdCBXZWJET01GbG9hdDMyQXJyYXkmIGFy cmF5KTsKKyAgICBXZWJET01JbnQzMkFycmF5IGZvbyhjb25zdCBXZWJET01GbG9hdDMyQXJyYXkm KTsKIAogICAgIFdURjo6RmxvYXQ2NEFycmF5KiBpbXBsKCkgY29uc3Q7CiB9OwpJbmRleDogU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0QWN0aXZlRE9N T2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0NQUC9XZWJET01UZXN0QWN0aXZlRE9NT2JqZWN0LmgJKHJldmlzaW9uIDE0ODQxMikKKysr IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdEFjdGl2 ZURPTU9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw4ICs0Miw4IEBAIHB1YmxpYzoKIAog ICAgIGludCBleGNpdGluZ0F0dHIoKSBjb25zdDsKIAotICAgIHZvaWQgZXhjaXRpbmdGdW5jdGlv bihjb25zdCBXZWJET01Ob2RlJiBuZXh0Q2hpbGQpOwotICAgIHZvaWQgcG9zdE1lc3NhZ2UoY29u c3QgV2ViRE9NU3RyaW5nJiBtZXNzYWdlKTsKKyAgICB2b2lkIGV4Y2l0aW5nRnVuY3Rpb24oY29u c3QgV2ViRE9NTm9kZSYpOworICAgIHZvaWQgcG9zdE1lc3NhZ2UoY29uc3QgV2ViRE9NU3RyaW5n Jik7CiAKICAgICBXZWJDb3JlOjpUZXN0QWN0aXZlRE9NT2JqZWN0KiBpbXBsKCkgY29uc3Q7CiAK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVz dENhbGxiYWNrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJhY2suaAkocmV2aXNpb24gMTQ4NDEyKQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q2FsbGJhY2su aAkod29ya2luZyBjb3B5KQpAQCAtNDgsMTIgKzQ4LDEyIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IH5XZWJET01UZXN0Q2FsbGJhY2soKTsKIAogICAgIGJvb2wgY2FsbGJhY2tXaXRoTm9QYXJhbSgp OwotICAgIGJvb2wgY2FsbGJhY2tXaXRoQ2xhc3MxUGFyYW0oY29uc3QgV2ViRE9NQ2xhc3MxJiBj bGFzczFQYXJhbSk7Ci0gICAgYm9vbCBjYWxsYmFja1dpdGhDbGFzczJQYXJhbShjb25zdCBXZWJE T01DbGFzczImIGNsYXNzMlBhcmFtLCBjb25zdCBXZWJET01TdHJpbmcmIHN0ckFyZyk7Ci0gICAg aW50IGNhbGxiYWNrV2l0aE5vbkJvb2xSZXR1cm5UeXBlKGNvbnN0IFdlYkRPTUNsYXNzMyYgY2xh c3MzUGFyYW0pOwotICAgIGJvb2wgY2FsbGJhY2tXaXRoU3RyaW5nTGlzdChjb25zdCBXZWJET01E T01TdHJpbmdMaXN0JiBsaXN0UGFyYW0pOwotICAgIGJvb2wgY2FsbGJhY2tXaXRoQm9vbGVhbihi b29sIGJvb2xQYXJhbSk7Ci0gICAgYm9vbCBjYWxsYmFja1JlcXVpcmVzVGhpc1RvUGFzcyhjb25z dCBXZWJET01DbGFzczgmIGNsYXNzOFBhcmFtLCBjb25zdCBXZWJET01UaGlzQ2xhc3MmIHRoaXND bGFzc1BhcmFtKTsKKyAgICBib29sIGNhbGxiYWNrV2l0aENsYXNzMVBhcmFtKGNvbnN0IFdlYkRP TUNsYXNzMSYpOworICAgIGJvb2wgY2FsbGJhY2tXaXRoQ2xhc3MyUGFyYW0oY29uc3QgV2ViRE9N Q2xhc3MyJiwgY29uc3QgV2ViRE9NU3RyaW5nJik7CisgICAgaW50IGNhbGxiYWNrV2l0aE5vbkJv b2xSZXR1cm5UeXBlKGNvbnN0IFdlYkRPTUNsYXNzMyYpOworICAgIGJvb2wgY2FsbGJhY2tXaXRo U3RyaW5nTGlzdChjb25zdCBXZWJET01ET01TdHJpbmdMaXN0Jik7CisgICAgYm9vbCBjYWxsYmFj a1dpdGhCb29sZWFuKGJvb2wpOworICAgIGJvb2wgY2FsbGJhY2tSZXF1aXJlc1RoaXNUb1Bhc3Mo Y29uc3QgV2ViRE9NQ2xhc3M4JiwgY29uc3QgV2ViRE9NVGhpc0NsYXNzJik7CiAKICAgICBXZWJD b3JlOjpUZXN0Q2FsbGJhY2sqIGltcGwoKSBjb25zdDsKIApJbmRleDogU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0Q3VzdG9tTmFtZWRHZXR0ZXIuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dl YkRPTVRlc3RDdXN0b21OYW1lZEdldHRlci5oCShyZXZpc2lvbiAxNDg0MTIpCisrKyBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRlc3RDdXN0b21OYW1lZEdl dHRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3IEBAIHB1YmxpYzoKICAgICBXZWJE T01UZXN0Q3VzdG9tTmFtZWRHZXR0ZXImIG9wZXJhdG9yPShjb25zdCBXZWJET01UZXN0Q3VzdG9t TmFtZWRHZXR0ZXImKTsKICAgICB2aXJ0dWFsIH5XZWJET01UZXN0Q3VzdG9tTmFtZWRHZXR0ZXIo KTsKIAotICAgIHZvaWQgYW5vdGhlckZ1bmN0aW9uKGNvbnN0IFdlYkRPTVN0cmluZyYgc3RyKTsK KyAgICB2b2lkIGFub3RoZXJGdW5jdGlvbihjb25zdCBXZWJET01TdHJpbmcmKTsKIAogICAgIFdl YkNvcmU6OlRlc3RDdXN0b21OYW1lZEdldHRlciogaW1wbCgpIGNvbnN0OwogCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRlc3RFdmVudFRhcmdl dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9D UFAvV2ViRE9NVGVzdEV2ZW50VGFyZ2V0LmgJKHJldmlzaW9uIDE0ODQxMikKKysrIFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdEV2ZW50VGFyZ2V0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTQwLDEwICs0MCwxMCBAQCBwdWJsaWM6CiAgICAgZXhwbGljaXQg V2ViRE9NVGVzdEV2ZW50VGFyZ2V0KFdlYkNvcmU6OlRlc3RFdmVudFRhcmdldCopOwogICAgIHZp cnR1YWwgfldlYkRPTVRlc3RFdmVudFRhcmdldCgpIHsgfQogCi0gICAgV2ViRE9NTm9kZSBpdGVt KHVuc2lnbmVkIGluZGV4KTsKLSAgICB2b2lkIGFkZEV2ZW50TGlzdGVuZXIoY29uc3QgV2ViRE9N U3RyaW5nJiB0eXBlLCBjb25zdCBXZWJET01FdmVudExpc3RlbmVyJiBsaXN0ZW5lciwgYm9vbCB1 c2VDYXB0dXJlKTsKLSAgICB2b2lkIHJlbW92ZUV2ZW50TGlzdGVuZXIoY29uc3QgV2ViRE9NU3Ry aW5nJiB0eXBlLCBjb25zdCBXZWJET01FdmVudExpc3RlbmVyJiBsaXN0ZW5lciwgYm9vbCB1c2VD YXB0dXJlKTsKLSAgICBib29sIGRpc3BhdGNoRXZlbnQoY29uc3QgV2ViRE9NRXZlbnQmIGV2dCk7 CisgICAgV2ViRE9NTm9kZSBpdGVtKHVuc2lnbmVkKTsKKyAgICB2b2lkIGFkZEV2ZW50TGlzdGVu ZXIoY29uc3QgV2ViRE9NU3RyaW5nJiwgY29uc3QgV2ViRE9NRXZlbnRMaXN0ZW5lciYsIGJvb2wp OworICAgIHZvaWQgcmVtb3ZlRXZlbnRMaXN0ZW5lcihjb25zdCBXZWJET01TdHJpbmcmLCBjb25z dCBXZWJET01FdmVudExpc3RlbmVyJiwgYm9vbCk7CisgICAgYm9vbCBkaXNwYXRjaEV2ZW50KGNv bnN0IFdlYkRPTUV2ZW50Jik7CiAKICAgICBXZWJDb3JlOjpUZXN0RXZlbnRUYXJnZXQqIGltcGwo KSBjb25zdDsKIH07CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv Q1BQL1dlYkRPTVRlc3RNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0TWVkaWFRdWVy eUxpc3RMaXN0ZW5lci5oCShyZXZpc2lvbiAxNDg0MTIpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRlc3RNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyLmgJ KHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDcgQEAgcHVibGljOgogICAgIFdlYkRPTVRlc3RN ZWRpYVF1ZXJ5TGlzdExpc3RlbmVyJiBvcGVyYXRvcj0oY29uc3QgV2ViRE9NVGVzdE1lZGlhUXVl cnlMaXN0TGlzdGVuZXImKTsKICAgICB2aXJ0dWFsIH5XZWJET01UZXN0TWVkaWFRdWVyeUxpc3RM aXN0ZW5lcigpOwogCi0gICAgdm9pZCBtZXRob2QoY29uc3QgV2ViRE9NTWVkaWFRdWVyeUxpc3RM aXN0ZW5lciYgbGlzdGVuZXIpOworICAgIHZvaWQgbWV0aG9kKGNvbnN0IFdlYkRPTU1lZGlhUXVl cnlMaXN0TGlzdGVuZXImKTsKIAogICAgIFdlYkNvcmU6OlRlc3RNZWRpYVF1ZXJ5TGlzdExpc3Rl bmVyKiBpbXBsKCkgY29uc3Q7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9DUFAvV2ViRE9NVGVzdE9iai5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9NVGVzdE9iai5oCShyZXZpc2lvbiAxNDg0 MTIpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRl c3RPYmouaAkod29ya2luZyBjb3B5KQpAQCAtMTU2LDI0ICsxNTYsMjQgQEAgcHVibGljOgogICAg IHZvaWQgc2V0TnVsbGFibGVTdHJpbmdWYWx1ZShpbnQpOwogCiAgICAgdm9pZCB2b2lkTWV0aG9k KCk7Ci0gICAgdm9pZCB2b2lkTWV0aG9kV2l0aEFyZ3MoaW50IGxvbmdBcmcsIGNvbnN0IFdlYkRP TVN0cmluZyYgc3RyQXJnLCBjb25zdCBXZWJET01UZXN0T2JqJiBvYmpBcmcpOworICAgIHZvaWQg dm9pZE1ldGhvZFdpdGhBcmdzKGludCwgY29uc3QgV2ViRE9NU3RyaW5nJiwgY29uc3QgV2ViRE9N VGVzdE9iaiYpOwogICAgIGludCBsb25nTWV0aG9kKCk7Ci0gICAgaW50IGxvbmdNZXRob2RXaXRo QXJncyhpbnQgbG9uZ0FyZywgY29uc3QgV2ViRE9NU3RyaW5nJiBzdHJBcmcsIGNvbnN0IFdlYkRP TVRlc3RPYmomIG9iakFyZyk7CisgICAgaW50IGxvbmdNZXRob2RXaXRoQXJncyhpbnQsIGNvbnN0 IFdlYkRPTVN0cmluZyYsIGNvbnN0IFdlYkRPTVRlc3RPYmomKTsKICAgICBXZWJET01UZXN0T2Jq IG9iak1ldGhvZCgpOwotICAgIFdlYkRPTVRlc3RPYmogb2JqTWV0aG9kV2l0aEFyZ3MoaW50IGxv bmdBcmcsIGNvbnN0IFdlYkRPTVN0cmluZyYgc3RyQXJnLCBjb25zdCBXZWJET01UZXN0T2JqJiBv YmpBcmcpOwotICAgIHZvaWQgbWV0aG9kV2l0aEVudW1BcmcoY29uc3QgV2ViRE9NVGVzdEVudW1U eXBlJiBlbnVtQXJnKTsKLSAgICBXZWJET01UZXN0T2JqIG1ldGhvZFRoYXRSZXF1aXJlc0FsbEFy Z3NBbmRUaHJvd3MoY29uc3QgV2ViRE9NU3RyaW5nJiBzdHJBcmcsIGNvbnN0IFdlYkRPTVRlc3RP YmomIG9iakFyZyk7Ci0gICAgdm9pZCBzZXJpYWxpemVkVmFsdWUoY29uc3QgV2ViRE9NU3RyaW5n JiBzZXJpYWxpemVkQXJnKTsKLSAgICB2b2lkIG9wdGlvbnNPYmplY3QoY29uc3QgV2ViRE9NRGlj dGlvbmFyeSYgb28sIGNvbnN0IFdlYkRPTURpY3Rpb25hcnkmIG9vbyk7CisgICAgV2ViRE9NVGVz dE9iaiBvYmpNZXRob2RXaXRoQXJncyhpbnQsIGNvbnN0IFdlYkRPTVN0cmluZyYsIGNvbnN0IFdl YkRPTVRlc3RPYmomKTsKKyAgICB2b2lkIG1ldGhvZFdpdGhFbnVtQXJnKGNvbnN0IFdlYkRPTVRl c3RFbnVtVHlwZSYpOworICAgIFdlYkRPTVRlc3RPYmogbWV0aG9kVGhhdFJlcXVpcmVzQWxsQXJn c0FuZFRocm93cyhjb25zdCBXZWJET01TdHJpbmcmLCBjb25zdCBXZWJET01UZXN0T2JqJik7Cisg ICAgdm9pZCBzZXJpYWxpemVkVmFsdWUoY29uc3QgV2ViRE9NU3RyaW5nJik7CisgICAgdm9pZCBv cHRpb25zT2JqZWN0KGNvbnN0IFdlYkRPTURpY3Rpb25hcnkmLCBjb25zdCBXZWJET01EaWN0aW9u YXJ5Jik7CiAgICAgdm9pZCBtZXRob2RXaXRoRXhjZXB0aW9uKCk7Ci0gICAgdm9pZCBhZGRFdmVu dExpc3RlbmVyKGNvbnN0IFdlYkRPTVN0cmluZyYgdHlwZSwgY29uc3QgV2ViRE9NRXZlbnRMaXN0 ZW5lciYgbGlzdGVuZXIsIGJvb2wgdXNlQ2FwdHVyZSk7Ci0gICAgdm9pZCByZW1vdmVFdmVudExp c3RlbmVyKGNvbnN0IFdlYkRPTVN0cmluZyYgdHlwZSwgY29uc3QgV2ViRE9NRXZlbnRMaXN0ZW5l ciYgbGlzdGVuZXIsIGJvb2wgdXNlQ2FwdHVyZSk7Ci0gICAgdm9pZCBtZXRob2RXaXRoT3B0aW9u YWxBcmcoaW50IG9wdCk7Ci0gICAgdm9pZCBtZXRob2RXaXRoTm9uT3B0aW9uYWxBcmdBbmRPcHRp b25hbEFyZyhpbnQgbm9uT3B0LCBpbnQgb3B0KTsKLSAgICB2b2lkIG1ldGhvZFdpdGhOb25PcHRp b25hbEFyZ0FuZFR3b09wdGlvbmFsQXJncyhpbnQgbm9uT3B0LCBpbnQgb3B0MSwgaW50IG9wdDIp OwotICAgIHZvaWQgbWV0aG9kV2l0aE9wdGlvbmFsU3RyaW5nKGNvbnN0IFdlYkRPTVN0cmluZyYg c3RyKTsKLSAgICB2b2lkIG1ldGhvZFdpdGhPcHRpb25hbFN0cmluZ0lzVW5kZWZpbmVkKGNvbnN0 IFdlYkRPTVN0cmluZyYgc3RyKTsKLSAgICB2b2lkIG1ldGhvZFdpdGhPcHRpb25hbFN0cmluZ0lz TnVsbFN0cmluZyhjb25zdCBXZWJET01TdHJpbmcmIHN0cik7CisgICAgdm9pZCBhZGRFdmVudExp c3RlbmVyKGNvbnN0IFdlYkRPTVN0cmluZyYsIGNvbnN0IFdlYkRPTUV2ZW50TGlzdGVuZXImLCBi b29sKTsKKyAgICB2b2lkIHJlbW92ZUV2ZW50TGlzdGVuZXIoY29uc3QgV2ViRE9NU3RyaW5nJiwg Y29uc3QgV2ViRE9NRXZlbnRMaXN0ZW5lciYsIGJvb2wpOworICAgIHZvaWQgbWV0aG9kV2l0aE9w dGlvbmFsQXJnKGludCk7CisgICAgdm9pZCBtZXRob2RXaXRoTm9uT3B0aW9uYWxBcmdBbmRPcHRp b25hbEFyZyhpbnQsIGludCk7CisgICAgdm9pZCBtZXRob2RXaXRoTm9uT3B0aW9uYWxBcmdBbmRU d29PcHRpb25hbEFyZ3MoaW50LCBpbnQsIGludCk7CisgICAgdm9pZCBtZXRob2RXaXRoT3B0aW9u YWxTdHJpbmcoY29uc3QgV2ViRE9NU3RyaW5nJik7CisgICAgdm9pZCBtZXRob2RXaXRoT3B0aW9u YWxTdHJpbmdJc1VuZGVmaW5lZChjb25zdCBXZWJET01TdHJpbmcmKTsKKyAgICB2b2lkIG1ldGhv ZFdpdGhPcHRpb25hbFN0cmluZ0lzTnVsbFN0cmluZyhjb25zdCBXZWJET01TdHJpbmcmKTsKICNp ZiBFTkFCTEUoQ29uZGl0aW9uMSkKICAgICBXZWJET01TdHJpbmcgY29uZGl0aW9uYWxNZXRob2Qx KCk7CiAjZW5kaWYKQEAgLTE4NCwyNCArMTg0LDI0IEBAIHB1YmxpYzoKICAgICB2b2lkIGNvbmRp dGlvbmFsTWV0aG9kMygpOwogI2VuZGlmCiAgICAgdm9pZCBjbGFzc01ldGhvZCgpOwotICAgIGlu dCBjbGFzc01ldGhvZFdpdGhPcHRpb25hbChpbnQgYXJnKTsKKyAgICBpbnQgY2xhc3NNZXRob2RX aXRoT3B0aW9uYWwoaW50KTsKICNpZiBFTkFCTEUoQ29uZGl0aW9uMSkKLSAgICB2b2lkIG92ZXJs b2FkZWRNZXRob2QxKGludCBhcmcpOworICAgIHZvaWQgb3ZlcmxvYWRlZE1ldGhvZDEoaW50KTsK ICNlbmRpZgogI2lmIEVOQUJMRShDb25kaXRpb24xKQotICAgIHZvaWQgb3ZlcmxvYWRlZE1ldGhv ZDEoY29uc3QgV2ViRE9NU3RyaW5nJiB0eXBlKTsKKyAgICB2b2lkIG92ZXJsb2FkZWRNZXRob2Qx KGNvbnN0IFdlYkRPTVN0cmluZyYpOwogI2VuZGlmCi0gICAgdm9pZCBjb252ZXJ0MShjb25zdCBX ZWJET01hJiB2YWx1ZSk7Ci0gICAgdm9pZCBjb252ZXJ0Mihjb25zdCBXZWJET01iJiB2YWx1ZSk7 Ci0gICAgdm9pZCBjb252ZXJ0NChjb25zdCBXZWJET01kJiB2YWx1ZSk7Ci0gICAgdm9pZCBjb252 ZXJ0NShjb25zdCBXZWJET01lJiB2YWx1ZSk7CisgICAgdm9pZCBjb252ZXJ0MShjb25zdCBXZWJE T01hJik7CisgICAgdm9pZCBjb252ZXJ0Mihjb25zdCBXZWJET01iJik7CisgICAgdm9pZCBjb252 ZXJ0NChjb25zdCBXZWJET01kJik7CisgICAgdm9pZCBjb252ZXJ0NShjb25zdCBXZWJET01lJik7 CiAgICAgV2ViRE9NU1ZHUG9pbnQgbXV0YWJsZVBvaW50RnVuY3Rpb24oKTsKICAgICBXZWJET01T VkdQb2ludCBpbW11dGFibGVQb2ludEZ1bmN0aW9uKCk7CiAgICAgdm9pZCBiYW5hbmEoKTsKLSAg ICBXZWJET01ib29sIHN0cmljdEZ1bmN0aW9uKGNvbnN0IFdlYkRPTVN0cmluZyYgc3RyLCBmbG9h dCBhLCBpbnQgYik7Ci0gICAgdm9pZCB2YXJpYWRpY1N0cmluZ01ldGhvZChjb25zdCBXZWJET01T dHJpbmcmIGhlYWQsIGNvbnN0IFdlYkRPTVN0cmluZyYgdGFpbCk7Ci0gICAgdm9pZCB2YXJpYWRp Y0RvdWJsZU1ldGhvZChkb3VibGUgaGVhZCwgZG91YmxlIHRhaWwpOwotICAgIHZvaWQgdmFyaWFk aWNOb2RlTWV0aG9kKGNvbnN0IFdlYkRPTU5vZGUmIGhlYWQsIGNvbnN0IFdlYkRPTU5vZGUmIHRh aWwpOworICAgIFdlYkRPTWJvb2wgc3RyaWN0RnVuY3Rpb24oY29uc3QgV2ViRE9NU3RyaW5nJiwg ZmxvYXQsIGludCk7CisgICAgdm9pZCB2YXJpYWRpY1N0cmluZ01ldGhvZChjb25zdCBXZWJET01T dHJpbmcmLCBjb25zdCBXZWJET01TdHJpbmcmKTsKKyAgICB2b2lkIHZhcmlhZGljRG91YmxlTWV0 aG9kKGRvdWJsZSwgZG91YmxlKTsKKyAgICB2b2lkIHZhcmlhZGljTm9kZU1ldGhvZChjb25zdCBX ZWJET01Ob2RlJiwgY29uc3QgV2ViRE9NTm9kZSYpOwogCiAgICAgV2ViQ29yZTo6VGVzdE9iaiog aW1wbCgpIGNvbnN0OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvQ1BQL1dlYkRPTVRlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvQ1BQL1dlYkRPTVRl c3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UuaAkocmV2aXNpb24gMTQ4NDEyKQorKysg U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0U2VyaWFs aXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDggKzUyLDgg QEAgcHVibGljOgogICAgIFdlYkRPTU1lc3NhZ2VQb3J0QXJyYXkgcG9ydHMoKSBjb25zdDsKICAg ICBXZWJET01TdHJpbmcgY2FjaGVkUmVhZG9ubHlWYWx1ZSgpIGNvbnN0OwogCi0gICAgdm9pZCBh Y2NlcHRUcmFuc2Zlckxpc3QoY29uc3QgV2ViRE9NU3RyaW5nJiBkYXRhLCBjb25zdCBXZWJET01B cnJheSYgdHJhbnNmZXJMaXN0KTsKLSAgICB2b2lkIG11bHRpVHJhbnNmZXJMaXN0KGNvbnN0IFdl YkRPTVN0cmluZyYgZmlyc3QsIGNvbnN0IFdlYkRPTUFycmF5JiB0eCwgY29uc3QgV2ViRE9NU3Ry aW5nJiBzZWNvbmQsIGNvbnN0IFdlYkRPTUFycmF5JiB0eHgpOworICAgIHZvaWQgYWNjZXB0VHJh bnNmZXJMaXN0KGNvbnN0IFdlYkRPTVN0cmluZyYsIGNvbnN0IFdlYkRPTUFycmF5Jik7CisgICAg dm9pZCBtdWx0aVRyYW5zZmVyTGlzdChjb25zdCBXZWJET01TdHJpbmcmLCBjb25zdCBXZWJET01B cnJheSYsIGNvbnN0IFdlYkRPTVN0cmluZyYsIGNvbnN0IFdlYkRPTUFycmF5Jik7CiAKICAgICBX ZWJDb3JlOjpUZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlKiBpbXBsKCkgY29uc3Q7 CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9DUFAvV2ViRE9N VGVzdFR5cGVkZWZzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0NQUC9XZWJET01UZXN0VHlwZWRlZnMuaAkocmV2aXNpb24gMTQ4NDEyKQorKysg U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0NQUC9XZWJET01UZXN0VHlwZWRl ZnMuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsMTAgKzU3LDEwIEBAIHB1YmxpYzoKICAgICBXZWJE T01TdHJpbmcgc3RyaW5nQXR0cldpdGhTZXR0ZXJFeGNlcHRpb24oKSBjb25zdDsKICAgICB2b2lk IHNldFN0cmluZ0F0dHJXaXRoU2V0dGVyRXhjZXB0aW9uKGNvbnN0IFdlYkRPTVN0cmluZyYpOwog Ci0gICAgdm9pZCBmdW5jKGNvbnN0IFdlYkRPTWxvbmdbXSYgeCk7Ci0gICAgdm9pZCBtdWx0aVRy YW5zZmVyTGlzdChjb25zdCBXZWJET01TdHJpbmcmIGZpcnN0LCBjb25zdCBXZWJET01BcnJheSYg dHgsIGNvbnN0IFdlYkRPTVN0cmluZyYgc2Vjb25kLCBjb25zdCBXZWJET01BcnJheSYgdHh4KTsK LSAgICB2b2lkIHNldFNoYWRvdyhmbG9hdCB3aWR0aCwgZmxvYXQgaGVpZ2h0LCBmbG9hdCBibHVy LCBjb25zdCBXZWJET01TdHJpbmcmIGNvbG9yLCBmbG9hdCBhbHBoYSk7Ci0gICAgdm9pZCBudWxs YWJsZUFycmF5QXJnKGNvbnN0IFdlYkRPTURPTVN0cmluZ1tdJiBhcnJheUFyZyk7CisgICAgdm9p ZCBmdW5jKGNvbnN0IFdlYkRPTWxvbmdbXSYpOworICAgIHZvaWQgbXVsdGlUcmFuc2Zlckxpc3Qo Y29uc3QgV2ViRE9NU3RyaW5nJiwgY29uc3QgV2ViRE9NQXJyYXkmLCBjb25zdCBXZWJET01TdHJp bmcmLCBjb25zdCBXZWJET01BcnJheSYpOworICAgIHZvaWQgc2V0U2hhZG93KGZsb2F0LCBmbG9h dCwgZmxvYXQsIGNvbnN0IFdlYkRPTVN0cmluZyYsIGZsb2F0KTsKKyAgICB2b2lkIG51bGxhYmxl QXJyYXlBcmcoY29uc3QgV2ViRE9NRE9NU3RyaW5nW10mKTsKICAgICBXZWJET01TVkdQb2ludCBp bW11dGFibGVQb2ludEZ1bmN0aW9uKCk7CiAgICAgdm9pZCBtZXRob2RXaXRoRXhjZXB0aW9uKCk7 CiAK