114595 2013-04-14 13:01:15 -0700 Only MutableStylePropertySets should be able to have CSSOM wrappers. 2013-04-14 13:31:35 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114568 1 kling kling commit-queue esprehn+autocc kling macpherson menard oldest_to_newest 875392 0 kling 2013-04-14 13:01:15 -0700 Let's enforce this at compile-time. 875393 1 198008 kling 2013-04-14 13:03:29 -0700 Created attachment 198008 Patch 875395 2 kling 2013-04-14 13:31:35 -0700 Committed r148410: <http://trac.webkit.org/changeset/148410> 198008 2013-04-14 13:03:29 -0700 2013-04-14 13:29:04 -0700 Patch bug-114595.diff text/plain 7645 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MTk1MGYzLi4yMGQwMmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYg QEAKIDIwMTMtMDQtMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIE9ubHkgTXV0YWJsZVN0eWxlUHJvcGVydHlTZXRzIHNob3VsZCBiZSBhYmxlIHRvIGhhdmUg Q1NTT00gd3JhcHBlcnMuCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzExNDU5NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaWdodGVuIHR5 cGluZyBzbyB0aGF0IG9ubHkgTXV0YWJsZVN0eWxlUHJvcGVydHlTZXRzIGNhbiBoYXZlIENTU09N IHdyYXBwZXJzIGFzc29jaWF0ZWQuCisgICAgICAgIFRoaXMgYWxsb3dzIHVzIHRvIGdldCByaWQg b2YgdGhlIG91dC1vZi1saW5lIGJhc2UgY2xhc3MgZGVzdHJ1Y3Rvci4KKworICAgICAgICAqIFdl YkNvcmUuZXhwLmluOgorICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnR5U2V0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok11dGFibGVTdHlsZVByb3BlcnR5U2V0Ojp+TXV0YWJsZVN0eWxlUHJvcGVy dHlTZXQpOgorICAgICAgICAoV2ViQ29yZTo6TXV0YWJsZVN0eWxlUHJvcGVydHlTZXQ6OmNzc1N0 eWxlRGVjbGFyYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TXV0YWJsZVN0eWxlUHJvcGVydHlT ZXQ6OmVuc3VyZUlubGluZUNTU1N0eWxlRGVjbGFyYXRpb24pOgorICAgICAgICAqIGNzcy9TdHls ZVByb3BlcnR5U2V0Lmg6CisgICAgICAgIChTdHlsZVByb3BlcnR5U2V0KToKKyAgICAgICAgKE11 dGFibGVTdHlsZVByb3BlcnR5U2V0KToKKyAgICAgICAgKiBkb20vU3R5bGVkRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdHlsZWRFbGVtZW50OjppbmxpbmVTdHlsZUNTU09NV3JhcHBl cik6CisKKzIwMTMtMDQtMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAg ICAgICAgIFJlbW92ZSB1bnVzZWQgZnVuY3Rpb24gZGVjbGFyYXRpb24gU3R5bGVQcm9wZXJ0eVNl dDo6c2V0TmVlZHNTdHlsZVJlY2FsYygpLgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFu dHRpIEtvaXZpc3RvLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4g Yi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCA5MTBhM2RjLi40YjcwZmRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgorKysgYi9Tb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtNTMzLDcgKzUzMyw2IEBAIF9fWk43V2ViQ29yZTE2U2Ny aXB0Q29udHJvbGxlcjE4d2luZG93U2NyaXB0T2JqZWN0RXYKIF9fWk43V2ViQ29yZTE2U2NyaXB0 Q29udHJvbGxlcjIwZXhlY3V0ZVNjcmlwdEluV29ybGRFUE5TXzE1RE9NV3JhcHBlcldvcmxkRVJL TjNXVEY2U3RyaW5nRWIKIF9fWk43V2ViQ29yZTE2U2NyaXB0Q29udHJvbGxlcjIxcHJvY2Vzc2lu Z1VzZXJHZXN0dXJlRXYKIF9fWk43V2ViQ29yZTE2U2NyaXB0Q29udHJvbGxlcjI0anNPYmplY3RG b3JQbHVnaW5FbGVtZW50RVBOU18xN0hUTUxQbHVnSW5FbGVtZW50RQotX19aTjdXZWJDb3JlMTZT dHlsZVByb3BlcnR5U2V0RDFFdgogX19aTjdXZWJDb3JlMTZUaHJlYWRHbG9iYWxEYXRhMTBzdGF0 aWNEYXRhRQogX19aTjdXZWJDb3JlMTZUaHJlYWRHbG9iYWxEYXRhQzFFdgogX19aTjdXZWJDb3Jl MTZUaHJlYWRHbG9iYWxEYXRhRDFFdgpAQCAtMTc4OSw3ICsxNzg4LDYgQEAgX19aTjdXZWJDb3Jl MTVTcGVlY2hTeW50aGVzaXMyMnNldFBsYXRmb3JtU3ludGhlc2l6ZXJFTjNXVEYxMFBhc3NPd25Q dHJJTlNfMjVQbGEKICNlbmRpZgogX19aTjdXZWJDb3JlMTZGb250UGxhdGZvcm1EYXRhQzFFUDZO U0ZvbnRmYmJiTlNfMTVGb250T3JpZW50YXRpb25FTlNfMTZGb250V2lkdGhWYXJpYW50RQogX19a TjdXZWJDb3JlMTZGb250UGxhdGZvcm1EYXRhQzJFUDZOU0ZvbnRmYmJiTlNfMTVGb250T3JpZW50 YXRpb25FTlNfMTZGb250V2lkdGhWYXJpYW50RQotX19aTjdXZWJDb3JlMTZTdHlsZVByb3BlcnR5 U2V0RDJFdgogX19aTjdXZWJDb3JlMTZjb2xvckZyb21OU0NvbG9yRVA3TlNDb2xvcgogX19aTjdX ZWJDb3JlMTZlbmNsb3NpbmdJbnRSZWN0RVJLN19OU1JlY3QKIF9fWk43V2ViQ29yZTE4U2VhcmNo UG9wdXBNZW51TWFjQzFFUE5TXzE1UG9wdXBNZW51Q2xpZW50RQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUHJvcGVydHlTZXQuY3BwCmluZGV4IGNkNWZjODUuLjU5ZGVjZWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVQcm9wZXJ0eVNldC5jcHAKQEAgLTEsNiArMSw2IEBACiAvKgogICogKEMpIDE5 OTktMjAwMyBMYXJzIEtub2xsIChrbm9sbEBrZGUub3JnKQotICogQ29weXJpZ2h0IChDKSAyMDA0 LCAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5LCAyMDEwLCAyMDEyIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAw NywgMjAwOCwgMjAwOSwgMjAxMCwgMjAxMiwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTEgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgpAQCAtNDksNyArNDksNyBAQCB1c2lu ZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXR5cGVkZWYgSGFzaE1h cDxjb25zdCBTdHlsZVByb3BlcnR5U2V0KiwgT3duUHRyPFByb3BlcnR5U2V0Q1NTU3R5bGVEZWNs YXJhdGlvbj4gPiBQcm9wZXJ0eVNldENTU09NV3JhcHBlck1hcDsKK3R5cGVkZWYgSGFzaE1hcDxN dXRhYmxlU3R5bGVQcm9wZXJ0eVNldCosIE93blB0cjxQcm9wZXJ0eVNldENTU1N0eWxlRGVjbGFy YXRpb24+ID4gUHJvcGVydHlTZXRDU1NPTVdyYXBwZXJNYXA7CiBzdGF0aWMgUHJvcGVydHlTZXRD U1NPTVdyYXBwZXJNYXAmIHByb3BlcnR5U2V0Q1NTT01XcmFwcGVyTWFwKCkKIHsKICAgICBERUZJ TkVfU1RBVElDX0xPQ0FMKFByb3BlcnR5U2V0Q1NTT01XcmFwcGVyTWFwLCBwcm9wZXJ0eVNldENT U09NV3JhcHBlck1hcEluc3RhbmNlLCAoKSk7CkBAIC0xMjEsNyArMTIxLDcgQEAgTXV0YWJsZVN0 eWxlUHJvcGVydHlTZXQ6Ok11dGFibGVTdHlsZVByb3BlcnR5U2V0KGNvbnN0IFN0eWxlUHJvcGVy dHlTZXQmIG90aGVyKQogICAgIH0KIH0KIAotU3R5bGVQcm9wZXJ0eVNldDo6flN0eWxlUHJvcGVy dHlTZXQoKQorTXV0YWJsZVN0eWxlUHJvcGVydHlTZXQ6On5NdXRhYmxlU3R5bGVQcm9wZXJ0eVNl dCgpCiB7CiAgICAgQVNTRVJUKCFtX293bnNDU1NPTVdyYXBwZXIgfHwgcHJvcGVydHlTZXRDU1NP TVdyYXBwZXJNYXAoKS5jb250YWlucyh0aGlzKSk7CiAgICAgaWYgKG1fb3duc0NTU09NV3JhcHBl cikKQEAgLTEyMDksMTEgKzEyMDksMTAgQEAgUGFzc1JlZlB0cjxNdXRhYmxlU3R5bGVQcm9wZXJ0 eVNldD4gU3R5bGVQcm9wZXJ0eVNldDo6Y29weVByb3BlcnRpZXNJblNldChjb25zdAogICAgIHJl dHVybiBNdXRhYmxlU3R5bGVQcm9wZXJ0eVNldDo6Y3JlYXRlKGxpc3QuZGF0YSgpLCBsaXN0LnNp emUoKSk7CiB9CiAKLVByb3BlcnR5U2V0Q1NTU3R5bGVEZWNsYXJhdGlvbiogU3R5bGVQcm9wZXJ0 eVNldDo6Y3NzU3R5bGVEZWNsYXJhdGlvbigpCitQcm9wZXJ0eVNldENTU1N0eWxlRGVjbGFyYXRp b24qIE11dGFibGVTdHlsZVByb3BlcnR5U2V0Ojpjc3NTdHlsZURlY2xhcmF0aW9uKCkKIHsKICAg ICBpZiAoIW1fb3duc0NTU09NV3JhcHBlcikKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgQVNTRVJU KGlzTXV0YWJsZSgpKTsKICAgICByZXR1cm4gcHJvcGVydHlTZXRDU1NPTVdyYXBwZXJNYXAoKS5n ZXQodGhpcyk7CiB9CiAKQEAgLTEyMzAsMTQgKzEyMjksMTQgQEAgQ1NTU3R5bGVEZWNsYXJhdGlv biogTXV0YWJsZVN0eWxlUHJvcGVydHlTZXQ6OmVuc3VyZUNTU1N0eWxlRGVjbGFyYXRpb24oKQog ICAgIHJldHVybiBjc3NvbVdyYXBwZXI7CiB9CiAKLUNTU1N0eWxlRGVjbGFyYXRpb24qIE11dGFi bGVTdHlsZVByb3BlcnR5U2V0OjplbnN1cmVJbmxpbmVDU1NTdHlsZURlY2xhcmF0aW9uKGNvbnN0 IFN0eWxlZEVsZW1lbnQqIHBhcmVudEVsZW1lbnQpCitDU1NTdHlsZURlY2xhcmF0aW9uKiBNdXRh YmxlU3R5bGVQcm9wZXJ0eVNldDo6ZW5zdXJlSW5saW5lQ1NTU3R5bGVEZWNsYXJhdGlvbihTdHls ZWRFbGVtZW50KiBwYXJlbnRFbGVtZW50KQogewogICAgIGlmIChtX293bnNDU1NPTVdyYXBwZXIp IHsKICAgICAgICAgQVNTRVJUKHByb3BlcnR5U2V0Q1NTT01XcmFwcGVyTWFwKCkuZ2V0KHRoaXMp LT5wYXJlbnRFbGVtZW50KCkgPT0gcGFyZW50RWxlbWVudCk7CiAgICAgICAgIHJldHVybiBwcm9w ZXJ0eVNldENTU09NV3JhcHBlck1hcCgpLmdldCh0aGlzKTsKICAgICB9CiAgICAgbV9vd25zQ1NT T01XcmFwcGVyID0gdHJ1ZTsKLSAgICBQcm9wZXJ0eVNldENTU1N0eWxlRGVjbGFyYXRpb24qIGNz c29tV3JhcHBlciA9IG5ldyBJbmxpbmVDU1NTdHlsZURlY2xhcmF0aW9uKHRoaXMsIGNvbnN0X2Nh c3Q8U3R5bGVkRWxlbWVudCo+KHBhcmVudEVsZW1lbnQpKTsKKyAgICBQcm9wZXJ0eVNldENTU1N0 eWxlRGVjbGFyYXRpb24qIGNzc29tV3JhcHBlciA9IG5ldyBJbmxpbmVDU1NTdHlsZURlY2xhcmF0 aW9uKHRoaXMsIHBhcmVudEVsZW1lbnQpOwogICAgIHByb3BlcnR5U2V0Q1NTT01XcmFwcGVyTWFw KCkuYWRkKHRoaXMsIGFkb3B0UHRyKGNzc29tV3JhcHBlcikpOwogICAgIHJldHVybiBjc3NvbVdy YXBwZXI7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNl dC5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuaAppbmRleCAxMTUzZTQx Li4yYmY4ZDFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNl dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmgKQEAgLTQ0LDgg KzQ0LDYgQEAgY2xhc3MgU3R5bGVTaGVldENvbnRlbnRzOwogY2xhc3MgU3R5bGVQcm9wZXJ0eVNl dCA6IHB1YmxpYyBSZWZDb3VudGVkPFN0eWxlUHJvcGVydHlTZXQ+IHsKICAgICBmcmllbmQgY2xh c3MgUHJvcGVydHlSZWZlcmVuY2U7CiBwdWJsaWM6Ci0gICAgflN0eWxlUHJvcGVydHlTZXQoKTsK LQogICAgIC8vIE92ZXJyaWRlIFJlZkNvdW50ZWQncyBkZXJlZigpIHRvIGVuc3VyZSBvcGVyYXRv ciBkZWxldGUgaXMgY2FsbGVkIG9uCiAgICAgLy8gdGhlIGFwcHJvcHJpYXRlIHN1YmNsYXNzIHR5 cGUuCiAgICAgdm9pZCBkZXJlZigpOwpAQCAtMTA2LDggKzEwNCw2IEBAIHB1YmxpYzoKICAgICAK ICAgICBTdHJpbmcgYXNUZXh0KCkgY29uc3Q7CiAKLSAgICBQcm9wZXJ0eVNldENTU1N0eWxlRGVj bGFyYXRpb24qIGNzc1N0eWxlRGVjbGFyYXRpb24oKTsKLQogICAgIGJvb2wgaXNNdXRhYmxlKCkg Y29uc3QgeyByZXR1cm4gbV9pc011dGFibGU7IH0KICAgICBib29sIGhhc0NTU09NV3JhcHBlcigp IGNvbnN0IHsgcmV0dXJuIG1fb3duc0NTU09NV3JhcHBlcjsgfQogCkBAIC0xODYsNiArMTgyLDgg QEAgaW5saW5lIGNvbnN0IFN0eWxlUHJvcGVydHlNZXRhZGF0YSogSW1tdXRhYmxlU3R5bGVQcm9w ZXJ0eVNldDo6bWV0YWRhdGFBcnJheSgpIGMKIAogY2xhc3MgTXV0YWJsZVN0eWxlUHJvcGVydHlT ZXQgOiBwdWJsaWMgU3R5bGVQcm9wZXJ0eVNldCB7CiBwdWJsaWM6CisgICAgfk11dGFibGVTdHls ZVByb3BlcnR5U2V0KCk7CisKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxNdXRhYmxlU3R5bGVQcm9w ZXJ0eVNldD4gY3JlYXRlKENTU1BhcnNlck1vZGUgPSBDU1NRdWlya3NNb2RlKTsKICAgICBzdGF0 aWMgUGFzc1JlZlB0cjxNdXRhYmxlU3R5bGVQcm9wZXJ0eVNldD4gY3JlYXRlKGNvbnN0IENTU1By b3BlcnR5KiBwcm9wZXJ0aWVzLCB1bnNpZ25lZCBjb3VudCk7CiAKQEAgLTE5Myw2ICsxOTEsOCBA QCBwdWJsaWM6CiAKICAgICB1bnNpZ25lZCBwcm9wZXJ0eUNvdW50KCkgY29uc3QgeyByZXR1cm4g bV9wcm9wZXJ0eVZlY3Rvci5zaXplKCk7IH0KIAorICAgIFByb3BlcnR5U2V0Q1NTU3R5bGVEZWNs YXJhdGlvbiogY3NzU3R5bGVEZWNsYXJhdGlvbigpOworCiAgICAgdm9pZCBhZGRQYXJzZWRQcm9w ZXJ0aWVzKGNvbnN0IFZlY3RvcjxDU1NQcm9wZXJ0eT4mKTsKICAgICB2b2lkIGFkZFBhcnNlZFBy b3BlcnR5KGNvbnN0IENTU1Byb3BlcnR5Jik7CiAKQEAgLTIxOSw3ICsyMTksNyBAQCBwdWJsaWM6 CiAgICAgdm9pZCBwYXJzZURlY2xhcmF0aW9uKGNvbnN0IFN0cmluZyYgc3R5bGVEZWNsYXJhdGlv biwgU3R5bGVTaGVldENvbnRlbnRzKiBjb250ZXh0U3R5bGVTaGVldCk7CiAKICAgICBDU1NTdHls ZURlY2xhcmF0aW9uKiBlbnN1cmVDU1NTdHlsZURlY2xhcmF0aW9uKCk7Ci0gICAgQ1NTU3R5bGVE ZWNsYXJhdGlvbiogZW5zdXJlSW5saW5lQ1NTU3R5bGVEZWNsYXJhdGlvbihjb25zdCBTdHlsZWRF bGVtZW50KiBwYXJlbnRFbGVtZW50KTsKKyAgICBDU1NTdHlsZURlY2xhcmF0aW9uKiBlbnN1cmVJ bmxpbmVDU1NTdHlsZURlY2xhcmF0aW9uKFN0eWxlZEVsZW1lbnQqIHBhcmVudEVsZW1lbnQpOwog CiAgICAgVmVjdG9yPENTU1Byb3BlcnR5LCA0PiBtX3Byb3BlcnR5VmVjdG9yOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU3R5bGVkRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vU3R5bGVkRWxlbWVudC5jcHAKaW5kZXggYTIwYzY3ZC4uZTIyNTk5MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcApAQCAtMTczLDcgKzE3Myw3IEBAIFByb3BlcnR5U2V0 Q1NTU3R5bGVEZWNsYXJhdGlvbiogU3R5bGVkRWxlbWVudDo6aW5saW5lU3R5bGVDU1NPTVdyYXBw ZXIoKQogewogICAgIGlmICghaW5saW5lU3R5bGUoKSB8fCAhaW5saW5lU3R5bGUoKS0+aGFzQ1NT T01XcmFwcGVyKCkpCiAgICAgICAgIHJldHVybiAwOwotICAgIFByb3BlcnR5U2V0Q1NTU3R5bGVE ZWNsYXJhdGlvbiogY3Nzb21XcmFwcGVyID0gZW5zdXJlVW5pcXVlRWxlbWVudERhdGEoKS0+bV9p bmxpbmVTdHlsZS0+Y3NzU3R5bGVEZWNsYXJhdGlvbigpOworICAgIFByb3BlcnR5U2V0Q1NTU3R5 bGVEZWNsYXJhdGlvbiogY3Nzb21XcmFwcGVyID0gZW5zdXJlTXV0YWJsZUlubGluZVN0eWxlKCkt PmNzc1N0eWxlRGVjbGFyYXRpb24oKTsKICAgICBBU1NFUlQoY3Nzb21XcmFwcGVyICYmIGNzc29t V3JhcHBlci0+cGFyZW50RWxlbWVudCgpID09IHRoaXMpOwogICAgIHJldHVybiBjc3NvbVdyYXBw ZXI7CiB9Cg==