114593 2013-04-14 11:40:17 -0700 [EFL][WK2] Regression(r148274): Broke rendering in the browser 2013-04-15 01:04:16 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Blocker --- 110463 1 cdumez cdumez andersca benjamin commit-queue gyuyoung.kim kenneth kling laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco oldest_to_newest 875384 0 cdumez 2013-04-14 11:40:17 -0700 <http://trac.webkit.org/changeset/148274> completely broke rendering in the browser. The view stays grey and the browser is unusable. That patch defined a new "didChangeViewportAttributes" callback but forgot to hook it up in the view client. Patch is on the way. 875385 1 198006 cdumez 2013-04-14 11:42:40 -0700 Created attachment 198006 Patch 875389 2 198006 commit-queue 2013-04-14 12:16:06 -0700 Comment on attachment 198006 Patch Clearing flags on attachment: 198006 Committed r148407: <http://trac.webkit.org/changeset/148407> 875390 3 commit-queue 2013-04-14 12:16:10 -0700 All reviewed patches have been landed. Closing bug. 875500 4 mikhail.pozdnyakov 2013-04-15 01:04:16 -0700 (In reply to comment #0) > <http://trac.webkit.org/changeset/148274> completely broke rendering in the browser. The view stays grey and the browser is unusable. > > That patch defined a new "didChangeViewportAttributes" callback but forgot to hook it up in the view client. > Ahh, I lost it while rebasing :( Thanks Chris for fixing. 198006 2013-04-14 11:42:40 -0700 2013-04-14 12:16:06 -0700 Patch 114593_rendering_regression.patch text/plain 1477 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NGZjM2M3Li45ODE1NGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDQtMTQgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gUmVncmVzc2lvbihyMTQ4Mjc0KTogQnJva2UgcmVu ZGVyaW5nIGluIHRoZSBicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTQ1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICByMTQ4Mjc0IGFkZGVkIGEgbmV3ICJkaWRDaGFuZ2VWaWV3cG9ydEF0dHJp YnV0ZXMiIGNhbGxiYWNrIHRvCisgICAgICAgIFdLVmlldyBidXQgZGlkIG5vdCBob29rIGl0IHVw IGluIFZpZXdDbGllbnRFZmwuIFRoaXMgcGF0Y2gKKyAgICAgICAgZml4ZXMgdGhpcyBhbmQgbWFr ZXMgcmVuZGVyaW5nIHdvcmsgYWdhaW4gaW4gdGhlIGJyb3dzZXIuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvZWZsL1ZpZXdDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViS2l0OjpWaWV3Q2xpZW50 RWZsOjpWaWV3Q2xpZW50RWZsKToKKwogMjAxMy0wNC0xNCAgQW5kcmVhcyBLbGluZyAgPGFrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBDU1NPTSBjbGFzc2VzIHRvIHVzaW5nIE11dGFi bGVTdHlsZVByb3BlcnR5U2V0IG92ZXIgU3R5bGVQcm9wZXJ0eVNldC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVmlld0NsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvZWZsL1ZpZXdDbGllbnRFZmwuY3BwCmluZGV4IGQxZGFhZWMuLjQ3MGJk NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvVmlld0NsaWVudEVm bC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9WaWV3Q2xpZW50RWZsLmNw cApAQCAtMTYxLDYgKzE2MSw3IEBAIFZpZXdDbGllbnRFZmw6OlZpZXdDbGllbnRFZmwoRXdrVmll dyogdmlldykKICAgICB2aWV3Q2xpZW50LmRpZENoYW5nZUNvbnRlbnRzUG9zaXRpb24gPSBkaWRD aGFuZ2VDb250ZW50c1Bvc2l0aW9uOwogICAgIHZpZXdDbGllbnQuZGlkUmVuZGVyRnJhbWUgPSBk aWRSZW5kZXJGcmFtZTsKICAgICB2aWV3Q2xpZW50LmRpZENvbXBsZXRlUGFnZVRyYW5zaXRpb24g PSBkaWRDb21wbGV0ZVBhZ2VUcmFuc2l0aW9uOworICAgIHZpZXdDbGllbnQuZGlkQ2hhbmdlVmll d3BvcnRBdHRyaWJ1dGVzID0gZGlkQ2hhbmdlVmlld3BvcnRBdHRyaWJ1dGVzOwogCiAgICAgV0tW aWV3U2V0Vmlld0NsaWVudChtX3ZpZXctPndrVmlldygpLCAmdmlld0NsaWVudCk7CiB9Cg==