114557 2013-04-13 02:55:59 -0700 [CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt 2013-04-22 20:31:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga benjamin cmarcelo commit-queue gyuyoung.kim rakuco oldest_to_newest 875133 0 paroga 2013-04-13 02:55:59 -0700 [CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt 875134 1 197929 paroga 2013-04-13 03:00:01 -0700 Created attachment 197929 Patch 876006 2 197929 bfulgham 2013-04-15 12:58:10 -0700 Comment on attachment 197929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review > Source/WTF/wtf/CMakeLists.txt:178 > + NullPtr.cpp Is this not needed by any other platform build? E.g., the Windows 2005 build (were it on CMake) would need this as well. 876122 3 197929 paroga 2013-04-15 16:21:29 -0700 Comment on attachment 197929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review >> Source/WTF/wtf/CMakeLists.txt:178 >> + NullPtr.cpp > > Is this not needed by any other platform build? E.g., the Windows 2005 build (were it on CMake) would need this as well. now it is in the files for all compilers, so VS2005 will see it too 879567 4 197929 laszlo.gombos 2013-04-22 20:05:28 -0700 Comment on attachment 197929 Patch r=me. 879572 5 197929 commit-queue 2013-04-22 20:31:33 -0700 Comment on attachment 197929 Patch Clearing flags on attachment: 197929 Committed r148941: <http://trac.webkit.org/changeset/148941> 879573 6 commit-queue 2013-04-22 20:31:36 -0700 All reviewed patches have been landed. Closing bug. 197929 2013-04-13 03:00:01 -0700 2013-04-22 20:31:33 -0700 Patch bug-114557.patch text/plain 1540 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNTJjYWQyZi4uZWIzOTNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMy0wNC0xMyAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAorICAgICAgICBbQ01ha2Vd IE1vdmUgTnVsbFB0ci5jcHAgZnJvbSBQbGF0Zm9ybVdpbkNFLmNtYWtlIHRvIENNYWtlTGlzdHMu dHh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ1 NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IGZpbGUgaXMgbm90IHNwZWNpZmljIHRvIFdpbmR3b3MgQ0UuIE1vdmUgaXQgdGhlIHRoZSBnZW5l cmFsCisgICAgICAgIENNYWtlTGlzdHMudHh0IHNvIG90aGVyIHBvcnRzIGNhbiB1c2UgaXQgdG8u IEl0IGRvZXMgbm90IGFmZmVjdAorICAgICAgICBwb3J0cyB3aGljaCBkbyBub3QgbmVlZCBpdCwg c2luY2UgaXQgY29udGFpbnMgYSBwcmVwcm9jZXNzb3IgZ3VhcmQuCisKKyAgICAgICAgKiB3dGYv Q01ha2VMaXN0cy50eHQ6CisgICAgICAgICogd3RmL1BsYXRmb3JtV2luQ0UuY21ha2U6CisKKzIw MTMtMDQtMTMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKICAgICAg ICAgW0NNYWtlXSBBZGQgV1RGX1VTRV8qX1VOSUNPREUgdmFyaWFibGVzCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ1NTYKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3Rz LnR4dAppbmRleCAzMmQwZDhjLi4yYTVhNGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9D TWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4dApAQCAtMTc1 LDYgKzE3NSw3IEBAIHNldChXVEZfU09VUkNFUwogICAgIE1haW5UaHJlYWQuY3BwCiAgICAgTWVk aWFUaW1lLmNwcAogICAgIE1ldGFBbGxvY2F0b3IuY3BwCisgICAgTnVsbFB0ci5jcHAKICAgICBP U1JhbmRvbVNvdXJjZS5jcHAKICAgICBNZW1vcnlJbnN0cnVtZW50YXRpb24uY3BwCiAgICAgTnVt YmVyT2ZDb3Jlcy5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtV2luQ0Uu Y21ha2UgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybVdpbkNFLmNtYWtlCmluZGV4IDNiNjY4YmQu LjIwNjIyZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtV2luQ0UuY21ha2UK KysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1XaW5DRS5jbWFrZQpAQCAtMSw1ICsxLDQgQEAK IGxpc3QoQVBQRU5EIFdURl9TT1VSQ0VTCi0gICAgTnVsbFB0ci5jcHAKICAgICBPU0FsbG9jYXRv cldpbi5jcHAKICAgICBUaHJlYWRpbmdXaW4uY3BwCiAgICAgVGhyZWFkU3BlY2lmaWNXaW4uY3Bw Cg==