114544 2013-04-12 16:19:25 -0700 Block freeing thread should call Region::destroy instead of delete 2013-04-12 16:43:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 875033 0 mhahnenberg 2013-04-12 16:19:25 -0700 Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of the state of the Region. We should call destroy() instead. 875036 1 197907 mhahnenberg 2013-04-12 16:23:43 -0700 Created attachment 197907 Patch 875043 2 mhahnenberg 2013-04-12 16:41:52 -0700 Committed r148314: <http://trac.webkit.org/changeset/148314> 875044 3 mhahnenberg 2013-04-12 16:43:48 -0700 <rdar://problem/13260356> 197907 2013-04-12 16:23:43 -0700 2013-04-12 16:31:16 -0700 Patch bug-114544-20130412162321.patch text/plain 1517 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ4MzExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTA0LTEyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQmxvY2sgZnJlZWluZyB0aHJlYWQgc2hvdWxkIGNhbGwgUmVnaW9uOjpkZXN0cm95 IGluc3RlYWQgb2YgZGVsZXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTQ1NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTaW5jZSBSZWdpb24gZG9lc24ndCBoYXZlIGEgdmlydHVhbCBkZXN0cnVjdG9y LCBjYWxsaW5nIGRlbGV0ZSB3aWxsIG5vdCBwcm9wZXJseSBjbGVhbiB1cCBhbGwgb2YgCisgICAg ICAgIHRoZSBzdGF0ZSBvZiB0aGUgUmVnaW9uLiBXZSBzaG91bGQgY2FsbCBkZXN0cm95KCkgaW5z dGVhZC4KKworICAgICAgICAqIGhlYXAvQmxvY2tBbGxvY2F0b3IuY3BwOgorICAgICAgICAoSlND OjpCbG9ja0FsbG9jYXRvcjo6cmVsZWFzZUZyZWVSZWdpb25zKToKKyAgICAgICAgKEpTQzo6Qmxv Y2tBbGxvY2F0b3I6OmJsb2NrRnJlZWluZ1RocmVhZE1haW4pOgorCiAyMDEzLTA0LTExICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIE1lcmdlIENoYXJh Y3RlckNsYXNzVGFibGUgaW50byBDaGFyYWN0ZXJDbGFzcwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0Jsb2NrQWxsb2NhdG9yLmNwcAkocmV2aXNpb24gMTQ4MzEwKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC03OCw3ICs3OCw3IEBAIHZvaWQgQmxvY2tBbGxvY2F0b3I6OnJlbGVhc2VGcmVlUmVn aW9ucygKICAgICAgICAgaWYgKCFyZWdpb24pCiAgICAgICAgICAgICBicmVhazsKIAotICAgICAg ICBkZWxldGUgcmVnaW9uOworICAgICAgICByZWdpb24tPmRlc3Ryb3koKTsKICAgICB9CiB9CiAK QEAgLTE1MCw3ICsxNTAsNyBAQCB2b2lkIEJsb2NrQWxsb2NhdG9yOjpibG9ja0ZyZWVpbmdUaHJl YWRNCiAgICAgICAgICAgICBpZiAoIXJlZ2lvbikKICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgIAotICAgICAgICAgICAgZGVsZXRlIHJlZ2lvbjsKKyAgICAgICAgICAgIHJlZ2lv bi0+ZGVzdHJveSgpOwogICAgICAgICB9CiAgICAgfQogfQo=