114543 2013-04-12 16:15:36 -0700 Demystify some code in RenderLayer::updateScrollableAreaSet() 2013-04-12 16:46:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc simon.fraser oldest_to_newest 875029 0 simon.fraser 2013-04-12 16:15:36 -0700 Demystify some code in RenderLayer::updateScrollableAreaSet() 875032 1 197906 simon.fraser 2013-04-12 16:17:18 -0700 Created attachment 197906 Patch 875034 2 197906 thorton 2013-04-12 16:19:47 -0700 Comment on attachment 197906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197906&action=review > Source/WebCore/rendering/RenderLayer.cpp:-6198 > -#else > - return; Is some irritating compiler going to complain about this empty if() in the !USE(ACCELERATED_COMPOSITING) case? 875047 3 simon.fraser 2013-04-12 16:46:17 -0700 https://trac.webkit.org/r148316 197906 2013-04-12 16:17:18 -0700 2013-04-12 16:19:46 -0700 Patch bug-114543-20130412161659.patch text/plain 1932 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGM4YTZlZDVlMTY5M2Fh YzQ2ZTNjZmEzOTRhOTFlYzczODAxNzI0MC4uYmM5NjM1MmIwMmExMTcwOTgyZDI5MTA3N2VhMjgy NjJmN2FhZTM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERlbXlzdGlmeSBz b21lIGNvZGUgaW4gUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGFibGVBcmVhU2V0KCkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDU0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFuIHVwIHNvbWUg Y29kZSB0aGF0IGNhbGxlZCBmdW5jdGlvbnMgd2l0aCBpbXBvcnRhbnQgc2lkZSBlZmZlY3RzCisg ICAgICAgIGluc2lkZSBhIHRlcm5hcnkgb3BlcmF0b3IsIGFuZCBjbGVhbiB1cCB0aGUgI2lmZGVm cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJMYXllcjo6dXBkYXRlU2Nyb2xsYWJsZUFyZWFTZXQpOgorCiAyMDEzLTA0LTEw ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIExvZyB3 aGVuIHRoZSBhbmltYXRpb24gdGltZXIgZmlyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwCmluZGV4IDAwNGM0YTk5MTQ5NjQ0ZGNiNDU3MDNjODIyZTM2NmM0YmE0MWQ5 YTAuLjE3OTRkZWRjYjI1OTBjZTkwYzg3NGIyMTU0MmEyOGFiMDY0ZDIyYTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNjE5MSwxMiArNjE5MSwxOCBAQCB2 b2lkIFJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxhYmxlQXJlYVNldChib29sIGhhc092ZXJmbG93 KQogICAgIGlmIChIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyID0gZnJhbWUtPm93bmVyRWxl bWVudCgpKQogICAgICAgICBpc1Zpc2libGVUb0hpdFRlc3QgJj0gb3duZXItPnJlbmRlcmVyKCkg JiYgb3duZXItPnJlbmRlcmVyKCktPnZpc2libGVUb0hpdFRlc3RpbmcoKTsKIAotICAgIGlmICho YXNPdmVyZmxvdyAmJiBpc1Zpc2libGVUb0hpdFRlc3QgPyBmcmFtZVZpZXctPmFkZFNjcm9sbGFi bGVBcmVhKHRoaXMpIDogZnJhbWVWaWV3LT5yZW1vdmVTY3JvbGxhYmxlQXJlYSh0aGlzKSkKKyAg ICBib29sIGlzU2Nyb2xsYWJsZSA9IGhhc092ZXJmbG93ICYmIGlzVmlzaWJsZVRvSGl0VGVzdDsK KyAgICBib29sIGFkZGVkT3JSZW1vdmVkID0gZmFsc2U7CisgICAgaWYgKGlzU2Nyb2xsYWJsZSkK KyAgICAgICAgYWRkZWRPclJlbW92ZWQgPSBmcmFtZVZpZXctPmFkZFNjcm9sbGFibGVBcmVhKHRo aXMpOworICAgIGVsc2UKKyAgICAgICAgYWRkZWRPclJlbW92ZWQgPSBmcmFtZVZpZXctPnJlbW92 ZVNjcm9sbGFibGVBcmVhKHRoaXMpOworICAgIAorICAgIGlmIChhZGRlZE9yUmVtb3ZlZCkgewog I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICAgICAgdXBkYXRlTmVlZHNDb21w b3NpdGVkU2Nyb2xsaW5nKCk7Ci0jZWxzZQotICAgICAgICByZXR1cm47CiAjZW5kaWYKKyAgICB9 CiB9CiAKIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbENvcm5lclN0eWxlKCkK