114515 2013-04-12 08:52:25 -0700 [BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically 2013-04-12 13:43:14 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yodai webkit-unassigned commit-queue mifenton rwlbuis tonikitoo oldest_to_newest 874769 0 yodai 2013-04-12 08:52:25 -0700 It is still hard to select text in URL bar with an inverted selection handle. We can improve the issue by replacing the Y coordinate of selection point with Y coordinate of start caret for single line input filed. Thus, the Y coordinate is always valid regardless of the actual location of the selection handle. 874782 1 197857 yodai 2013-04-12 09:09:10 -0700 Created attachment 197857 Patch 874918 2 197857 rwlbuis 2013-04-12 13:12:23 -0700 Comment on attachment 197857 Patch LGTM. 874933 3 197857 commit-queue 2013-04-12 13:43:13 -0700 Comment on attachment 197857 Patch Clearing flags on attachment: 197857 Committed r148302: <http://trac.webkit.org/changeset/148302> 874934 4 commit-queue 2013-04-12 13:43:14 -0700 All reviewed patches have been landed. Closing bug. 197857 2013-04-12 09:09:10 -0700 2013-04-12 13:43:12 -0700 Patch bug-114515-20130412120858.patch text/plain 6477 yodai U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4Mjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3ZjViZmViNWIwYmQzZmY5N2I0MWJiYzM5YWViNzZhM2ZmYmExNmFhLi5mYmEwZTk0Yzdj NjBlMjdlOWEzOGY5NTAyNzZmNWY2YjM5MmJiY2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMy0wNC0xMiAgWW9uZ3hpbiBEYWkgIDx5b2RhaUBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFibGUgc2VsZWN0aW5nIHRleHQgaW4g c2luZ2xlIGxpbmUgaW5wdXQgZmllbGQgd2l0aG91dCBzZWxlY3Rpb24gcG9pbnQgYmVpbmcgYWN0 dWFsbHkgb24gdGhlIHRhcmdldGVkIHRleHQgdmVydGljYWxseQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NTE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIgIzMxNzkyNC4KKyAgICAgICAgSW50ZXJu YWxseSByZXZpZXdlZCBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICBJdCB3YXMgc3RpbGwgaGFy ZCB0byBzZWxlY3QgdGV4dCBpbiBVUkwgYmFyIHdpdGggYW4gaW52ZXJ0ZWQgc2VsZWN0aW9uIGhh bmRsZS4KKyAgICAgICAgV2UgaW1wcm92ZSB0aGUgaXNzdWUgYnkgcmVwbGFjaW5nIHRoZSBZIGNv b3JkaW5hdGUgb2Ygc2VsZWN0aW9uIHBvaW50IHdpdGggWQorICAgICAgICBjb29yZGluYXRlIG9m IHN0YXJ0IGNhcmV0IGZvciBzaW5nbGUgbGluZSBpbnB1dCBmaWxlZC4gVGh1cywgdGhlIFkgY29v cmRpbmF0ZQorICAgICAgICBpcyBhbHdheXMgdmFsaWQgcmVnYXJkbGVzcyBvZiB0aGUgYWN0dWFs IGxvY2F0aW9uIG9mIHRoZSBzZWxlY3Rpb24gaGFuZGxlLgorCisgICAgICAgICogV2ViS2l0U3Vw cG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 U2VsZWN0aW9uSGFuZGxlcjo6c2V0U2VsZWN0aW9uKToKKyAgICAgICAgKEJsYWNrQmVycnk6Oldl YktpdDo6U2VsZWN0aW9uSGFuZGxlcjo6c3RhcnRDYXJldFZpZXdwb3J0UmVjdCk6CisgICAgICAg IChXZWJLaXQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVy OjpjYXJldFBvc2l0aW9uQ2hhbmdlZCk6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rp b25IYW5kbGVyLmg6CisgICAgICAgIChTZWxlY3Rpb25IYW5kbGVyKToKKwogMjAxMy0wNC0xMiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0Js YWNrQmVycnldIENyYXNoIHJ1bm5pbmcgbGF5b3V0IHRlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3Bw CmluZGV4IDEyYjg3MDBhZTI5ZTJmYWNkNzYwOTRiNzE3NmE3ZjI0Y2E1ZmU2OGUuLjUyZjJiMDE0 YWZmYjUzY2U3NzBkMDg0MTFiNjhkZTFmZmRiZjVhNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuY3Bw CkBAIC00NzYsNyArNDc2LDcgQEAgYm9vbCBTZWxlY3Rpb25IYW5kbGVyOjp1cGRhdGVPckhhbmRs ZUlucHV0U2VsZWN0aW9uKFZpc2libGVTZWxlY3Rpb24mIG5ld1NlbGVjdGkKICAgICByZXR1cm4g dHJ1ZTsKIH0KIAotdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZXRTZWxlY3Rpb24oY29uc3QgV2Vi Q29yZTo6SW50UG9pbnQmIHN0YXJ0LCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgZW5kKQordm9p ZCBTZWxlY3Rpb25IYW5kbGVyOjpzZXRTZWxlY3Rpb24oV2ViQ29yZTo6SW50UG9pbnQgc3RhcnQs IFdlYkNvcmU6OkludFBvaW50IGVuZCkKIHsKICAgICBtX3NlbGVjdGlvbkFjdGl2ZSA9IHRydWU7 CiAKQEAgLTUwNCw2ICs1MDQsMTcgQEAgdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZXRTZWxlY3Rp b24oY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHN0YXJ0LCBjb25zdCBXZWJDb3IKICAgICAvLyBB dCBsZWFzdCBvbmUgb2YgdGhlIGxvY2F0aW9ucyBtdXN0IGJlIHZhbGlkLgogICAgIEFTU0VSVChz dGFydElzVmFsaWQgfHwgbV9sYXN0VXBkYXRlZEVuZFBvaW50SXNWYWxpZCk7CiAKKyAgICBpZiAo bV93ZWJQYWdlLT5tX2lucHV0SGFuZGxlci0+aXNJbnB1dE1vZGUoKSAmJiAhbV93ZWJQYWdlLT5t X2lucHV0SGFuZGxlci0+aXNNdWx0aWxpbmVJbnB1dE1vZGUoKSkgeworICAgICAgICBXZWJDb3Jl OjpJbnRSZWN0IGNhcmV0KHN0YXJ0Q2FyZXRWaWV3cG9ydFJlY3QobV93ZWJQYWdlLT5mcmFtZU9m ZnNldChmb2N1c2VkRnJhbWUpKSk7CisgICAgICAgIGlmICghY2FyZXQuaXNFbXB0eSgpKSB7Cisg ICAgICAgICAgICBpbnQgY2VudGVyT2ZDYXJldFkgPSBjYXJldC5jZW50ZXIoKS55KCk7CisgICAg ICAgICAgICBpZiAoc3RhcnRJc1ZhbGlkKQorICAgICAgICAgICAgICAgIHN0YXJ0LnNldFkoY2Vu dGVyT2ZDYXJldFkpOworICAgICAgICAgICAgaWYgKG1fbGFzdFVwZGF0ZWRFbmRQb2ludElzVmFs aWQpCisgICAgICAgICAgICAgICAgZW5kLnNldFkoY2VudGVyT2ZDYXJldFkpOworICAgICAgICB9 CisgICAgfQorCiAgICAgV2ViQ29yZTo6SW50UG9pbnQgcmVsYXRpdmVTdGFydCA9IHN0YXJ0Owog ICAgIFdlYkNvcmU6OkludFBvaW50IHJlbGF0aXZlRW5kID0gZW5kOwogCkBAIC02MjMsNiArNjM0 LDIxIEBAIGJvb2wgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0Tm9kZUlmRmF0RmluZ2Vyc1Jlc3Vs dElzTGluayhGYXRGaW5nZXJzUmVzdWx0IGZhdEZpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitX ZWJDb3JlOjpJbnRSZWN0IFNlbGVjdGlvbkhhbmRsZXI6OnN0YXJ0Q2FyZXRWaWV3cG9ydFJlY3Qo Y29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIGZyYW1lT2Zmc2V0KSBjb25zdAoreworICAgIFdlYkNv cmU6OkludFJlY3QgY2FyZXRSZWN0OworICAgIEZyYW1lKiBmcmFtZSA9IG1fd2ViUGFnZS0+Zm9j dXNlZE9yTWFpbkZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJuIGNhcmV0 UmVjdDsKKworICAgIGlmIChmcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvblR5cGUoKSAhPSBW aXNpYmxlU2VsZWN0aW9uOjpOb1NlbGVjdGlvbikgeworICAgICAgICBjYXJldFJlY3QgPSBmcmFt ZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLnZpc2libGVTdGFydCgpLmFic29sdXRlQ2FyZXRC b3VuZHMoKTsKKyAgICAgICAgY2FyZXRSZWN0Lm1vdmVCeShmcmFtZU9mZnNldCk7CisgICAgfQor CisgICAgcmV0dXJuIGNhcmV0UmVjdDsKK30KKwogdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZWxl Y3RBdFBvaW50KGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBsb2NhdGlvbiwgU2VsZWN0aW9uRXhw YW5zaW9uVHlwZSBzZWxlY3Rpb25FeHBhbnNpb25UeXBlKQogewogICAgIGlmIChzZWxlY3Rpb25F eHBhbnNpb25UeXBlID09IFdvcmQpIHsKQEAgLTEyNzQsMTQgKzEzMDAsMTIgQEAgdm9pZCBTZWxl Y3Rpb25IYW5kbGVyOjpjYXJldFBvc2l0aW9uQ2hhbmdlZChib29sIHVzZXJUb3VjaFRyaWdnZXJl ZCkKICAgICAvLyBUaGlzIGZ1bmN0aW9uIHNob3VsZCBvbmx5IHJlYWNoIHRoaXMgcG9pbnQgaWYg aW5wdXQgbW9kZSBpcyBhY3RpdmUuCiAgICAgQVNTRVJUKG1fd2ViUGFnZS0+bV9pbnB1dEhhbmRs ZXItPmlzSW5wdXRNb2RlKCkpOwogCi0gICAgV2ViQ29yZTo6SW50UG9pbnQgZnJhbWVPZmZzZXQo bV93ZWJQYWdlLT5mcmFtZU9mZnNldChtX3dlYlBhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpKSk7 CiAgICAgV2ViQ29yZTo6SW50UmVjdCBjbGlwcGluZ1JlY3RGb3JDb250ZW50KGNsaXBwaW5nUmVj dEZvclZpc2libGVDb250ZW50KCkpOworICAgIFdlYkNvcmU6OkludFBvaW50IGZyYW1lT2Zmc2V0 KG1fd2ViUGFnZS0+ZnJhbWVPZmZzZXQobV93ZWJQYWdlLT5mb2N1c2VkT3JNYWluRnJhbWUoKSkp OwogICAgIGlmIChtX3dlYlBhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpLT5zZWxlY3Rpb24oKS0+ c2VsZWN0aW9uVHlwZSgpID09IFZpc2libGVTZWxlY3Rpb246OkNhcmV0U2VsZWN0aW9uKSB7Ci0g ICAgICAgIGNhcmV0TG9jYXRpb24gPSBtX3dlYlBhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpLT5z ZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCkudmlzaWJsZVN0YXJ0KCkuYWJzb2x1dGVDYXJldEJvdW5k cygpOwotICAgICAgICBjYXJldExvY2F0aW9uLm1vdmUoZnJhbWVPZmZzZXQueCgpLCBmcmFtZU9m ZnNldC55KCkpOwotCi0gICAgICAgIC8vIENsaXAgYWdhaW5zdCB0aGUgY29udGFpbmluZyBmcmFt ZSBhbmQgbm9kZSBib3VuZGFyaWVzLgotICAgICAgICBjYXJldExvY2F0aW9uLmludGVyc2VjdChj bGlwcGluZ1JlY3RGb3JDb250ZW50KTsKKyAgICAgICAgY2FyZXRMb2NhdGlvbiA9IHN0YXJ0Q2Fy ZXRWaWV3cG9ydFJlY3QoZnJhbWVPZmZzZXQpOworICAgICAgICBpZiAoIWNhcmV0TG9jYXRpb24u aXNFbXB0eSgpKQorICAgICAgICAgICAgY2FyZXRMb2NhdGlvbi5pbnRlcnNlY3QoY2xpcHBpbmdS ZWN0Rm9yQ29udGVudCk7IC8vIENsaXAgYWdhaW5zdCB0aGUgY29udGFpbmluZyBmcmFtZSBhbmQg bm9kZSBib3VuZGFyaWVzLgogICAgIH0KIAogICAgIG1fY2FyZXRBY3RpdmUgPSAhY2FyZXRMb2Nh dGlvbi5pc0VtcHR5KCk7CkBAIC0xMjk0LDcgKzEzMTgsNyBAQCB2b2lkIFNlbGVjdGlvbkhhbmRs ZXI6OmNhcmV0UG9zaXRpb25DaGFuZ2VkKGJvb2wgdXNlclRvdWNoVHJpZ2dlcmVkKQogICAgIFdl YkNvcmU6OkludFJlY3Qgbm9kZUJvdW5kaW5nQm94ID0gaXNTaW5nbGVMaW5lSW5wdXQgPyBtX3dl YlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5ib3VuZGluZ0JveEZvcklucHV0RmllbGQoKSA6IFdlYkNv cmU6OkludFJlY3QoKTsKIAogICAgIGlmICghbm9kZUJvdW5kaW5nQm94LmlzRW1wdHkoKSkgewot ICAgICAgICBub2RlQm91bmRpbmdCb3gubW92ZShmcmFtZU9mZnNldC54KCksIGZyYW1lT2Zmc2V0 LnkoKSk7CisgICAgICAgIG5vZGVCb3VuZGluZ0JveC5tb3ZlQnkoZnJhbWVPZmZzZXQpOwogCiAg ICAgICAgIC8vIENsaXAgYWdhaW5zdCB0aGUgY29udGFpbmluZyBmcmFtZSBhbmQgbm9kZSBib3Vu ZGFyaWVzLgogICAgICAgICBub2RlQm91bmRpbmdCb3guaW50ZXJzZWN0KGNsaXBwaW5nUmVjdEZv ckNvbnRlbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oCmluZGV4IGNhOGYyMDY1MWRiZWU1OGFiMjY1ZjRh MDFhOGRiZWFlYTExMjdhZDAuLjkwYzhjY2QxOTJiZGViOTIxYmE0MmNjMzNlNGRiNzZjOWQwMThi MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1Nl bGVjdGlvbkhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9TZWxlY3Rpb25IYW5kbGVyLmgKQEAgLTYzLDcgKzYzLDcgQEAgcHVibGljOgogCiAgICAg Ym9vbCBzZWxlY3Rpb25Db250YWlucyhjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYpOwogCi0gICAg dm9pZCBzZXRTZWxlY3Rpb24oY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHN0YXJ0LCBjb25zdCBX ZWJDb3JlOjpJbnRQb2ludCYgZW5kKTsKKyAgICB2b2lkIHNldFNlbGVjdGlvbihXZWJDb3JlOjpJ bnRQb2ludCBzdGFydCwgV2ViQ29yZTo6SW50UG9pbnQgZW5kKTsKICAgICB2b2lkIHNlbGVjdEF0 UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmLCBTZWxlY3Rpb25FeHBhbnNpb25UeXBlKTsK ICAgICB2b2lkIHNlbGVjdE9iamVjdChjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYsIFdlYkNvcmU6 OlRleHRHcmFudWxhcml0eSk7CiAgICAgdm9pZCBzZWxlY3RPYmplY3QoV2ViQ29yZTo6VGV4dEdy YW51bGFyaXR5KTsKQEAgLTEwNyw2ICsxMDcsOCBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBzZWxl Y3ROb2RlSWZGYXRGaW5nZXJzUmVzdWx0SXNMaW5rKEZhdEZpbmdlcnNSZXN1bHQpOwogCisgICAg V2ViQ29yZTo6SW50UmVjdCBzdGFydENhcmV0Vmlld3BvcnRSZWN0KGNvbnN0IFdlYkNvcmU6Oklu dFBvaW50JiBmcmFtZU9mZnNldCkgY29uc3Q7CisKICAgICBXZWJQYWdlUHJpdmF0ZSogbV93ZWJQ YWdlOwogCiAgICAgYm9vbCBtX3NlbGVjdGlvbkFjdGl2ZTsK