114512 2013-04-12 07:08:35 -0700 [Qt][Win] r148257 broke the build 2013-04-14 23:51:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 114478 1 zarvai webkit-unassigned hausmann jturcotte kadam oliver ossy oldest_to_newest 874701 0 zarvai 2013-04-12 07:08:35 -0700 After r148257 Qt Win build is broken. Maybe related to toJS changes, too. http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/64072/steps/compile-webkit/logs/stdio WebCore.lib(JSNotification.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore12NotificationE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::Notification *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNotification@1@@Z) WebCore.lib(JSInternals.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore9InternalsE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::Internals *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVInternals@1@@Z) WebCore.lib(JSDOMSelection.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore12DOMSelectionE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::DOMSelection *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVDOMSelection@1@@Z) ... 874787 1 oliver 2013-04-12 09:17:36 -0700 Committed r148280: <http://trac.webkit.org/changeset/148280> 874795 2 jturcotte 2013-04-12 09:30:08 -0700 (In reply to comment #1) > Committed r148280: <http://trac.webkit.org/changeset/148280> #if PLATFORM(MAC) || PLATFORM(BLACKBERRY) -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1 +#define BINDING_INTEGRITY 1 #endif Maybe this should be "ENABLE_BINDING_INTEGRITY" instead? 874833 3 oliver 2013-04-12 10:35:56 -0700 (In reply to comment #2) > (In reply to comment #1) > > Committed r148280: <http://trac.webkit.org/changeset/148280> > > #if PLATFORM(MAC) || PLATFORM(BLACKBERRY) > -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1 > +#define BINDING_INTEGRITY 1 > #endif > > Maybe this should be "ENABLE_BINDING_INTEGRITY" instead? whoah, that's an entirely bogus change, thanks for spotting it. O_o 875298 4 ossy 2013-04-14 00:47:52 -0700 Reopen, because it didn't fix anything, the build is still broken. 875369 5 oliver 2013-04-14 09:47:38 -0700 (In reply to comment #4) > Reopen, because it didn't fix anything, the build is still broken. Does QT set PLATFORM(WIN) ? 875467 6 ossy 2013-04-14 23:38:39 -0700 (In reply to comment #5) > (In reply to comment #4) > > Reopen, because it didn't fix anything, the build is still broken. > > Does QT set PLATFORM(WIN) ? No, but OS(WIN). Thanks for http://trac.webkit.org/changeset/148405 , it fixed the build. 875470 7 oliver 2013-04-14 23:51:43 -0700 Yay! Sorry for the delay. Seems icky to bludgeon out windows, but i think i need to do a bit more work to make binding generation windows friendly.