114506 2013-04-12 06:27:20 -0700 [ẁebkitpy] Executive.cpu_count() ignores $NUMBER_OF_PROCESSORS 2013-04-15 04:06:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned commit-queue dpranke rego zan oldest_to_newest 874561 0 pnormand 2013-04-12 06:27:20 -0700 $NUMBER_OF_PROCESSORS is used in webkitperl, it'd be nice to have support for it in webkitpy too. 874761 1 197852 rego 2013-04-12 08:43:36 -0700 Created attachment 197852 Patch 874766 2 197852 pnormand 2013-04-12 08:50:23 -0700 Comment on attachment 197852 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197852&action=review > Tools/Scripts/webkitpy/common/system/executive.py:145 > + if 'NUMBER_OF_PROCESSORS' in os.environ: This test can be removed. os.environ.get() will return None if the env var is not set, I think. > Tools/Scripts/webkitpy/common/system/executive.py:150 > + except: please explicitely catch ValueError :) 875457 3 198023 rego 2013-04-14 22:40:11 -0700 Created attachment 198023 Patch os.environ.get() returns None, but None has type NoneType and if you use it in int() it raises a TypeError exception instead of a ValueError. So, I've kept the if checking that the environment variable is defined and then I've added ValueError in the catch clause. 875472 4 pnormand 2013-04-14 23:55:43 -0700 (In reply to comment #3) > Created an attachment (id=198023) [details] > Patch > > os.environ.get() returns None, but None has type NoneType and if you use it in int() it raises a TypeError exception instead of a ValueError. So, I've kept the if checking that the environment variable is defined and then I've added ValueError in the catch clause. Well, it's possible to catch multiple exceptions with a single except or even multiple except statements :) 875565 5 198048 rego 2013-04-15 03:35:47 -0700 Created attachment 198048 Patch 875633 6 zan 2013-04-15 04:02:50 -0700 (In reply to comment #3) > Created an attachment (id=198023) [details] > Patch > > os.environ.get() returns None, but None has type NoneType and if you use it in int() it raises a TypeError exception instead of a ValueError. So, I've kept the if checking that the environment variable is defined and then I've added ValueError in the catch clause. It's possible to define the default value that's to be returned when the searched item is not present in the dictionary. In this case it would probably be 0. http://docs.python.org/2/library/stdtypes.html#dict.get Also, mildly interesting, the ẁ (U+1E81) in the [ẁebkitpy] tag in the title does not get reflected in the changelog. 875636 7 198048 commit-queue 2013-04-15 04:06:53 -0700 Comment on attachment 198048 Patch Clearing flags on attachment: 198048 Committed r148429: <http://trac.webkit.org/changeset/148429> 875637 8 commit-queue 2013-04-15 04:06:56 -0700 All reviewed patches have been landed. Closing bug. 197852 2013-04-12 08:43:36 -0700 2013-04-14 22:40:05 -0700 Patch bug-114506-20130412174313.patch text/plain 1512 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MjY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWE0MDgxNjA1YTdjOWJmZDUxNzI1YTVkNzMyMjQyNWQ4 MTM2NDlmMS4uNDg5NjllNDU2NjZhNTQ1ODBhYjgxMjkyZTZjNTEyNzkzMGViODFiMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA0LTEyICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFt3ZWJraXRweV0gVXNlICROVU1CRVJfT0ZfUFJPQ0VTU09SUyBpbiBFeGVj dXRpdmUuY3B1X2NvdW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weToK KyAgICAgICAgKEV4ZWN1dGl2ZS5jcHVfY291bnQpOiBNb2RpZnkgZnVuY3Rpb24gaW4gb3JkZXIg dG8gdXNlIHRoZSBlbnZpcm9ubWVudAorICAgICAgICB2YXJpYWJsZSAkTlVNQkVSX09GX1BST0NF U1NPUlMgaWYgaXQgaXMgZGVmaW5lZCBhbmQgaXQgaXMgYW4gaW50ZWdlcgorICAgICAgICBncmVh dGVyIHRoYW4gMC4KKwogMjAxMy0wNC0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZW1vdmUgQ2hyb21pdW0gc2NyaXB0cwpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKaW5kZXggM2IzYjdlZjk5YTNl NGZiOTg1ZGQxYjEyNDZhMTdmZGU3MjdjOTY3ZC4uNjExNjQ0NDQ1MTkyYmNlZGI2OTlkZjM5YjVk NDY3MDJmMTVmNzFjNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC0xNDIsNiArMTQyLDEzIEBAIGNsYXNzIEV4ZWN1dGl2ZShv YmplY3QpOgogICAgICAgICByZXR1cm4gY2hpbGRfb3V0cHV0CiAKICAgICBkZWYgY3B1X2NvdW50 KHNlbGYpOgorICAgICAgICBpZiAnTlVNQkVSX09GX1BST0NFU1NPUlMnIGluIG9zLmVudmlyb246 CisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgY3B1cyA9IGludChvcy5lbnZpcm9u LmdldCgnTlVNQkVSX09GX1BST0NFU1NPUlMnKSkKKyAgICAgICAgICAgICAgICBpZiBjcHVzID4g MDoKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGNwdXMKKyAgICAgICAgICAgIGV4Y2VwdDoK KyAgICAgICAgICAgICAgICBwYXNzCiAgICAgICAgIHJldHVybiBtdWx0aXByb2Nlc3NpbmcuY3B1 X2NvdW50KCkKIAogICAgIEBzdGF0aWNtZXRob2QK 198023 2013-04-14 22:40:11 -0700 2013-04-15 03:35:42 -0700 Patch bug-114506-20130415073945.patch text/plain 1554 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTc0YWQ1MDdhMGY3NjA5NWIzMTJlYmE3ZTA0YTg3NzEz MGI3NzY5OS4uYjhhZTgzZDQ4Mzc2OWM5NDVhYmQ5ZDYzNjcyN2I3OWY2MjVhZTQ0NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA0LTEyICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFt3ZWJraXRweV0gVXNlICROVU1CRVJfT0ZfUFJPQ0VTU09SUyBpbiBFeGVj dXRpdmUuY3B1X2NvdW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weToK KyAgICAgICAgKEV4ZWN1dGl2ZS5jcHVfY291bnQpOiBNb2RpZnkgZnVuY3Rpb24gaW4gb3JkZXIg dG8gdXNlIHRoZSBlbnZpcm9ubWVudAorICAgICAgICB2YXJpYWJsZSAkTlVNQkVSX09GX1BST0NF U1NPUlMgaWYgaXQgaXMgZGVmaW5lZCBhbmQgaXQgaXMgYW4gaW50ZWdlcgorICAgICAgICBncmVh dGVyIHRoYW4gMC4KKwogMjAxMy0wNC0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBCdWlsZCBmaXggYXR0ZW1wdCBmb3Igd2Via2l0Ym90LiBVbmljb2RpZnkg ZXZlcnl0aGluZy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmUucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZXhlY3V0aXZlLnB5CmluZGV4IDNiM2I3ZWY5OWEzZTRmYjk4NWRkMWIxMjQ2YTE3ZmRlNzI3Yzk2 N2QuLmJlMThjNzliNzE3ZDVlM2YxYzNiNTBjOTc1Y2M4NDFkNDcwM2U2YjAgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQpAQCAtMTQy LDYgKzE0MiwxMyBAQCBjbGFzcyBFeGVjdXRpdmUob2JqZWN0KToKICAgICAgICAgcmV0dXJuIGNo aWxkX291dHB1dAogCiAgICAgZGVmIGNwdV9jb3VudChzZWxmKToKKyAgICAgICAgaWYgJ05VTUJF Ul9PRl9QUk9DRVNTT1JTJyBpbiBvcy5lbnZpcm9uOgorICAgICAgICAgICAgdHJ5OgorICAgICAg ICAgICAgICAgIGNwdXMgPSBpbnQob3MuZW52aXJvbi5nZXQoJ05VTUJFUl9PRl9QUk9DRVNTT1JT JykpCisgICAgICAgICAgICAgICAgaWYgY3B1cyA+IDA6CisgICAgICAgICAgICAgICAgICAgIHJl dHVybiBjcHVzCisgICAgICAgICAgICBleGNlcHQgVmFsdWVFcnJvcjoKKyAgICAgICAgICAgICAg ICBwYXNzCiAgICAgICAgIHJldHVybiBtdWx0aXByb2Nlc3NpbmcuY3B1X2NvdW50KCkKIAogICAg IEBzdGF0aWNtZXRob2QK 198048 2013-04-15 03:35:47 -0700 2013-04-15 04:06:53 -0700 Patch bug-114506-20130415123521.patch text/plain 1493 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTc0YWQ1MDdhMGY3NjA5NWIzMTJlYmE3ZTA0YTg3NzEz MGI3NzY5OS4uYjhhZTgzZDQ4Mzc2OWM5NDVhYmQ5ZDYzNjcyN2I3OWY2MjVhZTQ0NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA0LTEyICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFt3ZWJraXRweV0gVXNlICROVU1CRVJfT0ZfUFJPQ0VTU09SUyBpbiBFeGVj dXRpdmUuY3B1X2NvdW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weToK KyAgICAgICAgKEV4ZWN1dGl2ZS5jcHVfY291bnQpOiBNb2RpZnkgZnVuY3Rpb24gaW4gb3JkZXIg dG8gdXNlIHRoZSBlbnZpcm9ubWVudAorICAgICAgICB2YXJpYWJsZSAkTlVNQkVSX09GX1BST0NF U1NPUlMgaWYgaXQgaXMgZGVmaW5lZCBhbmQgaXQgaXMgYW4gaW50ZWdlcgorICAgICAgICBncmVh dGVyIHRoYW4gMC4KKwogMjAxMy0wNC0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBCdWlsZCBmaXggYXR0ZW1wdCBmb3Igd2Via2l0Ym90LiBVbmljb2RpZnkg ZXZlcnl0aGluZy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmUucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZXhlY3V0aXZlLnB5CmluZGV4IDNiM2I3ZWY5OWEzZTRmYjk4NWRkMWIxMjQ2YTE3ZmRlNzI3Yzk2 N2QuLjliYjZkZjQzMjNiYjZjY2VmZGQzZmRkZWQ0YjI2YmFmMzBkZTkwMzEgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQpAQCAtMTQy LDYgKzE0MiwxMiBAQCBjbGFzcyBFeGVjdXRpdmUob2JqZWN0KToKICAgICAgICAgcmV0dXJuIGNo aWxkX291dHB1dAogCiAgICAgZGVmIGNwdV9jb3VudChzZWxmKToKKyAgICAgICAgdHJ5OgorICAg ICAgICAgICAgY3B1cyA9IGludChvcy5lbnZpcm9uLmdldCgnTlVNQkVSX09GX1BST0NFU1NPUlMn KSkKKyAgICAgICAgICAgIGlmIGNwdXMgPiAwOgorICAgICAgICAgICAgICAgIHJldHVybiBjcHVz CisgICAgICAgIGV4Y2VwdCAoVmFsdWVFcnJvciwgVHlwZUVycm9yKToKKyAgICAgICAgICAgIHBh c3MKICAgICAgICAgcmV0dXJuIG11bHRpcHJvY2Vzc2luZy5jcHVfY291bnQoKQogCiAgICAgQHN0 YXRpY21ldGhvZAo=