114501 2013-04-12 03:32:12 -0700 AnimationController: set timer delay to 0.016 in the BlackBerry port 2013-04-15 03:28:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 berto webkit-unassigned anilsson anlo cgarcia simon.fraser xan.lopez oldest_to_newest 874456 0 berto 2013-04-12 03:32:12 -0700 The BlackBerry is set to 60fps instead of 40. 874457 1 197741 berto 2013-04-12 03:35:35 -0700 Created attachment 197741 Patch This would be the trivial option, but I think anilsson has a better proposal, can you comment? 874458 2 berto 2013-04-12 03:36:21 -0700 Updating bug title since it affects cross-platform code. 874460 3 anilsson 2013-04-12 03:40:47 -0700 The thing I told berto about was: Another approach we have been discussing at BlackBerry is to hook up the AnimationController to the requestAnimationFrame mechanism. Then it would not have to use a Timer at all, and wouldn't have to hard code any timeout. It would perhaps be good if we could prioritize the tasks performed when RAF fires, so that JS handlers fire first (so they can start/stop animations, modify DOM etc) and then the AnimationController gets to run its native handlers. 874461 4 anilsson 2013-04-12 03:41:34 -0700 CC'ing Simon for his input 874788 5 simon.fraser 2013-04-12 09:18:04 -0700 AnimationController does use requestAnimationFrame for CSS animations: bug 64591, if the platform supports them. 875561 6 anilsson 2013-04-15 03:24:30 -0700 (In reply to comment #5) > AnimationController does use requestAnimationFrame for CSS animations: bug 64591, if the platform supports them. Thank you very much Simon - that's very useful! We can drop our local timer timeout tweak as soon as we pick up the fix for 64591. Marking this as invalid. 875562 7 anilsson 2013-04-15 03:28:42 -0700 (In reply to comment #3) > The thing I told berto about was: Another approach we have been discussing at BlackBerry is to hook up the AnimationController to the requestAnimationFrame mechanism. Then it would not have to use a Timer at all, and wouldn't have to hard code any timeout. > > It would perhaps be good if we could prioritize the tasks performed when RAF fires, so that JS handlers fire first (so they can start/stop animations, modify DOM etc) and then the AnimationController gets to run its native handlers. It's interesting to see that the developers on bug #64591 chose to let the AnimationController animations fire first, and only then service JS animations. I'm sure there's good arguments for doing it that way around, too. 197741 2013-04-12 03:35:35 -0700 2013-04-12 03:35:35 -0700 Patch 114501.diff text/plain 1166 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZjQzODY1Li42ZDc3NDJjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA0LTEyICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbQmxhY2tCZXJyeV0gQW5pbWF0aW9uQ29udHJvbGxlcjogc2V0IHRpbWVyIGRlbGF5 IHRvIDAuMDE2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTQ1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZSk6CisKIDIwMTMtMDQtMTEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CiAKICAgICAgICAgTW92ZSBDYWNoZWRSYXdSZXNvdXJjZUNsaWVudCBpbnRvIGEgc2VwYXJhdGUg ZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9u Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25D b250cm9sbGVyLmNwcAppbmRleCAxYzE1ODcwLi41OWIzY2FlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25Db250cm9sbGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25Db250cm9sbGVyLmNwcApAQCAtNDgs NyArNDgsMTEgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCisjaWYgUExBVEZPUk0oQkxBQ0tC RVJSWSkKK3N0YXRpYyBjb25zdCBkb3VibGUgY0FuaW1hdGlvblRpbWVyRGVsYXkgPSAwLjAxNjsK KyNlbHNlCiBzdGF0aWMgY29uc3QgZG91YmxlIGNBbmltYXRpb25UaW1lckRlbGF5ID0gMC4wMjU7 CisjZW5kaWYKIHN0YXRpYyBjb25zdCBkb3VibGUgY0JlZ2luQW5pbWF0aW9uVXBkYXRlVGltZU5v dFNldCA9IC0xOwogCiBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6QW5pbWF0aW9uQ29udHJv bGxlclByaXZhdGUoRnJhbWUqIGZyYW1lKQo=