114498 2013-04-12 02:07:52 -0700 [BlackBerry][CSS Filters] Non-image content disappears when filter applied 2013-04-15 02:17:04 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anlo cgarcia commit-queue jpetsovits mifenton rwlbuis tonikitoo xan.lopez oldest_to_newest 874439 0 anilsson 2013-04-12 02:07:52 -0700 For example: <div>Hello, world!</div> Applying style="-webkit-filter: blur(1px);" to this div makes it disappear. Sometimes it flickers into view or shows up depending on the order of rendering. PR 325051 874448 1 197739 anilsson 2013-04-12 03:00:50 -0700 Created attachment 197739 Patch 874449 2 anilsson 2013-04-12 03:03:11 -0700 I have been considering whether to add a new layout test that tries to apply a filter to some text. However, there's no reason to believe that other ports would fail to do that - being able to apply filters to images and rectangles means they will be able to apply them to anything. A test like that would just be duplication of already tested functionality to all other ports, and thus contribute nothing of value. Also, the BlackBerry port doesn't have pixel tests up and running yet, so such a test would not actually prevent regression of this fix. 874450 3 anilsson 2013-04-12 03:03:47 -0700 For these reasons I decided against adding a new layout test. For other ports, this is really already covered by existing layout tests. 874451 4 197739 cgarcia 2013-04-12 03:06:28 -0700 Comment on attachment 197739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197739&action=review > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:712 > + glVertexAttribPointer(m_positionLocation, 2, GL_FLOAT, GL_FALSE, 0, &layer->getTransformedBounds() ); There's an extra space between &layer->getTransformedBounds() and the last parentheses. 874459 5 anilsson 2013-04-12 03:37:05 -0700 (In reply to comment #4) > (From update of attachment 197739 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197739&action=review > > > Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:712 > > + glVertexAttribPointer(m_positionLocation, 2, GL_FLOAT, GL_FALSE, 0, &layer->getTransformedBounds() ); > > There's an extra space between &layer->getTransformedBounds() and the last parentheses. Thank you, I'll fix that before landing =) 875512 6 198034 anilsson 2013-04-15 01:44:56 -0700 Created attachment 198034 Patch 875524 7 198034 commit-queue 2013-04-15 02:17:02 -0700 Comment on attachment 198034 Patch Clearing flags on attachment: 198034 Committed r148423: <http://trac.webkit.org/changeset/148423> 875525 8 commit-queue 2013-04-15 02:17:04 -0700 All reviewed patches have been landed. Closing bug. 197739 2013-04-12 03:00:50 -0700 2013-04-15 01:44:51 -0700 Patch bug-114498-20130412120026.patch text/plain 2695 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTFjNTI3ZmY5ZDEzZmM2 Mzk3MWQ4ZTJjY2IzNTU5YjRlMDU5ZDIwMC4uZmZlYzcxOWRlYTdkZTllM2U2MGI2NjNkMGM0NDBl NjBhZTQ2ZDlkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA0LTEyICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV1bQ1NT IEZpbHRlcnNdIE5vbi1pbWFnZSBjb250ZW50IGRpc2FwcGVhcnMgd2hlbiBmaWx0ZXIgYXBwbGll ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NDk4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXBwbHlp bmcgYSBmaWx0ZXIgdG8gYSBkaXYgd2l0aCBzaW1wbGUgdGV4dCBjb250ZW50IGNhdXNlZCB0aGUg ZGl2IHRvCisgICAgICAgIGRpc2FwcGVhci4KKworICAgICAgICBJbiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Mjc2LCB3ZSBhZGRlZCBzb21lIEdMCisgICAgICAg IHN0YXRlIHNhdmUvcmVzdG9yZSBjb2RlIGZvciB2ZXJ0ZXggYXR0cmlidXRlcyB0byBtYWtlIHN1 cmUgdGhlIHN0YXRlCisgICAgICAgIGNoYW5nZXMgZG9uZSBieSBCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6R3JhcGhpY3MgZG9uJ3QgaW50ZXJmZXJlIHdpdGgKKyAgICAgICAgR0wgY29kZSBleGVjdXRp bmcgaW4gV2ViS2l0LiBIb3dldmVyLCBzYXZpbmcgYW5kIHJlc3RvcmluZyB2ZXJ0ZXgKKyAgICAg ICAgYXR0cmlidXRlIHN0YXRlIHdvbid0IGRvIG11Y2ggZ29vZCBpZiB0aG9zZSBhdHRyaWJ1dGVz IHdlcmUgbmV2ZXIKKyAgICAgICAgZW5hYmxlZCB0byBiZWdpbiB3aXRoLiBGaXhlZCBieSBlbmFi bGluZyB2ZXJ0ZXggYXR0cmlidXRlcworICAgICAgICBhcHByb3ByaWF0ZWx5IHdoZW4gc2V0dGlu ZyB0aGVtLCBzbyB0aGF0IHN0YXRlIGNhbiBiZSBzYXZlZCBhbmQKKyAgICAgICAgcmVzdG9yZWQu CisKKyAgICAgICAgQWxsIHRoZSBDU1MgRmlsdGVycyBsYXlvdXQgdGVzdHMgYXBwbHkgdGhlIGZp bHRlcnMgdG8gc2ltcGxlIHJlY3RhbmdsZXMKKyAgICAgICAgb3IgaW1hZ2VzLCB0aGVyZSdzIG5v dGhpbmcgc3VmZmljaWVudGx5IGNvbXBsZXggdGhhdCB3ZSBtYW5hZ2UgdG8KKyAgICAgICAgdHJp Z2dlciB0aGlzIEdMIHN0YXRlIGNvbmZsaWN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9MYXllckZpbHRlclJlbmRlcmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyRmlsdGVyUmVuZGVyZXI6OmFwcGx5QWN0aW9ucyk6CisKIDIwMTMtMDQtMTEgIEFydmlk IE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XVtDU1Mg RmlsdGVyc10gQmx1ciBmaWx0ZXIgZmFpbHMgdG8gcmVjb21wdXRlIGJsdXIgc2l6ZSB3aGVuIGxh eWVyIHNpemUgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYmxhY2tiZXJyeS9MYXllckZpbHRlclJlbmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJlci5jcHAKaW5k ZXggYzBhZGUxMGYwMmE1YmZkN2ZhYmEzNTFkZmYyYzNjNTE1MTFmNjU1Zi4uYWU5ZDYzMzA0YzMy ZTFmODVhZTdjMTNkNjY2ZWEzZjU2YjIwZDA0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllckZpbHRlclJlbmRlcmVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyRmlsdGVy UmVuZGVyZXIuY3BwCkBAIC03MDksOCArNzA5LDEwIEBAIHZvaWQgTGF5ZXJGaWx0ZXJSZW5kZXJl cjo6YXBwbHlBY3Rpb25zKHVuc2lnbmVkJiBmYm8sIExheWVyQ29tcG9zaXRpbmdUaHJlYWQqIGxh CiAKICAgICBMYXllclJlbmRlcmVyU3VyZmFjZSogc3VyZmFjZSA9IGxheWVyLT5sYXllclJlbmRl cmVyU3VyZmFjZSgpOwogCi0gICAgZ2xWZXJ0ZXhBdHRyaWJQb2ludGVyKDAsIDIsIEdMX0ZMT0FU LCBHTF9GQUxTRSwgMCwgJmxheWVyLT5nZXRUcmFuc2Zvcm1lZEJvdW5kcygpICk7CisgICAgZ2xW ZXJ0ZXhBdHRyaWJQb2ludGVyKG1fcG9zaXRpb25Mb2NhdGlvbiwgMiwgR0xfRkxPQVQsIEdMX0ZB TFNFLCAwLCAmbGF5ZXItPmdldFRyYW5zZm9ybWVkQm91bmRzKCkgKTsKKyAgICBnbEVuYWJsZVZl cnRleEF0dHJpYkFycmF5KG1fcG9zaXRpb25Mb2NhdGlvbik7CiAgICAgZ2xWZXJ0ZXhBdHRyaWJQ b2ludGVyKG1fdGV4Q29vcmRMb2NhdGlvbiwgMiwgR0xfRkxPQVQsIEdMX0ZBTFNFLCAwLCB0ZXhj b29yZHMpOworICAgIGdsRW5hYmxlVmVydGV4QXR0cmliQXJyYXkobV90ZXhDb29yZExvY2F0aW9u KTsKIAogICAgIG1fdGV4dHVyZS0+cHJvdGVjdChzdXJmYWNlLT50ZXh0dXJlKCktPnNpemUoKSwg QmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpBbHdheXNCYWNrZWQpOwogICAgIGlmIChy ZXF1aXJlU25hcHNob3QpCg== 198034 2013-04-15 01:44:56 -0700 2013-04-15 02:17:02 -0700 Patch bug-114498-20130415104429.patch text/plain 2989 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkyOWJmOWMxZWNiZGIy MzNkODRlNWVjOGZkYTdjNjcyOWE5YzRlNS4uMTcxZDIwZGVkMTJkYTNmMmIzZjZmYjBlNjAyNDc0 ZTM4NDEwMzAwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEzLTA0LTEyICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV1bQ1NT IEZpbHRlcnNdIE5vbi1pbWFnZSBjb250ZW50IGRpc2FwcGVhcnMgd2hlbiBmaWx0ZXIgYXBwbGll ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NDk4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAgICAg QXBwbHlpbmcgYSBmaWx0ZXIgdG8gYSBkaXYgd2l0aCBzaW1wbGUgdGV4dCBjb250ZW50IGNhdXNl ZCB0aGUgZGl2IHRvCisgICAgICAgIGRpc2FwcGVhci4KKworICAgICAgICBJbiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0Mjc2LCB3ZSBhZGRlZCBzb21lIEdMCisg ICAgICAgIHN0YXRlIHNhdmUvcmVzdG9yZSBjb2RlIGZvciB2ZXJ0ZXggYXR0cmlidXRlcyB0byBt YWtlIHN1cmUgdGhlIHN0YXRlCisgICAgICAgIGNoYW5nZXMgZG9uZSBieSBCbGFja0JlcnJ5OjpQ bGF0Zm9ybTo6R3JhcGhpY3MgZG9uJ3QgaW50ZXJmZXJlIHdpdGgKKyAgICAgICAgR0wgY29kZSBl eGVjdXRpbmcgaW4gV2ViS2l0LiBIb3dldmVyLCBzYXZpbmcgYW5kIHJlc3RvcmluZyB2ZXJ0ZXgK KyAgICAgICAgYXR0cmlidXRlIHN0YXRlIHdvbid0IGRvIG11Y2ggZ29vZCBpZiB0aG9zZSBhdHRy aWJ1dGVzIHdlcmUgbmV2ZXIKKyAgICAgICAgZW5hYmxlZCB0byBiZWdpbiB3aXRoLiBGaXhlZCBi eSBlbmFibGluZyB2ZXJ0ZXggYXR0cmlidXRlcworICAgICAgICBhcHByb3ByaWF0ZWx5IHdoZW4g c2V0dGluZyB0aGVtLCBzbyB0aGF0IHN0YXRlIGNhbiBiZSBzYXZlZCBhbmQKKyAgICAgICAgcmVz dG9yZWQuCisKKyAgICAgICAgQWxsIHRoZSBDU1MgRmlsdGVycyBsYXlvdXQgdGVzdHMgYXBwbHkg dGhlIGZpbHRlcnMgdG8gc2ltcGxlIHJlY3RhbmdsZXMKKyAgICAgICAgb3IgaW1hZ2VzLCB0aGVy ZSdzIG5vdGhpbmcgc3VmZmljaWVudGx5IGNvbXBsZXggdGhhdCB3ZSBtYW5hZ2UgdG8KKyAgICAg ICAgdHJpZ2dlciB0aGlzIEdMIHN0YXRlIGNvbmZsaWN0IGluIHRoZSBCbGFja0JlcnJ5IHBvcnQu IFRoaXMgc3VnZ2VzdHMKKyAgICAgICAgYWRkaW5nIGEgbmV3IHBsYXRmb3JtLXNwZWNpZmljIGxh eW91dCB0ZXN0IHdvdWxkIGJlIGFwcHJvcHJpYXRlLCBidXQKKyAgICAgICAgc2luY2Ugd2UgZG9u J3QgdXNlIHBpeGVsIHRlc3RzIHlldCwgc3VjaCBhIHRlc3Qgd291bGQgbm90IGhlbHAgZGV0ZWN0 CisgICAgICAgIHJlZ3Jlc3Npb25zLiBVbHRpbWF0ZWx5IHdlIGRlY2lkZWQgYWdhaW5zdCBhZGRp bmcgYSBsYXlvdXQgdGVzdCBmb3IKKyAgICAgICAgdGhpcyBidWcgYXQgdGhpcyB0aW1lLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllckZpbHRlclJlbmRlcmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyRmlsdGVyUmVuZGVyZXI6OmFwcGx5QWN0aW9u cyk6CisKIDIwMTMtMDQtMTQgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4K IAogICAgICAgICBbY3NzMy10ZXh0XSBQYXJzaW5nIC13ZWJraXQtaGFuZ2luZyB2YWx1ZSBmb3Ig dGV4dC1pbmRlbnQgZnJvbSBjc3MzLXRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyRmlsdGVyUmVuZGVy ZXIuY3BwCmluZGV4IGMwYWRlMTBmMDJhNWJmZDdmYWJhMzUxZGZmMmMzYzUxNTExZjY1NWYuLjBk MjZhZDE5ODViNGNlZGU1YjBjOTNlZDA4M2QyNGIxNDI0NWU3ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9M YXllckZpbHRlclJlbmRlcmVyLmNwcApAQCAtNzA5LDggKzcwOSwxMCBAQCB2b2lkIExheWVyRmls dGVyUmVuZGVyZXI6OmFwcGx5QWN0aW9ucyh1bnNpZ25lZCYgZmJvLCBMYXllckNvbXBvc2l0aW5n VGhyZWFkKiBsYQogCiAgICAgTGF5ZXJSZW5kZXJlclN1cmZhY2UqIHN1cmZhY2UgPSBsYXllci0+ bGF5ZXJSZW5kZXJlclN1cmZhY2UoKTsKIAotICAgIGdsVmVydGV4QXR0cmliUG9pbnRlcigwLCAy LCBHTF9GTE9BVCwgR0xfRkFMU0UsIDAsICZsYXllci0+Z2V0VHJhbnNmb3JtZWRCb3VuZHMoKSAp OworICAgIGdsVmVydGV4QXR0cmliUG9pbnRlcihtX3Bvc2l0aW9uTG9jYXRpb24sIDIsIEdMX0ZM T0FULCBHTF9GQUxTRSwgMCwgJmxheWVyLT5nZXRUcmFuc2Zvcm1lZEJvdW5kcygpKTsKKyAgICBn bEVuYWJsZVZlcnRleEF0dHJpYkFycmF5KG1fcG9zaXRpb25Mb2NhdGlvbik7CiAgICAgZ2xWZXJ0 ZXhBdHRyaWJQb2ludGVyKG1fdGV4Q29vcmRMb2NhdGlvbiwgMiwgR0xfRkxPQVQsIEdMX0ZBTFNF LCAwLCB0ZXhjb29yZHMpOworICAgIGdsRW5hYmxlVmVydGV4QXR0cmliQXJyYXkobV90ZXhDb29y ZExvY2F0aW9uKTsKIAogICAgIG1fdGV4dHVyZS0+cHJvdGVjdChzdXJmYWNlLT50ZXh0dXJlKCkt PnNpemUoKSwgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpBbHdheXNCYWNrZWQpOwog ICAgIGlmIChyZXF1aXJlU25hcHNob3QpCg==