11449 2006-10-29 07:35:49 -0800 Type-to-select in unopened popups doesn't work with Hebrew 2007-01-11 14:02:51 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned ap aroben oldest_to_newest 48516 0 mitz 2006-10-29 07:35:49 -0800 The newly added "type to select" feature for focused yet un-popped popups doesn't work with typing Hebrew. Once you pop the menu, type-to-select works. 35799 1 12364 mitz 2007-01-11 10:05:15 -0800 Created attachment 12364 Change isprint() to Unicode isPrintableChar() Includes change log and test. 35801 2 12364 aroben 2007-01-11 10:19:34 -0800 Comment on attachment 12364 Change isprint() to Unicode isPrintableChar() Can you make the test use standard DOM events instead of eventSender.keyDown? r=me 35802 3 mitz 2007-01-11 10:23:44 -0800 (In reply to comment #2) > (From update of attachment 12364 [edit]) > Can you make the test use standard DOM events instead of eventSender.keyDown? I'm afraid I can't, since charCode() looks at the PlatformKeyboardEvent. 35727 4 sam 2007-01-11 14:02:51 -0800 Landed in r18779. 12364 2007-01-11 10:05:15 -0800 2007-01-11 10:19:34 -0800 Change isprint() to Unicode isPrintableChar() 11449_r1.patch text/plain 3809 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4NzY4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDEtMTEgIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE0NDkKKyAgICAgICAgICBUeXBlLXRvLXNlbGVjdCBpbiB1bm9wZW5lZCBwb3B1cHMgZG9lc24n dCB3b3JrIHdpdGggSGVicmV3CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlbGVjdC10eXBlLWFo ZWFkLW5vbi1sYXRpbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMv c2VsZWN0LXR5cGUtYWhlYWQtbm9uLWxhdGluLmh0bWw6IEFkZGVkLgorCiAyMDA3LTAxLTEwICBS b2IgQnVpcyAgPGJ1aXNAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljLgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtdHlwZS1haGVhZC1ub24tbGF0aW4tZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0LXR5 cGUtYWhlYWQtbm9uLWxhdGluLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvZm9ybXMvc2VsZWN0LXR5cGUtYWhlYWQtbm9uLWxhdGluLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACitUZXN0IGZvciBodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ0OSBUeXBlLXRvLXNlbGVjdCBpbiB1bm9wZW5lZCBwb3B1 cHMgZG9lc24ndCB3b3JrIHdpdGggSGVicmV3LgorCisKK1NVQ0NFU1MKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtdHlwZS1haGVhZC1ub24tbGF0aW4uaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC10eXBlLWFoZWFkLW5vbi1sYXRp bi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtdHlw ZS1haGVhZC1ub24tbGF0aW4uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBAQAorPHA+ CisgICAgVGVzdCBmb3IgPGk+PGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE0NDkiPmh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NDQ5PC9hPgorICAgIFR5cGUtdG8tc2VsZWN0IGluIHVub3BlbmVkIHBvcHVwcyBkb2Vzbid0IHdv cmsgd2l0aCBIZWJyZXc8L2k+LgorPC9wPgorPHNlbGVjdCBpZD0ibWVudSI+PG9wdGlvbj4mI3gw NWU5Ozwvb3B0aW9uPjxvcHRpb24+JiN4MDVkMzs8L29wdGlvbj48b3B0aW9uPiYjeDA1ZDI7PC9v cHRpb24+PG9wdGlvbj4mI3gwNWRiOzwvb3B0aW9uPjxvcHRpb24+JiN4MDVlMjs8L29wdGlvbj48 L3NlbGVjdD4KKzxkaXYgaWQ9InJlc3VsdCI+Q2Fubm90IHJ1biBpbnRlcmFjdGl2ZWx5LjwvZGl2 PgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgdmFyIG1lbnUg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibWVudSIpOworICAgICAgICBtZW51LmZvY3VzKCk7 CisgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIlx1MDVkMiIpOworICAgICAgICB2YXIgcmVz dWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpOworICAgICAgICByZXN1bHQu aW5uZXJUZXh0ID0gbWVudS52YWx1ZSA9PSAiXHUwNWQyIiA/ICJTVUNDRVNTIiA6ICJGQUlMIjsK KyAgICB9Cis8L3NjcmlwdD4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODc2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDEtMTEgIE1pdHogUGV0dGVs ICA8bWl0ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNDQ5CisgICAgICAgICAgVHlwZS10by1zZWxlY3QgaW4gdW5vcGVuZWQgcG9wdXBzIGRvZXNu J3Qgd29yayB3aXRoIEhlYnJldworCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvc2VsZWN0LXR5 cGUtYWhlYWQtbm9uLWxhdGluLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNlbGVjdEVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIpOiBDaGFuZ2VkIGxvY2FsZS1zcGVjaWZpYworICAgICAgICBpc3ByaW50KCkgY29u ZGl0aW9uIHRvIGEgVW5pY29kZSBpc1ByaW50YWJsZUNoYXIoKS4KKwogMjAwNy0wMS0xMSAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJz LgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxODc2NikKKysr IFdlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3 MSw5ICs1NzEsOSBAQCB2b2lkIEhUTUxTZWxlY3RFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kCiAg ICAgaWYgKCFldnQtPmRlZmF1bHRIYW5kbGVkKCkgJiYgZXZ0LT50eXBlKCkgPT0ga2V5cHJlc3NF dmVudCAmJiBldnQtPmlzS2V5Ym9hcmRFdmVudCgpKSB7CiAgICAgICAgIEtleWJvYXJkRXZlbnQq IGtleWJvYXJkRXZlbnQgPSBzdGF0aWNfY2FzdDxLZXlib2FyZEV2ZW50Kj4oZXZ0KTsKICAgICAK LSAgICAgICAgaWYgKCFrZXlib2FyZEV2ZW50LT5jdHJsS2V5KCkgJiYgIWtleWJvYXJkRXZlbnQt PmFsdEtleSgpICYmICFrZXlib2FyZEV2ZW50LT5tZXRhS2V5KCkKLSAgICAgICAgICAgICYmIGlz cHJpbnQoc3RhdGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2dCktPmNoYXJDb2RlKCkpKSB7Ci0g ICAgICAgICAgICB0eXBlQWhlYWRGaW5kKHN0YXRpY19jYXN0PEtleWJvYXJkRXZlbnQqPihldnQp KTsKKyAgICAgICAgaWYgKCFrZXlib2FyZEV2ZW50LT5jdHJsS2V5KCkgJiYgIWtleWJvYXJkRXZl bnQtPmFsdEtleSgpICYmICFrZXlib2FyZEV2ZW50LT5tZXRhS2V5KCkgJiYKKyAgICAgICAgICAg IGlzUHJpbnRhYmxlQ2hhcihrZXlib2FyZEV2ZW50LT5jaGFyQ29kZSgpKSkgeworICAgICAgICAg ICAgdHlwZUFoZWFkRmluZChrZXlib2FyZEV2ZW50KTsKICAgICAgICAgICAgIGV2dC0+c2V0RGVm YXVsdEhhbmRsZWQoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQo=