114488 2013-04-11 20:39:06 -0700 REGRESSION(r147942): Potentially lots of crashes while updating widget hierarchy 2013-04-16 18:12:56 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 114521 Regression P1 Major --- 1 rniwa abucur abucur andersca ap commit-queue darin esprehn+autocc esprehn kevin sam thorton WebkitBugTracker oldest_to_newest 874342 0 rniwa 2013-04-11 20:39:06 -0700 See https://codereview.chromium.org/14218002/. We need to merge this Blink change back. 874351 1 rniwa 2013-04-11 21:59:28 -0700 esprehn: rniwa: I'd suggest rolling out r148092, r148026 and r147942 esprehn: unless you think you can fix removeChildren to be safe 874387 2 abucur 2013-04-11 23:59:33 -0700 Working on it. Hopefully I can find a proper fix by tomorrow morning your time. Otherwise I'll do the rollbacks. 874466 3 abucur 2013-04-12 04:17:48 -0700 This is the call stack causing the use after free: #0 0x000000010cc8da1e in WebCore::ScrollView::~ScrollView() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/platform/ScrollView.cpp:66 #1 0x000000010bc0d10d in WebCore::FrameView::~FrameView() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/page/FrameView.cpp:261 #2 0x000000010bc0cbe5 in WebCore::FrameView::~FrameView() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/page/FrameView.cpp:236 #3 0x000000010bc0cbb9 in WebCore::FrameView::~FrameView() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/page/FrameView.cpp:236 #4 0x000000010b4d84e3 in WTF::RefCounted<WebCore::Widget>::deref() at /Volumes/HDD/NonPerforce/WebKit/WebKitBuild/b114488/Debug/usr/local/include/wtf/RefCounted.h:202 #5 0x000000010b61625b in void WTF::derefIfNotNull<WebCore::FrameView>(WebCore::FrameView*) at /Volumes/HDD/NonPerforce/WebKit/WebKitBuild/b114488/Debug/usr/local/include/wtf/PassRefPtr.h:53 #6 0x000000010bbd8ed8 in WTF::RefPtr<WebCore::FrameView>::operator=(WTF::PassRefPtr<WebCore::FrameView> const&) at /Volumes/HDD/NonPerforce/WebKit/WebKitBuild/b114488/Debug/usr/local/include/wtf/RefPtr.h:134 #7 0x000000010bbd5085 in WebCore::Frame::setView(WTF::PassRefPtr<WebCore::FrameView>) at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/page/Frame.cpp:268 #8 0x000000010bbedef1 in WebCore::FrameLoader::closeAndRemoveChild(WebCore::Frame*) at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/loader/FrameLoader.cpp:2318 #9 0x000000010bbede25 in WebCore::FrameLoader::detachFromParent() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/loader/FrameLoader.cpp:2398 #10 0x000000010bbee147 in WebCore::FrameLoader::frameDetached() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/loader/FrameLoader.cpp:2376 #11 0x000000010bdafdd5 in WebCore::HTMLFrameOwnerElement::disconnectContentFrame() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/html/HTMLFrameOwnerElement.cpp:84 #12 0x000000010b6e3497 in WebCore::ChildFrameDisconnector::disconnectCollectedFrameOwners() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/dom/ContainerNodeAlgorithms.h:316 #13 0x000000010b6e06b1 in WebCore::ChildFrameDisconnector::disconnect(WebCore::ChildFrameDisconnector::DisconnectPolicy) at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/dom/ContainerNodeAlgorithms.h:336 #14 0x000000010b6dd75a in WebCore::ContainerNode::removeChildren() at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/dom/ContainerNode.cpp:596 #15 0x000000010c707476 in WebCore::replaceChildrenWithFragment(WebCore::ContainerNode*, WTF::PassRefPtr<WebCore::DocumentFragment>, int&) at /Volumes/HDD/NonPerforce/WebKit/Source/WebCore/editing/markup.cpp:1110 At first sight, it seems one of the children of the ScrollView is not properly reparented before the ScrollView is destroyed. I'll keep investigating. 874818 4 197863 abucur 2013-04-12 10:05:52 -0700 Created attachment 197863 Patch 875006 5 rniwa 2013-04-12 15:41:05 -0700 *** Bug 114413 has been marked as a duplicate of this bug. *** 876973 6 thorton 2013-04-16 17:43:54 -0700 <rdar://problem/13632610> 876983 7 rniwa 2013-04-16 18:12:56 -0700 *** This bug has been marked as a duplicate of bug 114521 *** 197863 2013-04-12 10:05:52 -0700 2013-04-12 10:32:42 -0700 Patch bug-114488-20130412200529.patch text/plain 8621 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIzZDA4NTI2MDM1YTM5 ZDNjNjI5MTQ3YzM3OGNlOWI5NDUyMWZhNS4uZjc5OWMyMzUzZTk3MDhhMDBiMjNjYzU0YTI0MDhh YzZkNDcyZGFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEzLTA0LTEyICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE0Nzk0 Mik6IFBvdGVudGlhbGx5IGxvdHMgb2YgY3Jhc2hlcyB3aGlsZSB1cGRhdGluZyB3aWRnZXQgaGll cmFyY2h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTQ0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD dXJyZW50bHkgaXQncyBwb3NzaWJsZSB0byBkaXNhYmxlIHRoZSB3aWRnZXQgaGllcmFyY2h5IHVw ZGF0ZXMgZHVyaW5nIERPTSBtYW5pcHVsYXRpb24KKyAgICAgICAgZnVuY3Rpb25zLiBXaGVuIGEg d2lkZ2V0IG5lZWRzIHRvIGJlIG1vdmVkLCB0aGUgbmV4dCBwYXJlbnQgaXMgc3RvcmVkIGluIGEg bWFwLiBUaGUgbXV0YXRpb24KKyAgICAgICAgaXMgYXBwbGllZCBvbmx5IHdoZW4gdGhlIHdpZGdl dCBoZWlyYXJjaHkgdXBkYXRlcyBhcmUgcmUtZW5hYmxlZC4gRHVyaW5nIHRoZSB0aW1lIHRoZSB3 aWRnZXQKKyAgICAgICAgdHJlZSBpcyBsb2NrZWQsIHRoZSBvbGQgcGFyZW50IGFuZCB0aGUgbmV3 IHBhcmVudCBvZiB0aGUgd2lkZ2V0IG1heSBiZSBkZWxldGVkIGNhdXNpbmcgYSBjcmFzaAorICAg ICAgICB3aGVuIHRoZSB0cmVlIGlzIHVubG9ja2VkLgorICAgICAgICBUaGUgcGF0Y2ggY2hhbmdl cyB0aGUgZGF0YSBzdHJjdHVyZSB1c2VkIHRvIHN0b3JlIHRoZSBuZXcgcGFyZW50IG9mIHRoZSB3 aWRnZXQgdG8gaG9sZCByZWZlcmVuY2VzCisgICAgICAgIHRvIGJvdGggdGhlIG9sZCBwYXJlbnQg YW5kIHRoZSBuZXcgcGFyZW50LiBUaGlzIHNob3VsZCBlbnN1cmUgdGhlIHdpZGdldCB0cmVlIG9w ZXJhdGlvbnMgYXJlCisgICAgICAgIGFsd2F5cyBzYWZlLgorICAgICAgICBUaGUgQ29udGFpbmVy Tm9kZTo6cmVtb3ZlQ2hpbGRyZW4gZnVuY3Rpb24gd2FzIGNoYW5nZWQgdG8gYWxsb3cgd2lkZ2V0 IHRyZWUgbWFuaXB1bGF0aW9uIGR1cmluZworICAgICAgICB0aGUgc2NyaXB0IGV4ZWN1dGlvbiAo YXMgaXQgaGFwcGVucyB3aXRoIHRoZSBvdGhlciBET00gbWFuaXB1bGF0aW9uIGZ1bmN0aW9ucyku CisKKyAgICAgICAgVGVzdHM6IHdvcmtpbmcgb24gaXQuLi4KKworICAgICAgICAqIGRvbS9Db250 YWluZXJOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRhaW5lck5vZGU6OnJlbW92ZUNo aWxkcmVuKTogRG8gbm90IGxvY2sgdGhlIHdpZGdldCB0cmVlIGR1cmluZyBzY3JpcHQgZXhlY3V0 aW9uLgorICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2Nyb2xsVmlldzo6flNjcm9sbFZpZXcpOiBBU1NFUlQgdGhlIGNoaWxkcmVuIGxpc3QgaXMg ZW1wdHkgd2hlbiB0aGUgU2Nyb2xsVmlldyBpcyBkZXN0cm95ZWQuCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlcldpZGdldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXRIaWVyYXJjaHlV cGRhdGVzU3VzcGVuc2lvblNjb3BlOjpzY2hlZHVsZVdpZGdldFRvTW92ZSk6CisgICAgICAgIChX ZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OldpZGdldEhpZXJhcmNoeVVwZGF0ZXNTdXNwZW5z aW9uU2NvcGU6Om1vdmVXaWRnZXRzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyV2lkZ2V0 Lmg6CisgICAgICAgIChXaWRnZXRIaWVyYXJjaHlVcGRhdGVzU3VzcGVuc2lvblNjb3BlKToKKwog MjAxMy0wNC0xMiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBmdW5jdGlvbmFsaXR5IGZpeCBmb3IgcG9ydHMgZW5hYmxpbmcgdGhlIE1p Y3JvRGF0YSBmZWF0dXJlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5l ck5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCmluZGV4IDE5 ZjQ5NzExNjdiYjY2ZWY2NzgwMmNmZmQxNDY3N2VlZDlmMWY5NmIuLmNkZWMwYTM1MmM0M2Y1YTMy MDIzNDA1M2FiYWEyOTU0NzhmYzdiZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9D b250YWluZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5j cHAKQEAgLTU4NCwzNiArNTg0LDQzIEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6cmVtb3ZlQ2hpbGRy ZW4oKQogCiAgICAgQ2hpbGRMaXN0TXV0YXRpb25TY29wZSBtdXRhdGlvbih0aGlzKTsKICAgICBO b2RlVmVjdG9yIHJlbW92ZWRDaGlsZHJlbjsKLSAgICB7CisgICAgd2hpbGUgKFJlZlB0cjxOb2Rl PiBjaGlsZCA9IG1fZmlyc3RDaGlsZCkgeworICAgICAgICAvLyBGaXJzdCBkaXNwYXRjaCB0aGUg bXV0YXRpb24gZXZlbnRzIGlmIGFueS4KKyAgICAgICAgLy8gVW5mb3J0dW5hdGVseSBpdCdzIHBv c3NpYmxlIGZvciB0aGlzIHRvIGJlIGNhbGxlZCBtb3JlIHRoYW4gb25jZSBmb3IgYSBub2RlCisg ICAgICAgIC8vIGJlY2F1c2Ugb2YgdGhlIG5hdHVyZSBvZiBtdXRhdGlvbiBldmVudHMgKGlmIHRo ZSBub2RlIGlzIG1vdmVkIGZ1cnRoZXIgaW4gdGhlIGNoaWxkIGxpc3QKKyAgICAgICAgLy8gYnkg YW4gZXZlbnQgaGFuZGxlcikuCisgICAgICAgIGRpc3BhdGNoQ2hpbGRSZW1vdmFsRXZlbnRzKGNo aWxkLmdldCgpKTsKKyAgICAgICAgQ2hpbGRGcmFtZURpc2Nvbm5lY3RvcihjaGlsZC5nZXQoKSku ZGlzY29ubmVjdCgpOworCisgICAgICAgIC8vIE11dGF0aW9uIG9yIHVubG9hZCBldmVudHMgY291 bGQgaGF2ZSBtb3ZlZCB0aGlzIGNoaWxkLgorICAgICAgICBpZiAoY2hpbGQgIT0gbV9maXJzdENo aWxkKQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgLy8gV2UgY2FuJ3QgdXNlIGEg YnVsayB2ZXJzaW9uIG9mIGRvY3VtZW50KCktPm5vZGVXaWxsQmVSZW1vdmVkKCkgYmVmb3JlIHRo ZSByZW1vdmFsIGxvb3AuCisgICAgICAgIC8vIFdlIG5lZWQgdG8gY2FsbCBkb2N1bWVudCgpLT5u b2RlV2lsbEJlUmVtb3ZlZCgpIG9uIGVhY2ggbm9kZSBpbiBjYXNlIHRoZSBub2RlIHdhcyBjcmVh dGVkCisgICAgICAgIC8vIGJ5IGEgbXV0YXRpb24gZXZlbnQgaGFuZGxlci4KKyAgICAgICAgLy8g ZG9jdW1lbnQoKS0+bm9kZVdpbGxiZVJlbW92ZWQoKSBtYXkgbW9kaWZ5IHRoZSBjaGlsZHJlbiBs aXN0IHNvIHdlIG1heSBuZWVkIHRvIHJldHJ5LgorICAgICAgICBkb2N1bWVudCgpLT5ub2RlV2ls bEJlUmVtb3ZlZChjaGlsZC5nZXQoKSk7CisgICAgICAgIGlmIChjaGlsZCAhPSBtX2ZpcnN0Q2hp bGQpCisgICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICAvLyBBZnRlciBhbGwgdGhlIHNj cmlwdHMgaGF2ZSBiZWVuIGV4ZWN1dGVkIHByb2NlZWQgd2l0aCB0aGUgcmVtb3ZhbCBvZiB0aGUg bm9kZS4KKyAgICAgICAgLy8gTG9jayB0aGUgd2lkZ2V0IHRyZWUgdW50aWwgdGhlIG5vZGUgaXMg cmVtb3ZlZC4KICAgICAgICAgV2lkZ2V0SGllcmFyY2h5VXBkYXRlc1N1c3BlbnNpb25TY29wZSBz dXNwZW5kV2lkZ2V0SGllcmFyY2h5VXBkYXRlczsKIAotICAgICAgICB3aGlsZSAoUmVmUHRyPE5v ZGU+IGNoaWxkID0gbV9maXJzdENoaWxkKSB7Ci0gICAgICAgICAgICAvLyBGaXJzdCBkaXNwYXRj aCB0aGUgbXV0YXRpb24gZXZlbnRzIGlmIGFueS4KLSAgICAgICAgICAgIC8vIFVuZm9ydHVuYXRl bHkgaXQncyBwb3NzaWJsZSBmb3IgdGhpcyB0byBiZSBjYWxsZWQgbW9yZSB0aGFuIG9uY2UgZm9y IGEgbm9kZQotICAgICAgICAgICAgLy8gYmVjYXVzZSBvZiB0aGUgbmF0dXJlIG9mIG11dGF0aW9u IGV2ZW50cyAoaWYgdGhlIG5vZGUgaXMgbW92ZWQgZnVydGhlciBpbiB0aGUgY2hpbGQgbGlzdAot ICAgICAgICAgICAgLy8gYnkgYW4gZXZlbnQgaGFuZGxlcikuCi0gICAgICAgICAgICBkaXNwYXRj aENoaWxkUmVtb3ZhbEV2ZW50cyhjaGlsZC5nZXQoKSk7Ci0gICAgICAgICAgICBDaGlsZEZyYW1l RGlzY29ubmVjdG9yKGNoaWxkLmdldCgpKS5kaXNjb25uZWN0KCk7Ci0KLSAgICAgICAgICAgIC8v IE11dGF0aW9uIG9yIHVubG9hZCBldmVudHMgY291bGQgaGF2ZSBtb3ZlZCB0aGlzIGNoaWxkLgot ICAgICAgICAgICAgaWYgKGNoaWxkICE9IG1fZmlyc3RDaGlsZCkKLSAgICAgICAgICAgICAgICBj b250aW51ZTsKLQotICAgICAgICAgICAgLy8gV2UgY2FuJ3QgdXNlIGEgYnVsayB2ZXJzaW9uIG9m IGRvY3VtZW50KCktPm5vZGVXaWxsQmVSZW1vdmVkKCkgYmVmb3JlIHRoZSByZW1vdmFsIGxvb3Au Ci0gICAgICAgICAgICAvLyBXZSBuZWVkIHRvIGNhbGwgZG9jdW1lbnQoKS0+bm9kZVdpbGxCZVJl bW92ZWQoKSBvbiBlYWNoIG5vZGUgaW4gY2FzZSB0aGUgbm9kZSB3YXMgY3JlYXRlZAotICAgICAg ICAgICAgLy8gYnkgYSBtdXRhdGlvbiBldmVudCBoYW5kbGVyLgotICAgICAgICAgICAgLy8gZG9j dW1lbnQoKS0+bm9kZVdpbGxiZVJlbW92ZWQoKSBtYXkgbW9kaWZ5IHRoZSBjaGlsZHJlbiBsaXN0 IHNvIHdlIG1heSBuZWVkIHRvIHJldHJ5LgotICAgICAgICAgICAgZG9jdW1lbnQoKS0+bm9kZVdp bGxCZVJlbW92ZWQoY2hpbGQuZ2V0KCkpOwotICAgICAgICAgICAgaWYgKGNoaWxkICE9IG1fZmly c3RDaGlsZCkKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAgICAgICAgLy8gTm90 aWZ5IHRoZSBtdXRhdGlvbiBvYnNlcnZlcnMuCi0gICAgICAgICAgICBtdXRhdGlvbi53aWxsUmVt b3ZlQ2hpbGQoY2hpbGQuZ2V0KCkpOwotICAgICAgICAgICAgY2hpbGQtPm5vdGlmeU11dGF0aW9u T2JzZXJ2ZXJzTm9kZVdpbGxEZXRhY2goKTsKLQotICAgICAgICAgICAgcmVtb3ZlQmV0d2Vlbigw LCBjaGlsZC0+bmV4dFNpYmxpbmcoKSwgY2hpbGQuZ2V0KCkpOwotICAgICAgICAgICAgcmVtb3Zl ZENoaWxkcmVuLmFwcGVuZChjaGlsZC5yZWxlYXNlKCkpOwotICAgICAgICB9CisgICAgICAgIC8v IE5vdGlmeSB0aGUgbXV0YXRpb24gb2JzZXJ2ZXJzLgorICAgICAgICBtdXRhdGlvbi53aWxsUmVt b3ZlQ2hpbGQoY2hpbGQuZ2V0KCkpOworICAgICAgICBjaGlsZC0+bm90aWZ5TXV0YXRpb25PYnNl cnZlcnNOb2RlV2lsbERldGFjaCgpOworCisgICAgICAgIHJlbW92ZUJldHdlZW4oMCwgY2hpbGQt Pm5leHRTaWJsaW5nKCksIGNoaWxkLmdldCgpKTsKKyAgICAgICAgcmVtb3ZlZENoaWxkcmVuLmFw cGVuZChjaGlsZC5yZWxlYXNlKCkpOworICAgIH0KKworICAgIC8vIE5vdGlmeSBpbnRlcmVzdGVk IHBhcnRpZXMgdGhlIERPTSB0cmVlIHdhcyBtb2RpZmllZC4KKyAgICAvLyBGSVhNRTogSXMgaXQg c3RpbGwgbmVjZXNzYXJ5IHRvIGxvY2sgdGhlIHdpZGdldCB0cmVlIHVudGlsIHRoZSBub3RpZmlj YXRpb25zIGFyZSBkb25lPworICAgIC8vIEZJWE1FOiBJcyBpdCBjb3JyZWN0IHRvIHVwZGF0ZSB0 aGUgd2lkZ2V0IHRyZWUgYmV0d2VlbiB0aGUgbm9kZSByZW1vdmFsIGFuZCB0aGUgbm90aWZpY2F0 aW9ucz8KKyAgICB7CisgICAgICAgIFdpZGdldEhpZXJhcmNoeVVwZGF0ZXNTdXNwZW5zaW9uU2Nv cGUgc3VzcGVuZFdpZGdldEhpZXJhcmNoeVVwZGF0ZXM7CiAKICAgICAgICAgLy8gRklYTUU6IFdl IGNvdWxkIGF2b2lkIHdhbGtpbmcgYWxsIHRoZSBjaGlsZHJlbiB0d2ljZSBieSBjYWxsaW5nCiAg ICAgICAgIC8vIG5vdGlmeSBpbnNpZGUgdGhlIGxvb3AgYW5kIGNoaWxkcmVuQ2hhbmdlZCBhZnRl ciBidXQgdGhhdCB3b3VsZCBtZWFuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3Bw CmluZGV4IGZkOGM3ODI3ZDY5MzMxM2UyODQ5NzdlNzU3ZGY4ZDJhOTNhZjM1NjguLjIyYzIwNDk5 NDFlY2E2ZTg0ODY4Y2UzYzQyY2NkNGViNDViOTFmZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L1Njcm9sbFZpZXcuY3BwCkBAIC02Myw2ICs2Myw3IEBAIFNjcm9sbFZpZXc6OlNjcm9sbFZpZXco KQogCiBTY3JvbGxWaWV3Ojp+U2Nyb2xsVmlldygpCiB7CisgICAgQVNTRVJUKCFtX2NoaWxkcmVu LnNpemUoKSk7CiAgICAgcGxhdGZvcm1EZXN0cm95KCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKaW5kZXggMTkwODI3YWM5MjM5NWVkMjc0MzFmNmQzZTQ3 NmM0ZGM4ZWUzMGVhNi4uNmYzMTMyOTI5ODU4YzhkNzBmM2EwMWM0ZDcyNzY1MmYyY2UxODIwOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKQEAgLTU1LDE1ICs1 NSwyNyBAQCBXaWRnZXRIaWVyYXJjaHlVcGRhdGVzU3VzcGVuc2lvblNjb3BlOjpXaWRnZXRUb1Bh cmVudE1hcCYgV2lkZ2V0SGllcmFyY2h5VXBkYXRlcwogICAgIHJldHVybiBtYXA7CiB9CiAKK3Zv aWQgV2lkZ2V0SGllcmFyY2h5VXBkYXRlc1N1c3BlbnNpb25TY29wZTo6c2NoZWR1bGVXaWRnZXRU b01vdmUoV2lkZ2V0KiB3aWRnZXQsIEZyYW1lVmlldyogZnJhbWUpCit7CisgICAgd2lkZ2V0TmV3 UGFyZW50TWFwKCkuc2V0KHdpZGdldCwgV2lkZ2V0UGFyZW50c1BhaXIoZnJhbWUsIHdpZGdldC0+ cGFyZW50KCkpKTsKK30KKwogdm9pZCBXaWRnZXRIaWVyYXJjaHlVcGRhdGVzU3VzcGVuc2lvblNj b3BlOjptb3ZlV2lkZ2V0cygpCiB7CisgICAgaWYgKHdpZGdldE5ld1BhcmVudE1hcCgpLmlzRW1w dHkoKSkKKyAgICAgICAgcmV0dXJuOworICAgIAogICAgIFdpZGdldFRvUGFyZW50TWFwIG1hcCA9 IHdpZGdldE5ld1BhcmVudE1hcCgpOwogICAgIHdpZGdldE5ld1BhcmVudE1hcCgpLmNsZWFyKCk7 CiAgICAgV2lkZ2V0VG9QYXJlbnRNYXA6Oml0ZXJhdG9yIGVuZCA9IG1hcC5lbmQoKTsKICAgICBm b3IgKFdpZGdldFRvUGFyZW50TWFwOjppdGVyYXRvciBpdCA9IG1hcC5iZWdpbigpOyBpdCAhPSBl bmQ7ICsraXQpIHsKICAgICAgICAgV2lkZ2V0KiBjaGlsZCA9IGl0LT5rZXkuZ2V0KCk7CisgICAg ICAgIFdpZGdldFBhcmVudHNQYWlyJiBwYXJlbnRzID0gaXQtPnZhbHVlOworCiAgICAgICAgIFNj cm9sbFZpZXcqIGN1cnJlbnRQYXJlbnQgPSBjaGlsZC0+cGFyZW50KCk7Ci0gICAgICAgIEZyYW1l VmlldyogbmV3UGFyZW50ID0gaXQtPnZhbHVlOworICAgICAgICBBU1NFUlQoY3VycmVudFBhcmVu dCA9PSBwYXJlbnRzLnNlY29uZCk7CisKKyAgICAgICAgRnJhbWVWaWV3KiBuZXdQYXJlbnQgPSBw YXJlbnRzLmZpcnN0LmdldCgpOwogICAgICAgICBpZiAobmV3UGFyZW50ICE9IGN1cnJlbnRQYXJl bnQpIHsKICAgICAgICAgICAgIGlmIChjdXJyZW50UGFyZW50KQogICAgICAgICAgICAgICAgIGN1 cnJlbnRQYXJlbnQtPnJlbW92ZUNoaWxkKGNoaWxkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJXaWRnZXQuaAppbmRleCBlZjhmM2I3NDE3OWQ4YzU4MDRlOTBjZTc4N2M1NmZkNDU5ODZh ZjU5Li5jMTlhMThhMWU4YWVkZDU4M2FmMWIxY2JjZjRkMTg3ODRiYzE4ZTE5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5oCkBAIC00MywxMCArNDMsMTEgQEAgcHVibGlj OgogICAgIH0KIAogICAgIHN0YXRpYyBib29sIGlzU3VzcGVuZGVkKCkgeyByZXR1cm4gc193aWRn ZXRIaWVyYXJjaHlVcGRhdGVTdXNwZW5kQ291bnQ7IH0KLSAgICBzdGF0aWMgdm9pZCBzY2hlZHVs ZVdpZGdldFRvTW92ZShXaWRnZXQqIHdpZGdldCwgRnJhbWVWaWV3KiBmcmFtZSkgeyB3aWRnZXRO ZXdQYXJlbnRNYXAoKS5zZXQod2lkZ2V0LCBmcmFtZSk7IH0KKyAgICBzdGF0aWMgdm9pZCBzY2hl ZHVsZVdpZGdldFRvTW92ZShXaWRnZXQqLCBGcmFtZVZpZXcqKTsKIAogcHJpdmF0ZToKLSAgICB0 eXBlZGVmIEhhc2hNYXA8UmVmUHRyPFdpZGdldD4sIEZyYW1lVmlldyo+IFdpZGdldFRvUGFyZW50 TWFwOworICAgIHR5cGVkZWYgc3RkOjpwYWlyPFJlZlB0cjxGcmFtZVZpZXc+LCBSZWZQdHI8U2Ny b2xsVmlldz4gPiBXaWRnZXRQYXJlbnRzUGFpcjsKKyAgICB0eXBlZGVmIEhhc2hNYXA8UmVmUHRy PFdpZGdldD4sIFdpZGdldFBhcmVudHNQYWlyPiBXaWRnZXRUb1BhcmVudE1hcDsKICAgICBzdGF0 aWMgV2lkZ2V0VG9QYXJlbnRNYXAmIHdpZGdldE5ld1BhcmVudE1hcCgpOwogCiAgICAgdm9pZCBt b3ZlV2lkZ2V0cygpOwo=