114462 2013-04-11 13:45:30 -0700 Cannot scroll to footer on a page with overflow:hidden on the body 2013-04-11 14:00:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin sam simon.fraser thorton oldest_to_newest 874120 0 bdakin 2013-04-11 13:45:30 -0700 If a WKView has a header/footer, you cannot scroll to the footer if the page has overflow:hidden on the body. <rdar://problem/13530042> 874137 1 197668 bdakin 2013-04-11 13:51:30 -0700 Created attachment 197668 Patch 874143 2 197668 simon.fraser 2013-04-11 13:56:26 -0700 Comment on attachment 197668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review > Source/WebCore/page/FrameView.cpp:614 > + || (m_frame->page() && m_frame->page()->mainFrame() == m_frame && (headerHeight() || footerHeight())); Why don't we have Frame::isMainFrame()? :( 874149 3 bdakin 2013-04-11 14:00:17 -0700 (In reply to comment #2) > (From update of attachment 197668 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review > > > Source/WebCore/page/FrameView.cpp:614 > > + || (m_frame->page() && m_frame->page()->mainFrame() == m_frame && (headerHeight() || footerHeight())); > > Why don't we have Frame::isMainFrame()? :( We REALLY should add this. http://trac.webkit.org/changeset/148234 197668 2013-04-11 13:51:30 -0700 2013-04-11 13:56:26 -0700 Patch for-review.txt text/plain 1938 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODIzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBDYW5ub3Qgc2Nyb2xsIHRvIGZvb3Rl ciBvbiBhIHBhZ2Ugd2l0aCBvdmVyZmxvdzpoaWRkZW4gb24gdGhlIGJvZHkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDQ2MgorICAgICAgICAtYW5k IGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzUzMDA0Mj4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBuZXcgc2Nl bmFyaW8gaW4gd2hpY2ggd2Ugd2FudCB0byBvdmVycmlkZUhpZGRlbiAtLSB3aGVuZXZlciB3ZSBh cmUgdGhlIAorICAgICAgICBtYWluRnJhbWUgYW5kIHRoZXJlIGlzIGEgaGVhZGVyIG9yIGZvb3Rl ci4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lVmlldzo6YXBwbHlPdmVyZmxvd1RvVmlld3BvcnQpOgorCiAyMDEzLTA0LTExICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFN0b3Jh Z2VNYW5hZ2VyOjpnZXRWYWx1ZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJl dmlzaW9uIDE0ODIxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjA3LDkgKzYwNywxMSBAQCB2b2lkIEZyYW1lVmlldzo6YXBwbHlPdmVy Zmxvd1RvVmlld3BvcnQoCiAgICAgLy8gdXNlIHRoZSByb290IGVsZW1lbnQuCiAKICAgICAvLyBU byBjb21iYXQgdGhlIGluYWJpbGl0eSB0byBzY3JvbGwgb24gYSBwYWdlIHdpdGggb3ZlcmZsb3c6 aGlkZGVuIG9uIHRoZSByb290IHdoZW4gc2NhbGVkLCBkaXNyZWdhcmQgaGlkZGVuIHdoZW4KLSAg ICAvLyB0aGVyZSBpcyBhIGZyYW1lU2NhbGVGYWN0b3IgdGhhdCBpcyBncmVhdGVyIHRoYW4gb25l IG9uIHRoZSBtYWluIGZyYW1lLgorICAgIC8vIHRoZXJlIGlzIGEgZnJhbWVTY2FsZUZhY3RvciB0 aGF0IGlzIGdyZWF0ZXIgdGhhbiBvbmUgb24gdGhlIG1haW4gZnJhbWUuIEFsc28gZGlzcmVnYXJk IGhpZGRlbiBpZiB0aGVyZSBpcyBhCisgICAgLy8gaGVhZGVyIG9yIGZvb3Rlci4KIAotICAgIGJv b2wgb3ZlcnJpZGVIaWRkZW4gPSBtX2ZyYW1lLT5wYWdlKCkgJiYgbV9mcmFtZS0+cGFnZSgpLT5t YWluRnJhbWUoKSA9PSBtX2ZyYW1lICYmIG1fZnJhbWUtPmZyYW1lU2NhbGVGYWN0b3IoKSA+IDE7 CisgICAgYm9vbCBvdmVycmlkZUhpZGRlbiA9IChtX2ZyYW1lLT5wYWdlKCkgJiYgbV9mcmFtZS0+ cGFnZSgpLT5tYWluRnJhbWUoKSA9PSBtX2ZyYW1lICYmIG1fZnJhbWUtPmZyYW1lU2NhbGVGYWN0 b3IoKSA+IDEpCisgICAgICAgIHx8IChtX2ZyYW1lLT5wYWdlKCkgJiYgbV9mcmFtZS0+cGFnZSgp LT5tYWluRnJhbWUoKSA9PSBtX2ZyYW1lICYmIChoZWFkZXJIZWlnaHQoKSB8fCBmb290ZXJIZWln aHQoKSkpOwogCiAgICAgRU92ZXJmbG93IG92ZXJmbG93WCA9IG8tPnN0eWxlKCktPm92ZXJmbG93 WCgpOwogICAgIEVPdmVyZmxvdyBvdmVyZmxvd1kgPSBvLT5zdHlsZSgpLT5vdmVyZmxvd1koKTsK