114450 2013-04-11 09:37:51 -0700 Default Implementation of toString for NPObject shouldn't return NPClass & NPObject address as String 2013-04-11 22:18:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 arurajku webkit-unassigned andersca ararunprasad commit-queue oldest_to_newest 873938 0 arurajku 2013-04-11 09:37:51 -0700 JSValue CInstance::stringValue(ExecState* exec) const { JSValue value; if (toJSPrimitive(exec, "toString", value)) return value; // Fallback to default implementation. char buf[1024]; snprintf(buf, sizeof(buf), "NPObject %p, NPClass %p", _object, _object->_class); return jsString(exec, buf); } In the above toString() default implementation, it leaks address of NPObject & NPClass to JS, it should be something like below, JSValue CInstance::stringValue(ExecState* exec) const { JSValue value; if (toJSPrimitive(exec, "toString", value)) return value; // Fallback to default implementation. return jsString(exec, "NPObject"); } 873960 1 197633 arurajku 2013-04-11 10:04:42 -0700 Created attachment 197633 Patch 873996 2 commit-queue 2013-04-11 11:17:48 -0700 The commit-queue encountered the following flaky tests while processing attachment 197633: svg/custom/empty-clip-path.svg bug 114453 (author: rwlbuis@gmail.com) The commit-queue is continuing to process your patch. 873997 3 197633 commit-queue 2013-04-11 11:18:38 -0700 Comment on attachment 197633 Patch Rejecting attachment 197633 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 197633, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 148214 = 820de4ece1da437818b95493f95a9bd02d45ac22 r148215 = 2bf34076aea6c98a56cb3985fb0255efc93faac2 r148216 = 39af3eace1316d74ce17e04bdd5c449fcf51da8d Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/19114 874015 4 197650 arurajku 2013-04-11 12:02:07 -0700 Created attachment 197650 Patch 874041 5 197650 commit-queue 2013-04-11 12:35:55 -0700 Comment on attachment 197650 Patch Clearing flags on attachment: 197650 Committed r148224: <http://trac.webkit.org/changeset/148224> 874042 6 commit-queue 2013-04-11 12:35:56 -0700 All reviewed patches have been landed. Closing bug. 874056 7 197650 darin 2013-04-11 12:47:03 -0700 Comment on attachment 197650 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197650&action=review > Source/WebCore/bridge/c/c_instance.cpp:285 > + return jsString(exec, "NPObject"); This should be calling jsNontrivialString rather than jsString. 874354 8 arurajku 2013-04-11 22:18:57 -0700 (In reply to comment #7) > (From update of attachment 197650 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197650&action=review > > > Source/WebCore/bridge/c/c_instance.cpp:285 > > + return jsString(exec, "NPObject"); > > This should be calling jsNontrivialString rather than jsString. jsNontrivialString(exec, String(ASCIILiteral("NPObject")) is ok? 197633 2013-04-11 10:04:42 -0700 2013-04-11 12:01:57 -0700 Patch bug-114450-20130411223359.patch text/plain 1329 arurajku SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODIxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTExICBBcnVucHJh c2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBEZWZhdWx0IElt cGxlbWVudGF0aW9uIG9mIHRvU3RyaW5nIGZvciBOUE9iamVjdCBzaG91bGRuJ3QgcmV0dXJuIE5Q Q2xhc3MgJiBOUE9iamVjdCBhZGRyZXNzIGFzIFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAg ICAgKiBicmlkZ2UvYy9jX2luc3RhbmNlLmNwcDoKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OkNJ bnN0YW5jZTo6c3RyaW5nVmFsdWUpOgorCiAyMDEzLTA0LTExICBBbGxhbiBTYW5kZmVsZCBKZW5z ZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIGhhbmRsZU1vdXNlTW92ZUV2 ZW50IHNob3VsZCBsZXQgaGl0LXRlc3RpbmcgaGl0LXRlc3Qgc2Nyb2xsYmFycwpJbmRleDogU291 cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19pbnN0YW5jZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvYnJpZGdlL2MvY19pbnN0YW5jZS5jcHAJKHJldmlzaW9uIDE0ODEyOCkKKysrIFNv dXJjZS9XZWJDb3JlL2JyaWRnZS9jL2NfaW5zdGFuY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y ODIsOSArMjgyLDcgQEAgSlNWYWx1ZSBDSW5zdGFuY2U6OnN0cmluZ1ZhbHVlKEV4ZWNTdGF0ZQog ICAgICAgICByZXR1cm4gdmFsdWU7CiAKICAgICAvLyBGYWxsYmFjayB0byBkZWZhdWx0IGltcGxl bWVudGF0aW9uLgotICAgIGNoYXIgYnVmWzEwMjRdOwotICAgIHNucHJpbnRmKGJ1Ziwgc2l6ZW9m KGJ1ZiksICJOUE9iamVjdCAlcCwgTlBDbGFzcyAlcCIsIF9vYmplY3QsIF9vYmplY3QtPl9jbGFz cyk7Ci0gICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMsIGJ1Zik7CisgICAgcmV0dXJuIGpzU3RyaW5n KGV4ZWMsICJOUE9iamVjdCIpOwogfQogCiBKU1ZhbHVlIENJbnN0YW5jZTo6bnVtYmVyVmFsdWUo RXhlY1N0YXRlKikgY29uc3QK 197650 2013-04-11 12:02:07 -0700 2013-04-11 12:47:03 -0700 Patch bug-114450-20130412003124.patch text/plain 1296 arurajku SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODIxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA0LTExICBBcnVucHJh c2FkIFJhamt1bWFyICA8YXJ1bnByYXNhZHJAbmRzLmNvbT4KKworICAgICAgICBEZWZhdWx0IElt cGxlbWVudGF0aW9uIG9mIHRvU3RyaW5nIGZvciBOUE9iamVjdCBzaG91bGRuJ3QgcmV0dXJuIE5Q Q2xhc3MgJiBOUE9iamVjdCBhZGRyZXNzIGFzIFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBicmlkZ2UvYy9jX2luc3RhbmNlLmNwcDoKKyAg ICAgICAgKEpTQzo6QmluZGluZ3M6OkNJbnN0YW5jZTo6c3RyaW5nVmFsdWUpOgorCiAyMDEzLTA0 LTExICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAg ICAgICAgIGhhbmRsZU1vdXNlTW92ZUV2ZW50IHNob3VsZCBsZXQgaGl0LXRlc3RpbmcgaGl0LXRl c3Qgc2Nyb2xsYmFycwpJbmRleDogU291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19pbnN0YW5jZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYnJpZGdlL2MvY19pbnN0YW5jZS5jcHAJ KHJldmlzaW9uIDE0ODEyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9jL2NfaW5zdGFuY2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODIsOSArMjgyLDcgQEAgSlNWYWx1ZSBDSW5zdGFuY2U6 OnN0cmluZ1ZhbHVlKEV4ZWNTdGF0ZQogICAgICAgICByZXR1cm4gdmFsdWU7CiAKICAgICAvLyBG YWxsYmFjayB0byBkZWZhdWx0IGltcGxlbWVudGF0aW9uLgotICAgIGNoYXIgYnVmWzEwMjRdOwot ICAgIHNucHJpbnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJOUE9iamVjdCAlcCwgTlBDbGFzcyAlcCIs IF9vYmplY3QsIF9vYmplY3QtPl9jbGFzcyk7Ci0gICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMsIGJ1 Zik7CisgICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMsICJOUE9iamVjdCIpOwogfQogCiBKU1ZhbHVl IENJbnN0YW5jZTo6bnVtYmVyVmFsdWUoRXhlY1N0YXRlKikgY29uc3QK