114443 2013-04-11 08:07:17 -0700 Build fix: use of uninitialized variable in ScrollingStateTree 2013-04-11 09:00:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 savagobr webkit-unassigned andersca cmarcelo commit-queue jamesr luiz tonikitoo oldest_to_newest 873825 0 savagobr 2013-04-11 08:07:17 -0700 Current trunk will fail compilation in Linux/gcc/Qt5 thanks to this warning: : /home/adenilson/apps/webkit/Webkit/Source/WTF/wtf/HashTraits.h:76:57: error: ‘newNode’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/adenilson/apps/webkit/Webkit/Source/WebCore/page/scrolling/ScrollingStateTree.cpp:65:25: note: ‘newNode’ was declared here cc1plus: all warnings being treated as errors make[3]: *** [.obj/release-shared/page/scrolling/ScrollingStateTree.o] Error 1 873829 1 197588 savagobr 2013-04-11 08:11:06 -0700 Created attachment 197588 Initialize the pointer before use (clears compilation warning). 873850 2 197588 commit-queue 2013-04-11 09:00:53 -0700 Comment on attachment 197588 Initialize the pointer before use (clears compilation warning). Clearing flags on attachment: 197588 Committed r148206: <http://trac.webkit.org/changeset/148206> 873851 3 commit-queue 2013-04-11 09:00:56 -0700 All reviewed patches have been landed. Closing bug. 197588 2013-04-11 08:11:06 -0700 2013-04-11 09:00:53 -0700 Initialize the pointer before use (clears compilation warning). build_fix.patch text/plain 1871 savagobr RnJvbSAwMjUyZjIxNWQzZjBhZjM3ODIzMTBlYzgxMDE4MzQ0MWM0NTE2MDY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBUaHUsIDExIEFwciAyMDEzIDExOjA5OjE0IC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gQnVpbGQgZml4LgoKU2lnbmVkLW9mZi1ieTogQWRlbmlsc29uIENhdmFsY2FudGkgPGNh dmFsY2FudGlpQGdtYWlsLmNvbT4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwIHwgICAgMiArLQogMiBmaWxl cyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDhiZGY1MGUuLjA1OTJhN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0wNC0x MSAgQWRlbmlsc29uIENhdmFsY2FudGkgIDxjYXZhbGNhbnRpaUBnbWFpbC5jb20+CisKKyAgICAg ICAgQnVpbGQgZml4OiB1c2Ugb2YgdW5pbml0aWFsaXplZCB2YXJpYWJsZSBpbiBTY3JvbGxpbmdT dGF0ZVRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNDQ0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluaXRpYWxpemUgcG9pbnRlciB0byB6ZXJvIGJlZm9yZSB1c2UsIGZpeGVzIGJ1aWxkLgorICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZXMgb24gYmVoYXZpb3IuCisKKyAgICAgICAgKiBw YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U2Nyb2xsaW5nU3RhdGVUcmVlOjphdHRhY2hOb2RlKToKKwogMjAxMy0wNC0xMSAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFBhcmVudCBib3ggd2l0aCBiYWNrZ3Jv dW5kLXNpemUgYXV0byBhbmQgZ3JhZGllbnQgaW1hZ2UgZG9lcyBub3QgZ2V0IHByb3Blcmx5IHJl cGFpbnRlZCB3aGVuIGNoaWxkIGJveCBpcyByZXNpemVkLiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwCmluZGV4IDA4MTgxODYu LjExMGU1ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9s bGluZ1N0YXRlVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Ny b2xsaW5nU3RhdGVUcmVlLmNwcApAQCAtNjIsNyArNjIsNyBAQCBTY3JvbGxpbmdOb2RlSUQgU2Ny b2xsaW5nU3RhdGVUcmVlOjphdHRhY2hOb2RlKFNjcm9sbGluZ05vZGVUeXBlIG5vZGVUeXBlLCBT Y3JvbAogICAgICAgICByZW1vdmVOb2RlKG5vZGUpOwogICAgIH0KIAotICAgIFNjcm9sbGluZ1N0 YXRlTm9kZSogbmV3Tm9kZTsKKyAgICBTY3JvbGxpbmdTdGF0ZU5vZGUqIG5ld05vZGUgPSAwOwog ICAgIGlmICghcGFyZW50SUQpIHsKICAgICAgICAgLy8gSWYgd2UncmUgcmVzZXR0aW5nIHRoZSBy b290IG5vZGUsIHdlIHNob3VsZCBjbGVhciB0aGUgSGFzaE1hcCBhbmQgZGVzdHJveSB0aGUgY3Vy cmVudCBjaGlsZHJlbi4KICAgICAgICAgY2xlYXIoKTsKLS0gCjEuNy4xMC40Cgo=