11444 2006-10-28 06:46:16 -0700 REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]: attempt to insert nil value) when submitting a form with an empty uninitialized field 2006-10-29 21:56:34 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED data:text/html,<form><input><input%20type="submit"%20value="Crash"></form> Regression P1 Normal --- 1 mitz webkit-unassigned ddkilzer ggaren oldest_to_newest 48914 0 mitz 2006-10-28 06:46:16 -0700 If you open the URL in a debug build of TOT and click the Crash button you get ASSERTION FAILED: Uncaught exception - *** -[NSCFDictionary setObject:forKey:]: attempt to insert nil value This is coming from createNSDictionary (FrameMac.mm) when the second String in a pair, which is the form field's value, is a NULL string. Before r17378 it was converted to an empty NSString, but now it's converted to nil, which cannot be inserted into the NSDictionary. 48767 1 ddkilzer 2006-10-28 15:47:22 -0700 Occurs when submitting Bugzilla comments (see Bug 10933 Comment #8). 48517 2 darin 2006-10-29 10:08:31 -0800 Fixed in r17408. (I didn't know about this bug report when I fixed it.) 48518 3 darin 2006-10-29 10:10:01 -0800 We need a layout test for this. 48520 4 11275 mitz 2006-10-29 10:49:38 -0800 Created attachment 11275 Layout test 48522 5 ggaren 2006-10-29 11:03:21 -0800 Committed revision 17419. 48543 6 11275 timothy 2006-10-29 21:56:34 -0800 Comment on attachment 11275 Layout test THis landed. 11275 2006-10-29 10:49:38 -0800 2006-10-29 21:56:34 -0800 Layout test 11444_test_r1.patch text/plain 2538 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3NDE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMTAtMjkgIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NDQ0CisgICAgICAgIFJFR1JFU1NJT04gKHIxNzM3OCk6IEV4Y2VwdGlvbiAoLVtOU0NGRGljdGlv bmFyeSBzZXRPYmplY3Q6Zm9yS2V5Ol06IGF0dGVtcHQgdG8gaW5zZXJ0IG5pbCB2YWx1ZSkKKyAg ICAgICAgd2hlbiBzdWJtaXR0aW5nIGEgZm9ybSB3aXRoIGFuIGVtcHR5IHVuaW5pdGlhbGl6ZWQg ZmllbGQKKworICAgICAgICAqIGZhc3QvZm9ybXMvc3VibWl0LW5pbC12YWx1ZS1maWVsZC1hc3Nl cnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3N1Ym1pdC1uaWwt dmFsdWUtZmllbGQtYXNzZXJ0Lmh0bWw6IEFkZGVkLgorCiAyMDA2LTEwLTMwICBNYXJrIFJvd2Ug IDxiZGFzaEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LW5pbC12YWx1ZS1maWVsZC1hc3NlcnQtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LW5p bC12YWx1ZS1maWVsZC1hc3NlcnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9zdWJtaXQtbmlsLXZhbHVlLWZpZWxkLWFzc2VydC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNiBAQAorVGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NDQgUkVHUkVTU0lPTiAocjE3Mzc4KTogRXhjZXB0 aW9uICgtW05TQ0ZEaWN0aW9uYXJ5IHNldE9iamVjdDpmb3JLZXk6XTogYXR0ZW1wdCB0byBpbnNl cnQgbmlsIHZhbHVlKSB3aGVuIHN1Ym1pdHRpbmcgYSBmb3JtIHdpdGggYW4gZW1wdHkgdW5pbml0 aWFsaXplZCBmaWVsZC4KKworUEFTUworCisKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9zdWJtaXQtbmlsLXZhbHVlLWZpZWxkLWFzc2VydC5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LW5pbC12YWx1ZS1maWVsZC1hc3NlcnQuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LW5pbC12YWx1ZS1maWVs ZC1hc3NlcnQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMyBAQAorPHA+CisgICAgVGVz dCBmb3IgPGk+PGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE0NDQiPmh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDQ0PC9hPgor ICAgIFJFR1JFU1NJT04gKHIxNzM3OCk6IEV4Y2VwdGlvbiAoLVtOU0NGRGljdGlvbmFyeSBzZXRP YmplY3Q6Zm9yS2V5Ol06IGF0dGVtcHQgdG8gaW5zZXJ0IG5pbCB2YWx1ZSkgd2hlbiBzdWJtaXR0 aW5nIGEgZm9ybSB3aXRoIGFuIGVtcHR5IHVuaW5pdGlhbGl6ZWQgZmllbGQ8L2k+LgorPC9wPgor PHAgaWQ9InJlc3VsdCI+RkFJTDwvcD4KKzxocj4KKzxmb3JtIGlkPSJ0Ij48aW5wdXQ+PC9mb3Jt PgorPHNjcmlwdD4KKyAgICBpZiAoIWxvY2F0aW9uLmhyZWYubWF0Y2goJ1xcPycpKSB7CisgICAg ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgfQorICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidCIpLnN1Ym1pdCgpOworICAgICAgICAvLyBEb24ndCBsZWF2ZSBEdW1wUmVu ZGVyVHJlZSBoYW5naW5nIGluIGNhc2Ugc3VibWl0KCkgZmFpbGVkCisgICAgICAgIGlmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5ub3RpZnlEb25lKCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9ICJQQVNTIjsKKyAgICAgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5v dGlmeURvbmUoKTsKKyAgICB9Cis8L3NjcmlwdD4K