114435 2013-04-11 05:23:56 -0700 [Qt][Mac] Linking fails with Qt 5.1 2013-09-16 12:14:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi allan.jensen commit-queue dino hausmann vestbo oldest_to_newest 873762 0 abecsi 2013-04-11 05:23:56 -0700 [Qt][Mac] Linking fails with Qt 5.1 873766 1 197578 abecsi 2013-04-11 05:24:58 -0700 Created attachment 197578 Patch 873772 2 197578 hausmann 2013-04-11 06:02:07 -0700 Comment on attachment 197578 Patch r=me but I'd prefer if the QMAKE_LFLAGS/CXXFLAGS setting could be replaced with CONFIG -= c++11 if it works. (mkspecs/features/c++11.prf adds those in the first place, and that should be processed after this .pri file) 873774 3 197578 vestbo 2013-04-11 06:07:15 -0700 Comment on attachment 197578 Patch I agree with Simon, try CONFIG -= c++11 first. 873782 4 abecsi 2013-04-11 06:32:33 -0700 Using CONFIG -= c++11 does not fix the issue for me. The build still fails because the linking command line still includes -stdlib=libc++. 873786 5 abecsi 2013-04-11 06:46:10 -0700 In ANGLE.pri CONFIG does not even contain c++11 yet, and because QT_CONFIG does it is still added to CONFIG in mkspecs/features/qt_common.prf, which apparently happens after processing this pri file. 873787 6 vestbo 2013-04-11 06:48:31 -0700 (In reply to comment #5) > In ANGLE.pri CONFIG does not even contain c++11 yet, and because QT_CONFIG does it is still added to CONFIG in mkspecs/features/qt_common.prf, which apparently happens after processing this pri file. Not sure why c++11 is handled that way, but QT_CONFIG -= c++11 should work around it. 873796 7 abecsi 2013-04-11 07:05:29 -0700 (In reply to comment #6) > (In reply to comment #5) > > In ANGLE.pri CONFIG does not even contain c++11 yet, and because QT_CONFIG does it is still added to CONFIG in mkspecs/features/qt_common.prf, which apparently happens after processing this pri file. > > Not sure why c++11 is handled that way, but QT_CONFIG -= c++11 should work around it. Ok, I though changing QT_CONFIG would not be an option. 873797 8 vestbo 2013-04-11 07:06:31 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > In ANGLE.pri CONFIG does not even contain c++11 yet, and because QT_CONFIG does it is still added to CONFIG in mkspecs/features/qt_common.prf, which apparently happens after processing this pri file. > > > > Not sure why c++11 is handled that way, but QT_CONFIG -= c++11 should work around it. > > Ok, I though changing QT_CONFIG would not be an option. It's a bit hackish, but less so than changing the QMAKE_LFLAGS_CXX11 873801 9 197586 abecsi 2013-04-11 07:24:49 -0700 Created attachment 197586 Patch 873826 10 197586 abecsi 2013-04-11 08:08:28 -0700 Comment on attachment 197586 Patch Clearing flags on attachment: 197586 Committed r148204: <http://trac.webkit.org/changeset/148204> 873827 11 abecsi 2013-04-11 08:08:33 -0700 All reviewed patches have been landed. Closing bug. 929772 12 allan.jensen 2013-09-16 09:49:34 -0700 How is this supposed to work. If you build ANGLE with libstdc++ includes, the symbols are just going to be missing in the final binary. This is the result of merging this now: http://testresults.qt-project.org/ci/QtWebKit_dev_Integration/build_00098/macx-clang_developer-build_OSX_10.8/log.txt.gz ANGLE referencing libstdc++ specific stuff, which is never linked in. 929850 13 abecsi 2013-09-16 12:02:43 -0700 (In reply to comment #12) > How is this supposed to work. If you build ANGLE with libstdc++ includes, the symbols are just going to be missing in the final binary. > > This is the result of merging this now: > http://testresults.qt-project.org/ci/QtWebKit_dev_Integration/build_00098/macx-clang_developer-build_OSX_10.8/log.txt.gz > > ANGLE referencing libstdc++ specific stuff, which is never linked in. ANGLE should not be build with c++11 support, and it wasn't when this got committed, since then the configuration in Qt might have changed, so this might not have an effect any more. 929856 14 allan.jensen 2013-09-16 12:14:00 -0700 (In reply to comment #13) > (In reply to comment #12) > > How is this supposed to work. If you build ANGLE with libstdc++ includes, the symbols are just going to be missing in the final binary. > > > > This is the result of merging this now: > > http://testresults.qt-project.org/ci/QtWebKit_dev_Integration/build_00098/macx-clang_developer-build_OSX_10.8/log.txt.gz > > > > ANGLE referencing libstdc++ specific stuff, which is never linked in. > > ANGLE should not be build with c++11 support, and it wasn't when this got committed, since then the configuration in Qt might have changed, so this might not have an effect any more. It isn't but that means it will by default be build with libstdc++, where the final QtWebKit module is linked with libc++. This means we end up with the wrong symbols. 197578 2013-04-11 05:24:58 -0700 2013-04-11 07:24:44 -0700 Patch bug-114435-20130411142441.patch text/plain 1554 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggODEwOGRmZTZmMWVkMjliZmZjMjlmOWZkYjhkYzVjMDMyMjgyNmVhZi4uNDJiMmMzYzZlOWVj NDY0ZGQyNDFjNGZlYjcxN2QyOTQ0MjIxMTAwYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTExICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVj c2lAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF1bTWFjXSBMaW5raW5nIGZhaWxzIHdpdGggUXQg NS4xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ0 MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdCA1 LjEgZW5hYmxlcyBDKysxMSBieSBkZWZhdWx0IHdoZW4gdXNpbmcgY2xhbmcgb24gTWFjCisgICAg ICAgIGFuZCBsaW5rcyBhZ2FpbnN0IHRoZSBsaWJjKysgc3RhbmRhcmQgbGlicmFyeS4gQXMgYSBy ZXN1bHQKKyAgICAgICAgYnVpbGRpbmcgdGhlIFF0V2ViS2l0IHNoYXJlZCBsaWJyYXJ5IGZhaWxz IHdoZW4gbGlua2luZworICAgICAgICBhZ2FpbnMgdGhlIEFOR0xFIGludGVybWVkaWF0ZSBzdGF0 aWMgbGlicmFyeSBiZWNhdXNlIGxpYmMrKworICAgICAgICBtaXNzZXMgc29tZSBzeW1ib2xzIG5l ZWRlZCBieSBBTkdMRS4KKyAgICAgICAgRGlzYWJsZSBDKysxMSBvcHRpb25zIGZvciBhbGwgdGFy Z2V0cyB0aGF0IGxpbmsgYWdhaW5zdCB0aGUKKyAgICAgICAgQU5HTEUgaW50ZXJtZWRpYXRlIGxp YnJhcnkgdG8gZml4IHRoZSBidWlsZC4KKworICAgICAgICAqIEFOR0xFLnByaToKKwogMjAxMy0w NC0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBN YXNzIHJlbW92ZSBhbGwgdGhlIGVtcHR5IGRpcmVjdG9yaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9BTkdMRS5wcmkgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9BTkdM RS5wcmkKaW5kZXggZTA2OWIxNDFmNzJhYTI2ZTg0NzkzMTYxODMwODg3MDc0OTU0NzAwYS4uZDgw MmIzNGY2ZTgwMTRhOWNmNTRlZjUxNTZmZTExOWRjZDc0MmQ0YSAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvQU5HTEUucHJpCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L0FOR0xFLnByaQpAQCAtNyw2ICs3LDExIEBACiAKIFNPVVJDRV9ESVIgPSAkJHtST09UX1dFQktJ VF9ESVJ9L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFCiAKKypjbGFuZyB7CisgICAgUU1BS0VfTEZM QUdTX0NYWDExID0KKyAgICBRTUFLRV9DWFhGTEFHU19DWFgxMSA9Cit9CisKIElOQ0xVREVQQVRI ICs9IFwKICAgICAkJFNPVVJDRV9ESVIvaW5jbHVkZS9HTFNMQU5HIFwKICAgICAkJFNPVVJDRV9E SVIvaW5jbHVkZS9LSFIK 197586 2013-04-11 07:24:49 -0700 2013-04-11 08:08:28 -0700 Patch bug-114435-20130411162432.patch text/plain 1467 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggODEwOGRmZTZmMWVkMjliZmZjMjlmOWZkYjhkYzVjMDMyMjgyNmVhZi4uNGE2OWUxNTk1YTJj YTIzMWM0Y2QyY2JmYmQ4MzI2Y2M1NjZkY2RhYiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTExICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVj c2lAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF1bTWFjXSBMaW5raW5nIGZhaWxzIHdpdGggUXQg NS4xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQ0 MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdCA1 LjEgZW5hYmxlcyBDKysxMSBieSBkZWZhdWx0IHdoZW4gdXNpbmcgY2xhbmcgb24gTWFjCisgICAg ICAgIGFuZCBsaW5rcyBhZ2FpbnN0IHRoZSBsaWJjKysgc3RhbmRhcmQgbGlicmFyeS4gQXMgYSBy ZXN1bHQKKyAgICAgICAgYnVpbGRpbmcgdGhlIFF0V2ViS2l0IHNoYXJlZCBsaWJyYXJ5IGZhaWxz IHdoZW4gbGlua2luZworICAgICAgICBhZ2FpbnMgdGhlIEFOR0xFIGludGVybWVkaWF0ZSBzdGF0 aWMgbGlicmFyeSBiZWNhdXNlIGxpYmMrKworICAgICAgICBtaXNzZXMgc29tZSBzeW1ib2xzIG5l ZWRlZCBieSBBTkdMRS4KKyAgICAgICAgRGlzYWJsZSBDKysxMSBmb3IgdGhlIEFOR0xFIGludGVy bWVkaWF0ZSBsaWJyYXJ5IHRvIGZpeCB0aGUgYnVpbGQuCisKKyAgICAgICAgKiBBTkdMRS5wcmk6 CisKIDIwMTMtMDQtMTAgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgTWFzcyByZW1vdmUgYWxsIHRoZSBlbXB0eSBkaXJlY3RvcmllcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQU5HTEUucHJpIGIvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvQU5HTEUucHJpCmluZGV4IGUwNjliMTQxZjcyYWEyNmU4NDc5MzE2MTgzMDg4NzA3NDk1 NDcwMGEuLmZjYjRhNDRkYWYxMGJhZTE3NWFiODZiYzg2ZTk3ZDA4MWRkOWE0YzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnByaQorKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9BTkdMRS5wcmkKQEAgLTcsNiArNyw4IEBACiAKIFNPVVJDRV9ESVIgPSAkJHtS T09UX1dFQktJVF9ESVJ9L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFCiAKKypjbGFuZzogUVRfQ09O RklHIC09IGMrKzExCisKIElOQ0xVREVQQVRIICs9IFwKICAgICAkJFNPVVJDRV9ESVIvaW5jbHVk ZS9HTFNMQU5HIFwKICAgICAkJFNPVVJDRV9ESVIvaW5jbHVkZS9LSFIK