11442 2006-10-28 01:41:49 -0700 [CSS 3] support for cursor: all-scroll 2006-11-01 03:55:05 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 lars webkit-unassigned ddkilzer mjs oldest_to_newest 49000 0 lars 2006-10-28 01:41:49 -0700 We should support more of the CSS 3 cursor style selectors. All-scroll could (for now) be the same as our 'move' cursor. 48910 1 11265 lars 2006-10-28 01:49:07 -0700 Created attachment 11265 adds support for CSS cursor style all-scroll Sets the 'move' cursor to be used for CSS cursor style="all-scroll" 48219 2 11265 mjs 2006-10-31 10:25:16 -0800 Comment on attachment 11265 adds support for CSS cursor style all-scroll r=me 48248 3 timothy 2006-10-31 13:10:43 -0800 Landed in r17493 48271 4 11265 ddkilzer 2006-10-31 16:31:34 -0800 Comment on attachment 11265 adds support for CSS cursor style all-scroll >Index: WebCore/css/CSSComputedStyleDeclaration.cpp >=================================================================== >--- WebCore/css/CSSComputedStyleDeclaration.cpp (revision 17395) >+++ WebCore/css/CSSComputedStyleDeclaration.cpp (working copy) >@@ -680,6 +680,9 @@ PassRefPtr<CSSValue> CSSComputedStyleDec > break; > case CURSOR_HELP: > value = new CSSPrimitiveValue(CSS_VAL_HELP); >+ case CURSOR_ALL_SCROLL: >+ value = new CSSPrimitiveValue(CSS_VAL_ALL_SCROLL); >+ break; > } > ASSERT(value); > if (list) { I believe there is a missing "break;" statement after "case CURSOR_HELP:" now. Patch forthcoming. 48272 5 ddkilzer 2006-10-31 16:31:53 -0800 Reopening to fix missing "break;" statement. 48273 6 11315 ddkilzer 2006-10-31 16:33:17 -0800 Created attachment 11315 Fix missing "break;" statement from previous patch 48142 7 11315 mitz 2006-10-31 22:00:34 -0800 Comment on attachment 11315 Fix missing "break;" statement from previous patch r=me 47714 8 ddkilzer 2006-11-01 03:55:05 -0800 Committed revision 17516 for Attachment 11315. 11265 2006-10-28 01:49:07 -0700 2006-10-31 10:25:16 -0800 adds support for CSS cursor style all-scroll allscrollcursor.txt text/plain 3363 lars SW5kZXg6IFdlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAkocmV2 aXNpb24gMTczOTUpCisrKyBXZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24u Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02ODAsNiArNjgwLDkgQEAgUGFzc1JlZlB0cjxDU1NWYWx1 ZT4gQ1NTQ29tcHV0ZWRTdHlsZURlYwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAg ICAgY2FzZSBDVVJTT1JfSEVMUDoKICAgICAgICAgICAgICAgICB2YWx1ZSA9IG5ldyBDU1NQcmlt aXRpdmVWYWx1ZShDU1NfVkFMX0hFTFApOworICAgICAgICAgICAgY2FzZSBDVVJTT1JfQUxMX1ND Uk9MTDoKKyAgICAgICAgICAgICAgICB2YWx1ZSA9IG5ldyBDU1NQcmltaXRpdmVWYWx1ZShDU1Nf VkFMX0FMTF9TQ1JPTEwpOworICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAg ICAgIEFTU0VSVCh2YWx1ZSk7CiAgICAgICAgIGlmIChsaXN0KSB7CkluZGV4OiBXZWJDb3JlL2Nz cy9DU1NWYWx1ZUtleXdvcmRzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU1ZhbHVl S2V5d29yZHMuaW4JKHJldmlzaW9uIDE3Mzk1KQorKysgV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3 b3Jkcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMjgzLDYgKzI4Myw3IEBAIHJvdy1yZXNpemUKIHRl eHQKIHdhaXQKIGhlbHAKK2FsbC1zY3JvbGwKICMKICMgQ1NTX1BST1BfRElSRUNUSU9OOgogIwpJ bmRleDogV2ViQ29yZS9jc3MvY3NzcGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nz cy9jc3NwYXJzZXIuY3BwCShyZXZpc2lvbiAxNzM5NSkKKysrIFdlYkNvcmUvY3NzL2Nzc3BhcnNl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc0Niw3ICs3NDYsNyBAQCBib29sIENTU1BhcnNlcjo6 cGFyc2VWYWx1ZShpbnQgcHJvcElkLCBiCiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAg fSBlbHNlIGlmICghc3RyaWN0ICYmIHZhbHVlLT5pZCA9PSBDU1NfVkFMX0hBTkQpIC8vIE1TSUUg NSBjb21wYXRpYmlsaXR5IDovCiAgICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKG5ldyBDU1NQ cmltaXRpdmVWYWx1ZShDU1NfVkFMX1BPSU5URVIpKTsKLSAgICAgICAgICAgIGVsc2UgaWYgKHZh bHVlICYmIHZhbHVlLT5pZCA+PSBDU1NfVkFMX0FVVE8gJiYgdmFsdWUtPmlkIDw9IENTU19WQUxf SEVMUCkKKyAgICAgICAgICAgIGVsc2UgaWYgKHZhbHVlICYmIHZhbHVlLT5pZCA+PSBDU1NfVkFM X0FVVE8gJiYgdmFsdWUtPmlkIDw9IENTU19WQUxfQUxMX1NDUk9MTCkKICAgICAgICAgICAgICAg ICBsaXN0LT5hcHBlbmQobmV3IENTU1ByaW1pdGl2ZVZhbHVlKHZhbHVlLT5pZCkpOwogICAgICAg ICAgICAgdmFsdWVMaXN0LT5uZXh0KCk7CiAgICAgICAgICAgICBwYXJzZWRWYWx1ZSA9IGxpc3Q7 CkBAIC03NTYsNyArNzU2LDcgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoaW50IHByb3BJ ZCwgYgogICAgICAgICBpZiAoIXN0cmljdCAmJiB2YWx1ZS0+aWQgPT0gQ1NTX1ZBTF9IQU5EKSB7 IC8vIE1TSUUgNSBjb21wYXRpYmlsaXR5IDovCiAgICAgICAgICAgICBpZCA9IENTU19WQUxfUE9J TlRFUjsKICAgICAgICAgICAgIHZhbGlkX3ByaW1pdGl2ZSA9IHRydWU7Ci0gICAgICAgIH0gZWxz ZSBpZiAodmFsdWUtPmlkID49IENTU19WQUxfQVVUTyAmJiB2YWx1ZS0+aWQgPD0gQ1NTX1ZBTF9I RUxQKQorICAgICAgICB9IGVsc2UgaWYgKHZhbHVlLT5pZCA+PSBDU1NfVkFMX0FVVE8gJiYgdmFs dWUtPmlkIDw9IENTU19WQUxfQUxMX1NDUk9MTCkKICAgICAgICAgICAgIHZhbGlkX3ByaW1pdGl2 ZSA9IHRydWU7CiAgICAgICAgIGJyZWFrOwogICAgIH0KSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZp c2lvbiAxNzM5NSkKKysrIFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC03NTIsNiArNzUyLDggQEAgc3RhdGljIEN1cnNvciBzZWxlY3RDdXJzb3IoY29uc3QgTW91 c2VFdgogICAgICAgICAgICAgcmV0dXJuIGhhbmRDdXJzb3IoKTsKICAgICAgICAgY2FzZSBDVVJT T1JfTU9WRToKICAgICAgICAgICAgIHJldHVybiBtb3ZlQ3Vyc29yKCk7CisgICAgICAgIGNhc2Ug Q1VSU09SX0FMTF9TQ1JPTEw6CisgICAgICAgICAgICByZXR1cm4gbW92ZUN1cnNvcigpOwogICAg ICAgICBjYXNlIENVUlNPUl9FX1JFU0laRToKICAgICAgICAgICAgIHJldHVybiBlYXN0UmVzaXpl Q3Vyc29yKCk7CiAgICAgICAgIGNhc2UgQ1VSU09SX1dfUkVTSVpFOgpJbmRleDogV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyU3R5bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJTdHlsZS5oCShyZXZpc2lvbiAxNzM5NSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clN0eWxlLmgJKHdvcmtpbmcgY29weSkKQEAgLTg3Myw3ICs4NzMsNyBAQCBlbnVtIEVDdXJzb3Ig ewogICAgIENVUlNPUl9BVVRPLCBDVVJTT1JfQ1JPU1MsIENVUlNPUl9ERUZBVUxULCBDVVJTT1Jf UE9JTlRFUiwgQ1VSU09SX01PVkUsCiAgICAgQ1VSU09SX0VfUkVTSVpFLCBDVVJTT1JfTkVfUkVT SVpFLCBDVVJTT1JfTldfUkVTSVpFLCBDVVJTT1JfTl9SRVNJWkUsIENVUlNPUl9TRV9SRVNJWkUs IENVUlNPUl9TV19SRVNJWkUsCiAgICAgQ1VSU09SX1NfUkVTSVpFLCBDVVJTT1JfV19SRVNJWkUs IENVUlNPUl9FV19SRVNJWkUsIENVUlNPUl9OU19SRVNJWkUsIENVUlNPUl9ORVNXX1JFU0laRSwg Q1VSU09SX05XU0VfUkVTSVpFLAotICAgIENVUlNPUl9DT0xfUkVTSVpFLCBDVVJTT1JfUk9XX1JF U0laRSwgQ1VSU09SX1RFWFQsIENVUlNPUl9XQUlULCBDVVJTT1JfSEVMUAorICAgIENVUlNPUl9D T0xfUkVTSVpFLCBDVVJTT1JfUk9XX1JFU0laRSwgQ1VSU09SX1RFWFQsIENVUlNPUl9XQUlULCBD VVJTT1JfSEVMUCwgQ1VSU09SX0FMTF9TQ1JPTEwKIH07CiAKIHN0cnVjdCBDdXJzb3JEYXRhIHsK 11315 2006-10-31 16:33:17 -0800 2006-10-31 22:00:34 -0800 Fix missing "break;" statement from previous patch bug-11442-add-break-stmt.diff text/plain 1244 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzUwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDYtMTAtMzEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHpl ci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgbWlzc2luZyAiYnJlYWs7IiBzdGF0ZW1lbnQgaW4gc3dpdGNoIHN0YXRlbWVudCBmcm9t IHIxNzQ5My4KKworICAgICAgICBCdWcgMTE0NDI6IFtDU1MgM10gc3VwcG9ydCBmb3IgY3Vyc29y OiBhbGwtc2Nyb2xsCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExNDQyCisKKyAgICAgICAgKiBjc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Z2V0UHJv cGVydHlDU1NWYWx1ZSk6CisKIDIwMDYtMTAtMzEgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGljZS4KSW5kZXg6IFdlYkNvcmUvY3Nz L0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9j c3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAkocmV2aXNpb24gMTc1MDIpCisrKyBX ZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02ODAsNiArNjgwLDcgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTQ29tcHV0ZWRTdHls ZURlYwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSBDVVJTT1JfSEVM UDoKICAgICAgICAgICAgICAgICB2YWx1ZSA9IG5ldyBDU1NQcmltaXRpdmVWYWx1ZShDU1NfVkFM X0hFTFApOworICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSBDVVJTT1Jf QUxMX1NDUk9MTDoKICAgICAgICAgICAgICAgICB2YWx1ZSA9IG5ldyBDU1NQcmltaXRpdmVWYWx1 ZShDU1NfVkFMX0FMTF9TQ1JPTEwpOwogICAgICAgICAgICAgICAgIGJyZWFrOwo=