114409 2013-04-10 20:34:55 -0700 Merge CharacterClassTable into CharacterClass 2013-04-11 20:44:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 873519 0 benjamin 2013-04-10 20:34:55 -0700 Merge CharacterClassTable into CharacterClass 873522 1 197501 benjamin 2013-04-10 20:39:46 -0700 Created attachment 197501 Patch 873981 2 197501 darin 2013-04-11 10:51:02 -0700 Comment on attachment 197501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197501&action=review > Source/JavaScriptCore/yarr/YarrPattern.cpp:180 > + OwnPtr<CharacterClass> characterClass = adoptPtr(new CharacterClass()); I like omitting the () in cases like this. 874344 3 benjamin 2013-04-11 20:44:23 -0700 Committed r148259: <http://trac.webkit.org/changeset/148259> 197501 2013-04-10 20:39:46 -0700 2013-04-11 10:51:02 -0700 Patch bug-114409-20130410203927.patch text/plain 6763 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YjkzOGMwNTExYWYwZTUzMDY2OTM5MjgzMWNhZDdmODRhMTU4ODMyLi40NTdiMDViNjhhOTJhM2Vm NmMyMTI3YjhkZDJjNjRjNGQ3OWVjNTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMy0wNC0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBNZXJnZSBDaGFyYWN0ZXJDbGFzc1RhYmxlIGludG8gQ2hhcmFjdGVy Q2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx NDQwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo YXJhY3RlckNsYXNzVGFibGUgaXMgb25seSBhIHBvaW50ZXIgYW5kIGEgYm9vbGVhbi4KKyAgICAg ICAgSXQgaXMgYSBsaXR0bGUgb3ZlcmtpbGwgdG8gbWFrZSBhIHNlcGFyYXRlIGFsbG9jYXRpb24K KyAgICAgICAgZm9yIHRoYXQuCisKKyAgICAgICAgKiBjcmVhdGVfcmVnZXhfdGFibGVzOgorICAg ICAgICAqIHlhcnIvWWFyckpJVC5jcHA6CisgICAgICAgIChKU0M6OllhcnI6OllhcnJHZW5lcmF0 b3I6Om1hdGNoQ2hhcmFjdGVyQ2xhc3MpOgorICAgICAgICAqIHlhcnIvWWFyclBhdHRlcm4uY3Bw OgorICAgICAgICAoSlNDOjpZYXJyOjpDaGFyYWN0ZXJDbGFzc0NvbnN0cnVjdG9yOjpjaGFyQ2xh c3MpOgorICAgICAgICAqIHlhcnIvWWFyclBhdHRlcm4uaDoKKyAgICAgICAgKENoYXJhY3RlckNs YXNzKToKKyAgICAgICAgKEpTQzo6WWFycjo6Q2hhcmFjdGVyQ2xhc3M6OkNoYXJhY3RlckNsYXNz KToKKwogMjAxMy0wNC0wOSAgQmFsYXpzIEtpbHZhZHkgIDxraWx2YWR5YkBob21lamlubmkuY29t PgogCiAgICAgICAgIExMSW50IGNvbmRpdGlvbmFsIGJyYW5jaCBjb21waWxhdGlvbiBmYXVsdCBv biBNSVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2NyZWF0ZV9yZWdleF90 YWJsZXMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX3JlZ2V4X3RhYmxlcwppbmRleCBi ZDc5OWJhMDQ0MWNkNDlkMWUxOWYzMGUxYzY3ODgyNTk2Njc3MWU5Li4yNjFiYTc2M2U5NGFlMDIx NGQyYjgwOWEyODc0NDgxODhmMzhhZWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvY3JlYXRlX3JlZ2V4X3RhYmxlcworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvY3JlYXRl X3JlZ2V4X3RhYmxlcwpAQCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChDKSAyMDEwIEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDEwLCAyMDEzIEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTkwLDExICs5MCwxMSBAQCBmb3IgbmFtZSwgY2xhc3NlcyBpbiB0eXBlcy5pdGVtcygp OgogICAgIGZ1bmN0aW9uICs9ICgie1xuIikKICAgICBpZiBlbWl0VGFibGVzIGFuZCBjbGFzc2Vz WyJVc2VUYWJsZSJdOgogICAgICAgICBpZiAiSW52ZXJzZSIgaW4gY2xhc3NlczoKLSAgICAgICAg ICAgIGZ1bmN0aW9uICs9ICgiICAgIENoYXJhY3RlckNsYXNzKiBjaGFyYWN0ZXJDbGFzcyA9IG5l dyBDaGFyYWN0ZXJDbGFzcyhDaGFyYWN0ZXJDbGFzc1RhYmxlOjpjcmVhdGUoXyVzRGF0YSwgdHJ1 ZSkpO1xuIiAlIChjbGFzc2VzWyJJbnZlcnNlIl0pKQorICAgICAgICAgICAgZnVuY3Rpb24gKz0g KCIgICAgQ2hhcmFjdGVyQ2xhc3MqIGNoYXJhY3RlckNsYXNzID0gbmV3IENoYXJhY3RlckNsYXNz KF8lc0RhdGEsIHRydWUpO1xuIiAlIChjbGFzc2VzWyJJbnZlcnNlIl0pKQogICAgICAgICBlbHNl OgotICAgICAgICAgICAgZnVuY3Rpb24gKz0gKCIgICAgQ2hhcmFjdGVyQ2xhc3MqIGNoYXJhY3Rl ckNsYXNzID0gbmV3IENoYXJhY3RlckNsYXNzKENoYXJhY3RlckNsYXNzVGFibGU6OmNyZWF0ZShf JXNEYXRhLCBmYWxzZSkpO1xuIiAlIChuYW1lKSkKKyAgICAgICAgICAgIGZ1bmN0aW9uICs9ICgi ICAgIENoYXJhY3RlckNsYXNzKiBjaGFyYWN0ZXJDbGFzcyA9IG5ldyBDaGFyYWN0ZXJDbGFzcyhf JXNEYXRhLCBmYWxzZSk7XG4iICUgKG5hbWUpKQogICAgIGVsc2U6Ci0gICAgICAgIGZ1bmN0aW9u ICs9ICgiICAgIENoYXJhY3RlckNsYXNzKiBjaGFyYWN0ZXJDbGFzcyA9IG5ldyBDaGFyYWN0ZXJD bGFzcygwKTtcbiIpCisgICAgICAgIGZ1bmN0aW9uICs9ICgiICAgIENoYXJhY3RlckNsYXNzKiBj aGFyYWN0ZXJDbGFzcyA9IG5ldyBDaGFyYWN0ZXJDbGFzcygpO1xuIikKICAgICBmb3IgKG1pbiwg bWF4KSBpbiByYW5nZXM6CiAgICAgICAgIGlmIChtaW4gPT0gbWF4KToKICAgICAgICAgICAgIGlm IChtaW4gPiAxMjcpOgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFy ckpJVC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmNwcAppbmRleCBl MjZiMTA2M2Q0OTFlMGYwYTk4NDFlYzg5MDkxZDJlNzA1ZTE4NmFmLi4yMGIyNmMxZWI5OGNlYTFh NDQ5MDcxZWYyMGE1MWZiZDc4MTQ2Y2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUveWFyci9ZYXJySklULmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJy SklULmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDkgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEzIEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucwpAQCAtMTc5LDggKzE3OSw4IEBAIGNsYXNzIFlhcnJHZW5lcmF0b3IgOiBwcml2YXRlIE1h Y3JvQXNzZW1ibGVyIHsKICAgICB2b2lkIG1hdGNoQ2hhcmFjdGVyQ2xhc3MoUmVnaXN0ZXJJRCBj aGFyYWN0ZXIsIEp1bXBMaXN0JiBtYXRjaERlc3QsIGNvbnN0IENoYXJhY3RlckNsYXNzKiBjaGFy Q2xhc3MpCiAgICAgewogICAgICAgICBpZiAoY2hhckNsYXNzLT5tX3RhYmxlKSB7Ci0gICAgICAg ICAgICBFeHRlbmRlZEFkZHJlc3MgdGFibGVFbnRyeShjaGFyYWN0ZXIsIHJlaW50ZXJwcmV0X2Nh c3Q8aW50cHRyX3Q+KGNoYXJDbGFzcy0+bV90YWJsZS0+bV90YWJsZSkpOwotICAgICAgICAgICAg bWF0Y2hEZXN0LmFwcGVuZChicmFuY2hUZXN0OChjaGFyQ2xhc3MtPm1fdGFibGUtPm1faW52ZXJ0 ZWQgPyBaZXJvIDogTm9uWmVybywgdGFibGVFbnRyeSkpOworICAgICAgICAgICAgRXh0ZW5kZWRB ZGRyZXNzIHRhYmxlRW50cnkoY2hhcmFjdGVyLCByZWludGVycHJldF9jYXN0PGludHB0cl90Pihj aGFyQ2xhc3MtPm1fdGFibGUpKTsKKyAgICAgICAgICAgIG1hdGNoRGVzdC5hcHBlbmQoYnJhbmNo VGVzdDgoY2hhckNsYXNzLT5tX3RhYmxlSW52ZXJ0ZWQgPyBaZXJvIDogTm9uWmVybywgdGFibGVF bnRyeSkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgIEp1bXAgdW5p Y29kZUZhaWw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0 dGVybi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVybi5jcHAKaW5k ZXggZmEwNTY3MTUzMmM5YzFhYjc5ZjUwMTRmMjMxOGEwOGI2NmY5YjQyYy4uMDRiMjgyZDUxYjU1 OThhMGU4Mjk2Y2M4ZDJhNzcxNDNiYmNmZDEwYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3lhcnIvWWFyclBhdHRlcm4uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS95 YXJyL1lhcnJQYXR0ZXJuLmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMp IDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAy MDA5LCAyMDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAo QykgMjAxMCBQZXRlciBWYXJnYSAocHZhcmdhQGluZi51LXN6ZWdlZC5odSksIFVuaXZlcnNpdHkg b2YgU3plZ2VkCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC0xNzcsNyArMTc3LDcgQEAgcHVibGljOgog CiAgICAgUGFzc093blB0cjxDaGFyYWN0ZXJDbGFzcz4gY2hhckNsYXNzKCkKICAgICB7Ci0gICAg ICAgIE93blB0cjxDaGFyYWN0ZXJDbGFzcz4gY2hhcmFjdGVyQ2xhc3MgPSBhZG9wdFB0cihuZXcg Q2hhcmFjdGVyQ2xhc3MoMCkpOworICAgICAgICBPd25QdHI8Q2hhcmFjdGVyQ2xhc3M+IGNoYXJh Y3RlckNsYXNzID0gYWRvcHRQdHIobmV3IENoYXJhY3RlckNsYXNzKCkpOwogCiAgICAgICAgIGNo YXJhY3RlckNsYXNzLT5tX21hdGNoZXMuc3dhcChtX21hdGNoZXMpOwogICAgICAgICBjaGFyYWN0 ZXJDbGFzcy0+bV9yYW5nZXMuc3dhcChtX3Jhbmdlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVybi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3lh cnIvWWFyclBhdHRlcm4uaAppbmRleCBkZjkyZWY0NWJmMTQzOTc1MDQ1OTRhNzU3MjY3ZjcyNzZh YjQyNmI5Li5lN2QxODdjMmIzMGZlZDI1MTY1NGJkMTc0ZTMyOTlmMGZlZjQzN2E5IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJyUGF0dGVybi5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS95YXJyL1lhcnJQYXR0ZXJuLmgKQEAgLTEsNSArMSw1IEBACiAvKgot ICogQ29weXJpZ2h0IChDKSAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAwOSwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKiBDb3B5cmlnaHQgKEMpIDIwMTAgUGV0ZXIgVmFyZ2EgKHB2YXJnYUBpbmYudS1zemVnZWQu aHUpLCBVbml2ZXJzaXR5IG9mIFN6ZWdlZAogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApAQCAtNTAsMzcgKzUw LDI4IEBAIHN0cnVjdCBDaGFyYWN0ZXJSYW5nZSB7CiAgICAgfQogfTsKIAotc3RydWN0IENoYXJh Y3RlckNsYXNzVGFibGUgOiBSZWZDb3VudGVkPENoYXJhY3RlckNsYXNzVGFibGU+IHsKLSAgICBj b25zdCBjaGFyKiBtX3RhYmxlOwotICAgIGJvb2wgbV9pbnZlcnRlZDsKLSAgICBzdGF0aWMgUGFz c1JlZlB0cjxDaGFyYWN0ZXJDbGFzc1RhYmxlPiBjcmVhdGUoY29uc3QgY2hhciogdGFibGUsIGJv b2wgaW52ZXJ0ZWQpCi0gICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IENoYXJhY3Rl ckNsYXNzVGFibGUodGFibGUsIGludmVydGVkKSk7Ci0gICAgfQotCi1wcml2YXRlOgotICAgIENo YXJhY3RlckNsYXNzVGFibGUoY29uc3QgY2hhciogdGFibGUsIGJvb2wgaW52ZXJ0ZWQpCi0gICAg ICAgIDogbV90YWJsZSh0YWJsZSkKLSAgICAgICAgLCBtX2ludmVydGVkKGludmVydGVkKQotICAg IHsKLSAgICB9Ci19OwotCiBzdHJ1Y3QgQ2hhcmFjdGVyQ2xhc3MgewogICAgIFdURl9NQUtFX0ZB U1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIC8vIEFsbCBDaGFyYWN0ZXJDbGFzcyBpbnN0YW5j ZXMgaGF2ZSB0byBoYXZlIHRoZSBmdWxsIHNldCBvZiBtYXRjaGVzIGFuZCByYW5nZXMsCi0gICAg Ly8gdGhleSBtYXkgaGF2ZSBhbiBvcHRpb25hbCB0YWJsZSBmb3IgZmFzdGVyIGxvb2t1cHMgKHdo aWNoIG11c3QgbWF0Y2ggdGhlCisgICAgLy8gdGhleSBtYXkgaGF2ZSBhbiBvcHRpb25hbCBtX3Rh YmxlIGZvciBmYXN0ZXIgbG9va3VwcyAod2hpY2ggbXVzdCBtYXRjaCB0aGUKICAgICAvLyBzcGVj aWZpZWQgbWF0Y2hlcyBhbmQgcmFuZ2VzKQotICAgIENoYXJhY3RlckNsYXNzKFBhc3NSZWZQdHI8 Q2hhcmFjdGVyQ2xhc3NUYWJsZT4gdGFibGUpCisgICAgQ2hhcmFjdGVyQ2xhc3MoKQorICAgICAg ICA6IG1fdGFibGUoMCkKKyAgICB7CisgICAgfQorICAgIENoYXJhY3RlckNsYXNzKGNvbnN0IGNo YXIqIHRhYmxlLCBib29sIGludmVydGVkKQogICAgICAgICA6IG1fdGFibGUodGFibGUpCisgICAg ICAgICwgbV90YWJsZUludmVydGVkKGludmVydGVkKQogICAgIHsKICAgICB9CiAgICAgVmVjdG9y PFVDaGFyPiBtX21hdGNoZXM7CiAgICAgVmVjdG9yPENoYXJhY3RlclJhbmdlPiBtX3JhbmdlczsK ICAgICBWZWN0b3I8VUNoYXI+IG1fbWF0Y2hlc1VuaWNvZGU7CiAgICAgVmVjdG9yPENoYXJhY3Rl clJhbmdlPiBtX3Jhbmdlc1VuaWNvZGU7Ci0gICAgUmVmUHRyPENoYXJhY3RlckNsYXNzVGFibGU+ IG1fdGFibGU7CisKKyAgICBjb25zdCBjaGFyKiBtX3RhYmxlOworICAgIGJvb2wgbV90YWJsZUlu dmVydGVkOwogfTsKIAogZW51bSBRdWFudGlmaWVyVHlwZSB7Cg==