114396 2013-04-10 17:09:43 -0700 [Windows, WinCairo] FeatureDefines.h Overriding Settings in VS Property Sheets 2013-06-13 10:48:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham aroben benjamin cmarcelo commit-queue kevino paroga roger_fong oldest_to_newest 873384 0 bfulgham 2013-04-10 17:09:43 -0700 The FeatureDefines.h file forces certain features to be active, regardless of the FeatureDefines.prop contents. This may be a historical issue, from a time when the property sheet did not exist and was not used to control feature activations. I think it is confusing (and wrong) for this header file to force any of the features to be turned on, if those features are defined and handled in the property sheet. 873387 1 bfulgham 2013-04-10 17:12:07 -0700 On the Apple Windows target, ENABLE_VIEW_MODE_CSS_MEDIA is included in compiler's command line output, e.g, /D "ENABLE_VIEW_MODE_CSS_MEDIA" because it is marked as "active" in the FeatureDefines.props file. On the WInCairo build, we have ENABLE_VIEW_MODE_CSS_MEDIA turned off at the moment (in the FeatureDefinesCairo.props file). Unfortunately, FeatureDefines.h silently flips it back on. I think the various defines for OS(WINDOWS) in the FeatureDefines.h file that automatically activate certain features should be removed, unless the GTK-Windows, WinCE, wxWidgets, or some other port needs them. 873524 2 paroga 2013-04-10 21:00:20 -0700 (In reply to comment #1) > I think the various defines for OS(WINDOWS) in the FeatureDefines.h file that automatically activate certain features should be removed, unless the GTK-Windows, WinCE, wxWidgets, or some other port needs them. No needs in the WinCE port. 900196 3 204627 bfulgham 2013-06-13 10:40:48 -0700 Created attachment 204627 Patch 900197 4 bfulgham 2013-06-13 10:41:32 -0700 I misunderstood how this file is being used. I think the right solution here is to add a default case for WinCairo that sets the ENABLE_VIEW_MODE_CSS_MEDIA flag to 0 for the WinCairo port. 900204 5 bfulgham 2013-06-13 10:48:30 -0700 Committed r151561: <http://trac.webkit.org/changeset/151561> 204627 2013-06-13 10:40:48 -0700 2013-06-13 10:45:55 -0700 Patch bug-114396-20130613103950.patch text/plain 1138 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTE1NTkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTEzICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29ycmVjdCBGZWF0dXJlRGVm aW5lcy5oIERlZmF1bHQgZm9yIEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQzOTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5l cy5oOiBUaGUgV2luQ2Fpcm8gcG9ydCBkb2VzIG5vdCAoY3VycmVudGx5KSBzdXBwb3J0IE1lZGlh IGVsZW1lbnRzLAorICAgICAgICBzbyBtYWtlIHN1cmUgd2UgZG8gbm90IGVuYWJsZSB0aGlzIGZl YXR1cmUgYnkgZGVmYXVsdCBmb3IgdGhhdCBwb3J0LgorCiAyMDEzLTA2LTEzICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBVbnJldmlld2Vk IGdhcmRlbmluZy4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaAkocmV2aXNpb24gMTUxNTU4 KQorKysgU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMuaAkod29ya2luZyBjb3B5KQpAQCAt MjI5LDYgKzIyOSwxMCBAQAogI2RlZmluZSBFTkFCTEVfV0VCX0FSQ0hJVkUgMQogI2VuZGlmCiAK KyNpZiAhZGVmaW5lZChFTkFCTEVfVklFV19NT0RFX0NTU19NRURJQSkKKyNkZWZpbmUgRU5BQkxF X1ZJRVdfTU9ERV9DU1NfTUVESUEgMAorI2VuZGlmCisKICNlbmRpZiAvKiBQTEFURk9STShXSU5f Q0FJUk8pICovCiAKIC8qIC0tLS0tLS0tLSBFRkwgcG9ydCAoVW5peCkgLS0tLS0tLS0tICovCg==