114356 2013-04-10 06:53:59 -0700 REGRESSION(r148034): IconDatabase::updatIconRecord crashes with null iconData and iconBitmap. 2013-04-11 02:16:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco oliver simon.fraser spena thorton oldest_to_newest 872767 0 rakuco 2013-04-10 06:53:59 -0700 REGRESSION(r148034): IconDatabase::updatIconRecord crashes with null iconData and iconBitmap. 872771 1 197262 rakuco 2013-04-10 06:57:37 -0700 Created attachment 197262 Patch 872809 2 197262 thorton 2013-04-10 08:45:53 -0700 Comment on attachment 197262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197262&action=review > Source/WebCore/loader/icon/IconDatabase.cpp:541 > + ASSERT(!(!!iconData && !!iconBitmap)); !! is a bit bizarre but there are other instances of it around. But I wonder why && alone isn't enough? 872821 3 rakuco 2013-04-10 09:05:55 -0700 (In reply to comment #2) > (From update of attachment 197262 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197262&action=review > > > Source/WebCore/loader/icon/IconDatabase.cpp:541 > > + ASSERT(!(!!iconData && !!iconBitmap)); > > !! is a bit bizarre but there are other instances of it around. But I wonder why && alone isn't enough? I was just being extra-cautious here; PassRefPtr::operator!() was casting them into bools, and I'm adding an extra ! to get the "original" boolean value. 872825 4 rakuco 2013-04-10 09:12:21 -0700 Committed r148097: <http://trac.webkit.org/changeset/148097> 872906 5 197262 darin 2013-04-10 09:42:32 -0700 Comment on attachment 197262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197262&action=review >>> Source/WebCore/loader/icon/IconDatabase.cpp:541 >>> + ASSERT(!(!!iconData && !!iconBitmap)); >> >> !! is a bit bizarre but there are other instances of it around. But I wonder why && alone isn't enough? > > I was just being extra-cautious here; PassRefPtr::operator!() was casting them into bools, and I'm adding an extra ! to get the "original" boolean value. No, those !! are not needed unless there is a bug in PassRefPtr. The && operator should work fine with two PassRefPtr values without requiring the ! at all. It would be nice to remove those. 873634 6 rakuco 2013-04-11 02:16:28 -0700 (In reply to comment #5) > (From update of attachment 197262 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197262&action=review > > >>> Source/WebCore/loader/icon/IconDatabase.cpp:541 > >>> + ASSERT(!(!!iconData && !!iconBitmap)); > >> > >> !! is a bit bizarre but there are other instances of it around. But I wonder why && alone isn't enough? > > > > I was just being extra-cautious here; PassRefPtr::operator!() was casting them into bools, and I'm adding an extra ! to get the "original" boolean value. > > No, those !! are not needed unless there is a bug in PassRefPtr. The && operator should work fine with two PassRefPtr values without requiring the ! at all. > > It would be nice to remove those. https://bugs.webkit.org/show_bug.cgi?id=114425 197262 2013-04-10 06:57:37 -0700 2013-04-10 09:42:32 -0700 Patch bug-114356-20130410165751.patch text/plain 2089 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE2ZGQ2ODA3MmM1ODEw Y2M4MjdkOTdjYzQ3ODBlMTgyOWEyNmNiNC4uN2MwNmM0ODU0ZmQwMTkzODZjNDYyMjkyZTAwNzZh ZTIxZmUxZGUzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA0LTEwICBSYXBo YWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT04ocjE0ODAzNCk6IEljb25EYXRhYmFzZTo6dXBkYXRlSWNvblJlY29y ZCBjcmFzaGVzIHdpdGggbnVsbCBpY29uRGF0YSBhbmQgaWNvbkJpdG1hcC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDM1NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gbG9hZGluZyBhbiBpY29u IGZhaWxzIChmb3IgZXhhbXBsZSwgd2hlbiBhIG5vbi1leGlzdGVudCBVUkkgaXMKKyAgICAgICAg cGFzc2VkIHRvIHRoZSBsb2FkZXIpLCB1cGRhdGVJY29uUmVjb3JkIGNhbiBiZSBjYWxsZWQgd2l0 aCBib3RoCisgICAgICAgIGljb25EYXRhIGFuZCBpY29uQml0bWFwIGhhdmluZyBubyBkYXRhLgor CisgICAgICAgIFRoaXMgdXNlZCB0byBiZSBmaW5lIGJlZm9yZSByMTQ4MDM0LCBidXQgY2F1c2Vz IGFuIGFzc2VydGlvbiBub3cuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBleGlzdGluZyB0ZXN0 cyBzdWNoIGFzIGZhc3QvZW5jb2RpbmcvbWlzcG9zaXRpb25lZC1tZXRhLmh0bWwKKyAgICAgICAg d2VyZSBjcmFzaGluZy4KKworICAgICAgICAqIGxvYWRlci9pY29uL0ljb25EYXRhYmFzZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpJY29uRGF0YWJhc2U6OnVwZGF0ZUljb25SZWNvcmQpOiBDaGFu Z2UgdGhlIEFTU0VSVCgpIHRvIGNoZWNrCisgICAgICAgIGZvciBhIE5BTkQgY29uZGl0aW9uIHRo YXQgb25seSBmYWlscyBpZiBib3RoIGljb25EYXRhIGFuZCBpY29uQml0bWFwCisgICAgICAgIGFy ZSBub3QgMC4KKwogMjAxMy0wNC0xMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE0NzcxOSk6IEZhaWx1cmVzIGluIHR3byBhMTF5 IHRlc3RzIG9uIEdUSwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNv bkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25EYXRhYmFzZS5j cHAKaW5kZXggYTUxYmJhMGQwOWU1MjgzODNmYzg0ZWVkN2I1NjU4YWJjY2U2OWZlNy4uMDIxMTZl NDE3ZWMxMzhlZDBhNmYyNDZjZGE5NGFjNDUzMDgwOWM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwCkBAIC01MzcsOCArNTM3LDggQEAgdm9pZCBJY29u RGF0YWJhc2U6OnBlcmZvcm1SZWxlYXNlSWNvbkZvclBhZ2VVUkwoY29uc3QgU3RyaW5nJiBwYWdl VVJMT3JpZ2luYWwsIGkKIAogdm9pZCBJY29uRGF0YWJhc2U6OnVwZGF0ZUljb25SZWNvcmQoUGFz c1JlZlB0cjxTaGFyZWRCdWZmZXI+IGljb25EYXRhLCBQYXNzUmVmUHRyPEltYWdlPiBpY29uQml0 bWFwLCBjb25zdCBTdHJpbmcmIGljb25VUkwpCiB7Ci0gICAgLy8gT25seSBvbmUgb2YgaWNvbkRh dGEgb3IgaWNvbkJpdG1hcCBzaG91bGQgYmUgcHJvdmlkZWQsIG5ldmVyIGJvdGguCi0gICAgQVNT RVJUKCFpY29uRGF0YSAhPSAhaWNvbkJpdG1hcCk7CisgICAgLy8gT25seSBvbmUgb2YgaWNvbkRh dGEgb3IgaWNvbkJpdG1hcCBzaG91bGQgYmUgcHJvdmlkZWQsIG5ldmVyIGJvdGguIE5vbmUgaXMg YWxzbyBmaW5lLgorICAgIEFTU0VSVCghKCEhaWNvbkRhdGEgJiYgISFpY29uQml0bWFwKSk7CiAK ICAgICBWZWN0b3I8U3RyaW5nPiBwYWdlVVJMczsKICAgICB7Cg==