114323 2013-04-09 17:12:53 -0700 TileController doesn't remove tiles when the view is resized, leading to stale content 2013-04-10 09:31:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin dino simon.fraser oldest_to_newest 872525 0 thorton 2013-04-09 17:12:53 -0700 You can see this when browsing around Amazon with Aggressive Tile Retention on: 1. Go to http://www.amazon.com/Best-Sellers-Video-Games-PlayStation-Hardware/zgbs/videogames/14210751/ 2. Scroll to the bottom. 3. Click on the next page of results. 4. Scroll to the bottom. 5. Move the mouse around. You'll probably see stale content start repainting. <rdar://problem/13520671> 872544 1 197194 thorton 2013-04-09 18:02:14 -0700 Created attachment 197194 patch 872546 2 197194 simon.fraser 2013-04-09 18:09:18 -0700 Comment on attachment 197194 patch View in context: https://bugs.webkit.org/attachment.cgi?id=197194&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.mm:736 > + if (it->key.y() < topLeftForBounds.y() > + || it->key.y() > bottomRightForBounds.y() > + || it->key.x() < topLeftForBounds.x() > + || it->key.x() > bottomRightForBounds.x()) Would be cleaner if you copied it->key into a TileIndex variable. 872899 3 thorton 2013-04-10 09:31:41 -0700 http://trac.webkit.org/changeset/148102 197194 2013-04-09 18:02:14 -0700 2013-04-09 18:09:18 -0700 patch fix-tiles.diff text/plain 3920 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMzU3MzZhLi5jZDY4MWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDQtMDkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgVGlsZUNvbnRyb2xsZXIgZG9lc24ndCByZW1vdmUgdGlsZXMgd2hlbiB0aGUgdmll dyBpcyByZXNpemVkLCBsZWFkaW5nIHRvIHN0YWxlIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDMyMworICAgICAgICA8cmRhcjovL3By b2JsZW0vMTM1MjA2NzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRW5zdXJlIHRoYXQgdGlsZXMgYXJlIHJlbW92ZWQgaWYgdGhlIHZpZXcgc2hyaW5r cywgc28gdGhhdCB0aGV5IGFyZSBub3QgZGlzcGxheWVkCisgICAgICAgIHdpdGggc3RhbGUgY29u dGVudCBpZiB0aGUgdmlldyBsYXRlciBncm93cyBhZ2FpbiAodGhleSB3aWxsIG5vdCBiZSByZXBh aW50ZWQgYnkgV2ViQ29yZQorICAgICAgICB3aGlsZSBvdXQtb2YtdmlldykuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW06CisgICAgICAgIChXZWJD b3JlOjpUaWxlQ29udHJvbGxlcjo6cmV2YWxpZGF0ZVRpbGVzKToKKwogMjAxMy0wNC0wOSAgRXJp YyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSB1c2Vy IGNhcHRpb24gc3R5bGVzIG5vdCBhcHBsaWVkIHRvIGNvcnJlY3QgZWxlbWVudApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVy LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xs ZXIuaAppbmRleCA2NWQ5OWI3Li41NDZmYTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIuaApAQCAtMTc1LDYg KzE3NSw3IEBAIHByaXZhdGU6CiAgICAgRmxvYXRSZWN0IG1fdmlzaWJsZVJlY3Q7CiAgICAgRmxv YXRSZWN0IG1fdmlzaWJsZVJlY3RBdExhc3RSZXZhbGlkYXRlOwogICAgIEZsb2F0UmVjdCBtX2V4 cG9zZWRSZWN0OyAvLyBUaGUgZXhwb3NlZCBhcmVhIG9mIGNvbnRhaW5pbmcgcGxhdGZvcm0gdmll d3MuCisgICAgSW50UmVjdCBtX2JvdW5kc0F0TGFzdFJldmFsaWRhdGU7CiAKICAgICB0eXBlZGVm IEhhc2hNYXA8VGlsZUluZGV4LCBUaWxlSW5mbz4gVGlsZU1hcDsKICAgICBUaWxlTWFwIG1fdGls ZXM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMv VGlsZUNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9t YWMvVGlsZUNvbnRyb2xsZXIubW0KaW5kZXggMGFkMTIzOS4uZWRkZTE1MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVyLm1t CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ29udHJv bGxlci5tbQpAQCAtNjExLDExICs2MTEsMTIgQEAgdm9pZCBUaWxlQ29udHJvbGxlcjo6cmV2YWxp ZGF0ZVRpbGVzKFRpbGVWYWxpZGF0aW9uUG9saWN5RmxhZ3MgZm9yZWdyb3VuZFZhbGlkYXQKICAg ICAgICAgcmV0dXJuOwogCiAgICAgRmxvYXRSZWN0IHZpc2libGVSZWN0ID0gbV92aXNpYmxlUmVj dDsKKyAgICBJbnRSZWN0IGJvdW5kcyA9IHRoaXMtPmJvdW5kcygpOwogCiAgICAgaWYgKG1fY2xp cHNUb0V4cG9zZWRSZWN0KQogICAgICAgICB2aXNpYmxlUmVjdC5pbnRlcnNlY3QobV9leHBvc2Vk UmVjdCk7CiAKLSAgICBpZiAodmlzaWJsZVJlY3QuaXNFbXB0eSgpIHx8IGJvdW5kcygpLmlzRW1w dHkoKSkKKyAgICBpZiAodmlzaWJsZVJlY3QuaXNFbXB0eSgpIHx8IGJvdW5kcy5pc0VtcHR5KCkp CiAgICAgICAgIHJldHVybjsKICAgICAKICAgICBUaWxlVmFsaWRhdGlvblBvbGljeUZsYWdzIHZh bGlkYXRpb25Qb2xpY3kgPSBtX2lzSW5XaW5kb3cgPyBmb3JlZ3JvdW5kVmFsaWRhdGlvblBvbGlj eSA6IGJhY2tncm91bmRWYWxpZGF0aW9uUG9saWN5OwpAQCAtNzE3LDExICs3MTgsMzYgQEAgdm9p ZCBUaWxlQ29udHJvbGxlcjo6cmV2YWxpZGF0ZVRpbGVzKFRpbGVWYWxpZGF0aW9uUG9saWN5Rmxh Z3MgZm9yZWdyb3VuZFZhbGlkYXQKICAgICAgICAgZm9yIChUaWxlTWFwOjppdGVyYXRvciBpdCA9 IG1fdGlsZXMuYmVnaW4oKSwgZW5kID0gbV90aWxlcy5lbmQoKTsgaXQgIT0gZW5kOyArK2l0KQog ICAgICAgICAgICAgW2l0LT52YWx1ZS5sYXllci5nZXQoKSByZW1vdmVGcm9tU3VwZXJsYXllcl07 CiAgICAgfQorCisgICAgaWYgKG1fYm91bmRzQXRMYXN0UmV2YWxpZGF0ZSAhPSBib3VuZHMpIHsK KyAgICAgICAgRmxvYXRSZWN0IHNjYWxlZEJvdW5kcyhib3VuZHMpOworICAgICAgICBzY2FsZWRC b3VuZHMuc2NhbGUobV9zY2FsZSk7CisgICAgICAgIEludFJlY3QgYm91bmRzSW5UaWxlQ29vcmRz KGVuY2xvc2luZ0ludFJlY3Qoc2NhbGVkQm91bmRzKSk7CisgICAgICAgIAorICAgICAgICBUaWxl SW5kZXggdG9wTGVmdEZvckJvdW5kczsKKyAgICAgICAgVGlsZUluZGV4IGJvdHRvbVJpZ2h0Rm9y Qm91bmRzOworICAgICAgICBnZXRUaWxlSW5kZXhSYW5nZUZvclJlY3QoYm91bmRzSW5UaWxlQ29v cmRzLCB0b3BMZWZ0Rm9yQm91bmRzLCBib3R0b21SaWdodEZvckJvdW5kcyk7CisgICAgICAgIAor ICAgICAgICBWZWN0b3I8VGlsZUluZGV4PiB0aWxlc1RvUmVtb3ZlOworICAgICAgICBmb3IgKFRp bGVNYXA6Oml0ZXJhdG9yIGl0ID0gbV90aWxlcy5iZWdpbigpLCBlbmQgPSBtX3RpbGVzLmVuZCgp OyBpdCAhPSBlbmQ7ICsraXQpIHsKKyAgICAgICAgICAgIGlmIChpdC0+a2V5LnkoKSA8IHRvcExl ZnRGb3JCb3VuZHMueSgpCisgICAgICAgICAgICAgICAgfHwgaXQtPmtleS55KCkgPiBib3R0b21S aWdodEZvckJvdW5kcy55KCkKKyAgICAgICAgICAgICAgICB8fCBpdC0+a2V5LngoKSA8IHRvcExl ZnRGb3JCb3VuZHMueCgpCisgICAgICAgICAgICAgICAgfHwgaXQtPmtleS54KCkgPiBib3R0b21S aWdodEZvckJvdW5kcy54KCkpCisgICAgICAgICAgICAgICAgcXVldWVUaWxlRm9yUmVtb3ZhbChp dC0+a2V5LCBpdC0+dmFsdWUsIHRpbGVzVG9SZW1vdmUpOworICAgICAgICB9CisgICAgICAgIAor ICAgICAgICBmb3IgKHNpemVfdCBpID0gMCwgc2l6ZSA9IHRpbGVzVG9SZW1vdmUuc2l6ZSgpOyBp IDwgc2l6ZTsgKytpKSB7CisgICAgICAgICAgICBUaWxlSW5mbyB0aWxlSW5mbyA9IG1fdGlsZXMu dGFrZSh0aWxlc1RvUmVtb3ZlW2ldKTsKKyAgICAgICAgICAgIExheWVyUG9vbDo6c2hhcmVkUG9v bCgpLT5hZGRMYXllcih0aWxlSW5mby5sYXllcik7CisgICAgICAgIH0KKyAgICB9CiAgICAgCiAg ICAgaWYgKG1fdGlsZWRTY3JvbGxpbmdJbmRpY2F0b3JMYXllcikKICAgICAgICAgdXBkYXRlVGls ZUNvdmVyYWdlTWFwKCk7CiAKICAgICBtX3Zpc2libGVSZWN0QXRMYXN0UmV2YWxpZGF0ZSA9IHZp c2libGVSZWN0OworICAgIG1fYm91bmRzQXRMYXN0UmV2YWxpZGF0ZSA9IGJvdW5kczsKIAogICAg IGlmIChkaXJ0eVJlY3RzLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwo=