114318 2013-04-09 16:21:09 -0700 Add liveness tests to JSC API entry points 2013-04-10 10:34:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver ggaren oldest_to_newest 872271 0 oliver 2013-04-09 16:21:09 -0700 Add liveness tests to JSC API entry points 872272 1 197185 oliver 2013-04-09 16:22:30 -0700 Created attachment 197185 Patch 872278 2 oliver 2013-04-09 16:27:38 -0700 Committed r148062: <http://trac.webkit.org/changeset/148062> 872536 3 oliver 2013-04-09 17:46:10 -0700 Reopening to attach new patch. 872537 4 197191 oliver 2013-04-09 17:46:11 -0700 Created attachment 197191 Patch 872550 5 197191 ggaren 2013-04-09 18:13:24 -0700 Comment on attachment 197191 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197191&action=review > Source/JavaScriptCore/API/JSObjectRef.cpp:343 > void* JSObjectGetPrivate(JSObjectRef object) > { > - JSObject* jsObject = toJS(object); > + JSObject* jsObject = unsafeToJS(object); Why does GetPrivate need to use the unsafe function? 872551 6 oliver 2013-04-09 18:16:44 -0700 (In reply to comment #5) > (From update of attachment 197191 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197191&action=review > > > Source/JavaScriptCore/API/JSObjectRef.cpp:343 > > void* JSObjectGetPrivate(JSObjectRef object) > > { > > - JSObject* jsObject = toJS(object); > > + JSObject* jsObject = unsafeToJS(object); > > Why does GetPrivate need to use the unsafe function? It's called by finalizers when (by definition) the structure chain for an object may no longer be perfect :-/ Somewhat annoying, but this still covers the majority of cases. 872552 7 ggaren 2013-04-09 18:19:11 -0700 > > Why does GetPrivate need to use the unsafe function? > > It's called by finalizers when (by definition) the structure chain for an object may no longer be perfect :-/ OK. You should add a comment that explains that detail. Also, let's rename the function to "uncheckedToJS". It's always safe to call the function, it just does less checking. 872553 8 197191 ggaren 2013-04-09 18:19:25 -0700 Comment on attachment 197191 Patch r=me with those changes 872554 9 oliver 2013-04-09 18:22:20 -0700 Committed r148073: <http://trac.webkit.org/changeset/148073> 872935 10 ap 2013-04-10 10:34:37 -0700 This has caused (or maybe uncovered) bug 114341. 197185 2013-04-09 16:22:30 -0700 2013-04-09 17:46:09 -0700 Patch bug-114318-20130409162212.patch text/plain 2919 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YjkzOGMwNTExYWYwZTUzMDY2OTM5MjgzMWNhZDdmODRhMTU4ODMyLi4zNDFkZjcyNWM1YzVlYTk4 YTYzNjcyNWY3NjViMWU0MDkxZDVjZGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMy0wNC0wOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBsaXZlbmVzcyB0ZXN0cyB0byBKU0MgQVBJIGVudHJ5IHBvaW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MzE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNpbXBsZSBj aGVja3MgZm9yIHRoZSBleGlzdGVuY2Ugb2YgYSBtZXRob2QgdGFibGUgb24gYW55CisgICAgICAg IEpTQ2VsbHMgcGFzc2VkIGFjcm9zcyB0aGUgQVBJLiAgVGhpcyBpbiB0dXJuIGZvcmNlcyBhIHN0 cnVjdHVyZQorICAgICAgICB2YWxpZGl0eSB0ZXN0LgorCisgICAgICAgICogQVBJL0FQSUNhc3Qu aDoKKyAgICAgICAgKHRvSlMpOgorICAgICAgICAodG9KU0ZvckdDKToKKwogMjAxMy0wNC0wOSAg QmFsYXpzIEtpbHZhZHkgIDxraWx2YWR5YkBob21lamlubmkuY29tPgogCiAgICAgICAgIExMSW50 IGNvbmRpdGlvbmFsIGJyYW5jaCBjb21waWxhdGlvbiBmYXVsdCBvbiBNSVBTLgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9BUElDYXN0LmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL0FQSUNhc3QuaAppbmRleCBjMWFiMTEwZDhjODcxYjQ4YTEyZmExNjMzY2M0NmZm ZTIxYTQ3MjU0Li5jODUwZTI5ZjZjM2QwMzA0M2Q5MDRhMDhiMjM1NWJkMjk2NmFhMDU0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0FQSUNhc3QuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL0FQSUNhc3QuaApAQCAtNjcsMTUgKzY3LDE5IEBAIGlubGluZSBK U0M6OkpTVmFsdWUgdG9KUyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZVJlZiB2KQogICAg IEpTQzo6SlNDZWxsKiBqc0NlbGwgPSByZWludGVycHJldF9jYXN0PEpTQzo6SlNDZWxsKj4oY29u c3RfY2FzdDxPcGFxdWVKU1ZhbHVlKj4odikpOwogICAgIGlmICghanNDZWxsKQogICAgICAgICBy ZXR1cm4gSlNDOjpqc051bGwoKTsKKyAgICBKU0M6OkpTVmFsdWUgcmVzdWx0OwogICAgIGlmIChq c0NlbGwtPmlzQVBJVmFsdWVXcmFwcGVyKCkpCi0gICAgICAgIHJldHVybiBKU0M6OmpzQ2FzdDxK U0M6OkpTQVBJVmFsdWVXcmFwcGVyKj4oanNDZWxsKS0+dmFsdWUoKTsKLSAgICByZXR1cm4ganND ZWxsOworICAgICAgICByZXN1bHQgPSBKU0M6OmpzQ2FzdDxKU0M6OkpTQVBJVmFsdWVXcmFwcGVy Kj4oanNDZWxsKS0+dmFsdWUoKTsKKyAgICBlbHNlCisgICAgICAgIHJlc3VsdCA9IGpzQ2VsbDsK ICNlbHNlCiAgICAgSlNDOjpKU1ZhbHVlIHJlc3VsdCA9IEpTQzo6SlNWYWx1ZTo6ZGVjb2RlKHJl aW50ZXJwcmV0X2Nhc3Q8SlNDOjpFbmNvZGVkSlNWYWx1ZT4oY29uc3RfY2FzdDxPcGFxdWVKU1Zh bHVlKj4odikpKTsKKyNlbmRpZgogICAgIGlmICghcmVzdWx0KQogICAgICAgICByZXR1cm4gSlND Ojpqc051bGwoKTsKKyAgICBpZiAocmVzdWx0LmlzQ2VsbCgpKQorICAgICAgICBSRUxFQVNFX0FT U0VSVChyZXN1bHQuYXNDZWxsKCktPm1ldGhvZFRhYmxlKCkpOwogICAgIHJldHVybiByZXN1bHQ7 Ci0jZW5kaWYKIH0KIAogaW5saW5lIEpTQzo6SlNWYWx1ZSB0b0pTRm9yR0MoSlNDOjpFeGVjU3Rh dGUqIGV4ZWMsIEpTVmFsdWVSZWYgdikKQEAgLTg1LDE1ICs4OSwyMSBAQCBpbmxpbmUgSlNDOjpK U1ZhbHVlIHRvSlNGb3JHQyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZVJlZiB2KQogICAg IEpTQzo6SlNDZWxsKiBqc0NlbGwgPSByZWludGVycHJldF9jYXN0PEpTQzo6SlNDZWxsKj4oY29u c3RfY2FzdDxPcGFxdWVKU1ZhbHVlKj4odikpOwogICAgIGlmICghanNDZWxsKQogICAgICAgICBy ZXR1cm4gSlNDOjpKU1ZhbHVlKCk7Ci0gICAgcmV0dXJuIGpzQ2VsbDsKKyAgICBKU0M6OkpTVmFs dWUgcmVzdWx0ID0ganNDZWxsOwogI2Vsc2UKLSAgICByZXR1cm4gSlNDOjpKU1ZhbHVlOjpkZWNv ZGUocmVpbnRlcnByZXRfY2FzdDxKU0M6OkVuY29kZWRKU1ZhbHVlPihjb25zdF9jYXN0PE9wYXF1 ZUpTVmFsdWUqPih2KSkpOworICAgIEpTQzo6SlNWYWx1ZSByZXN1bHQgPSBKU0M6OkpTVmFsdWU6 OmRlY29kZShyZWludGVycHJldF9jYXN0PEpTQzo6RW5jb2RlZEpTVmFsdWU+KGNvbnN0X2Nhc3Q8 T3BhcXVlSlNWYWx1ZSo+KHYpKSk7CiAjZW5kaWYKKyAgICBpZiAocmVzdWx0ICYmIHJlc3VsdC5p c0NlbGwoKSkKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQocmVzdWx0LmFzQ2VsbCgpLT5tZXRob2RU YWJsZSgpKTsKKyAgICByZXR1cm4gcmVzdWx0OwogfQogCiBpbmxpbmUgSlNDOjpKU09iamVjdCog dG9KUyhKU09iamVjdFJlZiBvKQogewotICAgIHJldHVybiByZWludGVycHJldF9jYXN0PEpTQzo6 SlNPYmplY3QqPihvKTsKKyAgICBKU0M6OkpTT2JqZWN0KiBvYmplY3QgPSByZWludGVycHJldF9j YXN0PEpTQzo6SlNPYmplY3QqPihvKTsKKyAgICBpZiAob2JqZWN0KQorICAgICAgICBSRUxFQVNF X0FTU0VSVChvYmplY3QtPm1ldGhvZFRhYmxlKCkpOworICAgIHJldHVybiBvYmplY3Q7CiB9CiAK IGlubGluZSBKU0M6OlByb3BlcnR5TmFtZUFycmF5KiB0b0pTKEpTUHJvcGVydHlOYW1lQWNjdW11 bGF0b3JSZWYgYSkK 197191 2013-04-09 17:46:11 -0700 2013-04-09 18:19:25 -0700 Patch bug-114318-20130409174553.patch text/plain 3847 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NGE1MTY5NTZiYzA0M2QwYTA0N2ZlYWNiYmVkMzUyZWFlMTU5NTY2Li4zZjM4Nzc1YTBiZDdlNzg0 Y2MwY2E0YjFkMmYzNmNmNjE5YTkxYzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxMy0wNC0wOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CisgICAgICAgIEFkZCBsaXZlbmVzcyB0ZXN0cyB0byBKU0MgQVBJIGVudHJ5IHBvaW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MzE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNpbXBsZSBj aGVja3MgZm9yIHRoZSBleGlzdGVuY2Ugb2YgYSBtZXRob2QgdGFibGUgb24gYW55CisgICAgICAg IEpTQ2VsbHMgcGFzc2VkIGFjcm9zcyB0aGUgQVBJLiAgVGhpcyBpbiB0dXJuIGZvcmNlcyBhIHN0 cnVjdHVyZQorICAgICAgICB2YWxpZGl0eSB0ZXN0LgorCisgICAgICAgICogQVBJL0FQSUNhc3Qu aDoKKyAgICAgICAgKHRvSlMpOgorICAgICAgICAodG9KU0ZvckdDKToKKyAgICAgICAgKHVuc2Fm ZVRvSlMpOgorICAgICAgICAqIEFQSS9KU09iamVjdFJlZi5jcHA6CisgICAgICAgIChKU09iamVj dEdldFByaXZhdGUpOgorCisyMDEzLTA0LTA5ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5j b20+CisKICAgICAgICAgUm9sbG91dCBsYXN0IHBhdGNoIGFzIGl0IGRlc3Ryb3llZCBldmVyeXRo aW5nCiAKICAgICAgICAgKiBBUEkvQVBJQ2FzdC5oOgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9BUElDYXN0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0FQSUNh c3QuaAppbmRleCBjMWFiMTEwZDhjODcxYjQ4YTEyZmExNjMzY2M0NmZmZTIxYTQ3MjU0Li5kNmY1 OTA2MTNkNzcxYWExNTk5ZDMyOTI3ZTNhNDdiY2M0MDU0ZmNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQVBJL0FQSUNhc3QuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0FQSUNhc3QuaApAQCAtNjcsMTUgKzY3LDE5IEBAIGlubGluZSBKU0M6OkpTVmFsdWUgdG9K UyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZVJlZiB2KQogICAgIEpTQzo6SlNDZWxsKiBq c0NlbGwgPSByZWludGVycHJldF9jYXN0PEpTQzo6SlNDZWxsKj4oY29uc3RfY2FzdDxPcGFxdWVK U1ZhbHVlKj4odikpOwogICAgIGlmICghanNDZWxsKQogICAgICAgICByZXR1cm4gSlNDOjpqc051 bGwoKTsKKyAgICBKU0M6OkpTVmFsdWUgcmVzdWx0OwogICAgIGlmIChqc0NlbGwtPmlzQVBJVmFs dWVXcmFwcGVyKCkpCi0gICAgICAgIHJldHVybiBKU0M6OmpzQ2FzdDxKU0M6OkpTQVBJVmFsdWVX cmFwcGVyKj4oanNDZWxsKS0+dmFsdWUoKTsKLSAgICByZXR1cm4ganNDZWxsOworICAgICAgICBy ZXN1bHQgPSBKU0M6OmpzQ2FzdDxKU0M6OkpTQVBJVmFsdWVXcmFwcGVyKj4oanNDZWxsKS0+dmFs dWUoKTsKKyAgICBlbHNlCisgICAgICAgIHJlc3VsdCA9IGpzQ2VsbDsKICNlbHNlCiAgICAgSlND OjpKU1ZhbHVlIHJlc3VsdCA9IEpTQzo6SlNWYWx1ZTo6ZGVjb2RlKHJlaW50ZXJwcmV0X2Nhc3Q8 SlNDOjpFbmNvZGVkSlNWYWx1ZT4oY29uc3RfY2FzdDxPcGFxdWVKU1ZhbHVlKj4odikpKTsKKyNl bmRpZgogICAgIGlmICghcmVzdWx0KQogICAgICAgICByZXR1cm4gSlNDOjpqc051bGwoKTsKKyAg ICBpZiAocmVzdWx0LmlzQ2VsbCgpKQorICAgICAgICBSRUxFQVNFX0FTU0VSVChyZXN1bHQuYXND ZWxsKCktPm1ldGhvZFRhYmxlKCkpOwogICAgIHJldHVybiByZXN1bHQ7Ci0jZW5kaWYKIH0KIAog aW5saW5lIEpTQzo6SlNWYWx1ZSB0b0pTRm9yR0MoSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIEpTVmFs dWVSZWYgdikKQEAgLTg1LDE3ICs4OSwyOCBAQCBpbmxpbmUgSlNDOjpKU1ZhbHVlIHRvSlNGb3JH QyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZVJlZiB2KQogICAgIEpTQzo6SlNDZWxsKiBq c0NlbGwgPSByZWludGVycHJldF9jYXN0PEpTQzo6SlNDZWxsKj4oY29uc3RfY2FzdDxPcGFxdWVK U1ZhbHVlKj4odikpOwogICAgIGlmICghanNDZWxsKQogICAgICAgICByZXR1cm4gSlNDOjpKU1Zh bHVlKCk7Ci0gICAgcmV0dXJuIGpzQ2VsbDsKKyAgICBKU0M6OkpTVmFsdWUgcmVzdWx0ID0ganND ZWxsOwogI2Vsc2UKLSAgICByZXR1cm4gSlNDOjpKU1ZhbHVlOjpkZWNvZGUocmVpbnRlcnByZXRf Y2FzdDxKU0M6OkVuY29kZWRKU1ZhbHVlPihjb25zdF9jYXN0PE9wYXF1ZUpTVmFsdWUqPih2KSkp OworICAgIEpTQzo6SlNWYWx1ZSByZXN1bHQgPSBKU0M6OkpTVmFsdWU6OmRlY29kZShyZWludGVy cHJldF9jYXN0PEpTQzo6RW5jb2RlZEpTVmFsdWU+KGNvbnN0X2Nhc3Q8T3BhcXVlSlNWYWx1ZSo+ KHYpKSk7CiAjZW5kaWYKKyAgICBpZiAocmVzdWx0ICYmIHJlc3VsdC5pc0NlbGwoKSkKKyAgICAg ICAgUkVMRUFTRV9BU1NFUlQocmVzdWx0LmFzQ2VsbCgpLT5tZXRob2RUYWJsZSgpKTsKKyAgICBy ZXR1cm4gcmVzdWx0OwogfQogCi1pbmxpbmUgSlNDOjpKU09iamVjdCogdG9KUyhKU09iamVjdFJl ZiBvKQoraW5saW5lIEpTQzo6SlNPYmplY3QqIHVuc2FmZVRvSlMoSlNPYmplY3RSZWYgbykKIHsK ICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxKU0M6OkpTT2JqZWN0Kj4obyk7CiB9CiAKK2lu bGluZSBKU0M6OkpTT2JqZWN0KiB0b0pTKEpTT2JqZWN0UmVmIG8pCit7CisgICAgSlNDOjpKU09i amVjdCogb2JqZWN0ID0gdW5zYWZlVG9KUyhvKTsKKyAgICBpZiAob2JqZWN0KQorICAgICAgICBS RUxFQVNFX0FTU0VSVChvYmplY3QtPm1ldGhvZFRhYmxlKCkpOworICAgIHJldHVybiBvYmplY3Q7 Cit9CisKIGlubGluZSBKU0M6OlByb3BlcnR5TmFtZUFycmF5KiB0b0pTKEpTUHJvcGVydHlOYW1l QWNjdW11bGF0b3JSZWYgYSkKIHsKICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxKU0M6OlBy b3BlcnR5TmFtZUFycmF5Kj4oYSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTT2JqZWN0UmVmLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmplY3RS ZWYuY3BwCmluZGV4IGExNDY0Y2NiMWM4YzFkNTI2YjUwMjE4ZDk5Y2VmN2JhYWY3NGI3YWUuLjFl MzFkZTBlZGJkYjRkMzNkNmE2YjM5MDk5OWU2ZDQ2ZTczMzczZTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwCkBAIC0zNDAsNyArMzQwLDcgQEAgYm9vbCBKU09i amVjdERlbGV0ZVByb3BlcnR5KEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVmIG9iamVjdCwg SlNTdHJpbmdSZWYgcHIKIAogdm9pZCogSlNPYmplY3RHZXRQcml2YXRlKEpTT2JqZWN0UmVmIG9i amVjdCkKIHsKLSAgICBKU09iamVjdCoganNPYmplY3QgPSB0b0pTKG9iamVjdCk7CisgICAgSlNP YmplY3QqIGpzT2JqZWN0ID0gdW5zYWZlVG9KUyhvYmplY3QpOwogICAgIAogICAgIGlmIChqc09i amVjdC0+aW5oZXJpdHMoJkpTQ2FsbGJhY2tPYmplY3Q8SlNHbG9iYWxPYmplY3Q+OjpzX2luZm8p KQogICAgICAgICByZXR1cm4ganNDYXN0PEpTQ2FsbGJhY2tPYmplY3Q8SlNHbG9iYWxPYmplY3Q+ Kj4oanNPYmplY3QpLT5nZXRQcml2YXRlKCk7Cg==