114291 2013-04-09 09:44:34 -0700 WKFrameIsDisplayingMarkupDocument should return true for Web Archives 2013-04-10 17:38:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 114399 1 graouts graouts commit-queue ddkilzer dino webkit-bug-importer oldest_to_newest 871921 0 graouts 2013-04-09 09:44:34 -0700 WKFrameIsDisplayingMarkupDocument should return true for Web Archives 871924 1 197138 graouts 2013-04-09 09:46:49 -0700 Created attachment 197138 Patch 871925 2 graouts 2013-04-09 09:47:35 -0700 <rdar://problem/8800121> 871926 3 webkit-bug-importer 2013-04-09 09:48:04 -0700 <rdar://problem/13609798> 871927 4 graouts 2013-04-09 09:48:43 -0700 <rdar://problem/8800121> 871959 5 197138 simon.fraser 2013-04-09 10:57:56 -0700 Comment on attachment 197138 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197138&action=review > Source/WebKit2/ChangeLog:8 > + Also return true for the Web Archive MIME type. Why? What are the implications of this change? 871960 6 197138 timothy 2013-04-09 10:58:03 -0700 Comment on attachment 197138 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197138&action=review > Source/WebKit2/UIProcess/WebFrameProxy.cpp:118 > // FIXME: This returns false when displaying a web archive. Remove this comment. 871971 7 197149 graouts 2013-04-09 11:12:28 -0700 Created attachment 197149 Patch 871972 8 graouts 2013-04-09 11:13:24 -0700 (In reply to comment #5) > (From update of attachment 197138 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197138&action=review > > > Source/WebKit2/ChangeLog:8 > > + Also return true for the Web Archive MIME type. > > Why? What are the implications of this change? This is so that commands in user agents that should only be contextual to markup documents do the right thing when a Web Archive is displayed. 871973 9 graouts 2013-04-09 11:13:33 -0700 (In reply to comment #6) > (From update of attachment 197138 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197138&action=review > > > Source/WebKit2/UIProcess/WebFrameProxy.cpp:118 > > // FIXME: This returns false when displaying a web archive. > > Remove this comment. Indeed! 872092 10 197149 dino 2013-04-09 14:33:25 -0700 Comment on attachment 197149 Patch It would be nice to know if there are any serious implications from this change. 872118 11 dino 2013-04-09 15:55:45 -0700 One more concern. You said this was a regression. What was the commit that it regressed in? 872582 12 ddkilzer 2013-04-09 21:34:47 -0700 (In reply to comment #11) > One more concern. You said this was a regression. What was the commit that it regressed in? I believe it was a regression from WebKit1 to WebKit2. 872622 13 197149 commit-queue 2013-04-09 23:43:33 -0700 Comment on attachment 197149 Patch Clearing flags on attachment: 197149 Committed r148078: <http://trac.webkit.org/changeset/148078> 872623 14 commit-queue 2013-04-09 23:43:35 -0700 All reviewed patches have been landed. Closing bug. 872905 15 197149 darin 2013-04-10 09:40:40 -0700 Comment on attachment 197149 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197149&action=review > Source/WebKit2/UIProcess/WebFrameProxy.cpp:118 > + return m_MIMEType == "text/html" || m_MIMEType == "image/svg+xml" || m_MIMEType == "application/x-webarchive" || DOMImplementation::isXMLMIMEType(m_MIMEType); I’m not sure this patch is right. Can’t a web archive be created with contents that are not HTML, SVG, or XML? In that case, this function would return the wrong thing. I think in the case of the web archive we need an “internal MIME type” to correctly implement this function. This version might be OK for now, but there is a chance that it has some edge cases wrong. 873394 16 197149 dino 2013-04-10 17:38:04 -0700 Comment on attachment 197149 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197149&action=review >> Source/WebKit2/UIProcess/WebFrameProxy.cpp:118 >> + return m_MIMEType == "text/html" || m_MIMEType == "image/svg+xml" || m_MIMEType == "application/x-webarchive" || DOMImplementation::isXMLMIMEType(m_MIMEType); > > I’m not sure this patch is right. Can’t a web archive be created with contents that are not HTML, SVG, or XML? In that case, this function would return the wrong thing. I think in the case of the web archive we need an “internal MIME type” to correctly implement this function. > > This version might be OK for now, but there is a chance that it has some edge cases wrong. Yeah, I guess we need to see if the web archive has an item that we'd load as html or svg. I opened https://bugs.webkit.org/show_bug.cgi?id=114399 197138 2013-04-09 09:46:49 -0700 2013-04-09 11:12:23 -0700 Patch bug-114291-20130409184617.patch text/plain 1613 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGNiZDk5OTFjZGNhYjIy ZjY5Yzc3M2FhZTY3ZTdiZTAyYTViM2JiOS4uYzlhNDZmNjlmZjc0NmM5M2NmYzk1ZjdkNzM2NmNm N2MyNTU4NTYyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTA5ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgV0tGcmFtZUlzRGlzcGxh eWluZ01hcmt1cERvY3VtZW50IHNob3VsZCByZXR1cm4gdHJ1ZSBmb3IgV2ViIEFyY2hpdmVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQyOTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIHJldHVy biB0cnVlIGZvciB0aGUgV2ViIEFyY2hpdmUgTUlNRSB0eXBlLiAgCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViRnJhbWVQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lUHJveHk6 OmlzRGlzcGxheWluZ01hcmt1cERvY3VtZW50KToKKwogMjAxMy0wNC0wOSAgTWljaGFlbCBCcsO8 bmluZyAgPG1pY2hhZWwuYnJ1bmluZ0BkaWdpYS5jb20+CiAKICAgICAgICAgRml4IEdUSyBXZWJL aXQyIGJ1aWxkIGFmdGVyIHIxNDgwMDUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJh bWVQcm94eS5jcHAKaW5kZXggYzlhNmM3ODViM2U0ZmFjMzY3MjdmMDQ5Nzc1NjVkOWFmMGE0NmRm Mi4uNDExY2E5NzNmNGZhNjJjYzIzOGFkYTA1NmQ3ZTc2NTIyMzQ0MWZlNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcApAQCAtMTE2LDcgKzExNiw3IEBAIGJv b2wgV2ViRnJhbWVQcm94eTo6aXNEaXNwbGF5aW5nTWFya3VwRG9jdW1lbnQoKSBjb25zdAogewog ICAgIC8vIEZJWE1FOiBUaGlzIGNoZWNrIHNob3VsZCBiZSBtb3ZlZCB0byBzb21ld2hlcmUgaW4g V2ViQ29yZS4KICAgICAvLyBGSVhNRTogVGhpcyByZXR1cm5zIGZhbHNlIHdoZW4gZGlzcGxheWlu ZyBhIHdlYiBhcmNoaXZlLgotICAgIHJldHVybiBtX01JTUVUeXBlID09ICJ0ZXh0L2h0bWwiIHx8 IG1fTUlNRVR5cGUgPT0gImltYWdlL3N2Zyt4bWwiIHx8IERPTUltcGxlbWVudGF0aW9uOjppc1hN TE1JTUVUeXBlKG1fTUlNRVR5cGUpOworICAgIHJldHVybiBtX01JTUVUeXBlID09ICJ0ZXh0L2h0 bWwiIHx8IG1fTUlNRVR5cGUgPT0gImltYWdlL3N2Zyt4bWwiIHx8IG1fTUlNRVR5cGUgPT0gImFw cGxpY2F0aW9uL3gtd2ViYXJjaGl2ZSIgfHwgRE9NSW1wbGVtZW50YXRpb246OmlzWE1MTUlNRVR5 cGUobV9NSU1FVHlwZSk7CiB9CiAKIGJvb2wgV2ViRnJhbWVQcm94eTo6aXNEaXNwbGF5aW5nUERG RG9jdW1lbnQoKSBjb25zdAo= 197149 2013-04-09 11:12:28 -0700 2013-04-10 17:38:04 -0700 Patch bug-114291-20130409201210.patch text/plain 1747 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGNiZDk5OTFjZGNhYjIy ZjY5Yzc3M2FhZTY3ZTdiZTAyYTViM2JiOS4uODMyNTA1MmU3MGM0MzM4Y2Y2MTljNzRhNmIzZjY1 Y2YxNTA5M2FmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTA5ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgV0tGcmFtZUlzRGlzcGxh eWluZ01hcmt1cERvY3VtZW50IHNob3VsZCByZXR1cm4gdHJ1ZSBmb3IgV2ViIEFyY2hpdmVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQyOTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIHJldHVy biB0cnVlIGZvciB0aGUgV2ViIEFyY2hpdmUgTUlNRSB0eXBlIHNpbmNlIGEgV2ViIEFyY2hpdmUK KyAgICAgICAgaXMgZGlzcGxheWluZyBhIG1hcmt1cCBkb2N1bWVudCBieSBuYXR1cmUuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkZyYW1lUHJveHk6OmlzRGlzcGxheWluZ01hcmt1cERvY3VtZW50KToKKwogMjAxMy0wNC0wOSAg TWljaGFlbCBCcsO8bmluZyAgPG1pY2hhZWwuYnJ1bmluZ0BkaWdpYS5jb20+CiAKICAgICAgICAg Rml4IEdUSyBXZWJLaXQyIGJ1aWxkIGFmdGVyIHIxNDgwMDUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAKaW5kZXggYzlhNmM3ODViM2U0ZmFjMzY3MjdmMDQ5Nzc1 NjVkOWFmMGE0NmRmMi4uMzU5MGZmZDg1Y2EzMTJlNTU3YWI0NTI1MTRmYmIzYjc1ZWJlMDJmOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZyYW1lUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcApAQCAtMTE1LDgg KzExNSw3IEBAIGJvb2wgV2ViRnJhbWVQcm94eTo6aXNEaXNwbGF5aW5nU3RhbmRhbG9uZUltYWdl RG9jdW1lbnQoKSBjb25zdAogYm9vbCBXZWJGcmFtZVByb3h5Ojppc0Rpc3BsYXlpbmdNYXJrdXBE b2N1bWVudCgpIGNvbnN0CiB7CiAgICAgLy8gRklYTUU6IFRoaXMgY2hlY2sgc2hvdWxkIGJlIG1v dmVkIHRvIHNvbWV3aGVyZSBpbiBXZWJDb3JlLgotICAgIC8vIEZJWE1FOiBUaGlzIHJldHVybnMg ZmFsc2Ugd2hlbiBkaXNwbGF5aW5nIGEgd2ViIGFyY2hpdmUuCi0gICAgcmV0dXJuIG1fTUlNRVR5 cGUgPT0gInRleHQvaHRtbCIgfHwgbV9NSU1FVHlwZSA9PSAiaW1hZ2Uvc3ZnK3htbCIgfHwgRE9N SW1wbGVtZW50YXRpb246OmlzWE1MTUlNRVR5cGUobV9NSU1FVHlwZSk7CisgICAgcmV0dXJuIG1f TUlNRVR5cGUgPT0gInRleHQvaHRtbCIgfHwgbV9NSU1FVHlwZSA9PSAiaW1hZ2Uvc3ZnK3htbCIg fHwgbV9NSU1FVHlwZSA9PSAiYXBwbGljYXRpb24veC13ZWJhcmNoaXZlIiB8fCBET01JbXBsZW1l bnRhdGlvbjo6aXNYTUxNSU1FVHlwZShtX01JTUVUeXBlKTsKIH0KIAogYm9vbCBXZWJGcmFtZVBy b3h5Ojppc0Rpc3BsYXlpbmdQREZEb2N1bWVudCgpIGNvbnN0Cg==