114272 2013-04-09 06:00:52 -0700 [BlackBerry][CSS Filters] Blur filter fails to recompute blur size when layer size changes 2013-04-11 07:35:00 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson anlo cgarcia commit-queue jpetsovits mifenton rwlbuis tonikitoo xan.lopez oldest_to_newest 871657 0 anilsson 2013-04-09 06:00:52 -0700 This seems to happen frequently with CSS filters applied to images - the initial image size is small, and when the image is fully decoded the surface size increases to the true image size. If a surface starts out at 12x12, the blur distance will be computed as 1/12 and that will still be used when the surface increases to the right size. Can be seen by manual inspection ofLayoutTests/css3/filters/effect-blur-hw.html PR 323730 873665 1 anilsson 2013-04-11 02:54:46 -0700 "blur size" is the term used in the actual shader 873730 2 197567 anilsson 2013-04-11 03:29:01 -0700 Created attachment 197567 Patch 873795 3 197567 rwlbuis 2013-04-11 07:00:36 -0700 Comment on attachment 197567 Patch Nice fix. 873808 4 197567 commit-queue 2013-04-11 07:34:57 -0700 Comment on attachment 197567 Patch Clearing flags on attachment: 197567 Committed r148201: <http://trac.webkit.org/changeset/148201> 873809 5 commit-queue 2013-04-11 07:35:00 -0700 All reviewed patches have been landed. Closing bug. 197567 2013-04-11 03:29:01 -0700 2013-04-11 07:34:57 -0700 Patch bug-114272-20130411122839.patch text/plain 7165 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjNhZjIxYTcwYTc0MGZh MTMwYmNjNWE0ZDBlM2FlZmZhOWJiMmUwYi4uZTM4ZDg1NzI5NDA5OGEyZTZiM2VkNWU1YzMxZTM0 ODVhZGY1ZDgwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQyIEBACisyMDEzLTA0LTExICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV1bQ1NT IEZpbHRlcnNdIEJsdXIgZmlsdGVyIGZhaWxzIHRvIHJlY29tcHV0ZSBibHVyIHNpemUgd2hlbiBs YXllciBzaXplIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNDI3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEJsdXIgYXBwZWFyZWQgYmxvY2t5IG9yIHBpeGVsYXRlZCB3aGVuIHN1cmZhY2Ug Y2hhbmdlZCBzaXplIGFmdGVyCisgICAgICAgIGNyZWF0aW5nIHRoZSBmaWx0ZXIgYWN0aW9ucy4g VGhlIGluaXRpYWwgaW1hZ2Ugc2l6ZSB3YXMgdXNlZCB0bworICAgICAgICBkZXRlcm1pbmUgdGhl IGJsdXIgc2l6ZSAoZXhwcmVzc2VkIGluIHRleHR1cmUgY29vcmRpbmF0ZSBzeXN0ZW0pLgorICAg ICAgICBGaXhlZCBieSByZWNvbXB1dGluZyB0aGUgYmx1ciBzaXplIHdoZW4gdGhlIHN1cmZhY2Ug c2l6ZSBjaGFuZ2VzLCB1c2luZworICAgICAgICBhIG5ldyBVbmlmb3JtMWYgc3ViY2xhc3MgdGhh dCBjYW4gdXNlIGEgZnVuY3RvciB0byBjb21wdXRlIHRoZSB1bmlmb3JtCisgICAgICAgIHZhbHVl IHBlci1mcmFtZS4KKworICAgICAgICBUaGlzIGZpeGVzIGNzczMvZmlsdGVycy9lZmZlY3QtYmx1 ci1ody5odG1sLiBUaGlzIGNhbiBvbmx5IGJlIHZlcmlmaWVkCisgICAgICAgIGJ5IG1hbnVhbCBp bnNwZWN0aW9uIGJlY2F1c2UgdGhlIEJsYWNrQmVycnkgcG9ydCBpcyBub3QgY3VycmVudGx5IHVz aW5nCisgICAgICAgIHBpeGVsIHRlc3RzLgorCisgICAgICAgIFBSIDMyMzczMAorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllckZpbHRlclJlbmRlcmVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoU3VyZmFjZUZ1bmN0b3IpOgorICAgICAgICAo V2ViQ29yZTo6U3VyZmFjZUZ1bmN0b3I6OlN1cmZhY2VGdW5jdG9yKToKKyAgICAgICAgKEludmVy c2VTdXJmYWNlV2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6SW52ZXJzZVN1cmZhY2VXaWR0aDo6 SW52ZXJzZVN1cmZhY2VXaWR0aCk6CisgICAgICAgIChXZWJDb3JlOjpJbnZlcnNlU3VyZmFjZVdp ZHRoOjpvcGVyYXRvcigpKToKKyAgICAgICAgKEludmVyc2VTdXJmYWNlSGVpZ2h0KToKKyAgICAg ICAgKFdlYkNvcmU6OkludmVyc2VTdXJmYWNlSGVpZ2h0OjpJbnZlcnNlU3VyZmFjZUhlaWdodCk6 CisgICAgICAgIChXZWJDb3JlOjpMYXllckZpbHRlclJlbmRlcmVyOjphY3Rpb25zRm9yT3BlcmF0 aW9ucyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllckZpbHRl clJlbmRlcmVyLmg6CisgICAgICAgIChVbmlmb3JtMWYpOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgIChVbmlmb3JtMWZXaXRoRnVuY3Rvcik6CisgICAgICAgIChXZWJDb3JlOjpVbmlmb3Jt MWZXaXRoRnVuY3Rvcjo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlVuaWZvcm0xZldpdGhG dW5jdG9yOjpVbmlmb3JtMWZXaXRoRnVuY3Rvcik6CisgICAgICAgIChXZWJDb3JlOjpVbmlmb3Jt MWZXaXRoRnVuY3Rvcjo6YXBwbHkpOgorICAgICAgICAoV2ViQ29yZTo6VW5pZm9ybTFmOjpjcmVh dGVXaXRoRnVuY3Rvcik6CisKIDIwMTMtMDQtMTAgIEFydmlkIE5pbHNzb24gIDxhbmlsc3NvbkBy aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBMYXllclRleHR1cmUgcmVmYWN0b3JpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkv TGF5ZXJGaWx0ZXJSZW5kZXJlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ibGFja2JlcnJ5L0xheWVyRmlsdGVyUmVuZGVyZXIuY3BwCmluZGV4IGE4NDc4NzQ4Yzc2MGM0 ZDI2MWQwYWYwOTUzMGI4M2UyMWY4OTAxYWYuLmMwYWRlMTBmMDJhNWJmZDdmYWJhMzUxZGZmMmMz YzUxNTExZjY1NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllckZpbHRlclJlbmRlcmVyLmNwcApAQCAt MzgsNiArMzgsMzEgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBTdXJmYWNlRnVu Y3RvciB7CitwdWJsaWM6CisgICAgU3VyZmFjZUZ1bmN0b3IoTGF5ZXJSZW5kZXJlclN1cmZhY2Uq IHN1cmZhY2UpCisgICAgICAgIDogbV9zdXJmYWNlKHN1cmZhY2UpCisgICAgeworICAgIH0KKwor cHJvdGVjdGVkOgorICAgIExheWVyUmVuZGVyZXJTdXJmYWNlKiBtX3N1cmZhY2U7Cit9OworCitj bGFzcyBJbnZlcnNlU3VyZmFjZVdpZHRoIDogcHVibGljIFN1cmZhY2VGdW5jdG9yIHsKK3B1Ymxp YzoKKyAgICBJbnZlcnNlU3VyZmFjZVdpZHRoKExheWVyUmVuZGVyZXJTdXJmYWNlKiBzdXJmYWNl KSA6IFN1cmZhY2VGdW5jdG9yKHN1cmZhY2UpIHsgfQorCisgICAgZmxvYXQgb3BlcmF0b3IoKSAo KSB7IHJldHVybiAxLjBmIC8gbV9zdXJmYWNlLT5zaXplKCkud2lkdGgoKTsgfQorfTsKKworY2xh c3MgSW52ZXJzZVN1cmZhY2VIZWlnaHQgOiBwdWJsaWMgU3VyZmFjZUZ1bmN0b3IgeworcHVibGlj OgorICAgIEludmVyc2VTdXJmYWNlSGVpZ2h0KExheWVyUmVuZGVyZXJTdXJmYWNlKiBzdXJmYWNl KSA6IFN1cmZhY2VGdW5jdG9yKHN1cmZhY2UpIHsgfQorCisgICAgZmxvYXQgb3BlcmF0b3IoKSAo KSB7IHJldHVybiAxLjBmIC8gbV9zdXJmYWNlLT5zaXplKCkuaGVpZ2h0KCk7IH0KK307CisKIHN0 YXRpYyBpbnQgb3BlcmF0aW9uVHlwZVRvUHJvZ3JhbUlEKGNvbnN0IEZpbHRlck9wZXJhdGlvbjo6 T3BlcmF0aW9uVHlwZSYgdCkKIHsKICAgICBzd2l0Y2ggKHQpIHsKQEAgLTYwMSwxNCArNjI2LDEy IEBAIFZlY3RvcjxSZWZQdHI8TGF5ZXJGaWx0ZXJSZW5kZXJlckFjdGlvbj4gPiBMYXllckZpbHRl clJlbmRlcmVyOjphY3Rpb25zRm9yT3BlcmF0CiAKICAgICAgICAgICAgIC8vIEJMVVIgWToKICAg ICAgICAgICAgIHJldC5sYXN0KCktPmFwcGVuZFBhcmFtZXRlcihVbmlmb3JtMWY6OmNyZWF0ZSht X2Ftb3VudExvY2F0aW9uW0xheWVyRGF0YTo6Q1NTRmlsdGVyU2hhZGVyQmx1clldLCBhbW91bnQp KTsKLSAgICAgICAgICAgIHJldC5sYXN0KCktPmFwcGVuZFBhcmFtZXRlcihVbmlmb3JtMWY6OmNy ZWF0ZShtX2JsdXJBbW91bnRMb2NhdGlvblswXQotICAgICAgICAgICAgICAgICwgMS4wZiAvIGZs b2F0KHN1cmZhY2UtPnNpemUoKS5oZWlnaHQoKSkpKTsKKyAgICAgICAgICAgIHJldC5sYXN0KCkt PmFwcGVuZFBhcmFtZXRlcihVbmlmb3JtMWY6OmNyZWF0ZVdpdGhGdW5jdG9yKG1fYmx1ckFtb3Vu dExvY2F0aW9uWzBdLCBJbnZlcnNlU3VyZmFjZUhlaWdodChzdXJmYWNlKSkpOwogCiAgICAgICAg ICAgICAvLyBCTFVSIFg6CiAgICAgICAgICAgICByZXQuYXBwZW5kKExheWVyRmlsdGVyUmVuZGVy ZXJBY3Rpb246OmNyZWF0ZShMYXllckRhdGE6OkNTU0ZpbHRlclNoYWRlckJsdXJYKSk7CiAgICAg ICAgICAgICByZXQubGFzdCgpLT5hcHBlbmRQYXJhbWV0ZXIoVW5pZm9ybTFmOjpjcmVhdGUobV9h bW91bnRMb2NhdGlvbltMYXllckRhdGE6OkNTU0ZpbHRlclNoYWRlckJsdXJYXSwgYW1vdW50KSk7 Ci0gICAgICAgICAgICByZXQubGFzdCgpLT5hcHBlbmRQYXJhbWV0ZXIoVW5pZm9ybTFmOjpjcmVh dGUobV9ibHVyQW1vdW50TG9jYXRpb25bMV0KLSAgICAgICAgICAgICAgICAsIDEuMGYgLyBmbG9h dChzdXJmYWNlLT5zaXplKCkud2lkdGgoKSkpKTsKKyAgICAgICAgICAgIHJldC5sYXN0KCktPmFw cGVuZFBhcmFtZXRlcihVbmlmb3JtMWY6OmNyZWF0ZVdpdGhGdW5jdG9yKG1fYmx1ckFtb3VudExv Y2F0aW9uWzFdLCBJbnZlcnNlU3VyZmFjZVdpZHRoKHN1cmZhY2UpKSk7CiAKICAgICAgICAgICAg IH0KICAgICAgICAgICAgIGJyZWFrOwpAQCAtNjM0LDE1ICs2NTcsMTMgQEAgVmVjdG9yPFJlZlB0 cjxMYXllckZpbHRlclJlbmRlcmVyQWN0aW9uPiA+IExheWVyRmlsdGVyUmVuZGVyZXI6OmFjdGlv bnNGb3JPcGVyYXQKICAgICAgICAgICAgIHJldC5hcHBlbmQoTGF5ZXJGaWx0ZXJSZW5kZXJlckFj dGlvbjo6Y3JlYXRlKExheWVyRGF0YTo6Q1NTRmlsdGVyU2hhZGVyQmx1clkpKTsKICAgICAgICAg ICAgIHJldC5sYXN0KCktPmFwcGVuZFBhcmFtZXRlcihVbmlmb3JtMWY6OmNyZWF0ZShtX2Ftb3Vu dExvY2F0aW9uW0xheWVyRGF0YTo6Q1NTRmlsdGVyU2hhZGVyQmx1clldCiAgICAgICAgICAgICAg ICAgLCBkc2ZvLnN0ZERldmlhdGlvbigpKSk7Ci0gICAgICAgICAgICByZXQubGFzdCgpLT5hcHBl bmRQYXJhbWV0ZXIoVW5pZm9ybTFmOjpjcmVhdGUobV9ibHVyQW1vdW50TG9jYXRpb25bMF0KLSAg ICAgICAgICAgICAgICAsIDEuMGYgLyBmbG9hdChzdXJmYWNlLT5zaXplKCkuaGVpZ2h0KCkpKSk7 CisgICAgICAgICAgICByZXQubGFzdCgpLT5hcHBlbmRQYXJhbWV0ZXIoVW5pZm9ybTFmOjpjcmVh dGVXaXRoRnVuY3RvcihtX2JsdXJBbW91bnRMb2NhdGlvblswXSwgSW52ZXJzZVN1cmZhY2VIZWln aHQoc3VyZmFjZSkpKTsKIAogICAgICAgICAgICAgLy8gQkxVUiBYCiAgICAgICAgICAgICByZXQu YXBwZW5kKExheWVyRmlsdGVyUmVuZGVyZXJBY3Rpb246OmNyZWF0ZShMYXllckRhdGE6OkNTU0Zp bHRlclNoYWRlckJsdXJYKSk7CiAgICAgICAgICAgICByZXQubGFzdCgpLT5hcHBlbmRQYXJhbWV0 ZXIoVW5pZm9ybTFmOjpjcmVhdGUobV9hbW91bnRMb2NhdGlvbltMYXllckRhdGE6OkNTU0ZpbHRl clNoYWRlckJsdXJYXQogICAgICAgICAgICAgICAgICwgZHNmby5zdGREZXZpYXRpb24oKSkpOwot ICAgICAgICAgICAgcmV0Lmxhc3QoKS0+YXBwZW5kUGFyYW1ldGVyKFVuaWZvcm0xZjo6Y3JlYXRl KG1fYmx1ckFtb3VudExvY2F0aW9uWzFdCi0gICAgICAgICAgICAgICAgLCAxLjBmIC8gZmxvYXQo c3VyZmFjZS0+c2l6ZSgpLndpZHRoKCkpKSk7CisgICAgICAgICAgICByZXQubGFzdCgpLT5hcHBl bmRQYXJhbWV0ZXIoVW5pZm9ybTFmOjpjcmVhdGVXaXRoRnVuY3RvcihtX2JsdXJBbW91bnRMb2Nh dGlvblsxXSwgSW52ZXJzZVN1cmZhY2VXaWR0aChzdXJmYWNlKSkpOwogCiAgICAgICAgICAgICAv LyBSZXBhaW50IG9yaWdpbmFsIGltYWdlCiAgICAgICAgICAgICByZXQuYXBwZW5kKExheWVyRmls dGVyUmVuZGVyZXJBY3Rpb246OmNyZWF0ZShMYXllckRhdGE6OkNTU0ZpbHRlclNoYWRlclBhc3N0 aHJvdWdoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L0xheWVyRmlsdGVyUmVuZGVyZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJlci5oCmluZGV4IGYxMWViNzJk MjU5NDBiZTdiZDcwYThjYzg0NGYwNDk5ZWJiZDk4MjAuLmVlMjU0MGE3NmU5MWM1MWU3MWIyNTZl MzRiN2EyYTI5NWFjYzI0ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJlci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJGaWx0ZXJSZW5kZXJlci5oCkBA IC02OSwxNCArNjksNDcgQEAgY2xhc3MgVW5pZm9ybTFmIDogcHVibGljIFVuaWZvcm0gewogcHVi bGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFVuaWZvcm0+IGNyZWF0ZShpbnQgbG9jYXRpb24s IGZsb2F0IHZhbCk7CiAKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9yPgorICAgIHN0YXRp YyBQYXNzUmVmUHRyPFVuaWZvcm0+IGNyZWF0ZVdpdGhGdW5jdG9yKGludCBsb2NhdGlvbiwgRnVu Y3Rvcik7CisKIHByb3RlY3RlZDoKICAgICBVbmlmb3JtMWYoaW50IGxvY2F0aW9uLCBmbG9hdCB2 YWwpOwogCi1wcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBhcHBseSgpOworCiAgICAgZmxvYXQg bV92YWw7CiB9OwogCit0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9yPgorY2xhc3MgVW5pZm9ybTFm V2l0aEZ1bmN0b3IgOiBwdWJsaWMgVW5pZm9ybTFmIHsKK3B1YmxpYzoKKyAgICBzdGF0aWMgUGFz c1JlZlB0cjxVbmlmb3JtPiBjcmVhdGUoaW50IGxvY2F0aW9uLCBGdW5jdG9yIGZ1bmN0b3IpCisg ICAgeworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFVuaWZvcm0xZldpdGhGdW5jdG9yKGxv Y2F0aW9uLCBmdW5jdG9yKSk7CisgICAgfQorCitwcm90ZWN0ZWQ6CisgICAgVW5pZm9ybTFmV2l0 aEZ1bmN0b3IoaW50IGxvY2F0aW9uLCBGdW5jdG9yIGZ1bmN0b3IpCisgICAgICAgIDogVW5pZm9y bTFmKGxvY2F0aW9uLCAwKQorICAgICAgICAsIG1fZnVuY3RvcihmdW5jdG9yKQorICAgIHsKKyAg ICB9CisKKyAgICB2aXJ0dWFsIHZvaWQgYXBwbHkoKQorICAgIHsKKyAgICAgICAgbV92YWwgPSBt X2Z1bmN0b3IoKTsKKyAgICAgICAgVW5pZm9ybTFmOjphcHBseSgpOworICAgIH0KKworICAgIEZ1 bmN0b3IgbV9mdW5jdG9yOworfTsKKwordGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rvcj4KK2lubGlu ZSBQYXNzUmVmUHRyPFVuaWZvcm0+IFVuaWZvcm0xZjo6Y3JlYXRlV2l0aEZ1bmN0b3IoaW50IGxv Y2F0aW9uLCBGdW5jdG9yIGZ1bmN0b3IpCit7CisgICAgcmV0dXJuIFVuaWZvcm0xZldpdGhGdW5j dG9yPEZ1bmN0b3I+OjpjcmVhdGUobG9jYXRpb24sIGZ1bmN0b3IpOworfQorCiBjbGFzcyBVbmlm b3JtMWkgOiBwdWJsaWMgVW5pZm9ybSB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8 VW5pZm9ybT4gY3JlYXRlKGludCBsb2NhdGlvbiwgaW50IHZhbCk7Cg==