114268 2013-04-09 05:00:43 -0700 [CSS Regions] Regions don't create a stacking context for their contents 2013-06-11 14:55:19 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 mibalan mvujovic achicu commit-queue esprehn+autocc glenn WebkitBugTracker oldest_to_newest 871629 0 197030 mibalan 2013-04-09 05:00:43 -0700 Created attachment 197030 W3C test showcasing the problem The CSS Regions spec states that regions should create a stacking context for their contents. However, it currently doesn't look like this is happening Steps to reproduce: Open attached file in browser EXPECTED The purple square is drawn on top of the other squares ACTUAL The purple square is drawn under the yellow square (actually under all the other three squares) 899226 1 204343 mvujovic 2013-06-11 10:54:19 -0700 Created attachment 204343 Patch 899240 2 204343 achicu 2013-06-11 11:41:04 -0700 Comment on attachment 204343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204343&action=review > Source/WebCore/rendering/RenderRegion.cpp:166 > + bool isPaintingBackground = (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == PaintPhaseChildBlockBackground); > + if (!isValid() || (!isPaintingBackground && paintInfo.phase != PaintPhaseSelection)) Let's extract this into something like "bool shouldPaint". It looks bad with so many negations in it. 899276 3 204356 mvujovic 2013-06-11 13:34:15 -0700 Created attachment 204356 Patch Updated patch based on Alex's comments. 899277 4 mvujovic 2013-06-11 13:37:05 -0700 (In reply to comment #2) > (From update of attachment 204343 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204343&action=review > > > Source/WebCore/rendering/RenderRegion.cpp:166 > > + bool isPaintingBackground = (paintInfo.phase == PaintPhaseBlockBackground || paintInfo.phase == PaintPhaseChildBlockBackground); > > + if (!isValid() || (!isPaintingBackground && paintInfo.phase != PaintPhaseSelection)) > > Let's extract this into something like "bool shouldPaint". It looks bad with so many negations in it. Good suggestion. I pulled the isValid() into it's own if statement. Now this if statement only contains the phase checking. I ended up not needing a boolean. 899298 5 204356 achicu 2013-06-11 14:33:00 -0700 Comment on attachment 204356 Patch r=me 899299 6 204356 mvujovic 2013-06-11 14:33:54 -0700 Comment on attachment 204356 Patch Thanks for the review! Setting cq+. 899306 7 204356 commit-queue 2013-06-11 14:55:17 -0700 Comment on attachment 204356 Patch Clearing flags on attachment: 204356 Committed r151475: <http://trac.webkit.org/changeset/151475> 899307 8 commit-queue 2013-06-11 14:55:19 -0700 All reviewed patches have been landed. Closing bug. 197030 2013-04-09 05:00:43 -0700 2013-04-09 05:00:43 -0700 W3C test showcasing the problem regions-stacking-context-004.html text/html 1770 mibalan PCFET0NUWVBFIGh0bWw+CjxodG1sPgoJPGhlYWQ+CgkJPHRpdGxlPkNTUyBUZXN0OiByZWdpb25z IGNyZWF0ZSBzdGFja2luZyBjb250ZXh0czwvdGl0bGU+CgkJPGxpbmsgcmVsPSJhdXRob3IiIHRp dGxlPSJNaWhhaSBCYWxhbiIgaHJlZj0ibWFpbHRvOm1pYmFsYW5AYWRvYmUuY29tIj4KCQk8bGlu ayByZWw9ImhlbHAiIGhyZWY9Imh0dHA6Ly93d3cudzMub3JnL1RSL2NzczMtcmVnaW9ucy8jdGhl LWZsb3ctaW50by1wcm9wZXJ0eSI+CgkJPGxpbmsgcmVsPSJoZWxwIiBocmVmPSJodHRwOi8vd3d3 LnczLm9yZy9UUi9jc3MzLXJlZ2lvbnMvI3RoZS1mbG93LWZyb20tcHJvcGVydHkiPgoJCTxtZXRh IG5hbWU9ImZsYWdzIiBjb250ZW50PSJhaGVtIj4KCQk8bWV0YSBuYW1lPSJhc3NlcnQiIGNvbnRl bnQ9IlRlc3QgY2hlY2tzIHRoYXQgcmVnaW9ucyBjcmVhdGUgc3RhY2tpbmcgY29udGV4dHMgZm9y IGNvbnRlbnQgZmxvd2VkIGludG8gdGhlbS4iPgoJCTxsaW5rIHJlbD0ibWF0Y2giIGhyZWY9InJl ZmVyZW5jZS9yZWdpb25zLXN0YWNraW5nLWNvbnRleHQtMDA0LXJlZi5odG1sIj4KCQk8c3R5bGU+ CgkJI2NvbnRlbnQgewoJCQlvcGFjaXR5OiAwLjc7CgkJfQoJCSNjb250ZW50ID4gZGl2IHsKCQkJ cG9zaXRpb246IHJlbGF0aXZlOwoJCQl3aWR0aDogMTAwcHg7CgkJCWhlaWdodDogMTAwcHg7CgkJ CS13ZWJraXQtZmxvdy1pbnRvOiBmbG93OwoJCX0KCQkubGVmdCB7CgkJCXRvcDogMDsKCQkJbGVm dDogMDsKCQkJYmFja2dyb3VuZC1jb2xvcjogbGlnaHRncmVlbjsKCQl9CgkJLmNlbnRlciB7CgkJ CXRvcDogLTc1cHg7CgkJCWxlZnQ6IDI1cHg7CgkJCWJhY2tncm91bmQtY29sb3I6IGxpZ2h0Ymx1 ZTsKCQl9CgkJLnJpZ2h0IHsKCQkJdG9wOiAtMTUwcHg7CgkJCWxlZnQ6IDUwcHg7CgkJCWJhY2tn cm91bmQtY29sb3I6IHllbGxvdzsKCQl9CgoJCSNyZWdpb24gewoJCQl3aWR0aDogMTUwcHg7CgkJ CWhlaWdodDogMTUwcHg7CgkJCS13ZWJraXQtZmxvdy1mcm9tOiBmbG93OwoJCX0KCQkjcmVnaW9u IHB7CgkJCWhlaWdodDogNTAlOwoJCQliYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CgkJfQoKCQkjZHVt bXkgewoJCQliYWNrZ3JvdW5kLWNvbG9yOiBwdXJwbGU7CgkJCXdpZHRoOiAxMDBweDsKCQkJaGVp Z2h0OiAxMDBweDsKCQkJbWFyZ2luLXRvcDogLTc1cHg7CgkJCW1hcmdpbi1sZWZ0OiA3NXB4OwoJ CX0KCQk8L3N0eWxlPgoJPC9oZWFkPgoJPGJvZHk+CgkJPG9sPgoJCQk8bGk+WW91IHNob3VsZCBz ZWUgbm8gcmVkLjwvbGk+CgkJCTxsaT5Zb3Ugc2hvdWxkIHNlZSBmb3VyIGNvbG9yZWQgb3Zlcmxh cHBpbmcgc3F1YXJlcywgZnJvbSBiYWNrIHRvIGZyb250OiBhIGdyZWVuIHNxdWFyZSwgYSBibHVl IHNxdWFyZSwgYSB5ZWxsb3cgc3F1YXJlIGFuZCBhIHB1cnBsZSBzcXVhcmUuPC9saT4KCQkJPCEt LSBUaGUgcHVycGxlIHNxdWFyZSBzaG91bGQgYmUgcGFpbnRlZCBvbiB0b3Agb2YgdGhlIG90aGVy IG9uZXMgYmVjYXVzZSB0aGUgcmVnaW9uIGNyZWF0ZXMgYSBzdGFja2lnbiBjb250ZXh0IGZvciBp dHMgY29udGVudHMuIC0tPgoJCTwvb2w+CgoJCTxkaXYgaWQ9InJlZ2lvbiI+CgkJCTxwPiZuYnNw OzwvcD4KCQk8L2Rpdj4KCQk8ZGl2IGlkPSJkdW1teSI+PC9kaXY+CgoJCTxkaXYgaWQ9ImNvbnRl bnQiPgoJCQk8ZGl2IGNsYXNzPSJsZWZ0Ij48L2Rpdj4KCQkJPGRpdiBjbGFzcz0iY2VudGVyIj48 L2Rpdj4KCQkJPGRpdiBjbGFzcz0icmlnaHQiPjwvZGl2PgoJCTwvZGl2PgoJPC9ib2R5Pgo8L2h0 bWw+ 204343 2013-06-11 10:54:19 -0700 2013-06-11 13:34:15 -0700 Patch 114268-1.patch text/plain 5866 mvujovic ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MTU2NzgwLi4wYjQ2M2VjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDYt MTAgIE1heCBWdWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gUmVnaW9ucyBkb24ndCBjcmVhdGUgYSBzdGFja2luZyBjb250ZXh0IGZvciB0aGVpciBj b250ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE0MjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L3JlZ2lvbnMvcmVnaW9uLXNpYmxpbmctcGFpbnQtb3JkZXItZXhwZWN0ZWQuaHRtbDog QWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJsaW5nLXBhaW50LW9yZGVy Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTA2LTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBVbnJldmlld2VkIFRlc3RFeHBlY3RhdGlvbiBj bGVhbnVwLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJs aW5nLXBhaW50LW9yZGVyLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMv cmVnaW9uLXNpYmxpbmctcGFpbnQtb3JkZXItZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi44NjM1MjU4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJsaW5nLXBhaW50LW9yZGVyLWV4cGVjdGVkLmh0bWwK QEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8IS0tCisgICAgVGhpcyBpcyBhIHRl c3QgcmVmZXJlbmNlIGZpbGUuCisgICAgVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgaWYgYSByZWdp b24gYXBwZWFycyBiZWZvcmUgYSBzaWJsaW5nIGVsZW1lbnQgaW4gRE9NIG9yZGVyLCB0aGUgcmVn aW9uJ3MKKyAgICBjb250ZW50IHBhaW50cyBiZWxvdyB0aGUgc2libGluZy4KKyAgICBUaGlzIHRl c3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIHJlZCB2aXNpYmxlLgorLS0+Cis8aHRtbD4KKzxoZWFk PgorICAgIDxzdHlsZT4KKyAgICAgICAgI3JlZ2lvbiB7CisgICAgICAgICAgICBiYWNrZ3JvdW5k LWNvbG9yOiBncmF5OworICAgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICAgICAgaGVp Z2h0OiAxMDBweDsKKyAgICAgICAgfQorICAgICAgICAjc2libGluZy1vZi1yZWdpb24geworICAg ICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgICAgICB3aWR0aDogMTAw cHg7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgbWFyZ2luLXRvcDog LTkwcHg7CisgICAgICAgICAgICBtYXJnaW4tbGVmdDogMTBweDsKKyAgICAgICAgfQorICAgIDwv c3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJyZWdpb24iPjwvZGl2PgorICAg IDxkaXYgaWQ9InNpYmxpbmctb2YtcmVnaW9uIj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9yZWdpb24tc2libGluZy1wYWludC1v cmRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJsaW5nLXBhaW50 LW9yZGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uODQ1ZjVhMgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9yZWdpb24tc2libGlu Zy1wYWludC1vcmRlci5odG1sCkBAIC0wLDAgKzEsNDIgQEAKKzwhRE9DVFlQRSBodG1sPgorPCEt LQorICAgIFRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGlmIGEgcmVnaW9uIGFwcGVhcnMgYmVmb3Jl IGEgc2libGluZyBlbGVtZW50IGluIERPTSBvcmRlciwgdGhlIHJlZ2lvbidzCisgICAgY29udGVu dCBwYWludHMgYmVsb3cgdGhlIHNpYmxpbmcuCisgICAgVGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVy ZSBpcyBubyByZWQgdmlzaWJsZS4KKy0tPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+Cisg ICAgICAgIC8qCisgICAgICAgICAgICBUaGlzIGVsZW1lbnQgc2hvdWxkIG5vdCBiZSB2aXNpYmxl IGJlY2F1c2UgdGhlIHJlZ2lvbidzIGNvbnRlbnQgc2hvdWxkIHBhaW50IHVuZGVyIHRoZQorICAg ICAgICAgICAgcmVnaW9uJ3Mgc2libGluZy4KKyAgICAgICAgKi8KKyAgICAgICAgI2NvbnRlbnQt Zm9yLXJlZ2lvbiB7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgICAg ICAgICAtd2Via2l0LWZsb3ctaW50bzogZmxvdzsKKyAgICAgICAgICAgIHdpZHRoOiA1MHB4Owor ICAgICAgICAgICAgaGVpZ2h0OiA1MHB4OworICAgICAgICAgICAgbWFyZ2luLWxlZnQ6IDUwcHg7 CisgICAgICAgICAgICBtYXJnaW4tdG9wOiA1MHB4OworICAgICAgICB9CisgICAgICAgICNyZWdp b24geworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JheTsKKyAgICAgICAgICAgIC13 ZWJraXQtZmxvdy1mcm9tOiBmbG93OworICAgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAg ICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgfQorICAgICAgICAjc2libGluZy1vZi1yZWdp b24geworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgICAgICB3 aWR0aDogMTAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgbWFy Z2luLXRvcDogLTkwcHg7CisgICAgICAgICAgICBtYXJnaW4tbGVmdDogMTBweDsKKyAgICAgICAg fQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJjb250ZW50LWZv ci1yZWdpb24iPjwvZGl2PgorICAgIDxkaXYgaWQ9InJlZ2lvbiI+PC9kaXY+CisgICAgPGRpdiBp ZD0ic2libGluZy1vZi1yZWdpb24iPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IGYxN2RhYzkuLmVjMWVkZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzNyBAQAorMjAxMy0w Ni0xMCAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBS ZWdpb25zXSBSZWdpb25zIGRvbid0IGNyZWF0ZSBhIHN0YWNraW5nIGNvbnRleHQgZm9yIHRoZWly IGNvbnRlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTQyNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQYWludCB0aGUgcmVnaW9uIGNvbnRlbnQgKGZyb20gUmVuZGVyRmxvd1RocmVhZCkgZHVyaW5n IHRoZSBiYWNrZ3JvdW5kIHBoYXNlIGluc3RlYWQgb2YgdGhlCisgICAgICAgIGZvcmVncm91bmQg cGhhc2UuCisKKyAgICAgICAgTGV0J3MgYXNzdW1lIHRoZXJlIGlzIGEgcmVnaW9uIGFuZCBhIHNp YmxpbmcgZWxlbWVudC4gVGhlIHNpYmxpbmcgcGFydGlhbGx5IG92ZXJsYXBzIHRoZQorICAgICAg ICByZWdpb24gYW5kIGFwcGVhcnMgYWZ0ZXIgdGhlIHJlZ2lvbiBpbiBET00gb3JkZXIuCisKKyAg ICAgICAgQmVmb3JlIHRoaXMgcGF0Y2gsIHdlIHdvdWxkIHBhaW50IGluIHRoaXMgb3JkZXI6Cisg ICAgICAgIDEpIFJlZ2lvbiBiYWNrZ3JvdW5kCisgICAgICAgIDIpIFNpYmxpbmcgYmFja2dyb3Vu ZAorICAgICAgICAzKSBSZWdpb24gY29udGVudAorICAgICAgICA0KSBTaWJsaW5nIGNvbnRlbnQK KworICAgICAgICBBcyBhIHJlc3VsdCwgdGhlIHNpYmxpbmcgYmFja2dyb3VuZCB3b3VsZCBpbmNv cnJlY3RseSBwYWludCBiZXR3ZWVuIHRoZSByZWdpb24KKyAgICAgICAgYmFja2dyb3VuZCBhbmQg dGhlIHJlZ2lvbiBjb250ZW50LiBJbnN0ZWFkLCB0aGUgc2libGluZyBiYWNrZ3JvdW5kIHNob3Vs ZCBwYWludCBvdmVyIHRoZQorICAgICAgICByZWdpb24gYmFja2dyb3VuZCBhbmQgdGhlIHJlZ2lv biBjb250ZW50LgorCisgICAgICAgIEFmdGVyIHRoaXMgcGF0Y2gsIHdlIHBhaW50IGluIHRoaXMg b3JkZXI6CisgICAgICAgIDEpIFJlZ2lvbiBiYWNrZ3JvdW5kCisgICAgICAgIDIpIFJlZ2lvbiBj b250ZW50CisgICAgICAgIDMpIFNpYmxpbmcgYmFja2dyb3VuZAorICAgICAgICA0KSBTaWJsaW5n IGNvbnRlbnQKKworICAgICAgICBUZXN0OiBmYXN0L3JlZ2lvbnMvcmVnaW9uLXNpYmxpbmctcGFp bnQtb3JkZXIuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJSZWdpb246OnBhaW50T2JqZWN0KToKKwogMjAxMy0wNi0w NiAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ1NTIFNo YXBlc10gUmVuYW1lIHVwZGF0ZUxpbmVCb3VuZGFyaWVzRm9yRXhjbHVzaW9ucyB0byB1cGRhdGVT aGFwZUFuZFNlZ21lbnRzRm9yQ3VycmVudExpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclJlZ2lvbi5jcHAKaW5kZXggMjYxMTljYi4uMjY0OGM1MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKQEAgLTE2MSw4ICsxNjEsOSBAQCB2b2lkIFJlbmRl clJlZ2lvbjo6cGFpbnRPYmplY3QoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBv aW50JiBwYWludE9mZgogICAgIC8vIERlbGVnYXRlIHBhaW50aW5nIG9mIGNvbnRlbnQgaW4gcmVn aW9uIHRvIFJlbmRlckZsb3dUaHJlYWQuCiAgICAgLy8gUmVuZGVyRmxvd1RocmVhZCBpcyBhIHNl bGYgcGFpbnRpbmcgbGF5ZXIgKGJlaW5nIGEgcG9zaXRpb25lZCBvYmplY3QpIHdobyBpcyBwYWlu dGluZyBpdHMgY2hpbGRyZW4sIHRoZSBjb2xsZWN0ZWQgb2JqZWN0cy4KICAgICAvLyBTaW5jZSB3 ZSBkbyBub3Qgd2FudCB0byBwYWludCB0aGUgZmxvdyB0aHJlYWQgY29udGVudCBtdWx0aXBsZSB0 aW1lcyAoZm9yIGVhY2ggcGFpbnRpbmcgcGhhc2Ugb2YgdGhlIHJlZ2lvbiBvYmplY3QpLAotICAg IC8vIHdlIGFsbG93IHRoZSBmbG93IHRocmVhZCBwYWludGluZyBvbmx5IGZvciB0aGUgc2VsZWN0 aW9uIGFuZCB0aGUgZm9yZWdyb3VuZCBwaGFzZS4KLSAgICBpZiAoIWlzVmFsaWQoKSB8fCAocGFp bnRJbmZvLnBoYXNlICE9IFBhaW50UGhhc2VGb3JlZ3JvdW5kICYmIHBhaW50SW5mby5waGFzZSAh PSBQYWludFBoYXNlU2VsZWN0aW9uKSkKKyAgICAvLyB3ZSBhbGxvdyB0aGUgZmxvdyB0aHJlYWQg cGFpbnRpbmcgb25seSBmb3IgdGhlIHNlbGVjdGlvbiBhbmQgdGhlIGJhY2tncm91bmQgcGhhc2Uu CisgICAgYm9vbCBpc1BhaW50aW5nQmFja2dyb3VuZCA9IChwYWludEluZm8ucGhhc2UgPT0gUGFp bnRQaGFzZUJsb2NrQmFja2dyb3VuZCB8fCBwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQaGFzZUNo aWxkQmxvY2tCYWNrZ3JvdW5kKTsKKyAgICBpZiAoIWlzVmFsaWQoKSB8fCAoIWlzUGFpbnRpbmdC YWNrZ3JvdW5kICYmIHBhaW50SW5mby5waGFzZSAhPSBQYWludFBoYXNlU2VsZWN0aW9uKSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgc2V0UmVnaW9uT2JqZWN0c1JlZ2lvblN0eWxlKCk7Cg== 204356 2013-06-11 13:34:15 -0700 2013-06-11 14:55:17 -0700 Patch 114268-2.patch text/plain 5893 mvujovic ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MTU2NzgwLi4wYjQ2M2VjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDYt MTAgIE1heCBWdWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gUmVnaW9ucyBkb24ndCBjcmVhdGUgYSBzdGFja2luZyBjb250ZXh0IGZvciB0aGVpciBj b250ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE0MjY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBmYXN0L3JlZ2lvbnMvcmVnaW9uLXNpYmxpbmctcGFpbnQtb3JkZXItZXhwZWN0ZWQuaHRtbDog QWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJsaW5nLXBhaW50LW9yZGVy Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTA2LTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw bGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBVbnJldmlld2VkIFRlc3RFeHBlY3RhdGlvbiBj bGVhbnVwLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJs aW5nLXBhaW50LW9yZGVyLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMv cmVnaW9uLXNpYmxpbmctcGFpbnQtb3JkZXItZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi44NjM1MjU4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJsaW5nLXBhaW50LW9yZGVyLWV4cGVjdGVkLmh0bWwK QEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8IS0tCisgICAgVGhpcyBpcyBhIHRl c3QgcmVmZXJlbmNlIGZpbGUuCisgICAgVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgaWYgYSByZWdp b24gYXBwZWFycyBiZWZvcmUgYSBzaWJsaW5nIGVsZW1lbnQgaW4gRE9NIG9yZGVyLCB0aGUgcmVn aW9uJ3MKKyAgICBjb250ZW50IHBhaW50cyBiZWxvdyB0aGUgc2libGluZy4KKyAgICBUaGlzIHRl c3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIHJlZCB2aXNpYmxlLgorLS0+Cis8aHRtbD4KKzxoZWFk PgorICAgIDxzdHlsZT4KKyAgICAgICAgI3JlZ2lvbiB7CisgICAgICAgICAgICBiYWNrZ3JvdW5k LWNvbG9yOiBncmF5OworICAgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICAgICAgaGVp Z2h0OiAxMDBweDsKKyAgICAgICAgfQorICAgICAgICAjc2libGluZy1vZi1yZWdpb24geworICAg ICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgICAgICB3aWR0aDogMTAw cHg7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgbWFyZ2luLXRvcDog LTkwcHg7CisgICAgICAgICAgICBtYXJnaW4tbGVmdDogMTBweDsKKyAgICAgICAgfQorICAgIDwv c3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJyZWdpb24iPjwvZGl2PgorICAg IDxkaXYgaWQ9InNpYmxpbmctb2YtcmVnaW9uIj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9yZWdpb24tc2libGluZy1wYWludC1v cmRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zaWJsaW5nLXBhaW50 LW9yZGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uODQ1ZjVhMgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9yZWdpb24tc2libGlu Zy1wYWludC1vcmRlci5odG1sCkBAIC0wLDAgKzEsNDIgQEAKKzwhRE9DVFlQRSBodG1sPgorPCEt LQorICAgIFRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGlmIGEgcmVnaW9uIGFwcGVhcnMgYmVmb3Jl IGEgc2libGluZyBlbGVtZW50IGluIERPTSBvcmRlciwgdGhlIHJlZ2lvbidzCisgICAgY29udGVu dCBwYWludHMgYmVsb3cgdGhlIHNpYmxpbmcuCisgICAgVGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVy ZSBpcyBubyByZWQgdmlzaWJsZS4KKy0tPgorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+Cisg ICAgICAgIC8qCisgICAgICAgICAgICBUaGlzIGVsZW1lbnQgc2hvdWxkIG5vdCBiZSB2aXNpYmxl IGJlY2F1c2UgdGhlIHJlZ2lvbidzIGNvbnRlbnQgc2hvdWxkIHBhaW50IHVuZGVyIHRoZQorICAg ICAgICAgICAgcmVnaW9uJ3Mgc2libGluZy4KKyAgICAgICAgKi8KKyAgICAgICAgI2NvbnRlbnQt Zm9yLXJlZ2lvbiB7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgICAg ICAgICAtd2Via2l0LWZsb3ctaW50bzogZmxvdzsKKyAgICAgICAgICAgIHdpZHRoOiA1MHB4Owor ICAgICAgICAgICAgaGVpZ2h0OiA1MHB4OworICAgICAgICAgICAgbWFyZ2luLWxlZnQ6IDUwcHg7 CisgICAgICAgICAgICBtYXJnaW4tdG9wOiA1MHB4OworICAgICAgICB9CisgICAgICAgICNyZWdp b24geworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JheTsKKyAgICAgICAgICAgIC13 ZWJraXQtZmxvdy1mcm9tOiBmbG93OworICAgICAgICAgICAgd2lkdGg6IDEwMHB4OworICAgICAg ICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgfQorICAgICAgICAjc2libGluZy1vZi1yZWdp b24geworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgICAgICB3 aWR0aDogMTAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgbWFy Z2luLXRvcDogLTkwcHg7CisgICAgICAgICAgICBtYXJnaW4tbGVmdDogMTBweDsKKyAgICAgICAg fQorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGlkPSJjb250ZW50LWZv ci1yZWdpb24iPjwvZGl2PgorICAgIDxkaXYgaWQ9InJlZ2lvbiI+PC9kaXY+CisgICAgPGRpdiBp ZD0ic2libGluZy1vZi1yZWdpb24iPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IGYxN2RhYzkuLmVjMWVkZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzNyBAQAorMjAxMy0w Ni0xMCAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBS ZWdpb25zXSBSZWdpb25zIGRvbid0IGNyZWF0ZSBhIHN0YWNraW5nIGNvbnRleHQgZm9yIHRoZWly IGNvbnRlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTQyNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQYWludCB0aGUgcmVnaW9uIGNvbnRlbnQgKGZyb20gUmVuZGVyRmxvd1RocmVhZCkgZHVyaW5n IHRoZSBiYWNrZ3JvdW5kIHBoYXNlIGluc3RlYWQgb2YgdGhlCisgICAgICAgIGZvcmVncm91bmQg cGhhc2UuCisKKyAgICAgICAgTGV0J3MgYXNzdW1lIHRoZXJlIGlzIGEgcmVnaW9uIGFuZCBhIHNp YmxpbmcgZWxlbWVudC4gVGhlIHNpYmxpbmcgcGFydGlhbGx5IG92ZXJsYXBzIHRoZQorICAgICAg ICByZWdpb24gYW5kIGFwcGVhcnMgYWZ0ZXIgdGhlIHJlZ2lvbiBpbiBET00gb3JkZXIuCisKKyAg ICAgICAgQmVmb3JlIHRoaXMgcGF0Y2gsIHdlIHdvdWxkIHBhaW50IGluIHRoaXMgb3JkZXI6Cisg ICAgICAgIDEpIFJlZ2lvbiBiYWNrZ3JvdW5kCisgICAgICAgIDIpIFNpYmxpbmcgYmFja2dyb3Vu ZAorICAgICAgICAzKSBSZWdpb24gY29udGVudAorICAgICAgICA0KSBTaWJsaW5nIGNvbnRlbnQK KworICAgICAgICBBcyBhIHJlc3VsdCwgdGhlIHNpYmxpbmcgYmFja2dyb3VuZCB3b3VsZCBpbmNv cnJlY3RseSBwYWludCBiZXR3ZWVuIHRoZSByZWdpb24KKyAgICAgICAgYmFja2dyb3VuZCBhbmQg dGhlIHJlZ2lvbiBjb250ZW50LiBJbnN0ZWFkLCB0aGUgc2libGluZyBiYWNrZ3JvdW5kIHNob3Vs ZCBwYWludCBvdmVyIHRoZQorICAgICAgICByZWdpb24gYmFja2dyb3VuZCBhbmQgdGhlIHJlZ2lv biBjb250ZW50LgorCisgICAgICAgIEFmdGVyIHRoaXMgcGF0Y2gsIHdlIHBhaW50IGluIHRoaXMg b3JkZXI6CisgICAgICAgIDEpIFJlZ2lvbiBiYWNrZ3JvdW5kCisgICAgICAgIDIpIFJlZ2lvbiBj b250ZW50CisgICAgICAgIDMpIFNpYmxpbmcgYmFja2dyb3VuZAorICAgICAgICA0KSBTaWJsaW5n IGNvbnRlbnQKKworICAgICAgICBUZXN0OiBmYXN0L3JlZ2lvbnMvcmVnaW9uLXNpYmxpbmctcGFp bnQtb3JkZXIuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJSZWdpb246OnBhaW50T2JqZWN0KToKKwogMjAxMy0wNi0w NiAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ1NTIFNo YXBlc10gUmVuYW1lIHVwZGF0ZUxpbmVCb3VuZGFyaWVzRm9yRXhjbHVzaW9ucyB0byB1cGRhdGVT aGFwZUFuZFNlZ21lbnRzRm9yQ3VycmVudExpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclJlZ2lvbi5jcHAKaW5kZXggMjYxMTljYi4uMDQyZWI0NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKQEAgLTE1OCwxMSArMTU4LDE0IEBAIHZvaWQgUmVu ZGVyUmVnaW9uOjpwYWludE9iamVjdChQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0 UG9pbnQmIHBhaW50T2ZmCiAKICAgICBSZW5kZXJCbG9jazo6cGFpbnRPYmplY3QocGFpbnRJbmZv LCBwYWludE9mZnNldCk7CiAKKyAgICBpZiAoIWlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgLy8gRGVsZWdhdGUgcGFpbnRpbmcgb2YgY29udGVudCBpbiByZWdpb24gdG8gUmVuZGVy Rmxvd1RocmVhZC4KICAgICAvLyBSZW5kZXJGbG93VGhyZWFkIGlzIGEgc2VsZiBwYWludGluZyBs YXllciAoYmVpbmcgYSBwb3NpdGlvbmVkIG9iamVjdCkgd2hvIGlzIHBhaW50aW5nIGl0cyBjaGls ZHJlbiwgdGhlIGNvbGxlY3RlZCBvYmplY3RzLgogICAgIC8vIFNpbmNlIHdlIGRvIG5vdCB3YW50 IHRvIHBhaW50IHRoZSBmbG93IHRocmVhZCBjb250ZW50IG11bHRpcGxlIHRpbWVzIChmb3IgZWFj aCBwYWludGluZyBwaGFzZSBvZiB0aGUgcmVnaW9uIG9iamVjdCksCi0gICAgLy8gd2UgYWxsb3cg dGhlIGZsb3cgdGhyZWFkIHBhaW50aW5nIG9ubHkgZm9yIHRoZSBzZWxlY3Rpb24gYW5kIHRoZSBm b3JlZ3JvdW5kIHBoYXNlLgotICAgIGlmICghaXNWYWxpZCgpIHx8IChwYWludEluZm8ucGhhc2Ug IT0gUGFpbnRQaGFzZUZvcmVncm91bmQgJiYgcGFpbnRJbmZvLnBoYXNlICE9IFBhaW50UGhhc2VT ZWxlY3Rpb24pKQorICAgIC8vIHdlIGFsbG93IHRoZSBmbG93IHRocmVhZCBwYWludGluZyBvbmx5 IGZvciB0aGUgc2VsZWN0aW9uIGFuZCB0aGUgYmFja2dyb3VuZCBwaGFzZS4KKyAgICBpZiAocGFp bnRJbmZvLnBoYXNlICE9IFBhaW50UGhhc2VCbG9ja0JhY2tncm91bmQgJiYgcGFpbnRJbmZvLnBo YXNlICE9IFBhaW50UGhhc2VDaGlsZEJsb2NrQmFja2dyb3VuZCAmJiBwYWludEluZm8ucGhhc2Ug IT0gUGFpbnRQaGFzZVNlbGVjdGlvbikKICAgICAgICAgcmV0dXJuOwogCiAgICAgc2V0UmVnaW9u T2JqZWN0c1JlZ2lvblN0eWxlKCk7Cg==