114267 2013-04-09 04:44:07 -0700 Throttle compositing layer flushes in subframes 2013-04-09 05:11:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned abarth japhet simon.fraser webkit.review.bot oldest_to_newest 871614 0 koivisto 2013-04-09 04:44:07 -0700 Throttle compositing layer flushes in all frames, not just the main one. 871615 1 197027 koivisto 2013-04-09 04:46:10 -0700 Created attachment 197027 patch 871623 2 197027 kling 2013-04-09 04:52:11 -0700 Comment on attachment 197027 patch View in context: https://bugs.webkit.org/attachment.cgi?id=197027&action=review r=me > Source/WebCore/page/FrameView.cpp:2297 > + if (RenderView* renderView = frame->view()->renderView()) > + renderView->compositor()->setLayerFlushThrottlingEnabled(isLoadProgressing); I take it frame->view() is always non-null here. 871635 3 koivisto 2013-04-09 05:11:11 -0700 http://trac.webkit.org/changeset/148013 197027 2013-04-09 04:46:10 -0700 2013-04-09 04:52:11 -0700 patch layer-flush-throttling-frames.patch text/plain 3093 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODAwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTA5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBUaHJvdHRsZSBjb21wb3NpdGlu ZyBsYXllciBmbHVzaGVzIGluIHN1YmZyYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MjY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhyb3R0bGUgY29tcG9zaXRpbmcgbGF5ZXIgZmx1c2hlcyBp biBhbGwgZnJhbWVzLCBub3QganVzdCB0aGUgbWFpbiBvbmUuCisgICAgICAgIAorICAgICAgICBU aGlzIGVzcGVjaWFsbHkgcmVkdWNlcyBmbHVzaGVzL3JlcGFpbnRzIGdlbmVyYXRlZCBieSBhZHMg aW4gaWZyYW1lcy4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6bG9hZFByb2dyZXNzaW5nU3RhdHVzQ2hhbmdlZCk6Cisg ICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3 Ojp1cGRhdGVMYXllckZsdXNoVGhyb3R0bGluZ0luQWxsRnJhbWVzKToKKyAgICAgICAgKiBwYWdl L0ZyYW1lVmlldy5oOgorCiAyMDEzLTA0LTA5ICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3Jn PgogCiAgICAgICAgIEluaXRpYWxpemF0aW9uIHNraXBwZWQgZXJyb3Igb24gV2luQ2FyaW8gYWZ0 ZXIgcjE0NzY0MwpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZp c2lvbiAxNDc3OTcpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMzE5LDcgKzMzMTksNyBAQCBOZXR3b3JraW5nQ29udGV4dCogRnJh bWVMb2FkZXI6Om5ldHdvcmtpCiB2b2lkIEZyYW1lTG9hZGVyOjpsb2FkUHJvZ3Jlc3NpbmdTdGF0 dXNDaGFuZ2VkKCkKIHsKICAgICBib29sIGlzTG9hZFByb2dyZXNzaW5nID0gbV9mcmFtZS0+cGFn ZSgpLT5wcm9ncmVzcygpLT5pc0xvYWRQcm9ncmVzc2luZygpOwotICAgIG1fZnJhbWUtPnBhZ2Uo KS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+dXBkYXRlTGF5ZXJGbHVzaFRocm90dGxpbmcoaXNMb2Fk UHJvZ3Jlc3NpbmcpOworICAgIG1fZnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+ dXBkYXRlTGF5ZXJGbHVzaFRocm90dGxpbmdJbkFsbEZyYW1lcyhpc0xvYWRQcm9ncmVzc2luZyk7 CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXI6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdElu Zm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwCShyZXZpc2lvbiAxNDc3OTcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIyODksMTEgKzIyODksMTMgQEAgdm9pZCBGcmFtZVZpZXc6 OmVuZERpc2FibGVSZXBhaW50cygpCiAgICAgbV9kaXNhYmxlUmVwYWludHMtLTsKIH0KIAotdm9p ZCBGcmFtZVZpZXc6OnVwZGF0ZUxheWVyRmx1c2hUaHJvdHRsaW5nKGJvb2wgaXNMb2FkUHJvZ3Jl c3NpbmcpCit2b2lkIEZyYW1lVmlldzo6dXBkYXRlTGF5ZXJGbHVzaFRocm90dGxpbmdJbkFsbEZy YW1lcyhib29sIGlzTG9hZFByb2dyZXNzaW5nKQogewogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01Q T1NJVElORykKLSAgICBpZiAoUmVuZGVyVmlldyogdmlldyA9IHJlbmRlclZpZXcoKSkKLSAgICAg ICAgdmlldy0+Y29tcG9zaXRvcigpLT5zZXRMYXllckZsdXNoVGhyb3R0bGluZ0VuYWJsZWQoaXNM b2FkUHJvZ3Jlc3NpbmcpOworICAgIGZvciAoRnJhbWUqIGZyYW1lID0gbV9mcmFtZS5nZXQoKTsg ZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KG1fZnJhbWUuZ2V0KCkp KSB7CisgICAgICAgIGlmIChSZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gZnJhbWUtPnZpZXcoKS0+ cmVuZGVyVmlldygpKQorICAgICAgICAgICAgcmVuZGVyVmlldy0+Y29tcG9zaXRvcigpLT5zZXRM YXllckZsdXNoVGhyb3R0bGluZ0VuYWJsZWQoaXNMb2FkUHJvZ3Jlc3NpbmcpOworICAgIH0KICNl bHNlCiAgICAgVU5VU0VEX1BBUkFNKGlzTG9hZFByb2dyZXNzaW5nKTsKICNlbmRpZgpJbmRleDog U291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5oCShyZXZpc2lvbiAxNDc3OTcpCisrKyBTb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzYsNyArMjM2LDcgQEAgcHVi bGljOgogICAgIHZvaWQgc3RhcnREZWZlcnJlZFJlcGFpbnRUaW1lcihkb3VibGUgZGVsYXkpOwog ICAgIHZvaWQgcmVzZXREZWZlcnJlZFJlcGFpbnREZWxheSgpOwogCi0gICAgdm9pZCB1cGRhdGVM YXllckZsdXNoVGhyb3R0bGluZyhib29sIGlzTG9hZFByb2dyZXNzaW5nKTsKKyAgICB2b2lkIHVw ZGF0ZUxheWVyRmx1c2hUaHJvdHRsaW5nSW5BbGxGcmFtZXMoYm9vbCBpc0xvYWRQcm9ncmVzc2lu Zyk7CiAKICAgICB2b2lkIGJlZ2luRGlzYWJsZVJlcGFpbnRzKCk7CiAgICAgdm9pZCBlbmREaXNh YmxlUmVwYWludHMoKTsK