114266 2013-04-09 04:32:07 -0700 Get rid of truncated thread name warnings for non-Windows platforms 2013-04-11 10:05:09 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos aroben benjamin cdumez cmarcelo commit-queue darin kling menard ojan.autocc rakuco roger_fong webkit.review.bot oldest_to_newest 871613 0 tmpsantos 2013-04-09 04:32:07 -0700 ERROR: Thread name "com.apple.WebKit.ProcessLauncher" is longer than 31 characters and will be truncated by Visual Studio /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*) ERROR: Thread name "com.apple.WebKit.EventDispatcher" is longer than 31 characters and will be truncated by Visual Studio /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*) ERROR: Thread name "com.apple.WebKit.PluginProcessConnectionManager" is longer than 31 characters and will be truncated by Visual Studio /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/Threading.cpp(78) : WTF::ThreadIdentifier WTF::createThread(WTF::ThreadFunction, void*, const char*) 871636 1 197032 tmpsantos 2013-04-09 05:11:24 -0700 Created attachment 197032 Patch 871645 2 197032 aroben 2013-04-09 05:34:06 -0700 Comment on attachment 197032 Patch We had this enabled for all platforms because it seemed likely that long thread names would keep being introduced if the warning only appeared on Windows. But apparently this warning isn't effective. Maybe we should make it a compile-time error instead? 871798 3 tmpsantos 2013-04-09 06:51:05 -0700 (In reply to comment #2) > (From update of attachment 197032 [details]) > We had this enabled for all platforms because it seemed likely that long thread names would keep being introduced if the warning only appeared on Windows. But apparently this warning isn't effective. Maybe we should make it a compile-time error instead? Not a Windows expert, but looks to me that you will have a problem only if the truncated names are the same, which doesn't happen today. Maybe is a better idea just keep my patch and file a bug if the collision ever occurs one day. 873439 4 197032 commit-queue 2013-04-10 20:10:49 -0700 Comment on attachment 197032 Patch Clearing flags on attachment: 197032 Committed r148166: <http://trac.webkit.org/changeset/148166> 873440 5 commit-queue 2013-04-10 20:10:51 -0700 All reviewed patches have been landed. Closing bug. 873961 6 darin 2013-04-11 10:05:09 -0700 This is unfortunate for code that actually is used on Windows as well as other ports. We’d like to notice that the thread names are no good before actually running on Windows. It seems that the problem comes with code that has no intention of running on Windows, getting warnings about a non-problem. I guess we can just not worry about this any more unless the confusing thread names on Windows become a real world problem for someone, and then we can revisit this. 197032 2013-04-09 05:11:24 -0700 2013-04-10 20:10:48 -0700 Patch bug-114266-20130409151112.patch text/plain 1489 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGVhZDRhZjY3NzljMmJjOGY5MTE4MTgw YmFhMjc4YTg0ODkwMDY1ZjcuLmViOTY2MzgwOWQ5YmQ4YTA0NGRlNTM0NDIxM2M5NGUyMjhjOTY1 MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDQtMDkgIFRoaWFnbyBNYXJjb3MgUC4gU2Fu dG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CisKKyAgICAgICAgW1dURl0gR2V0IHJpZCBv ZiB0cnVuY2F0ZWQgdGhyZWFkIG5hbWUgd2FybmluZ3MgZm9yIG5vbi1XaW5kb3dzIHBsYXRmb3Jt cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MjY2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGlkZSB0 aGUgYW5ub3lpbmcgbWVzc2FnZSBmcm9tIHBvcnRzIHRoYXQgYXJlIG5vdCByZWFsbHkgaW50ZXJl c3RlZAorICAgICAgICBhYm91dCBpdC4KKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmcuY3BwOgor ICAgICAgICAoV1RGOjpjcmVhdGVUaHJlYWQpOgorCiAyMDEzLTA0LTA5ICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDTWFrZV0gUmVtb3ZlIGNvbmRp dGlvbmFsIHNvdXJjZSBmaWxlIGxpc3RzIGluIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvVGhyZWFkaW5nLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZy5jcHAKaW5kZXggZmYz MDFiZDMzZGRkZGYxMGM4MzA1MDI2MGZhZjcwMTI0NTRkNTY3NC4uYzNmZjU4MzE1ZjAzZTVjYWQ1 NDMxNTlkNzZlZjc4MWJmNjc3Mjc4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVGhyZWFk aW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmcuY3BwCkBAIC03Myw3ICs3Myw3 IEBAIFRocmVhZElkZW50aWZpZXIgY3JlYXRlVGhyZWFkKFRocmVhZEZ1bmN0aW9uIGVudHJ5UG9p bnQsIHZvaWQqIGRhdGEsIGNvbnN0IGNoYXIqCiB7CiAgICAgLy8gVmlzdWFsIFN0dWRpbyBoYXMg YSAzMS1jaGFyYWN0ZXIgbGltaXQgb24gdGhyZWFkIG5hbWVzLiBMb25nZXIgbmFtZXMgd2lsbAog ICAgIC8vIGJlIHRydW5jYXRlZCBzaWxlbnRseSwgYnV0IHdlJ2QgbGlrZSBjYWxsZXJzIHRvIGtu b3cgYWJvdXQgdGhlIGxpbWl0LgotI2lmICFMT0dfRElTQUJMRUQKKyNpZiAhTE9HX0RJU0FCTEVE ICYmIFBMQVRGT1JNKFdJTikKICAgICBpZiAobmFtZSAmJiBzdHJsZW4obmFtZSkgPiAzMSkKICAg ICAgICAgTE9HX0VSUk9SKCJUaHJlYWQgbmFtZSBcIiVzXCIgaXMgbG9uZ2VyIHRoYW4gMzEgY2hh cmFjdGVycyBhbmQgd2lsbCBiZSB0cnVuY2F0ZWQgYnkgVmlzdWFsIFN0dWRpbyIsIG5hbWUpOwog I2VuZGlmCg==