114259 2013-04-09 03:00:53 -0700 REGRESSION (r147719): Failures in two a11y tests on GTK 2013-04-10 00:35:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 1 zan zan benjamin esprehn+autocc jdiggs ojan.autocc rniwa webkit.review.bot oldest_to_newest 871572 0 zan 2013-04-09 03:00:53 -0700 The following two tests started failing after r147719 landed: platform/gtk/accessibility/aria-slider-required-attributes.html platform/gtk/accessibility/combo-box-collapsed-selection-changed.html http://trac.webkit.org/changeset/147719 Specifically, the `cache->handleFocusedUIElementChanged` call should be restored (with the comment about Chromium removed/changed). http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showAllRuns=true&tests=platform%2Fgtk%2Faccessibility%2Faria-slider-required-attributes.html%2Cplatform%2Fgtk%2Faccessibility%2Fcombo-box-collapsed-selection-changed.html 871580 1 197017 zan 2013-04-09 03:06:37 -0700 Created attachment 197017 Patch 872630 2 197017 zan 2013-04-10 00:35:10 -0700 Comment on attachment 197017 Patch Clearing flags on attachment: 197017 Committed r148081: <http://trac.webkit.org/changeset/148081> 872631 3 zan 2013-04-10 00:35:15 -0700 All reviewed patches have been landed. Closing bug. 197017 2013-04-09 03:06:37 -0700 2013-04-10 00:35:10 -0700 Patch bug-114259-20130409120619.patch text/plain 1681 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0ODAwMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA0LTA5ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTQ3 NzE5KTogRmFpbHVyZXMgaW4gdHdvIGExMXkgdGVzdHMgb24gR1RLCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQyNTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgLSBjb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIFBhcnRpYWxseSByZXZlcnQgcjE0NzcxOSwgcmVz dG9yaW5nIHRoZSBwb3NzaWJsZSBjcmVhdGlvbiBvZiB0aGUgQVhPYmplY3QgY2FjaGUgCisgICAg ICAgIGFuZCB0aGUgc3Vic2VxdWVudCBjYWxsIHRvIGl0cyBoYW5kbGVGb2N1c2VkVUlFbGVtZW50 Q2hhbmdlZCBtZXRob2QuIFJlbW92aW5nIHRoaXMKKyAgICAgICAgY29kZSBjYXVzZWQgcmVncmVz c2lvbnMgaW4gYWNjZXNzaWJpbGl0eSB0ZXN0cyBvbiB0aGUgR1RLIHBvcnQsIHNvIHRoZSBjb21t ZW50IGFib3V0CisgICAgICAgIHRoZSBBWE9iamVjdCBjYWNoZSBpcyBhZGp1c3RlZCBhY2NvcmRp bmdseS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6c2V0Rm9jdXNlZE5vZGUpOgorCiAyMDEzLTA0LTA5ICBKaW53b28gU29uZyAgPGpp bndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV0syXSBSZW1vdmUgYnVpbGQgd2Fy bmluZ3MgZm9yIHVudXNlZCBwYXJhbWV0ZXJzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJ KHJldmlzaW9uIDE0Nzk5OSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM0ODgsNiArMzQ4OCwxMiBAQCBib29sIERvY3VtZW50OjpzZXRGb2N1 c2VkTm9kZShQYXNzUmVmUHRyCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAoIWZvY3VzQ2hh bmdlQmxvY2tlZCAmJiBtX2ZvY3VzZWROb2RlKSB7CisgICAgICAgIC8vIENyZWF0ZSB0aGUgQVhP YmplY3QgY2FjaGUgaW4gYSBmb2N1cyBjaGFuZ2UgYmVjYXVzZSBHVEsgcmVsaWVzIG9uIGl0Lgor ICAgICAgICBpZiAoQVhPYmplY3RDYWNoZSogY2FjaGUgPSBheE9iamVjdENhY2hlKCkpCisgICAg ICAgICAgICBjYWNoZS0+aGFuZGxlRm9jdXNlZFVJRWxlbWVudENoYW5nZWQob2xkRm9jdXNlZE5v ZGUuZ2V0KCksIG5ld0ZvY3VzZWROb2RlLmdldCgpKTsKKyAgICB9CisKICAgICBpZiAoIWZvY3Vz Q2hhbmdlQmxvY2tlZCkKICAgICAgICAgcGFnZSgpLT5jaHJvbWUoKS0+Zm9jdXNlZE5vZGVDaGFu Z2VkKG1fZm9jdXNlZE5vZGUuZ2V0KCkpOwogCg==