114258 2013-04-09 02:43:38 -0700 Initialization skipped error on WinCario after r147643 2013-04-09 03:43:11 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P2 Trivial --- 1 loki loki cdumez commit-queue galpeter mrobinson ossy oldest_to_newest 871566 0 loki 2013-04-09 02:43:38 -0700 There is compiler error on WinCario after http://trac.webkit.org/changeset/147643 The output (http://build.webkit.org/builders/WinCairo%20Release/builds/25100/steps/compile-webkit/logs/stdio) says: platform\win\DragImageCairoWin.cpp(184) : error C2362: initialization of 'surface' is skipped by 'goto exit' which can be fixed by adding an extra block statement ( http://msdn.microsoft.com/en-us/library/s6s80d9f(v=vs.80).aspx ). 871568 1 197014 loki 2013-04-09 02:46:58 -0700 Created attachment 197014 Patch 871583 2 197014 ossy 2013-04-09 03:12:27 -0700 Comment on attachment 197014 Patch LGTM, r=me. 871593 3 197014 commit-queue 2013-04-09 03:43:08 -0700 Comment on attachment 197014 Patch Clearing flags on attachment: 197014 Committed r148003: <http://trac.webkit.org/changeset/148003> 871594 4 commit-queue 2013-04-09 03:43:11 -0700 All reviewed patches have been landed. Closing bug. 197014 2013-04-09 02:46:58 -0700 2013-04-09 03:43:08 -0700 Patch bug-114258-20130409114641.patch text/plain 1999 loki U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhlZGQyNzU4NWIyMjAy MDU4ODY1NmYyZDYwZGQ0Nzk3Y2M4NGExZS4uZGU1MzFiN2JlMTQ2YzJlMDJhZjBlYmU0MjU1YzIy MzhjZjkwZDg5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTA5ICBHYWJv ciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIEluaXRpYWxpemF0aW9uIHNraXBw ZWQgZXJyb3Igb24gV2luQ2FyaW8gYWZ0ZXIgcjE0NzY0MworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MjU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGQgZml4LiBBZGRpbmcgZXh0cmEgYmxvY2sg c3RhdGVtZW50IHRvIGF2b2lkIGVycm9yIEMyMzYyIG9uIFdpbkNhcmlvCisKKyAgICAgICAgKiBw bGF0Zm9ybS93aW4vRHJhZ0ltYWdlQ2Fpcm9XaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3Jl YXRlRHJhZ0ltYWdlRnJvbUltYWdlKToKKwogMjAxMy0wNC0wOCAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgV2ViQ29yZS5neXAvZ3lwaQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0RyYWdJbWFnZUNhaXJvV2luLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9EcmFnSW1hZ2VDYWlyb1dpbi5jcHAKaW5kZXgg NTQyNTM2NGUzMzY3MTMwNTdmYTNlZGM5NWU1MmRkMGE3ZjkzM2E1Mi4uNjgxY2NmZTdjYzEyNjEz M2FmZWQyZjNjYWY4MjczMTVkZWI0NjYyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL0RyYWdJbWFnZUNhaXJvV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS93aW4vRHJhZ0ltYWdlQ2Fpcm9XaW4uY3BwCkBAIC0xNjgsMTUgKzE2OCwxNyBAQCBEcmFn SW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKEltYWdlKiBpbWcsIFJlc3BlY3RJbWFn ZU9yaWVudGF0aW9uRW51bSkKICAgICAgICAgaGJtcCA9IDA7CiAgICAgfQogCi0gICAgY2Fpcm9f dCogY3IgPSBkcmF3Q29udGV4dC0+Y3IoKTsKLSAgICBjYWlyb19zZXRfc291cmNlX3JnYihjciwg MS4wLCAwLjAsIDEuMCk7Ci0gICAgY2Fpcm9fZmlsbF9wcmVzZXJ2ZShjcik7Ci0KLSAgICBSZWZQ dHI8Y2Fpcm9fc3VyZmFjZV90PiBzdXJmYWNlID0gaW1nLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRG cmFtZSgpOwotICAgIGlmIChzdXJmYWNlKSB7Ci0gICAgICAgIC8vIERyYXcgdGhlIGltYWdlLgot ICAgICAgICBjYWlyb19zZXRfc291cmNlX3N1cmZhY2UoY3IsIHN1cmZhY2UuZ2V0KCksIDAuMCwg MC4wKTsKLSAgICAgICAgY2Fpcm9fcGFpbnQoY3IpOworICAgIHsgLy8gVGhpcyBibG9jayBpcyBy ZXF1aXJlZCBkdWUgdG8gdGhlIG1zdmMgY29tcGlsZXIgZXJyb3IgQzIzNjIuCisgICAgICAgIGNh aXJvX3QqIGNyID0gZHJhd0NvbnRleHQtPmNyKCk7CisgICAgICAgIGNhaXJvX3NldF9zb3VyY2Vf cmdiKGNyLCAxLjAsIDAuMCwgMS4wKTsKKyAgICAgICAgY2Fpcm9fZmlsbF9wcmVzZXJ2ZShjcik7 CisKKyAgICAgICAgUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gc3VyZmFjZSA9IGltZy0+bmF0aXZl SW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKKyAgICAgICAgaWYgKHN1cmZhY2UpIHsKKyAgICAgICAg ICAgIC8vIERyYXcgdGhlIGltYWdlLgorICAgICAgICAgICAgY2Fpcm9fc2V0X3NvdXJjZV9zdXJm YWNlKGNyLCBzdXJmYWNlLmdldCgpLCAwLjAsIDAuMCk7CisgICAgICAgICAgICBjYWlyb19wYWlu dChjcik7CisgICAgICAgIH0KICAgICB9CiAKICAgICBkZWFsbG9jQ29udGV4dChkcmF3Q29udGV4 dCk7Cg==