114242 2013-04-08 22:47:29 -0700 REGRESSION (r147454): Youtube annotation links to new window broken 2013-09-10 09:01:46 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac (Intel) OS X 10.8 RESOLVED FIXED http://www.youtube.com/watch?feature=player_detailpage&v=fdJc1_IBKJA#t=205s InRadar, Regression P1 Normal --- 1 kevin andersca allan.jensen andersca cevans commit-queue jimoase jochen jturcotte oldest_to_newest 871462 0 kevin 2013-04-08 22:47:29 -0700 Youtube videos with annotation links that open a new window for the video page are no longer working, while links that load a video into the existing page continue to work fine. Load the link above which is cued up to just before the end of a video where some annotation links appear on the screen. Click the one on the left for Behind the Scenes and it pauses the video but doesn't open the new window as it should, while the link on the right for Water Jet Packs loads into the existing page fine. I'm finding this problem on many other videos where the link opens a new window rather than the loading into the existing page anywhere the link annotation may appear throughout the video. 871465 1 kevin 2013-04-08 22:51:26 -0700 This bug also seems to affect clicking the "Watch on Youtube" button that appears as a Youtube logo on the lower toolbar on embedded pages like: https://online.hillsdale.edu/page.aspx?pid=1893 The new window at youtube.com doesn't open. This was reported in Bug 114097 871932 2 ap 2013-04-09 09:56:56 -0700 Regressed in <http://trac.webkit.org/changeset/147454>. 871934 3 ap 2013-04-09 10:00:51 -0700 *** Bug 114097 has been marked as a duplicate of this bug. *** 871935 4 ap 2013-04-09 10:01:12 -0700 <rdar://problem/13609940> 872003 5 jochen 2013-04-09 12:05:24 -0700 that's bad, sorry will investigate & fix 872076 6 197173 andersca 2013-04-09 14:15:25 -0700 Created attachment 197173 Patch 872093 7 andersca 2013-04-09 14:34:27 -0700 Committed r148054: <http://trac.webkit.org/changeset/148054> 927282 8 allan.jensen 2013-09-10 06:36:13 -0700 The same needs to be done for WebKit1. 927283 9 211195 allan.jensen 2013-09-10 06:38:45 -0700 Created attachment 211195 Patch 927312 10 211195 andersca 2013-09-10 08:26:03 -0700 Comment on attachment 211195 Patch Looks good. Next time please open a new bug instead of re-using one that's already been closed. 927322 11 211195 commit-queue 2013-09-10 09:01:42 -0700 Comment on attachment 211195 Patch Clearing flags on attachment: 211195 Committed r155447: <http://trac.webkit.org/changeset/155447> 927323 12 commit-queue 2013-09-10 09:01:46 -0700 All reviewed patches have been landed. Closing bug. 197173 2013-04-09 14:15:25 -0700 2013-09-10 06:38:41 -0700 Patch bug-114242-20130409141507.patch text/plain 1691 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4MDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGIwNmY1NjA1ZTllN2Yy MDI0YmFkZjExZDM5Mzg5MTQxYjIzMTMwNy4uNmY2Nzk4NTM0YzJkODcxZDBmNWQ2N2EwZjQyYmYz NzA4MzNmYWM0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA0LTA5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTiAo cjE0NzQ1NCk6IFlvdXR1YmUgYW5ub3RhdGlvbiBsaW5rcyB0byBuZXcgd2luZG93IGJyb2tlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MjQyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzYwOTk0MD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgdGhlIGN1cnJlbnQgdXNlciBnZXN0dXJlIHRv ICJEZWZpbml0ZWx5UHJvY2Vzc2luZ05ld1VzZXJHZXN0dXJlIiBpZiBwb3B1cHMgYXJlIGFsbG93 ZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OnBlcmZvcm1GcmFtZUxvYWRVUkxSZXF1ZXN0KToKKwor MjAxMy0wNC0wOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAg ICAgIElmIHdlIGZhaWwgdG8gZGVjb2RlIGEgbWVzc2FnZSBuYW1lLCBwYXNzIHRoZSBtZXNzYWdl IGxlbmd0aCBhcyB0aGUgbmFtZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE0MzA1CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzYwNTcwMz4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAppbmRl eCAxOWI5ZDc1NDMwYjc5NTA0NTdkNDZmYTA1NjQ1MTQ2YTFkNmRjMGZlLi5mNmVlM2JmMjRlMGIx YWRlNGRmZGFjNzI3ODJmOTFjM2NlM2I1YzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCkBAIC0xMDc5LDYgKzEwNzksOCBAQCB2b2lk IFBsdWdpblZpZXc6OnBlcmZvcm1GcmFtZUxvYWRVUkxSZXF1ZXN0KFVSTFJlcXVlc3QqIHJlcXVl c3QpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBVc2VyR2VzdHVyZUluZGljYXRvciBn ZXN0dXJlSW5kaWNhdG9yKHJlcXVlc3QtPmFsbG93UG9wdXBzKCkgPyBEZWZpbml0ZWx5UHJvY2Vz c2luZ05ld1VzZXJHZXN0dXJlIDogUG9zc2libHlQcm9jZXNzaW5nVXNlckdlc3R1cmUpOworCiAg ICAgLy8gRmlyc3QsIHRyeSB0byBmaW5kIGEgdGFyZ2V0IGZyYW1lLgogICAgIEZyYW1lKiB0YXJn ZXRGcmFtZSA9IGZyYW1lLT5sb2FkZXIoKS0+ZmluZEZyYW1lRm9yTmF2aWdhdGlvbihyZXF1ZXN0 LT50YXJnZXQoKSk7CiAgICAgaWYgKCF0YXJnZXRGcmFtZSkgewo= 211195 2013-09-10 06:38:45 -0700 2013-09-10 09:01:42 -0700 Patch bug-114242-20130910153844.patch text/plain 1812 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU0N2I4OWNjM2JlOWE1 YTA1NTJhNDgyNDYxYzM0NjQ0NzcxYjg0Ni4uYmI4YzE3YTFiM2ZlYjMzZjdhNmIxYTBjNzgzZWRi NDU5ZGY2ZmU3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTEwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04gKHIxNDc0NTQpOiBZb3V0dWJlIGFubm90YXRpb24gbGlua3MgdG8gbmV3IHdpbmRv dyBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNDI0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNldCB0aGUgVXNlckdlc3R1cmVJbmRpY2F0b3IgdG8gYWxsb3cgcG9wdXBzIHRoZSBzYW1lIHdh eSB0aGUgaXNzdWUgd2FzIHNvbHZlZCBmb3IgV2ViS2l0Mi4KKworICAgICAgICAqIHBsdWdpbnMv UGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpwZXJmb3JtUmVx dWVzdCk6CisKIDIwMTMtMDktMTAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgog CiAgICAgICAgIHRvRm9vRWxlbWVudCgpIHNob3VsZCB1c2Ugc3RhdGljX2Nhc3QsIG5vdCByZWlu dGVycHJldF9jYXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5W aWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKaW5kZXggNmE1 ZGUyZTgyNGRmOTBlMTA1ZGI5NGE0NmFkYTEzMzA0OTAyNWRlMC4uZDhkYjlmNzU0YjU5MzRjMDg3 NjU0NGQyZjMxNWJlYjRkOTIxYzljYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcu Y3BwCkBAIC02NCw2ICs2NCw3IEBACiAjaW5jbHVkZSAiU2NyaXB0VmFsdWUuaCIKICNpbmNsdWRl ICJTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCisjaW5jbHVkZSAiVXNl ckdlc3R1cmVJbmRpY2F0b3IuaCIKICNpbmNsdWRlICJXaGVlbEV2ZW50LmgiCiAjaW5jbHVkZSAi Y19pbnN0YW5jZS5oIgogI2luY2x1ZGUgIm5wcnVudGltZV9pbXBsLmgiCkBAIC00MjgsNiArNDI5 LDggQEAgdm9pZCBQbHVnaW5WaWV3OjpwZXJmb3JtUmVxdWVzdChQbHVnaW5SZXF1ZXN0KiByZXF1 ZXN0KQogICAgIEtVUkwgcmVxdWVzdFVSTCA9IHJlcXVlc3QtPmZyYW1lTG9hZFJlcXVlc3QoKS5y ZXNvdXJjZVJlcXVlc3QoKS51cmwoKTsKICAgICBTdHJpbmcganNTdHJpbmcgPSBzY3JpcHRTdHJp bmdJZkphdmFTY3JpcHRVUkwocmVxdWVzdFVSTCk7CiAKKyAgICBVc2VyR2VzdHVyZUluZGljYXRv ciBnZXN0dXJlSW5kaWNhdG9yKHJlcXVlc3QtPnNob3VsZEFsbG93UG9wdXBzKCkgPyBEZWZpbml0 ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlIDogUG9zc2libHlQcm9jZXNzaW5nVXNlckdlc3R1cmUp OworCiAgICAgaWYgKGpzU3RyaW5nLmlzTnVsbCgpKSB7CiAgICAgICAgIC8vIGlmIHRoaXMgaXMg bm90IGEgdGFyZ2V0ZWQgcmVxdWVzdCwgY3JlYXRlIGEgc3RyZWFtIGZvciBpdC4gb3RoZXJ3aXNl LAogICAgICAgICAvLyBqdXN0IHBhc3MgaXQgb2ZmIHRvIHRoZSBsb2FkZXIK