114221 2013-04-08 16:34:03 -0700 Remove chromium EWS support, and fix broken test. 2013-04-08 17:21:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 glenn glenn abarth benjamin commit-queue dpranke eric rniwa webkit.review.bot oldest_to_newest 871264 0 glenn 2013-04-08 16:34:03 -0700 Remove AbstractChromiumEWS class and subclasses (and related unit tests). Also fix broken unit test: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses which had a misspelled class name and a non-conforming test entry point name. 871266 1 196969 glenn 2013-04-08 16:41:23 -0700 Created attachment 196969 Patch 871291 2 196969 rniwa 2013-04-08 17:19:08 -0700 Comment on attachment 196969 Patch Oh oops, sorry wrong patch. 871295 3 196969 commit-queue 2013-04-08 17:21:04 -0700 Comment on attachment 196969 Patch Clearing flags on attachment: 196969 Committed r147966: <http://trac.webkit.org/changeset/147966> 871296 4 commit-queue 2013-04-08 17:21:06 -0700 All reviewed patches have been landed. Closing bug. 196969 2013-04-08 16:41:23 -0700 2013-04-08 17:21:04 -0700 Patch bug-114221-20130408174112.patch text/plain 3812 glenn U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3OTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjIzZWYwYWI3MWE2M2Q3ZjQ0MjhhZGFmYmY4YTEwOTVl YmQ5ZWQwNi4uYjYzYjA1NTY0YmQ4OTU4NDM0NTZkNzZjNmE3ZjZlMGVjMDg4ODZkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEzLTA0LTA4ICBHbGVubiBBZGFtcyAgPGdsZW5uQHNreW5hdi5jb20+CisKKyAgICAg ICAgUmVtb3ZlIGNocm9taXVtIEVXUyBzdXBwb3J0LCBhbmQgZml4IGJyb2tlbiB0ZXN0LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MjIxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5OgorICAgICAgICAoQWJz dHJhY3RDaHJvbWl1bUVXUyk6IFJlbW92ZWQuCisgICAgICAgIChDaHJvbWl1bUxpbnV4RVdTKTog UmVtb3ZlZC4KKyAgICAgICAgKENocm9taXVtTGludXhEZWJ1Z0VXUyk6IFJlbW92ZWQuCisgICAg ICAgIChDaHJvbWl1bVdpbmRvd3NFV1MpOiBSZW1vdmVkLgorICAgICAgICAoQ2hyb21pdW1BbmRy b2lkRVdTKTogUmVtb3ZlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFu ZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5OgorICAgICAgICAoRWFybHlXYXJuaW5n U3lzdGVtVGVzdCk6IEZpeCBtaXNzcGVsbGVkIGNsYXNzIG5hbWUuCisgICAgICAgICh0ZXN0X2V3 c2VzKTogRml4IGVudHJ5IHBvaW50IG5hbWUgdG8gZW5zdXJlIHRlc3QgaXMgcnVuLgorCiAyMDEz LTA0LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBw b3J0IDY2NjUgaW5zdGVhZCBvZiA2NjY3IHNpbmNlIHRoZSBsYXR0ZXIgZG9lc24ndCBzZWVtIHRv IHdvcmsgd2VsbC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv Y29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CmluZGV4IDA0NDA4ZjM0MDc2YzQ1OTAxNDIw N2FmN2UyNWIzZWNiN2JiZjk2NTUuLjg2ZTg1MWZlODY4ODBhMWYxZWU5YWEyOTkwNGRhMTA0NWEy NWI3YzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9l YXJseXdhcm5pbmdzeXN0ZW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQpAQCAtMTc2LDM4ICsxNzYsNiBAQCBjbGFzcyBX aW5FV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0pOgogICAgIHBvcnRfbmFtZSA9ICJ3aW4i CiAgICAgX2RlZmF1bHRfcnVuX3Rlc3RzID0gVHJ1ZQogCi1jbGFzcyBBYnN0cmFjdENocm9taXVt RVdTKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToKLSAgICBwb3J0X25hbWUgPSAiY2hyb21p dW0iCi0gICAgd2F0Y2hlcnMgPSBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS53YXRjaGVycyAr IFsKLSAgICAgICAgImRnbGF6a292QGNocm9taXVtLm9yZyIsCi0gICAgXQotCi0KLWNsYXNzIENo cm9taXVtTGludXhFV1MoQWJzdHJhY3RDaHJvbWl1bUVXUyk6Ci0gICAgIyBGSVhNRTogV2Ugc2hv dWxkIHJlbmFtZSB0aGlzIGNvbW1hbmQgdG8gY3ItbGludXgtZXdzLCBidXQgdGhhdCByZXF1aXJl cwotICAgICMgICAgICAgIGEgZGF0YWJhc2UgbWlncmF0aW9uLiA6KAotICAgIG5hbWUgPSAiY2hy b21pdW0tZXdzIgotICAgIHBvcnRfbmFtZSA9ICJjaHJvbWl1bS14dmZiIgotCi0KLWNsYXNzIENo cm9taXVtTGludXhEZWJ1Z0VXUyhBYnN0cmFjdENocm9taXVtRVdTKToKLSAgICBuYW1lID0gImNy LWxpbnV4LWRlYnVnLWV3cyIKLSAgICBwb3J0X25hbWUgPSAiY2hyb21pdW0teHZmYiIKLSAgICBf YnVpbGRfc3R5bGUgPSAiZGVidWciCi0KLQotY2xhc3MgQ2hyb21pdW1XaW5kb3dzRVdTKEFic3Ry YWN0Q2hyb21pdW1FV1MpOgotICAgIG5hbWUgPSAiY3Itd2luLWV3cyIKLQotCi1jbGFzcyBDaHJv bWl1bUFuZHJvaWRFV1MoQWJzdHJhY3RDaHJvbWl1bUVXUyk6Ci0gICAgbmFtZSA9ICJjci1hbmRy b2lkLWV3cyIKLSAgICBwb3J0X25hbWUgPSAiY2hyb21pdW0tYW5kcm9pZCIKLSAgICB3YXRjaGVy cyA9IEFic3RyYWN0Q2hyb21pdW1FV1Mud2F0Y2hlcnMgKyBbCi0gICAgICAgICJwZXRlcitld3NA Y2hyb21pdW0ub3JnIiwKLSAgICBdCi0KLQogY2xhc3MgTWFjRVdTKEFic3RyYWN0RWFybHlXYXJu aW5nU3lzdGVtKToKICAgICBuYW1lID0gIm1hYy1ld3MiCiAgICAgcG9ydF9uYW1lID0gIm1hYyIK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdh cm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CmluZGV4IDVmMGI4MDZjYTM4ZTIy ZGMxZjRhZWY4ODRmZDY3YjQzYjNlMzM2ZWQuLmQ4YzYwMmE4NzViNDU2MjFlNmYwZjM1NDMzYzc2 MDJlYzUwMGYxYzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQpAQCAt NTAsNyArNTAsNyBAQCBjbGFzcyBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbVRlc3QoUXVldWVz VGVzdCk6CiAgICAgICAgIHNlbGYuYXNzZXJ0TXVsdGlMaW5lRXF1YWwoZXdzLl9mYWlsaW5nX3Rl c3RzX21lc3NhZ2UodGFzaywgcGF0Y2gpLCAiTmV3IGZhaWxpbmcgdGVzdHM6XG5iYXIuaHRtbFxu Zm9vLmh0bWwiKQogCiAKLWNsYXNzIEVhcmx5V2FybmluZ1N5dGVtVGVzdChRdWV1ZXNUZXN0KToK K2NsYXNzIEVhcmx5V2FybmluZ1N5c3RlbVRlc3QoUXVldWVzVGVzdCk6CiAgICAgZGVmIF9kZWZh dWx0X2V4cGVjdGVkX2xvZ3Moc2VsZiwgZXdzKToKICAgICAgICAgc3RyaW5nX3JlcGxhY2VtZW50 cyA9IHsKICAgICAgICAgICAgICJuYW1lIjogZXdzLm5hbWUsCkBAIC04MywxMiArODMsOSBAQCBN T0NLOiByZWxlYXNlX3dvcmtfaXRlbTogJShuYW1lKXMgMTAwMDAKICAgICAgICAgb3B0aW9ucy5y dW5fdGVzdHMgPSBld3MuX2RlZmF1bHRfcnVuX3Rlc3RzCiAgICAgICAgIHNlbGYuYXNzZXJ0X3F1 ZXVlX291dHB1dHMoZXdzLCBleHBlY3RlZF9sb2dzPXNlbGYuX2RlZmF1bHRfZXhwZWN0ZWRfbG9n cyhld3MpLCBvcHRpb25zPW9wdGlvbnMpCiAKLSAgICBkZWYgX3Rlc3RfZXdzZXMoc2VsZik6Cisg ICAgZGVmIHRlc3RfZXdzZXMoc2VsZik6CiAgICAgICAgIHNlbGYuX3Rlc3RfZXdzKE1hY0VXUygp KQogICAgICAgICBzZWxmLl90ZXN0X2V3cyhNYWNXSzJFV1MoKSkKLSAgICAgICAgc2VsZi5fdGVz dF9ld3MoQ2hyb21pdW1MaW51eEVXUygpKQotICAgICAgICBzZWxmLl90ZXN0X2V3cyhDaHJvbWl1 bVdpbmRvd3NFV1MoKSkKLSAgICAgICAgc2VsZi5fdGVzdF9ld3MoQ2hyb21pdW1BbmRyb2lkRVdT KCkpCiAgICAgICAgIHNlbGYuX3Rlc3RfZXdzKFF0RVdTKCkpCiAgICAgICAgIHNlbGYuX3Rlc3Rf ZXdzKFF0V0syRVdTKCkpCiAgICAgICAgIHNlbGYuX3Rlc3RfZXdzKEd0a0VXUygpKQo=