11419 2006-10-26 01:24:23 -0700 REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView] ([view isKindOfClass:[WebHTMLView class]]) when running the layout tests 2006-10-26 17:26:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned ap mrowe sam oldest_to_newest 49654 0 mitz 2006-10-26 01:24:23 -0700 run-webkit-tests editing/selection/fake-drag.html editing/selection/paragraph-granularity.htmlresults is the above assertion failure. Backtrace: 0 com.apple.WebKit 0x0105ab14 -[WebHTMLView(WebPrivate) _topHTMLView] + 320 (WebHTMLView.m:946) 1 com.apple.WebKit 0x0105ab70 -[WebHTMLView(WebPrivate) _isTopHTMLView] + 60 (WebHTMLView.m:952) 2 com.apple.WebKit 0x01074324 -[WebHTMLView(WebDocumentInternalProtocols) draggingCancelledWithDraggingInfo:] + 64 (WebHTMLView.m:5952) 3 com.apple.WebKit 0x0109cf74 -[WebView _delegateDragOperationForDraggingInfo:] + 216 (WebView.mm:2338) 4 com.apple.WebKit 0x0109d2f8 -[WebView draggingUpdated:] + 68 (WebView.mm:2379) 5 DumpRenderTree 0x00005d60 -[EventSendingController mouseMoveToX:Y:] + 1160 (EventSendingController.m:221) The problem is that EventSendingController calls WebView's draggingUpdated, passing nil. Down in _delegateDragOperationForDraggingInfo:, windowPoint is assigned garbage and newDraggingView gets assigned randomly (with either 0 or the WebView). As fras as I can tell, the regression is just the result of "different garbage" (I observed that windowPoint is different). I think DumpRenderTree is at fault, as EventSendingController shouldn't call draggingUpdated if draggingInfo is 0 (nor draggedImage:movedTo:). Maybe WebView's behavior in this case can improve, by asserting and returning immediately from draggingUpdated if passed nil. 49636 1 mitz 2006-10-26 01:26:26 -0700 The first sentence should say:run-webkit-tests editing/selection/fake-drag.html editing/selection/paragraph-granularity.html results is the above assertion failure. 49513 2 11230 sam 2006-10-26 15:07:04 -0700 Created attachment 11230 patch Fix based on mitz's comments. 49514 3 11230 ggaren 2006-10-26 15:32:17 -0700 Comment on attachment 11230 patch r=me 49519 4 mitz 2006-10-26 17:26:07 -0700 Landed by ggaren in r17347. 11230 2006-10-26 15:07:04 -0700 2006-10-26 15:32:17 -0700 patch dragfix.diff text/plain 1619 sam SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3MzQ1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMTAtMjYgIFNhbSBXZWluaWcgIDxzYW0u d2VpbmlnQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExNDE5CisgICAgICAgIFJFR1JFU1NJT04gKHIxNzI5OSk6IEFzc2VydGlvbiBmYWlsdXJlIGlu IC1bV2ViSFRNTFZpZXcoV2ViUHJpdmF0ZSkgX3RvcEhUTUxWaWV3XQorICAgICAgICAoW3ZpZXcg aXNLaW5kT2ZDbGFzczpbV2ViSFRNTFZpZXcgY2xhc3NdXSkgd2hlbiBydW5uaW5nIHRoZSBsYXlv dXQgdGVzdHMKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0V2ZW50U2VuZGluZ0NvbnRyb2xs ZXIubToKKyAgICAgICAgKC1bRXZlbnRTZW5kaW5nQ29udHJvbGxlciBtb3VzZU1vdmVUb1g6WTpd KToKKwogMjAwNi0xMC0yNiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8emltbWVybWFubkBrZGUub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubQkocmV2aXNpb24gMTcz NDUpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9FdmVudFNlbmRpbmdDb250cm9sbGVy Lm0JKHdvcmtpbmcgY29weSkKQEAgLTIxNywxMCArMjE3LDExIEBAIE5TQXJyYXkgKndlYmtpdERv bUV2ZW50TmFtZXM7CiAgICAgaWYgKHN1YlZpZXcpIHsKICAgICAgICAgaWYgKGRvd24pIHsKICAg ICAgICAgICAgIFtzdWJWaWV3IG1vdXNlRHJhZ2dlZDpldmVudF07Ci0gICAgICAgICAgICBbW2Ry YWdnaW5nSW5mbyBkcmFnZ2luZ1NvdXJjZV0gZHJhZ2dlZEltYWdlOltkcmFnZ2luZ0luZm8gZHJh Z2dlZEltYWdlXSBtb3ZlZFRvOmxhc3RNb3VzZVBvc2l0aW9uXTsKLSAgICAgICAgICAgIFtbZnJh bWUgd2ViVmlld10gZHJhZ2dpbmdVcGRhdGVkOmRyYWdnaW5nSW5mb107Ci0gICAgICAgIH0KLSAg ICAgICAgZWxzZQorICAgICAgICAgICAgaWYgKGRyYWdnaW5nSW5mbykgeworICAgICAgICAgICAg ICAgIFtbZHJhZ2dpbmdJbmZvIGRyYWdnaW5nU291cmNlXSBkcmFnZ2VkSW1hZ2U6W2RyYWdnaW5n SW5mbyBkcmFnZ2VkSW1hZ2VdIG1vdmVkVG86bGFzdE1vdXNlUG9zaXRpb25dOworICAgICAgICAg ICAgICAgIFtbZnJhbWUgd2ViVmlld10gZHJhZ2dpbmdVcGRhdGVkOmRyYWdnaW5nSW5mb107Cisg ICAgICAgICAgICB9CisgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgW3N1YlZpZXcgbW91c2VN b3ZlZDpldmVudF07CiAgICAgfQogfQo=