114134 2013-04-07 18:15:57 -0700 [BlackBerry] Provide more specific error description for SocketStreamError 2013-04-08 08:28:37 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned commit-queue joenotcharles rwlbuis tonikitoo oldest_to_newest 870586 0 seokju 2013-04-07 18:15:57 -0700 Pass the reason of a failure to SocketStreamError instance and notify it via SocketStreamHandleClient::didFailSocketStream(). 870587 1 196818 seokju 2013-04-07 18:17:14 -0700 Created attachment 196818 Patch 870773 2 196818 rwlbuis 2013-04-08 07:30:02 -0700 Comment on attachment 196818 Patch Thanks for your contribution! I think the change is good, but can you check if you missed any instance of didFailSocketStream being called in this file? Thanks! 870778 3 joenotcharles 2013-04-08 07:41:54 -0700 (In reply to comment #2) > (From update of attachment 196818 [details]) > Thanks for your contribution! I think the change is good, but can you check if you missed any instance of didFailSocketStream being called in this file? Thanks! The only other call to didFailSocketStream is in notifyClose, which has no message param, so I think it's fine for the SocketError to use the default message-less constructor for that call. 870780 4 196818 rwlbuis 2013-04-08 07:53:14 -0700 Comment on attachment 196818 Patch Ok, after Joe's explanation, this change is fine! 870789 5 196818 commit-queue 2013-04-08 08:28:35 -0700 Comment on attachment 196818 Patch Clearing flags on attachment: 196818 Committed r147915: <http://trac.webkit.org/changeset/147915> 870790 6 commit-queue 2013-04-08 08:28:37 -0700 All reviewed patches have been landed. Closing bug. 196818 2013-04-07 18:17:14 -0700 2013-04-08 08:28:35 -0700 Patch bug-114134-20130408101658.patch text/plain 2826 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzVhNWY5ZDkwMDMzMGYx OGU1YTBlYmU4ODU1YzgxZmU4NDhjMTQ2Zi4uMTVjMjUzZGI5YTMzOGJhZDU2ZDBmMmQ1ZjUyMmUx NGFhNDNkYzJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTA3ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0g UHJvdmlkZSBtb3JlIHNwZWNpZmljIGVycm9yIGRlc2NyaXB0aW9uIGZvciBTb2NrZXRTdHJlYW1F cnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0 MTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFz cyB0aGUgcmVhc29uIG9mIGEgZmFpbHVyZSB0byBTb2NrZXRTdHJlYW1FcnJvciBpbnN0YW5jZQor ICAgICAgICBhbmQgbm90aWZ5IGl0IHZpYSBTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQ6OmRpZEZh aWxTb2NrZXRTdHJlYW0oKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9Tb2NrZXRTdHJlYW1FcnJvci5oOgorICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtRXJy b3I6OlNvY2tldFN0cmVhbUVycm9yKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvU29ja2V0U3RyZWFtSGFuZGxlQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTb2NrZXRTdHJlYW1IYW5kbGU6Om5vdGlmeVN0YXR1c1JlY2VpdmVkKToKKwogMjAxMy0wNC0w NyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQg ZGVmYXVsdCBpbXBsZW1lbnRhdGlvbiBmb3IgS1VSTDo6ZmlsZVN5c3RlbVBhdGgoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1NvY2tldFN0 cmVhbUVycm9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkv U29ja2V0U3RyZWFtRXJyb3IuaAppbmRleCA4MGRmYTM5YmRmZjA5NzliYmY2OWM2Nzc4ZjVjNGJh ODhiMDg4YjI4Li41M2M5ODdjMjcwNWE3MWYwOWI5ZWZjMjFjNTQ4N2Y4NWEwNzkyOTQ3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0 U3RyZWFtRXJyb3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvU29ja2V0U3RyZWFtRXJyb3IuaApAQCAtMSw1ICsxLDYgQEAKIC8qCiAgKiBDb3B5cmln aHQgKEMpIDIwMDkgR29vZ2xlIEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmln aHQgKEMpIDIwMTMgU2Vva2p1IEt3b24gKHNlb2tqdS5rd29uQGdtYWlsLmNvbSkKICAqCiAgKiBS ZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9y IHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTQyLDYgKzQzLDEwIEBAIHB1YmxpYzoKICAg ICAgICAgOiBTb2NrZXRTdHJlYW1FcnJvckJhc2UoZXJyb3JDb2RlKQogICAgIHsKICAgICB9Cisg ICAgU29ja2V0U3RyZWFtRXJyb3IoaW50IGVycm9yQ29kZSwgY29uc3QgQmxhY2tCZXJyeTo6UGxh dGZvcm06OlN0cmluZyYgZGVzY3JpcHRpb24pCisgICAgICAgIDogU29ja2V0U3RyZWFtRXJyb3JC YXNlKGVycm9yQ29kZSwgU3RyaW5nKCksIGRlc2NyaXB0aW9uKQorICAgIHsKKyAgICB9CiAKIH07 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9Tb2NrZXRTdHJlYW1IYW5kbGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvYmxhY2tiZXJyeS9Tb2NrZXRTdHJlYW1IYW5kbGVCbGFja0JlcnJ5LmNwcApp bmRleCBiN2RjZTNmYmRlOGFiYTg1ODhmYmI0NzBiMWUxYmZkN2YzZDQyYjNkLi4yY2U4OWI2Y2Ey NmQ1OGIzZDAwMDU1MjJkNGNjMzZlNGIyZTM0ZWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvU29ja2V0U3RyZWFtSGFuZGxlQmxhY2tCZXJy eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Nv Y2tldFN0cmVhbUhhbmRsZUJsYWNrQmVycnkuY3BwCkBAIC0xMDUsNyArMTA1LDcgQEAgdm9pZCBT b2NrZXRTdHJlYW1IYW5kbGU6Om5vdGlmeVN0YXR1c1JlY2VpdmVkKGludCBzdGF0dXMsIGNvbnN0 IEJsYWNrQmVycnk6OlBsYXQKICAgICBSZWZQdHI8U29ja2V0U3RyZWFtSGFuZGxlPiBwcm90ZWN0 KHRoaXMpOwogICAgIG1fc3RhdHVzID0gc3RhdHVzOwogICAgIGlmIChGaWx0ZXJTdHJlYW06OlN0 YXR1c1N1Y2Nlc3MgIT0gc3RhdHVzKQotICAgICAgICBtX2NsaWVudC0+ZGlkRmFpbFNvY2tldFN0 cmVhbSh0aGlzLCBTb2NrZXRTdHJlYW1FcnJvcihzdGF0dXMpKTsKKyAgICAgICAgbV9jbGllbnQt PmRpZEZhaWxTb2NrZXRTdHJlYW0odGhpcywgU29ja2V0U3RyZWFtRXJyb3Ioc3RhdHVzLCBtZXNz YWdlKSk7CiAgICAgZWxzZSB7CiAgICAgICAgIG1fc3RhdGUgPSBPcGVuOwogICAgICAgICBtX2Ns aWVudC0+ZGlkT3BlblNvY2tldFN0cmVhbSh0aGlzKTsK