114132 2013-04-07 14:53:34 -0700 [WIN] Fix problems with export macros of AutodrainedPool 2013-04-07 15:59:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga oldest_to_newest 870558 0 paroga 2013-04-07 14:53:34 -0700 [WIN] Fix problems with export macros of AutodrainedPool 870559 1 196814 paroga 2013-04-07 14:57:03 -0700 Created attachment 196814 Patch 870566 2 196814 ggaren 2013-04-07 15:46:30 -0700 Comment on attachment 196814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196814&action=review Please fix the style comment below before landing. > Source/WTF/wtf/AutodrainedPool.h:49 > + inline explicit AutodrainedPool(int = 1) { } > + inline ~AutodrainedPool() { } > + inline void cycle() { } No need for the inline keyword when defining a function inside its class declaration -- inline is implied. 870567 3 paroga 2013-04-07 15:59:15 -0700 Committed r147884: <http://trac.webkit.org/changeset/147884> 196814 2013-04-07 14:57:03 -0700 2013-04-07 15:46:30 -0700 Patch bug-114132-20130407235647.patch text/plain 1848 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgyMDU5NjNiNThiNzYzYTUzMzM3NTcz ZGFkZjM1YzhiMTU2YWU1ZDkuLjdiNWZjODdhMmEyZTk3MzEyMDViOWJiMThjODZiYjIxNmI0MDBk MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDQtMDcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dJTl0gRml4IHByb2JsZW1zIHdpdGggZXhw b3J0IG1hY3JvcyBvZiBBdXRvZHJhaW5lZFBvb2wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDEzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEV4cG9ydGluZyBhIGlubGluZSBmdW5jdGlvbiByZXN1bHRz IGluIGFuIGVycm9yIHdpdGggdGhlIE1TIGNvbXBpbGVyLgorCisgICAgICAgICogd3RmL0F1dG9k cmFpbmVkUG9vbC5oOgorICAgICAgICAoQXV0b2RyYWluZWRQb29sKToKKyAgICAgICAgKFdURjo6 QXV0b2RyYWluZWRQb29sOjpBdXRvZHJhaW5lZFBvb2wpOgorICAgICAgICAoV1RGOjpBdXRvZHJh aW5lZFBvb2w6On5BdXRvZHJhaW5lZFBvb2wpOgorICAgICAgICAoV1RGOjpBdXRvZHJhaW5lZFBv b2w6OmN5Y2xlKToKKwogMjAxMy0wNC0wNiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJlbW92ZWQgdjggYmluZGluZ3MgaG9va3MgZnJvbSBJREwgZmlsZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0F1dG9kcmFpbmVkUG9vbC5oIGIvU291cmNlL1dU Ri93dGYvQXV0b2RyYWluZWRQb29sLmgKaW5kZXggODY2NzE0ZGZmYTc5M2JhYjVmYTNkZTRiOWI2 ZGQ4ODU4ZWY5YTllNC4uN2JlMGYwNjc2NjBiMTM0N2IxMWRiOTE4MzRmODUxNGNlZDlmNWNmNyAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXV0b2RyYWluZWRQb29sLmgKKysrIGIvU291cmNl L1dURi93dGYvQXV0b2RyYWluZWRQb29sLmgKQEAgLTM4LDEwICszOCwxNiBAQCBuYW1lc3BhY2Ug V1RGIHsKIGNsYXNzIEF1dG9kcmFpbmVkUG9vbCB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUo QXV0b2RyYWluZWRQb29sKTsKIHB1YmxpYzoKKyNpZiBQTEFURk9STShNQUMpCiAgICAgV1RGX0VY UE9SVF9QUklWQVRFIGV4cGxpY2l0IEF1dG9kcmFpbmVkUG9vbChpbnQgaXRlcmF0aW9uTGltaXQg PSAxKTsKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgfkF1dG9kcmFpbmVkUG9vbCgpOwotICAgIAor CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgY3ljbGUoKTsKKyNlbHNlCisgICAgaW5saW5l IGV4cGxpY2l0IEF1dG9kcmFpbmVkUG9vbChpbnQgPSAxKSB7IH0KKyAgICBpbmxpbmUgfkF1dG9k cmFpbmVkUG9vbCgpIHsgfQorICAgIGlubGluZSB2b2lkIGN5Y2xlKCkgeyB9CisjZW5kaWYKICAg ICAKIHByaXZhdGU6CiAjaWYgUExBVEZPUk0oTUFDKQpAQCAtNTEsMTYgKzU3LDggQEAgcHJpdmF0 ZToKICNlbmRpZgogfTsKIAotI2lmICFQTEFURk9STShNQUMpCi1pbmxpbmUgQXV0b2RyYWluZWRQ b29sOjpBdXRvZHJhaW5lZFBvb2woaW50KSB7IH0KLWlubGluZSBBdXRvZHJhaW5lZFBvb2w6On5B dXRvZHJhaW5lZFBvb2woKSB7IH0KLWlubGluZSB2b2lkIEF1dG9kcmFpbmVkUG9vbDo6Y3ljbGUo KSB7IH0KLSNlbmRpZgotCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAogdXNpbmcgV1RGOjpBdXRvZHJh aW5lZFBvb2w7CiAKICNlbmRpZgotCi0K