114121 2013-04-07 09:55:39 -0700 [GTK] Windows build failure after r136056 2013-04-11 13:21:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned bfulgham commit-queue dbates mrobinson oldest_to_newest 870473 0 kalevlember 2013-04-07 09:55:39 -0700 CXX Source/WebCore/platform/graphics/cairo/Programs_TestWebKitAPI_TestGtk-IntRectCairo.o ../Source/WebCore/platform/graphics/cairo/IntRectCairo.cpp:28:1: error: prototype for 'WebCore::IntRect::IntRect(const cairo_rectangle_int_t&)' does not match any in class 'WebCore::IntRect' IntRect::IntRect(const cairo_rectangle_int_t& r) ^ In file included from ../Source/WebCore/platform/graphics/cairo/IntRectCairo.cpp:22:0: ../Source/WebCore/platform/graphics/IntRect.h:82:7: error: candidates are: WebCore::IntRect::IntRect(const WebCore::IntRect&) class IntRect { ^ ../Source/WebCore/platform/graphics/IntRect.h:92:14: error: WebCore::IntRect::IntRect(const WebCore::LayoutRect&) explicit IntRect(const LayoutRect&); // don't do this implicitly since it's lossy ^ ../Source/WebCore/platform/graphics/IntRect.h:91:14: error: WebCore::IntRect::IntRect(const WebCore::FloatRect&) explicit IntRect(const FloatRect&); // don't do this implicitly since it's lossy ^ ../Source/WebCore/platform/graphics/IntRect.h:88:5: error: WebCore::IntRect::IntRect(int, int, int, int) IntRect(int x, int y, int width, int height) ^ ../Source/WebCore/platform/graphics/IntRect.h:86:5: error: WebCore::IntRect::IntRect(const WebCore::IntPoint&, const WebCore::IntSize&) IntRect(const IntPoint& location, const IntSize& size) ^ ../Source/WebCore/platform/graphics/IntRect.h:85:5: error: WebCore::IntRect::IntRect() IntRect() { } ^ ../Source/WebCore/platform/graphics/cairo/IntRectCairo.cpp:34:43: error: no 'WebCore::IntRect::operator cairo_rectangle_int_t() const' member function declared in class 'WebCore::IntRect' IntRect::operator cairo_rectangle_int_t() const ^ make[1]: *** [Source/WebCore/platform/graphics/cairo/Programs_TestWebKitAPI_TestGtk-IntRectCairo.o] Error 1 870478 1 kalevlember 2013-04-07 10:07:18 -0700 r136056 broke the build for some Windows ports that aren't the apple-win port. Looks like the config.h addition should be guarded by PLATFORM(WIN) instead of #ifdef(WIN32). The #undefs there don't make sense for GTK Windows port, at least. 870480 2 196793 kalevlember 2013-04-07 10:08:03 -0700 Created attachment 196793 Patch 874098 3 196793 commit-queue 2013-04-11 13:21:06 -0700 Comment on attachment 196793 Patch Clearing flags on attachment: 196793 Committed r148230: <http://trac.webkit.org/changeset/148230> 874099 4 commit-queue 2013-04-11 13:21:09 -0700 All reviewed patches have been landed. Closing bug. 196793 2013-04-07 10:08:03 -0700 2013-04-11 13:21:06 -0700 Patch 0001-GTK-Windows-build-failure-after-r136056.patch text/plain 1362 kalevlember RnJvbSA5MTk4NTUxYjBlOGQ4NGE1ZDcxYWZmNjkzMDQ1OWFiY2Y4MWVmMzU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCA3IEFwciAyMDEzIDE4OjI3OjQ3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gW0dU S10gV2luZG93cyBidWlsZCBmYWlsdXJlIGFmdGVyIHIxMzYwNTYKCi0tLQogVG9vbHMvQ2hhbmdl TG9nICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIFRvb2xzL1Rlc3RXZWJLaXRBUEkvY29u ZmlnLmggfCAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IDQxZDZiMjcuLmYwNzNjMDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wNC0wNyAgS2FsZXYgTGVt YmVyICA8a2FsZXZsZW1iZXJAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFdpbmRvd3MgYnVp bGQgZmFpbHVyZSBhZnRlciByMTM2MDU2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTQxMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvY29uZmlnLmg6IE1ha2Ugc3VyZSBkZWZp bmVzIGFyZSBjb3JyZWN0IGZvciBvdGhlcgorICAgICAgICBXaW5kb3dzIHBvcnRzIHRoYW4gYXBw bGUtd2luLgorCiAyMDEzLTAzLTIxICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBnZW5lcmF0ZS1mZWF0dXJlLWRlZmluZXMtZmlsZXMgaXMgaW5j b21wYXRpYmxlIHdpdGggUHl0aG9uMwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9j b25maWcuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29uZmlnLmgKaW5kZXggZDQ3MTRjZC4uNmZi ODRiMyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9jb25maWcuaAorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL2NvbmZpZy5oCkBAIC00Nyw3ICs0Nyw3IEBACiAjZW5kaWYKICNlbmRp ZgogCi0jZWxpZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikKKyNlbGlmIFBMQVRG T1JNKFdJTikKIAogI2lmbmRlZiBOT01JTk1BWAogI2RlZmluZSBOT01JTk1BWApAQCAtNjYsNyAr NjYsNyBAQAogI3VuZGVmIFdURl9VU0VfQ1VSTAogI2VuZGlmCiAKLSNlbmRpZgorI2VuZGlmIC8v IFBMQVRGT1JNKFdJTikKIAogI2luY2x1ZGUgPHN0ZGludC5oPgogCi0tIAoxLjguMgoK