11411 2006-10-25 02:16:12 -0700 REGRESSION (r17280): Repro crash when clicking a link with target="_blank" 2006-10-25 05:19:10 -0700 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, Regression P1 Critical --- 1 mitz webkit-unassigned oldest_to_newest 49859 0 mitz 2006-10-25 02:16:12 -0700 Safari crashes when you click a link with target="_blank" in a document with an http: URL. The crash is in -[WebCoreFrameBridge canTargetLoadInFrame:] due to this change in r17280: - WebCoreFrameBridge *parentBridge = [targetFrame parent]; + WebCoreFrameBridge *parentBridge = Mac([targetFrame _frame]->tree()->parent())->bridge(); 49862 1 11201 catfish.man 2006-10-25 04:24:45 -0700 Created attachment 11201 Fix 49828 2 11204 catfish.man 2006-10-25 04:40:20 -0700 Created attachment 11204 Updated based on comments 49720 3 11205 catfish.man 2006-10-25 04:46:52 -0700 Created attachment 11205 Once more into the breach... Silly *s, always being in the wrong place. 49721 4 11205 mitz 2006-10-25 04:49:08 -0700 Comment on attachment 11205 Once more into the breach... r=me 49726 5 mrowe 2006-10-25 05:19:10 -0700 Landed in r17288. 11201 2006-10-25 04:24:45 -0700 2006-10-25 04:40:20 -0700 Fix target-blank-crash-fix.txt text/plain 1366 catfish.man SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzI4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDYtMTAtMjUgIERhdmlkIFNtaXRoICA8c2V0IEVNQUlMX0FERFJF U1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZWQgUkVHUkVTU0lPTiAocjE3MjgwKTogUmVwcm8gY3Jhc2gg d2hlbiBjbGlja2luZyBhIGxpbmsgd2l0aCB0YXJnZXQ9Il9ibGFuayIKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MTEKKworICAgICAgICAqIGJyaWRn ZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tOgorICAgICAgICAoLVtXZWJDb3JlRnJhbWVCcmlk Z2UgY2FuVGFyZ2V0TG9hZEluRnJhbWU6XSk6IENoZWNrIHRoYXQgdGhlIHRhcmdldCBoYXMgYSBm cmFtZSBiZWZvcmUgdXNpbmcgaXQuCisKIDIwMDYtMTAtMjUgIE1hY2llaiBTdGFjaG93aWFrICA8 bWpzQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXIgc3RhbXBlZCBieSBNaXR6LgpJbmRleDog V2ViQ29yZS9icmlkZ2UvbWFjL1dlYkNvcmVGcmFtZUJyaWRnZS5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2JyaWRnZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCShyZXZpc2lvbiAxNzI4NikK KysrIFdlYkNvcmUvYnJpZGdlL21hYy9XZWJDb3JlRnJhbWVCcmlkZ2UubW0JKHdvcmtpbmcgY29w eSkKQEAgLTM4MCw3ICszODAsMTAgQEAgc3RhdGljIGlubGluZSBXZWJDb3JlRnJhbWVCcmlkZ2Ug KmJyaWRnZQogICAgICAgICByZXR1cm4gWUVTOwogICAgIH0KICAgICAKLSAgICBXZWJDb3JlRnJh bWVCcmlkZ2UgKnBhcmVudEJyaWRnZSA9IE1hYyhbdGFyZ2V0RnJhbWUgX2ZyYW1lXS0+dHJlZSgp LT5wYXJlbnQoKSktPmJyaWRnZSgpOworICAgIEZyYW1lKiB0YXJnZXQgPSBbdGFyZ2V0RnJhbWUg X2ZyYW1lXTsKKyAgICBXZWJDb3JlRnJhbWVCcmlkZ2UgKnBhcmVudEJyaWRnZSA9IE5VTEw7Cisg ICAgaWYodGFyZ2V0KQorICAgICAgICBwYXJlbnRCcmlkZ2UgPSBNYWModGFyZ2V0LT50cmVlKCkt PnBhcmVudCgpKS0+YnJpZGdlKCk7CiAgICAgLy8gQWxsb3cgaWYgdGFyZ2V0IGlzIGFuIGVudGly ZSB3aW5kb3cuCiAgICAgaWYgKCFwYXJlbnRCcmlkZ2UpCiAgICAgICAgIHJldHVybiBZRVM7Cg== 11204 2006-10-25 04:40:20 -0700 2006-10-25 04:46:52 -0700 Updated based on comments target-blank-crash-fix.txt text/plain 1317 catfish.man SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzI4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDYtMTAtMjUgIERhdmlkIFNtaXRoICA8Y2F0ZmlzaC5tYW5AZ21h aWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVkIFJFR1JFU1NJT04gKHIxNzI4MCk6IFJlcHJvIGNyYXNoIHdoZW4gY2xpY2tpbmcgYSBs aW5rIHdpdGggdGFyZ2V0PSJfYmxhbmsiCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNDExCisKKyAgICAgICAgKiBicmlkZ2UvbWFjL1dlYkNvcmVGcmFt ZUJyaWRnZS5tbToKKyAgICAgICAgKC1bV2ViQ29yZUZyYW1lQnJpZGdlIGNhblRhcmdldExvYWRJ bkZyYW1lOl0pOiBDaGVjayB0aGF0IHRoZSB0YXJnZXQgaGFzIGEgZnJhbWUgYmVmb3JlIHVzaW5n IGl0LgorCiAyMDA2LTEwLTI1ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAK ICAgICAgICAgUnViYmVyIHN0YW1wZWQgYnkgTWl0ei4KSW5kZXg6IFdlYkNvcmUvYnJpZGdlL21h Yy9XZWJDb3JlRnJhbWVCcmlkZ2UubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2UvbWFj L1dlYkNvcmVGcmFtZUJyaWRnZS5tbQkocmV2aXNpb24gMTcyODYpCisrKyBXZWJDb3JlL2JyaWRn ZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zODAsNyArMzgw LDggQEAgc3RhdGljIGlubGluZSBXZWJDb3JlRnJhbWVCcmlkZ2UgKmJyaWRnZQogICAgICAgICBy ZXR1cm4gWUVTOwogICAgIH0KICAgICAKLSAgICBXZWJDb3JlRnJhbWVCcmlkZ2UgKnBhcmVudEJy aWRnZSA9IE1hYyhbdGFyZ2V0RnJhbWUgX2ZyYW1lXS0+dHJlZSgpLT5wYXJlbnQoKSktPmJyaWRn ZSgpOworICAgIEZyYW1lKiB0YXJnZXQgPSBbdGFyZ2V0RnJhbWUgX2ZyYW1lXTsKKyAgICBXZWJD b3JlRnJhbWVCcmlkZ2UqIHBhcmVudEJyaWRnZSA9IHRhcmdldCA/IE1hYyh0YXJnZXQtPnRyZWUo KS0+cGFyZW50KCkpLT5icmlkZ2UoKSA6IG5pbDsKICAgICAvLyBBbGxvdyBpZiB0YXJnZXQgaXMg YW4gZW50aXJlIHdpbmRvdy4KICAgICBpZiAoIXBhcmVudEJyaWRnZSkKICAgICAgICAgcmV0dXJu IFlFUzsK 11205 2006-10-25 04:46:52 -0700 2006-10-25 04:49:08 -0700 Once more into the breach... target-blank-crash-fix.txt text/plain 1317 catfish.man SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzI4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDYtMTAtMjUgIERhdmlkIFNtaXRoICA8Y2F0ZmlzaC5tYW5AZ21h aWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVkIFJFR1JFU1NJT04gKHIxNzI4MCk6IFJlcHJvIGNyYXNoIHdoZW4gY2xpY2tpbmcgYSBs aW5rIHdpdGggdGFyZ2V0PSJfYmxhbmsiCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExNDExCisKKyAgICAgICAgKiBicmlkZ2UvbWFjL1dlYkNvcmVGcmFt ZUJyaWRnZS5tbToKKyAgICAgICAgKC1bV2ViQ29yZUZyYW1lQnJpZGdlIGNhblRhcmdldExvYWRJ bkZyYW1lOl0pOiBDaGVjayB0aGF0IHRoZSB0YXJnZXQgaGFzIGEgZnJhbWUgYmVmb3JlIHVzaW5n IGl0LgorCiAyMDA2LTEwLTI1ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAK ICAgICAgICAgUnViYmVyIHN0YW1wZWQgYnkgTWl0ei4KSW5kZXg6IFdlYkNvcmUvYnJpZGdlL21h Yy9XZWJDb3JlRnJhbWVCcmlkZ2UubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2UvbWFj L1dlYkNvcmVGcmFtZUJyaWRnZS5tbQkocmV2aXNpb24gMTcyODcpCisrKyBXZWJDb3JlL2JyaWRn ZS9tYWMvV2ViQ29yZUZyYW1lQnJpZGdlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zODAsNyArMzgw LDggQEAgc3RhdGljIGlubGluZSBXZWJDb3JlRnJhbWVCcmlkZ2UgKmJyaWRnZQogICAgICAgICBy ZXR1cm4gWUVTOwogICAgIH0KICAgICAKLSAgICBXZWJDb3JlRnJhbWVCcmlkZ2UgKnBhcmVudEJy aWRnZSA9IE1hYyhbdGFyZ2V0RnJhbWUgX2ZyYW1lXS0+dHJlZSgpLT5wYXJlbnQoKSktPmJyaWRn ZSgpOworICAgIEZyYW1lICp0YXJnZXQgPSBbdGFyZ2V0RnJhbWUgX2ZyYW1lXTsKKyAgICBXZWJD b3JlRnJhbWVCcmlkZ2UgKnBhcmVudEJyaWRnZSA9IHRhcmdldCA/IE1hYyh0YXJnZXQtPnRyZWUo KS0+cGFyZW50KCkpLT5icmlkZ2UoKSA6IG5pbDsKICAgICAvLyBBbGxvdyBpZiB0YXJnZXQgaXMg YW4gZW50aXJlIHdpbmRvdy4KICAgICBpZiAoIXBhcmVudEJyaWRnZSkKICAgICAgICAgcmV0dXJu IFlFUzsK