114101 2013-04-06 15:31:05 -0700 Change requisite hardware checks for enabling multisample framebuffers. 2013-04-09 16:04:10 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned dino noam roger_fong webkit.review.bot oldest_to_newest 870356 0 roger_fong 2013-04-06 15:31:05 -0700 m_maySupportMultisampling should be true by default for all platforms/hardware now except older versions of AMD. 870357 1 196754 roger_fong 2013-04-06 15:35:25 -0700 Created attachment 196754 patch 870417 2 196754 benjamin 2013-04-06 23:10:28 -0700 Comment on attachment 196754 patch View in context: https://bugs.webkit.org/attachment.cgi?id=196754&action=review > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:95 > - if (m_isNVIDIA || (m_isAMD && systemSupportsMultisampling)) > - m_maySupportMultisampling = true; > + if (!(m_isNVIDIA || m_isIntel || (m_isAMD && systemSupportsMultisampling))) > + m_maySupportMultisampling = false; It looks like the previous code would never put m_maySupportMultisampling = false. What about leaving m_maySupportMultisampling uninitialized then?: m_maySupportMultisampling = m_isNVIDIA || m_isIntel || (m_isAMD && systemSupportsMultisampling); 871132 3 roger_fong 2013-04-08 13:10:11 -0700 I think what we ended up wanting was for it to be true by default for everything except for certain versions of AMD... O wait...if I wanted to do that I guess I could of just done: + if (m_isAMD && !systemSupportsMultisampling))) + m_maySupportMultisampling = false; 872018 4 dino 2013-04-09 12:19:22 -0700 (In reply to comment #3) > I think what we ended up wanting was for it to be true by default for everything except for certain versions of AMD... > > O wait...if I wanted to do that I guess I could of just done: > > + if (m_isAMD && !systemSupportsMultisampling))) > + m_maySupportMultisampling = false; Yeah, do that one! We should assume other ports want this supported. Meanwhile, we know it isn't good on AMD before a certain version on OS X, so turn it off there. We might have to turn it off on older OS X systems for other hardware too, but we don't know for sure yet. 872049 5 197163 roger_fong 2013-04-09 13:25:21 -0700 Created attachment 197163 patch 872125 6 roger_fong 2013-04-09 16:04:10 -0700 Committed:http://trac.webkit.org/changeset/148060 196754 2013-04-06 15:35:25 -0700 2013-04-09 13:25:21 -0700 patch patch.patch text/plain 1509 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Nzg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTA2ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIHJlcXVpc2l0ZSBo YXJkd2FyZSBjaGVja3MgZm9yIGVuYWJsaW5nIGFudGlhbGlhc2luZy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDEwMQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTIzNDI3NzY+LgorCisgICAgICAgIG1fbWF5U3VwcG9ydE11bHRpc2FtcGxpbmcg c2hvdWxkIGJlIHRydWUgYnkgZGVmYXVsdCBmb3IgYWxsIHBsYXRmb3Jtcy9oYXJkd2FyZSBub3cg ZXhjZXB0IG9sZGVyIHZlcnNpb25zIG9mIEFNRC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNp b25zM0RPcGVuR0xDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3Bl bkdMQ29tbW9uOjpFeHRlbnNpb25zM0RPcGVuR0xDb21tb24pOgorCiAyMDEzLTA0LTA2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIFVT RShTS0lBX09OX01BQ19DSFJPTUlVTSkgZ3VhcmRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9u czNET3BlbkdMQ29tbW9uLmNwcAkocmV2aXNpb24gMTQ3NTA5KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTkxLDggKzkxLDggQEAKICAgICAgICAgc3lzdGVtU3VwcG9ydHNNdWx0 aXNhbXBsaW5nID0gdmVyc2lvbiA+PSAweDEwNzI7CiAjZW5kaWYgLy8gU05PV19MRU9QQVJEIGFu ZCBMSU9OCiAKLSAgICBpZiAobV9pc05WSURJQSB8fCAobV9pc0FNRCAmJiBzeXN0ZW1TdXBwb3J0 c011bHRpc2FtcGxpbmcpKQotICAgICAgICBtX21heVN1cHBvcnRNdWx0aXNhbXBsaW5nID0gdHJ1 ZTsKKyAgICBpZiAoIShtX2lzTlZJRElBIHx8IG1faXNJbnRlbCB8fCAobV9pc0FNRCAmJiBzeXN0 ZW1TdXBwb3J0c011bHRpc2FtcGxpbmcpKSkKKyAgICAgICAgbV9tYXlTdXBwb3J0TXVsdGlzYW1w bGluZyA9IGZhbHNlOwogI2VuZGlmCiB9CiAK 197163 2013-04-09 13:25:21 -0700 2013-04-09 14:31:36 -0700 patch patch.patch text/plain 1478 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0Nzg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA0LTA2ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIHJlcXVpc2l0ZSBo YXJkd2FyZSBjaGVja3MgZm9yIGVuYWJsaW5nIGFudGlhbGlhc2luZy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDEwMQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTIzNDI3NzY+LgorCisgICAgICAgIG1fbWF5U3VwcG9ydE11bHRpc2FtcGxpbmcg c2hvdWxkIGJlIHRydWUgYnkgZGVmYXVsdCBmb3IgYWxsIHBsYXRmb3Jtcy9oYXJkd2FyZSBub3cg ZXhjZXB0IG9sZGVyIHZlcnNpb25zIG9mIEFNRC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNp b25zM0RPcGVuR0xDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9uczNET3Bl bkdMQ29tbW9uOjpFeHRlbnNpb25zM0RPcGVuR0xDb21tb24pOgorCiAyMDEzLTA0LTA2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIFVT RShTS0lBX09OX01BQ19DSFJPTUlVTSkgZ3VhcmRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9u czNET3BlbkdMQ29tbW9uLmNwcAkocmV2aXNpb24gMTQ3NTA5KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTkxLDggKzkxLDggQEAKICAgICAgICAgc3lzdGVtU3VwcG9ydHNNdWx0 aXNhbXBsaW5nID0gdmVyc2lvbiA+PSAweDEwNzI7CiAjZW5kaWYgLy8gU05PV19MRU9QQVJEIGFu ZCBMSU9OCiAKLSAgICBpZiAobV9pc05WSURJQSB8fCAobV9pc0FNRCAmJiBzeXN0ZW1TdXBwb3J0 c011bHRpc2FtcGxpbmcpKQotICAgICAgICBtX21heVN1cHBvcnRNdWx0aXNhbXBsaW5nID0gdHJ1 ZTsKKyAgICBpZiAobV9pc0FNRCAmJiAhc3lzdGVtU3VwcG9ydHNNdWx0aXNhbXBsaW5nKQorICAg ICAgICBtX21heVN1cHBvcnRNdWx0aXNhbXBsaW5nID0gZmFsc2U7CiAjZW5kaWYKIH0KIAo=