114085 2013-04-06 02:26:40 -0700 --minimal build fails with error: control reaches end of non-void function 2013-04-06 13:02:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 0 bartosh webkit-unassigned commit-queue fpizlo ggaren oliver oldest_to_newest 870261 0 bartosh 2013-04-06 02:26:40 -0700 ./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error: /home/ed/git/wk/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp: In function ‘unsigned int JSC::getBytecodeOffsetForCallFrame(JSC::CallFrame*)’: /home/ed/git/wk/WebKit/Source/JavaScriptCore/interpreter/Interpreter.cpp:580:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/JavaScriptCore/CMakeFiles/javascriptcore_efl.dir/interpreter/Interpreter.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/JavaScriptCore/CMakeFiles/javascriptcore_efl.dir/all] Error 2 make: *** [all] Error 2 870266 1 196727 bartosh 2013-04-06 03:13:36 -0700 Created attachment 196727 Patch 870317 2 196727 ggaren 2013-04-06 11:00:33 -0700 Comment on attachment 196727 Patch r=me 870328 3 196727 commit-queue 2013-04-06 11:25:14 -0700 Comment on attachment 196727 Patch Rejecting attachment 196727 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 196727, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/interpreter/Interpreter.cpp Hunk #1 FAILED at 576. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/interpreter/Interpreter.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-commit-queue.appspot.com/results/17524468 870329 4 196748 bartosh 2013-04-06 11:34:40 -0700 Created attachment 196748 Patch Rebased. Please, review. 870336 5 196748 commit-queue 2013-04-06 13:02:34 -0700 Comment on attachment 196748 Patch Clearing flags on attachment: 196748 Committed r147851: <http://trac.webkit.org/changeset/147851> 870337 6 commit-queue 2013-04-06 13:02:37 -0700 All reviewed patches have been landed. Closing bug. 196727 2013-04-06 03:13:36 -0700 2013-04-06 11:34:40 -0700 Patch bug-114085-20130406131322.patch text/plain 1343 bartosh U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZWY4NjE4ZWUyMGEwMWQ4MWYxNDBhN2Q5M2I5NTk2NDZhMGNkOTE4Li41OGRhM2E2NDUwZTQyYTU2 NTVjZGJkYzFjYmJiODYwY2U1MDdmZGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wNC0wNiAgRWQgQmFydG9zaCAgPGJhcnRvc2hAZ21haWwuY29tPgor CisgICAgICAgIC0tbWluaW1hbCBidWlsZCBmYWlscyB3aXRoIGVycm9yOiBjb250cm9sIHJlYWNo ZXMgZW5kIG9mIG5vbi12b2lkIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQwODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGludGVycHJldGVyL0ludGVycHJldGVyLmNwcDogcmV0dXJu IDAgaWYgSklUIGlzIG5vdCBlbmFibGVkCisgICAgICAgIChKU0M6OmdldEJ5dGVjb2RlT2Zmc2V0 Rm9yQ2FsbEZyYW1lKToKKwogMjAxMy0wNC0wNSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWlu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgU2Vjb25kIGF0dGVtcHQgdG8gZml4IHRoZSBXaW5kb3dz IGJvdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVy cHJldGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRl ci5jcHAKaW5kZXggMjVlMTFlNjg5Mzc0OGU0ZjAwYzE1NDZhN2VmYTMwOTNmODI3YWE1ZS4uNjJh NDFkYThlNjVlOTExOGVjZWQ4Zjg2ZDY0MzdlODZiZTM0YjgzNSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBAIC01NzYsNiArNTc2 LDggQEAgc3RhdGljIHVuc2lnbmVkIGdldEJ5dGVjb2RlT2Zmc2V0Rm9yQ2FsbEZyYW1lKENhbGxG cmFtZSogY2FsbEZyYW1lKQogICAgICAgICByZXR1cm4gY29kZUJsb2NrLT5jb2RlT3JpZ2luKGNh bGxGcmFtZS0+Y29kZU9yaWdpbkluZGV4Rm9yREZHKCkpLmJ5dGVjb2RlSW5kZXg7CiAjZW5kaWYK ICAgICByZXR1cm4gY2FsbEZyYW1lLT5ieXRlY29kZU9mZnNldEZvck5vbkRGR0NvZGUoKTsKKyNl bHNlCisgICAgcmV0dXJuIDA7CiAjZW5kaWYKIH0KIAo= 196748 2013-04-06 11:34:40 -0700 2013-04-06 13:02:34 -0700 Patch Patch.114085 text/plain 1505 bartosh Y29tbWl0IGY1YzkxNTIwZjc2ZTA0NmIzYmRhZGM1OGQ0NWFmYmE3NzYxMzk2NDcKQXV0aG9yOiBF ZCBCYXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KRGF0ZTogICBTYXQgQXByIDYgMTM6MTQ6MTUg MjAxMyArMDMwMAoKICAgIEZpeGVkIDExNDA4NQogICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBFZCBC YXJ0b3NoIDxiYXJ0b3NoQGdtYWlsLmNvbT4KCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YWRmYWQ4Li5lM2E5ZDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBA QAorMjAxMy0wNC0wNiAgRWQgQmFydG9zaCAgPGJhcnRvc2hAZ21haWwuY29tPgorCisgICAgICAg IC0tbWluaW1hbCBidWlsZCBmYWlscyB3aXRoIGVycm9yOiBjb250cm9sIHJlYWNoZXMgZW5kIG9m IG5vbi12b2lkIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMTQwODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGludGVycHJldGVyL0ludGVycHJldGVyLmNwcDogcmV0dXJuIDAgaWYgSklU IGlzIG5vdCBlbmFibGVkCisgICAgICAgIChKU0M6OmdldEJ5dGVjb2RlT2Zmc2V0Rm9yQ2FsbEZy YW1lKToKKwogMjAxMy0wNC0wNiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgog CiAgICAgICAgIFJvbGxlZCBvdXQgMTQ3ODIwIGFuZCAxNDc4MTggYmVjYXVzZSB0aGV5IGNhdXNl ZCBwbHVnaW5zIHRlc3RzIHRvIEFTU0VSVApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKaW5kZXggZTJjNzhhYy4uNTE2NzU1MSAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBA IC01NzcsNiArNTc3LDggQEAgc3RhdGljIGludCBnZXRMaW5lTnVtYmVyRm9yQ2FsbEZyYW1lKEpT R2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgQ2FsbEZyYW1lKiBjYWxsRnIKICAgICAgICAgcmV0dXJu IGNvZGVCbG9jay0+bGluZU51bWJlckZvckJ5dGVjb2RlT2Zmc2V0KGNvZGVCbG9jay0+Y29kZU9y aWdpbihjYWxsRnJhbWUtPmNvZGVPcmlnaW5JbmRleEZvckRGRygpKS5ieXRlY29kZUluZGV4KTsK ICNlbmRpZgogICAgIHJldHVybiBjb2RlQmxvY2stPmxpbmVOdW1iZXJGb3JCeXRlY29kZU9mZnNl dChjYWxsRnJhbWUtPmJ5dGVjb2RlT2Zmc2V0Rm9yTm9uREZHQ29kZSgpKTsKKyNlbHNlCisgICAg cmV0dXJuIDA7CiAjZW5kaWYKIH0KIAo=