<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>114071</bug_id>
          
          <creation_ts>2013-04-05 16:00:35 -0700</creation_ts>
          <short_desc>AX: VoiceOver can&apos;t press on items</short_desc>
          <delta_ts>2013-04-08 12:24:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="chris fleizach">cfleizach</reporter>
          <assigned_to name="chris fleizach">cfleizach</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jdiggs</cc>
    
    <cc>jer.noble</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>870120</commentid>
    <comment_count>0</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-05 16:00:35 -0700</bug_when>
    <thetext>Now when I visit apple.com with WebKit Nightly I hear &quot;AXScrollToVisible Lunch&quot; when I Control-Option-space on a link</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870147</commentid>
    <comment_count>1</comment_count>
      <attachid>196702</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-05 17:05:33 -0700</bug_when>
    <thetext>Created attachment 196702
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870148</commentid>
    <comment_count>2</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-05 17:05:44 -0700</bug_when>
    <thetext>rdar://13580932</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870149</commentid>
    <comment_count>3</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-05 17:06:13 -0700</bug_when>
    <thetext>Adding Tim to help with review</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870154</commentid>
    <comment_count>4</comment_count>
      <attachid>196702</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-05 17:10:59 -0700</bug_when>
    <thetext>Comment on attachment 196702
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=196702&amp;action=review

&gt; Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:938
&gt; -    static NSArray *defaultElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityShowMenuAction, NSAccessibilityScrollToVisibleAction, nil];
&gt; +    static NSArray *defaultElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityShowMenuAction, scrollToVisibleAction, nil];
&gt;  
&gt;      // Action elements allow Press.
&gt;      // The order is important to VoiceOver, which expects the &apos;default&apos; action to be the first action. In this case the default action should be press.
&gt; -    static NSArray *actionElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityPressAction, NSAccessibilityShowMenuAction, NSAccessibilityScrollToVisibleAction, nil];
&gt; +    static NSArray *actionElementActions = [[NSArray alloc] initWithObjects:NSAccessibilityPressAction, NSAccessibilityShowMenuAction, scrollToVisibleAction, nil];

This is just *asking* for someone to come along and add something after scrollToVisibleAction and wonder why it doesn&apos;t work. Can we organize this differently somehow? Even if you split this line and put the ifdefs in the middle of it, that would seem better to me (we do that elsewhere).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870165</commentid>
    <comment_count>5</comment_count>
      <attachid>196706</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-05 17:27:50 -0700</bug_when>
    <thetext>Created attachment 196706
patch

good point. how does this look</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870167</commentid>
    <comment_count>6</comment_count>
      <attachid>196706</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-05 17:29:03 -0700</bug_when>
    <thetext>Comment on attachment 196706
patch

That works too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870182</commentid>
    <comment_count>7</comment_count>
      <attachid>196706</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-04-05 18:06:48 -0700</bug_when>
    <thetext>Comment on attachment 196706
patch

Clearing flags on attachment: 196706

Committed r147824: &lt;http://trac.webkit.org/changeset/147824&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870183</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-04-05 18:06:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870987</commentid>
    <comment_count>9</comment_count>
      <attachid>196706</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2013-04-08 12:02:46 -0700</bug_when>
    <thetext>Comment on attachment 196706
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196706&amp;action=review

&gt; LayoutTests/platform/mac-future/accessibility/press-action-is-first-expected.txt:2
&gt; +This tests that the AXPressAction comes first for activatable items instead of the scroll to visible action. This is needed for screenreaders to operate correctly.

Please don&apos;t land test results in mac-future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870993</commentid>
    <comment_count>10</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-08 12:10:53 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 196706 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=196706&amp;action=review
&gt; 
&gt; &gt; LayoutTests/platform/mac-future/accessibility/press-action-is-first-expected.txt:2
&gt; &gt; +This tests that the AXPressAction comes first for activatable items instead of the scroll to visible action. This is needed for screenreaders to operate correctly.
&gt; 
&gt; Please don&apos;t land test results in mac-future.

Should this be removed then</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870994</commentid>
    <comment_count>11</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-04-08 12:17:58 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (In reply to comment #9)
&gt; &gt; (From update of attachment 196706 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=196706&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; LayoutTests/platform/mac-future/accessibility/press-action-is-first-expected.txt:2
&gt; &gt; &gt; +This tests that the AXPressAction comes first for activatable items instead of the scroll to visible action. This is needed for screenreaders to operate correctly.
&gt; &gt; 
&gt; &gt; Please don&apos;t land test results in mac-future.
&gt; 
&gt; Should this be removed then

I cleaned things up in r147943. &lt;http://trac.webkit.org/changeset/147943&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>870996</commentid>
    <comment_count>12</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2013-04-08 12:24:43 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; (In reply to comment #9)
&gt; &gt; &gt; (From update of attachment 196706 [details] [details] [details])
&gt; &gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=196706&amp;action=review
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; LayoutTests/platform/mac-future/accessibility/press-action-is-first-expected.txt:2
&gt; &gt; &gt; &gt; +This tests that the AXPressAction comes first for activatable items instead of the scroll to visible action. This is needed for screenreaders to operate correctly.
&gt; &gt; &gt; 
&gt; &gt; &gt; Please don&apos;t land test results in mac-future.
&gt; &gt; 
&gt; &gt; Should this be removed then
&gt; 
&gt; I cleaned things up in r147943. &lt;http://trac.webkit.org/changeset/147943&gt;

Thanks</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>196702</attachid>
            <date>2013-04-05 17:05:33 -0700</date>
            <delta_ts>2013-04-05 17:27:50 -0700</delta_ts>
            <desc>patch </desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>4810</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzgxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTA1ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFZvaWNlT3ZlciBj
YW4ndCBwcmVzcyBvbiBpdGVtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTE0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgVGhlIEFYU2Nyb2xsVG9WaXNpYmxlQWN0aW9uIHNob3VsZCBub3QgYmUgdXNl
ZCBvbiBlYXJsaWVyIE1hYyB2ZXJzaW9ucyBiZWNhdXNlCisgICAgICAgIGl0IGNvbmZ1c2VzIFZv
aWNlT3Zlci4KKworICAgICAgICBVcGRhdGVkIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICog
YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW06Cisg
ICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlBY3Rp
b25OYW1lc10pOgorCiAyMDEzLTA0LTA1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+
CiAKICAgICAgICAgVW5pZnkgdGhlIG1hbnkgYW5kIHZhcmllZCBzdGFjayB0cmFjZSBtZWNoYW5p
c21zLCBhbmQgbWFrZSB0aGUgcmVzdWx0IHNhbmUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nl
c3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5
T2JqZWN0V3JhcHBlck1hYy5tbQkocmV2aXNpb24gMTQ3ODAxKQorKysgU291cmNlL1dlYkNvcmUv
YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0JKHdv
cmtpbmcgY29weSkKQEAgLTkyNCwxMiArOTI0LDE4IEBACiAgICAgaWYgKCFbc2VsZiB1cGRhdGVP
YmplY3RCYWNraW5nU3RvcmVdKQogICAgICAgICByZXR1cm4gbmlsOwogICAgIAorICAgIC8vIENl
cnRhaW4gZWFybGllciBWb2ljZU92ZXIgdmVyc2lvbnMgZG8gbm90IHN1cHBvcnQgc2Nyb2xsIHRv
IHZpc2libGUuCisgICAgTlNTdHJpbmcgKnNjcm9sbFRvVmlzaWJsZUFjdGlvbiA9IE5TQWNjZXNz
aWJpbGl0eVNjcm9sbFRvVmlzaWJsZUFjdGlvbjsKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlO
X1JFUVVJUkVEIDwgMTA5MAorICAgIHNjcm9sbFRvVmlzaWJsZUFjdGlvbiA9IG5pbDsKKyNlbmRp
ZgorICAgIAogICAgIC8vIEFsbCBlbGVtZW50cyBzaG91bGQgZ2V0IFNob3dNZW51IGFuZCBTY3Jv
bGxUb1Zpc2libGUuCi0gICAgc3RhdGljIE5TQXJyYXkgKmRlZmF1bHRFbGVtZW50QWN0aW9ucyA9
IFtbTlNBcnJheSBhbGxvY10gaW5pdFdpdGhPYmplY3RzOk5TQWNjZXNzaWJpbGl0eVNob3dNZW51
QWN0aW9uLCBOU0FjY2Vzc2liaWxpdHlTY3JvbGxUb1Zpc2libGVBY3Rpb24sIG5pbF07CisgICAg
c3RhdGljIE5TQXJyYXkgKmRlZmF1bHRFbGVtZW50QWN0aW9ucyA9IFtbTlNBcnJheSBhbGxvY10g
aW5pdFdpdGhPYmplY3RzOk5TQWNjZXNzaWJpbGl0eVNob3dNZW51QWN0aW9uLCBzY3JvbGxUb1Zp
c2libGVBY3Rpb24sIG5pbF07CiAKICAgICAvLyBBY3Rpb24gZWxlbWVudHMgYWxsb3cgUHJlc3Mu
CiAgICAgLy8gVGhlIG9yZGVyIGlzIGltcG9ydGFudCB0byBWb2ljZU92ZXIsIHdoaWNoIGV4cGVj
dHMgdGhlICdkZWZhdWx0JyBhY3Rpb24gdG8gYmUgdGhlIGZpcnN0IGFjdGlvbi4gSW4gdGhpcyBj
YXNlIHRoZSBkZWZhdWx0IGFjdGlvbiBzaG91bGQgYmUgcHJlc3MuCi0gICAgc3RhdGljIE5TQXJy
YXkgKmFjdGlvbkVsZW1lbnRBY3Rpb25zID0gW1tOU0FycmF5IGFsbG9jXSBpbml0V2l0aE9iamVj
dHM6TlNBY2Nlc3NpYmlsaXR5UHJlc3NBY3Rpb24sIE5TQWNjZXNzaWJpbGl0eVNob3dNZW51QWN0
aW9uLCBOU0FjY2Vzc2liaWxpdHlTY3JvbGxUb1Zpc2libGVBY3Rpb24sIG5pbF07CisgICAgc3Rh
dGljIE5TQXJyYXkgKmFjdGlvbkVsZW1lbnRBY3Rpb25zID0gW1tOU0FycmF5IGFsbG9jXSBpbml0
V2l0aE9iamVjdHM6TlNBY2Nlc3NpYmlsaXR5UHJlc3NBY3Rpb24sIE5TQWNjZXNzaWJpbGl0eVNo
b3dNZW51QWN0aW9uLCBzY3JvbGxUb1Zpc2libGVBY3Rpb24sIG5pbF07CiAKICAgICAvLyBNZW51
IGVsZW1lbnRzIGFsbG93IFByZXNzIGFuZCBDYW5jZWwuCiAgICAgc3RhdGljIE5TQXJyYXkgKm1l
bnVFbGVtZW50QWN0aW9ucyA9IFtbYWN0aW9uRWxlbWVudEFjdGlvbnMgYXJyYXlCeUFkZGluZ09i
amVjdDpOU0FjY2Vzc2liaWxpdHlDYW5jZWxBY3Rpb25dIHJldGFpbl07CkluZGV4OiBMYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp
c2lvbiAxNDc4MTgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg
LTEsMyArMSwxNCBAQAorMjAxMy0wNC0wNSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBw
bGUuY29tPgorCisgICAgICAgIEFYOiBWb2ljZU92ZXIgY2FuJ3QgcHJlc3Mgb24gaXRlbXMKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA3MQorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v
bWFjLWZ1dHVyZS9hY2Nlc3NpYmlsaXR5OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMt
ZnV0dXJlL2FjY2Vzc2liaWxpdHkvcHJlc3MtYWN0aW9uLWlzLWZpcnN0LWV4cGVjdGVkLnR4dDog
QWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvcHJlc3MtYWN0aW9u
LWlzLWZpcnN0LWV4cGVjdGVkLnR4dDoKKwogMjAxMy0wNC0wNSAgTWFyayBIYWhuZW5iZXJnICA8
bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIHRyeUNhY2hlR2V0QnlJRCBzZXRzIFN0
cnVjdHVyZVN0dWJJbmZvIGFjY2Vzc1R5cGUgdG8gYW4gaW5jb3JyZWN0IHZhbHVlCkluZGV4OiBM
YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9wcmVzcy1hY3Rpb24taXMtZmly
c3QtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9h
Y2Nlc3NpYmlsaXR5L3ByZXNzLWFjdGlvbi1pcy1maXJzdC1leHBlY3RlZC50eHQJKHJldmlzaW9u
IDE0Nzc5NikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3ByZXNz
LWFjdGlvbi1pcy1maXJzdC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQsOCArNCw4
IEBACiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz
LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAotQnV0dG9uIHN1cHBvcnRlZCBhY3Rp
b25zOiBBWFByZXNzLEFYU2hvd01lbnUsQVhTY3JvbGxUb1Zpc2libGUKLUxpbmsgc3VwcG9ydGVk
IGFjdGlvbnM6IEFYUHJlc3MsQVhTaG93TWVudSxBWFNjcm9sbFRvVmlzaWJsZQorQnV0dG9uIHN1
cHBvcnRlZCBhY3Rpb25zOiBBWFByZXNzLEFYU2hvd01lbnUKK0xpbmsgc3VwcG9ydGVkIGFjdGlv
bnM6IEFYUHJlc3MsQVhTaG93TWVudQogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQog
CiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtZnV0dXJlL2Fj
Y2Vzc2liaWxpdHkvcHJlc3MtYWN0aW9uLWlzLWZpcnN0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtZnV0dXJlL2FjY2Vzc2liaWxpdHkvcHJlc3Mt
YWN0aW9uLWlzLWZpcnN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz
L3BsYXRmb3JtL21hYy1mdXR1cmUvYWNjZXNzaWJpbGl0eS9wcmVzcy1hY3Rpb24taXMtZmlyc3Qt
ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEyIEBACisKK1RoaXMgdGVzdHMg
dGhhdCB0aGUgQVhQcmVzc0FjdGlvbiBjb21lcyBmaXJzdCBmb3IgYWN0aXZhdGFibGUgaXRlbXMg
aW5zdGVhZCBvZiB0aGUgc2Nyb2xsIHRvIHZpc2libGUgYWN0aW9uLiBUaGlzIGlzIG5lZWRlZCBm
b3Igc2NyZWVucmVhZGVycyB0byBvcGVyYXRlIGNvcnJlY3RseS4KKworT24gc3VjY2VzcywgeW91
IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1Qg
Q09NUExFVEUiLgorCisKK0J1dHRvbiBzdXBwb3J0ZWQgYWN0aW9uczogQVhQcmVzcyxBWFNob3dN
ZW51LEFYU2Nyb2xsVG9WaXNpYmxlCitMaW5rIHN1cHBvcnRlZCBhY3Rpb25zOiBBWFByZXNzLEFY
U2hvd01lbnUsQVhTY3JvbGxUb1Zpc2libGUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy
dWUKKworVEVTVCBDT01QTEVURQorCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>196706</attachid>
            <date>2013-04-05 17:27:50 -0700</date>
            <delta_ts>2013-04-08 12:02:46 -0700</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>4718</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzgxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTA1ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFZvaWNlT3ZlciBj
YW4ndCBwcmVzcyBvbiBpdGVtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTE0MDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgVGhlIEFYU2Nyb2xsVG9WaXNpYmxlQWN0aW9uIHNob3VsZCBub3QgYmUgdXNl
ZCBvbiBlYXJsaWVyIE1hYyB2ZXJzaW9ucyBiZWNhdXNlCisgICAgICAgIGl0IGNvbmZ1c2VzIFZv
aWNlT3Zlci4KKworICAgICAgICBVcGRhdGVkIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICog
YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW06Cisg
ICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlBY3Rp
b25OYW1lc10pOgorCiAyMDEzLTA0LTA1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+
CiAKICAgICAgICAgVW5pZnkgdGhlIG1hbnkgYW5kIHZhcmllZCBzdGFjayB0cmFjZSBtZWNoYW5p
c21zLCBhbmQgbWFrZSB0aGUgcmVzdWx0IHNhbmUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nl
c3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5
T2JqZWN0V3JhcHBlck1hYy5tbQkocmV2aXNpb24gMTQ3ODAxKQorKysgU291cmNlL1dlYkNvcmUv
YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0JKHdv
cmtpbmcgY29weSkKQEAgLTkyNSwxMSArOTI1LDIwIEBACiAgICAgICAgIHJldHVybiBuaWw7CiAg
ICAgCiAgICAgLy8gQWxsIGVsZW1lbnRzIHNob3VsZCBnZXQgU2hvd01lbnUgYW5kIFNjcm9sbFRv
VmlzaWJsZS4KKyAgICAvLyBCdXQgY2VydGFpbiBlYXJsaWVyIFZvaWNlT3ZlciB2ZXJzaW9ucyBk
byBub3Qgc3VwcG9ydCBzY3JvbGwgdG8gdmlzaWJsZSwgYW5kIGl0IGNvbmZ1c2VzIHRoZW0gdG8g
c2VlIGl0IGluIHRoZSBsaXN0LgorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQg
PCAxMDkwCisgICAgc3RhdGljIE5TQXJyYXkgKmRlZmF1bHRFbGVtZW50QWN0aW9ucyA9IFtbTlNB
cnJheSBhbGxvY10gaW5pdFdpdGhPYmplY3RzOk5TQWNjZXNzaWJpbGl0eVNob3dNZW51QWN0aW9u
LCBuaWxdOworI2Vsc2UKICAgICBzdGF0aWMgTlNBcnJheSAqZGVmYXVsdEVsZW1lbnRBY3Rpb25z
ID0gW1tOU0FycmF5IGFsbG9jXSBpbml0V2l0aE9iamVjdHM6TlNBY2Nlc3NpYmlsaXR5U2hvd01l
bnVBY3Rpb24sIE5TQWNjZXNzaWJpbGl0eVNjcm9sbFRvVmlzaWJsZUFjdGlvbiwgbmlsXTsKKyNl
bmRpZgogCiAgICAgLy8gQWN0aW9uIGVsZW1lbnRzIGFsbG93IFByZXNzLgogICAgIC8vIFRoZSBv
cmRlciBpcyBpbXBvcnRhbnQgdG8gVm9pY2VPdmVyLCB3aGljaCBleHBlY3RzIHRoZSAnZGVmYXVs
dCcgYWN0aW9uIHRvIGJlIHRoZSBmaXJzdCBhY3Rpb24uIEluIHRoaXMgY2FzZSB0aGUgZGVmYXVs
dCBhY3Rpb24gc2hvdWxkIGJlIHByZXNzLgorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR
VUlSRUQgPCAxMDkwCisgICAgc3RhdGljIE5TQXJyYXkgKmFjdGlvbkVsZW1lbnRBY3Rpb25zID0g
W1tOU0FycmF5IGFsbG9jXSBpbml0V2l0aE9iamVjdHM6TlNBY2Nlc3NpYmlsaXR5UHJlc3NBY3Rp
b24sIE5TQWNjZXNzaWJpbGl0eVNob3dNZW51QWN0aW9uLCBuaWxdOworI2Vsc2UKICAgICBzdGF0
aWMgTlNBcnJheSAqYWN0aW9uRWxlbWVudEFjdGlvbnMgPSBbW05TQXJyYXkgYWxsb2NdIGluaXRX
aXRoT2JqZWN0czpOU0FjY2Vzc2liaWxpdHlQcmVzc0FjdGlvbiwgTlNBY2Nlc3NpYmlsaXR5U2hv
d01lbnVBY3Rpb24sIE5TQWNjZXNzaWJpbGl0eVNjcm9sbFRvVmlzaWJsZUFjdGlvbiwgbmlsXTsK
KyNlbmRpZgogCiAgICAgLy8gTWVudSBlbGVtZW50cyBhbGxvdyBQcmVzcyBhbmQgQ2FuY2VsLgog
ICAgIHN0YXRpYyBOU0FycmF5ICptZW51RWxlbWVudEFjdGlvbnMgPSBbW2FjdGlvbkVsZW1lbnRB
Y3Rpb25zIGFycmF5QnlBZGRpbmdPYmplY3Q6TlNBY2Nlc3NpYmlsaXR5Q2FuY2VsQWN0aW9uXSBy
ZXRhaW5dOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91
dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ3ODE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDQtMDUgIENocmlzIEZs
ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogVm9pY2VPdmVyIGNh
bid0IHByZXNzIG9uIGl0ZW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xMTQwNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICAqIHBsYXRmb3JtL21hYy1mdXR1cmUvYWNjZXNzaWJpbGl0eTogQWRkZWQuCisg
ICAgICAgICogcGxhdGZvcm0vbWFjLWZ1dHVyZS9hY2Nlc3NpYmlsaXR5L3ByZXNzLWFjdGlvbi1p
cy1maXJzdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nl
c3NpYmlsaXR5L3ByZXNzLWFjdGlvbi1pcy1maXJzdC1leHBlY3RlZC50eHQ6CisKIDIwMTMtMDQt
MDUgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICB0
cnlDYWNoZUdldEJ5SUQgc2V0cyBTdHJ1Y3R1cmVTdHViSW5mbyBhY2Nlc3NUeXBlIHRvIGFuIGlu
Y29ycmVjdCB2YWx1ZQpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp
dHkvcHJlc3MtYWN0aW9uLWlzLWZpcnN0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv
dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9wcmVzcy1hY3Rpb24taXMtZmlyc3Qt
ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNDc3OTYpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t
YWMvYWNjZXNzaWJpbGl0eS9wcmVzcy1hY3Rpb24taXMtZmlyc3QtZXhwZWN0ZWQudHh0CSh3b3Jr
aW5nIGNvcHkpCkBAIC00LDggKzQsOCBAQAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy
aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAK
LUJ1dHRvbiBzdXBwb3J0ZWQgYWN0aW9uczogQVhQcmVzcyxBWFNob3dNZW51LEFYU2Nyb2xsVG9W
aXNpYmxlCi1MaW5rIHN1cHBvcnRlZCBhY3Rpb25zOiBBWFByZXNzLEFYU2hvd01lbnUsQVhTY3Jv
bGxUb1Zpc2libGUKK0J1dHRvbiBzdXBwb3J0ZWQgYWN0aW9uczogQVhQcmVzcyxBWFNob3dNZW51
CitMaW5rIHN1cHBvcnRlZCBhY3Rpb25zOiBBWFByZXNzLEFYU2hvd01lbnUKIFBBU1Mgc3VjY2Vz
c2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMv
cGxhdGZvcm0vbWFjLWZ1dHVyZS9hY2Nlc3NpYmlsaXR5L3ByZXNzLWFjdGlvbi1pcy1maXJzdC1l
eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWZ1dHVy
ZS9hY2Nlc3NpYmlsaXR5L3ByZXNzLWFjdGlvbi1pcy1maXJzdC1leHBlY3RlZC50eHQJKHJldmlz
aW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtZnV0dXJlL2FjY2Vzc2liaWxpdHkv
cHJlc3MtYWN0aW9uLWlzLWZpcnN0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr
MSwxMiBAQAorCitUaGlzIHRlc3RzIHRoYXQgdGhlIEFYUHJlc3NBY3Rpb24gY29tZXMgZmlyc3Qg
Zm9yIGFjdGl2YXRhYmxlIGl0ZW1zIGluc3RlYWQgb2YgdGhlIHNjcm9sbCB0byB2aXNpYmxlIGFj
dGlvbi4gVGhpcyBpcyBuZWVkZWQgZm9yIHNjcmVlbnJlYWRlcnMgdG8gb3BlcmF0ZSBjb3JyZWN0
bHkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn
ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitCdXR0b24gc3VwcG9ydGVkIGFj
dGlvbnM6IEFYUHJlc3MsQVhTaG93TWVudSxBWFNjcm9sbFRvVmlzaWJsZQorTGluayBzdXBwb3J0
ZWQgYWN0aW9uczogQVhQcmVzcyxBWFNob3dNZW51LEFYU2Nyb2xsVG9WaXNpYmxlCitQQVNTIHN1
Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>