114070 2013-04-05 15:41:51 -0700 Setting a header or footer should cause a relayout 2013-04-05 15:51:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin sam simon.fraser oldest_to_newest 870108 0 bdakin 2013-04-05 15:41:51 -0700 If a WebView is given a header or footer through API, we need to relayout the page. Otherwise, if a header/footer is added after the page has content, then space is not properly allocated for the header and footer, and hit testing is off. Part of <rdar://problem/13503637> 870109 1 196691 bdakin 2013-04-05 15:44:48 -0700 Created attachment 196691 Patch 870111 2 bdakin 2013-04-05 15:51:26 -0700 Thanks Sam! http://trac.webkit.org/changeset/147806 196691 2013-04-05 15:44:48 -0700 2013-04-05 15:50:08 -0700 Patch for-review.txt text/plain 1675 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NzgwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA0LTA1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTZXR0aW5nIGEgaGVhZGVyIG9yIGZv b3RlciBzaG91bGQgY2F1c2UgYSByZWxheW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MDcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFyayB0aGUgUmVuZGVyVmlldyBhcyBuZWVkaW5nIGxheW91 dCBpbiBvcmRlciB0byBhZGp1c3QgZXZlcnl0aGluZyBmb3IgdGhlIG5ldyAKKyAgICAgICAgaGVh ZGVyL2Zvb3Rlci4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lVmlldzo6c2V0SGVhZGVySGVpZ2h0KToKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lVmlldzo6c2V0Rm9vdGVySGVpZ2h0KToKKwogMjAxMy0wNC0wNSAgQ2hyaXMgRmxlaXphY2gg IDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBNYWtlIFNWRyBHcm91cCBjb250 YWluZXJzIGFjY2Vzc2libGUgZWxlbWVudHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAJKHJldmlzaW9uIDE0Nzc2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAkod29ya2luZyBjb3B5KQpAQCAtOTM1LDYgKzkzNSw5IEBAIHZvaWQgRnJhbWVWaWV3OjpzZXRI ZWFkZXJIZWlnaHQoaW50IGhlYWQKICAgICBpZiAobV9mcmFtZSAmJiBtX2ZyYW1lLT5wYWdlKCkp CiAgICAgICAgIEFTU0VSVChtX2ZyYW1lID09IG1fZnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCkp OwogICAgIG1faGVhZGVySGVpZ2h0ID0gaGVhZGVySGVpZ2h0OworCisgICAgaWYgKFJlbmRlclZp ZXcqIHJlbmRlclZpZXcgPSB0aGlzLT5yZW5kZXJWaWV3KCkpCisgICAgICAgIHJlbmRlclZpZXct PnNldE5lZWRzTGF5b3V0KHRydWUpOwogfQogCiB2b2lkIEZyYW1lVmlldzo6c2V0Rm9vdGVySGVp Z2h0KGludCBmb290ZXJIZWlnaHQpCkBAIC05NDIsNiArOTQ1LDkgQEAgdm9pZCBGcmFtZVZpZXc6 OnNldEZvb3RlckhlaWdodChpbnQgZm9vdAogICAgIGlmIChtX2ZyYW1lICYmIG1fZnJhbWUtPnBh Z2UoKSkKICAgICAgICAgQVNTRVJUKG1fZnJhbWUgPT0gbV9mcmFtZS0+cGFnZSgpLT5tYWluRnJh bWUoKSk7CiAgICAgbV9mb290ZXJIZWlnaHQgPSBmb290ZXJIZWlnaHQ7CisKKyAgICBpZiAoUmVu ZGVyVmlldyogcmVuZGVyVmlldyA9IHRoaXMtPnJlbmRlclZpZXcoKSkKKyAgICAgICAgcmVuZGVy Vmlldy0+c2V0TmVlZHNMYXlvdXQodHJ1ZSk7CiB9CiAKIGJvb2wgRnJhbWVWaWV3OjpoYXNDb21w b3NpdGVkQ29udGVudCgpIGNvbnN0Cg==