114061 2013-04-05 13:44:37 -0700 [GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp 2013-04-08 05:57:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jesus jesus benjamin cmarcelo commit-queue gergely gustavo kilvadyb ojan.autocc ossy webkit.review.bot oldest_to_newest 870053 0 jesus 2013-04-05 13:44:37 -0700 [GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp 870054 1 196675 jesus 2013-04-05 13:47:20 -0700 Created attachment 196675 Patch 870085 2 196675 commit-queue 2013-04-05 14:45:43 -0700 Comment on attachment 196675 Patch Clearing flags on attachment: 196675 Committed r147799: <http://trac.webkit.org/changeset/147799> 870086 3 commit-queue 2013-04-05 14:45:45 -0700 All reviewed patches have been landed. Closing bug. 870715 4 ossy 2013-04-08 05:40:27 -0700 (In reply to comment #2) > (From update of attachment 196675 [details]) > Clearing flags on attachment: 196675 > > Committed r147799: <http://trac.webkit.org/changeset/147799> It broke the Qt MIPS build. It seems Qt-MIPS port uses GLIB: /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()': /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/CurrentTime.cpp:298: error: 'g_get_monotonic_time' was not declared in this scope I cc-ed MIPS maintainters. 870717 5 ossy 2013-04-08 05:44:03 -0700 Not only MIPS, but Qt port uses GLIB if GStreamer is used. 870726 6 jesus 2013-04-08 05:54:11 -0700 (In reply to comment #5) > Not only MIPS, but Qt port uses GLIB if GStreamer is used. If Qt doesn't want to use the GLib implementation, being it for MIPS or not, then I can add a !PLATFORM(QT) there. What do you think? 870730 7 ossy 2013-04-08 05:57:16 -0700 (In reply to comment #6) > (In reply to comment #5) > > Not only MIPS, but Qt port uses GLIB if GStreamer is used. > > If Qt doesn't want to use the GLib implementation, being it for MIPS or not, then I can add a !PLATFORM(QT) there. > > What do you think? I exactly thought this fix and then landed in http://trac.webkit.org/changeset/147910 :) 196675 2013-04-05 13:47:20 -0700 2013-04-05 14:45:43 -0700 Patch bug-114061-20130405174454.patch text/plain 1698 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNhZmM3ZDdhZDIzNDYyZmFkNTIyMThi OWI4MzViMjFiNTllZWM5YTQuLmNmZWIzYTZkODk0MTgxNTJhOGU1MzE2MzExZDRhMjkyMjkxYjU4 OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDQtMDUgIEplc3VzIFNhbmNoZXotUGFsZW5j aWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtHVEtdIENoYW5n ZSBmcm9tIFBMQVRGT1JNKEdUSykgdG8gVVNFKEdMSUIpIGluIFdURi9DdXJyZW50VGltZS5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA2MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyBvdGhl ciBwb3J0cyB1c2luZyBHTGliIGNhbiB1c2UgdGhlIGNvcnJlY3QgaW1wbGVtZW50YXRpb24KKyAg ICAgICAgYW5kIG5vdCB0aGUgZmFsbGJhY2sgb25lIHdpdGhvdXQgYWRkaW5nIGFueSBvdGhlciBQ TEFURk9STSBndWFyZHMKKyAgICAgICAgaGVyZS4KKworICAgICAgICAqIHd0Zi9DdXJyZW50VGlt ZS5jcHA6CisgICAgICAgIChXVEYpOgorCiAyMDEzLTA0LTA1ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIG1vcmUgZGVhZCBDaHJvbWl1bSBj b2RlIGZyb20gV1RGCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9DdXJyZW50VGltZS5jcHAg Yi9Tb3VyY2UvV1RGL3d0Zi9DdXJyZW50VGltZS5jcHAKaW5kZXggMzAxNDM5NGE1MGU2NTk1OTg5 M2M1NDY2YjRlZWMxNzJkMTA4YzgwMi4uZTYxYjEzOGIyZmUyZjMzMjBlOGE5OGUyNmQwZmE5MGI3 OTVkNDE2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ3VycmVudFRpbWUuY3BwCisrKyBi L1NvdXJjZS9XVEYvd3RmL0N1cnJlbnRUaW1lLmNwcApAQCAtNTUsNyArNTUsNyBAQAogI2luY2x1 ZGUgPHN5cy90aW1lLmg+CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKEdUSykKKyNpZiBVU0UoR0xJ QikgJiYgIVBMQVRGT1JNKEVGTCkKICNpbmNsdWRlIDxnbGliLmg+CiAjZW5kaWYKIApAQCAtMjIy LDcgKzIyMiw3IEBAIGRvdWJsZSBjdXJyZW50VGltZSgpCiAKICNlbmRpZiAvLyBVU0UoUVVFUllf UEVSRk9STUFOQ0VfQ09VTlRFUikKIAotI2VsaWYgUExBVEZPUk0oR1RLKQorI2VsaWYgVVNFKEdM SUIpICYmICFQTEFURk9STShFRkwpCiAKIC8vIE5vdGU6IEdUSyBvbiBXaW5kb3dzIHdpbGwgcGlj ayB1cCB0aGUgUExBVEZPUk0oV0lOKSBpbXBsZW1lbnRhdGlvbiBhYm92ZSB3aGljaCBwcm92aWRl cwogLy8gYmV0dGVyIGFjY3VyYWN5IGNvbXBhcmVkIHdpdGggV2luZG93cyBpbXBsZW1lbnRhdGlv biBvZiBnX2dldF9jdXJyZW50X3RpbWU6CkBAIC0yOTEsNyArMjkxLDcgQEAgZG91YmxlIG1vbm90 b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpCiAgICAgcmV0dXJuIGVjb3JlX3RpbWVfZ2V0KCk7CiB9 CiAKLSNlbGlmIFBMQVRGT1JNKEdUSykKKyNlbGlmIFVTRShHTElCKSAmJiAhUExBVEZPUk0oRUZM KQogCiBkb3VibGUgbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkKIHsK