114054 2013-04-05 12:48:45 -0700 hang in mediaSelectionGroupForMediaCharacteristic 2013-04-09 16:50:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble eric.carlson webkit.review.bot oldest_to_newest 869963 0 jer.noble 2013-04-05 12:48:45 -0700 hang in mediaSelectionGroupForMediaCharacteristic 869964 1 jer.noble 2013-04-05 12:49:00 -0700 <rdar://problem/13558774> 869975 2 196671 jer.noble 2013-04-05 12:57:27 -0700 Created attachment 196671 Patch 870187 3 196671 eric.carlson 2013-04-05 18:44:11 -0700 Comment on attachment 196671 Patch Nicely done! 872363 4 jer.noble 2013-04-09 16:50:58 -0700 Committed r148064: <http://trac.webkit.org/changeset/148064> 196671 2013-04-05 12:57:27 -0700 2013-04-05 18:44:10 -0700 Patch bug-114054-20130405125714.patch text/plain 6251 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjUzMjc4OGJiNjRiYTg4 YzE1YjU4YjU5OTU3MDAxODg4YWYwYmM0MC4uNDk0MGRkYzc3ZWIwNTYxZTUzOTE3NzcyODNkZTU2 NmU1MzRiZmY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEzLTA0LTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIGhhbmcgaW4gbWVkaWFTZWxl Y3Rpb25Hcm91cEZvck1lZGlhQ2hhcmFjdGVyaXN0aWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgRml4ZXMgc3BvcmFkaWMgaGFu Z3MgaW4gbWVkaWEvIHRlc3RzLgorCisgICAgICAgIC1bQVZVUkxBc3NldCBtZWRpYVNlbGVjdGlv bkdyb3VwRm9yTWVkaWFDaGFyYWN0ZXJpc3RpYzpdIGNhbiBkZWFkbG9jayBpbiBjZXJ0YWluIHNp dHVhdGlvbnM6IFdoZW4gQVZVUkxBc3NldAorICAgICAgICBwb3N0cyBhIHN5bmNocm9ub3VzIEFW QXNzZXRSZXNvdXJjZUxvYWRlciBub3RpZmljYXRpb24gdG8gdGhlIG1haW4gdGhyZWFkLCBjYWxs aW5nIC1tZWRpYVNlbGVjdGlvbkdyb3VwRm9yTWVkaWFDaGFyYWN0ZXJpc3RpYzoKKyAgICAgICAg b24gdGhlIG1haW4gdGhyZWFkIHJlcXVpcmVzIElPIHRvIG9jY3VyIGlmIHRoZSBtZWRpYSBjaGFy YWN0ZXJpc3RpY3MgYXJlIG5vdCB5ZXQgbG9hZGVkLiBJbnN0ZWFkIG9mIGJsb2NraW5nLAorICAg ICAgICBiYWlsIG91dCBlYXJseSBpZiB0aGUgbWVkaWEgY2hhcmFjdGVyaXN0aWNzIGFyZSBub3Qg eWV0IGtub3duLgorICAgICAgICAKKyAgICAgICAgQWRkIGEgbmV3IG1ldGhvZCwgc2FmZU1lZGlh U2VsZWN0aW9uR3JvdXBGb3JMZWdpYmxlTWVkaWEoKSwgd2hpY2ggZmlyc3QgY2hlY2tzIHNlbGVj dGlvbiBncm91cCBhdmFpbGFiaWxpdHkKKyAgICAgICAgYmVmb3JlIGNhbGxpbmcgbWVkaWFTZWxl Y3Rpb25Hcm91cEZvck1lZGlhQ2hhcmFjdGVyaXN0aWM6LgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9u T2JqQy5oOgorICAgICAgICAoTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQyk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVy UHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnNhZmVNZWRpYVNlbGVjdGlvbkdyb3VwRm9yTGVnaWJs ZU1lZGlhKTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZv dW5kYXRpb25PYmpDOjpjcmVhdGVBVlBsYXllckl0ZW0pOiBVc2UgbmV3IHNhZmUgbWV0aG9kLgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dHJh Y2tzQ2hhbmdlZCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uT2JqQzo6cHJvY2Vzc1RleHRUcmFja3MpOiBEaXR0by4KKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnNldEN1cnJlbnRUcmFj ayk6IERpdHRvLgorCiAyMDEzLTA0LTA0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgdGhlIGd5cCBidWlsZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0 aW9uT2JqQy5oCmluZGV4IDlkNGViNjQzZWM3YzY5N2MzMDdmMGZlYzMzODFlYTk4NWM1MjllZTUu LmVkMzI2M2M2OWFjNTUwNjA4Y2M0ZWNkYTQ2NmNhZjdkOTNkMzI2M2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxh eWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b25PYmpDLmgKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogCiBP QkpDX0NMQVNTIEFWVVJMQXNzZXQ7CitPQkpDX0NMQVNTIEFWTWVkaWFTZWxlY3Rpb25Hcm91cDsK IE9CSkNfQ0xBU1MgQVZQbGF5ZXI7CiBPQkpDX0NMQVNTIEFWUGxheWVySXRlbTsKIE9CSkNfQ0xB U1MgQVZQbGF5ZXJJdGVtTGVnaWJsZU91dHB1dDsKQEAgLTE2NCw2ICsxNjUsNyBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgSW5iYW5kVGV4dFRyYWNrUHJpdmF0ZUFWRiogY3VycmVudFRyYWNrKCkg T1ZFUlJJREU7CiAgICAgdm9pZCBwcm9jZXNzVGV4dFRyYWNrcygpOwogICAgIHZvaWQgY2xlYXJU ZXh0VHJhY2tzKCk7CisgICAgQVZNZWRpYVNlbGVjdGlvbkdyb3VwKiBzYWZlTWVkaWFTZWxlY3Rp b25Hcm91cEZvckxlZ2libGVNZWRpYSgpOwogI2VuZGlmCiAKICAgICBSZXRhaW5QdHI8QVZVUkxB c3NldD4gbV9hdkFzc2V0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KaW5kZXggY2I1YzIxMDM5MGQw ZWI5NTQwOWI3ZGY3MjQxMzA3YmYzZDA1MzFkNi4uM2FkNDkxNjhkNjA2ZWVhZWVkOGQ4YjYyZjQ1 OTcxN2I4YTllNmU2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCkBAIC00NjYsNyArNDY2LDcg QEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpjcmVhdGVBVlBsYXll ckl0ZW0oKQogCiAgICAgLy8gV2UgZW5hYmxlZCBhdXRvbWF0aWMgbWVkaWEgc2VsZWN0aW9uIGJl Y2F1c2Ugd2Ugd2FudCBhbHRlcm5hdGUgYXVkaW8gdHJhY2tzIHRvIGJlIGVuYWJsZWQvZGlzYWJs ZWQgYXV0b21hdGljYWxseSwKICAgICAvLyBidXQgc2V0IHRoZSBzZWxlY3RlZCBsZWdpYmxlIHRy YWNrIHRvIG5pbCBzbyB0ZXh0IHRyYWNrcyB3aWxsIG5vdCBiZSBhdXRvbWF0aWNhbGx5IGNvbmZp Z3VyZWQuCi0gICAgW21fYXZQbGF5ZXJJdGVtLmdldCgpIHNlbGVjdE1lZGlhT3B0aW9uOm5pbCBp bk1lZGlhU2VsZWN0aW9uR3JvdXA6W21fYXZBc3NldC5nZXQoKSBtZWRpYVNlbGVjdGlvbkdyb3Vw Rm9yTWVkaWFDaGFyYWN0ZXJpc3RpYzpBVk1lZGlhQ2hhcmFjdGVyaXN0aWNMZWdpYmxlXV07Cisg ICAgW21fYXZQbGF5ZXJJdGVtLmdldCgpIHNlbGVjdE1lZGlhT3B0aW9uOm5pbCBpbk1lZGlhU2Vs ZWN0aW9uR3JvdXA6c2FmZU1lZGlhU2VsZWN0aW9uR3JvdXBGb3JMZWdpYmxlTWVkaWEoKV07CiAK ICAgICBbbV9sZWdpYmxlT3V0cHV0LmdldCgpIHNldERlbGVnYXRlOm1fb2JqY09ic2VydmVyLmdl dCgpIHF1ZXVlOmRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCldOwogICAgIFttX2xlZ2libGVPdXRw dXQuZ2V0KCkgc2V0QWR2YW5jZUludGVydmFsRm9yRGVsZWdhdGVJbnZvY2F0aW9uOmxlZ2libGVP dXRwdXRBZHZhbmNlSW50ZXJ2YWxdOwpAQCAtOTg0LDcgKzk4NCw3IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dHJhY2tzQ2hhbmdlZCgpCiAKICNpZiBIQVZFKEFW Rk9VTkRBVElPTl9URVhUX1RSQUNLX1NVUFBPUlQpCiAgICAgaWYgKCFoYXNDYXB0aW9ucyAmJiBt X2xlZ2libGVPdXRwdXQpIHsKLSAgICAgICAgQVZNZWRpYVNlbGVjdGlvbkdyb3VwVHlwZSAqbGVn aWJsZUdyb3VwID0gW21fYXZBc3NldC5nZXQoKSBtZWRpYVNlbGVjdGlvbkdyb3VwRm9yTWVkaWFD aGFyYWN0ZXJpc3RpYzpBVk1lZGlhQ2hhcmFjdGVyaXN0aWNMZWdpYmxlXTsKKyAgICAgICAgQVZN ZWRpYVNlbGVjdGlvbkdyb3VwVHlwZSAqbGVnaWJsZUdyb3VwID0gc2FmZU1lZGlhU2VsZWN0aW9u R3JvdXBGb3JMZWdpYmxlTWVkaWEoKTsKICAgICAgICAgaGFzQ2FwdGlvbnMgPSBbW0FWTWVkaWFT ZWxlY3Rpb25Hcm91cCBwbGF5YWJsZU1lZGlhU2VsZWN0aW9uT3B0aW9uc0Zyb21BcnJheTpbbGVn aWJsZUdyb3VwIG9wdGlvbnNdXSBjb3VudF07CiAgICAgfQogICAgIGlmIChoYXNDYXB0aW9ucykK QEAgLTEyOTUsOSArMTI5NSwyMCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakM6OmNsZWFyVGV4dFRyYWNrcygpCiAgICAgbV90ZXh0VHJhY2tzLmNsZWFyKCk7CiB9CiAK K0FWTWVkaWFTZWxlY3Rpb25Hcm91cFR5cGUqIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bk9iakM6OnNhZmVNZWRpYVNlbGVjdGlvbkdyb3VwRm9yTGVnaWJsZU1lZGlhKCkKK3sKKyAgICBp ZiAoIW1fYXZBc3NldCkKKyAgICAgICAgcmV0dXJuIG5pbDsKKworICAgIGlmIChbbV9hdkFzc2V0 LmdldCgpIHN0YXR1c09mVmFsdWVGb3JLZXk6QCJhdmFpbGFibGVNZWRpYUNoYXJhY3RlcmlzdGlj c1dpdGhNZWRpYVNlbGVjdGlvbk9wdGlvbnMiIGVycm9yOk5VTExdICE9IEFWS2V5VmFsdWVTdGF0 dXNMb2FkZWQpCisgICAgICAgIHJldHVybiBuaWw7CisKKyAgICByZXR1cm4gW21fYXZBc3NldC5n ZXQoKSBtZWRpYVNlbGVjdGlvbkdyb3VwRm9yTWVkaWFDaGFyYWN0ZXJpc3RpYzpBVk1lZGlhQ2hh cmFjdGVyaXN0aWNMZWdpYmxlXTsKK30KKwogdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb25PYmpDOjpwcm9jZXNzVGV4dFRyYWNrcygpCiB7Ci0gICAgQVZNZWRpYVNlbGVjdGlvbkdy b3VwVHlwZSAqbGVnaWJsZUdyb3VwID0gW21fYXZBc3NldC5nZXQoKSBtZWRpYVNlbGVjdGlvbkdy b3VwRm9yTWVkaWFDaGFyYWN0ZXJpc3RpYzpBVk1lZGlhQ2hhcmFjdGVyaXN0aWNMZWdpYmxlXTsK KyAgICBBVk1lZGlhU2VsZWN0aW9uR3JvdXBUeXBlICpsZWdpYmxlR3JvdXAgPSBzYWZlTWVkaWFT ZWxlY3Rpb25Hcm91cEZvckxlZ2libGVNZWRpYSgpOwogICAgIGlmICghbGVnaWJsZUdyb3VwKSB7 CiAgICAgICAgIExPRyhNZWRpYSwgIk1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6 OnByb2Nlc3NUZXh0VHJhY2tzKCVwKSAtIG5pbCBtZWRpYVNlbGVjdGlvbkdyb3VwIiwgdGhpcyk7 CiAgICAgICAgIHJldHVybjsKQEAgLTEzNjcsNyArMTM3OCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6c2V0Q3VycmVudFRyYWNrKEluYmFuZFRleHRUcmFja1By aXZhdGVBCiAKICAgICBMT0coTWVkaWEsICJNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDOjpzZXRDdXJyZW50VHJhY2soJXApIC0gc2VsZWN0aW5nIG1lZGlhIG9wdGlvbiAlcCIsIHRo aXMsIG1lZGlhU2VsZWN0aW9uT3B0aW9uKTsKIAotICAgIFttX2F2UGxheWVySXRlbS5nZXQoKSBz ZWxlY3RNZWRpYU9wdGlvbjptZWRpYVNlbGVjdGlvbk9wdGlvbiBpbk1lZGlhU2VsZWN0aW9uR3Jv dXA6W21fYXZBc3NldC5nZXQoKSBtZWRpYVNlbGVjdGlvbkdyb3VwRm9yTWVkaWFDaGFyYWN0ZXJp c3RpYzpBVk1lZGlhQ2hhcmFjdGVyaXN0aWNMZWdpYmxlXV07CisgICAgW21fYXZQbGF5ZXJJdGVt LmdldCgpIHNlbGVjdE1lZGlhT3B0aW9uOm1lZGlhU2VsZWN0aW9uT3B0aW9uIGluTWVkaWFTZWxl Y3Rpb25Hcm91cDpzYWZlTWVkaWFTZWxlY3Rpb25Hcm91cEZvckxlZ2libGVNZWRpYSgpXTsKICAg ICBtX2N1cnJlbnRUcmFjayA9IHRyYWNrUHJpdmF0ZTsKIH0KIAo=