114046 2013-04-05 11:00:06 -0700 [GStreamer] Segfault when attempting to install missing plugins 2013-04-05 12:43:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 b.long webkit-unassigned b.long commit-queue eric.carlson gustavo jer.noble menard mrobinson pnormand webkit-ews webkit.review.bot oldest_to_newest 869879 0 b.long 2013-04-05 11:00:06 -0700 [GStreamer] Segfault when attempting to install missing plugins 869883 1 196654 b.long 2013-04-05 11:07:01 -0700 Created attachment 196654 Patch 869885 2 b.long 2013-04-05 11:08:26 -0700 GStreamer 1.0: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-gstpbutilsinstallplugins.html#gst-install-plugins-async GStreamer 0.10: https://developer.gnome.org/gst-plugins-libs/0.10/gst-plugins-base-libs-gstpbutilsinstallplugins.html#gst-install-plugins-async 869887 3 196654 webkit-ews 2013-04-05 11:11:27 -0700 Comment on attachment 196654 Patch Attachment 196654 did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17438314 869890 4 196654 webkit-ews 2013-04-05 11:13:10 -0700 Comment on attachment 196654 Patch Attachment 196654 did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17442277 869897 5 b.long 2013-04-05 11:17:45 -0700 Nevermind, I read this wrong. 869898 6 b.long 2013-04-05 11:18:41 -0700 I do get a segfault here though, so I'm still trying to figure out why. 869901 7 b.long 2013-04-05 11:26:03 -0700 I guess this was added in bug #34085. I get segfaults on both Ubuntu and Fedora 18, using QtWebKit with GStreamer 1.0 if I open a page that requires plugins I don't have (specifically, a .ogv file with kate subtitles). I'm waiting for a build to finish so I get more details. 869904 8 196656 b.long 2013-04-05 11:36:27 -0700 Created attachment 196656 Backtrace 869915 9 196654 pnormand 2013-04-05 11:47:17 -0700 Comment on attachment 196654 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196654&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:783 > +#ifdef GST_API_VERSION_1 You mean ifndef I suppose? 869916 10 pnormand 2013-04-05 11:48:48 -0700 Well the details argument is a list of strings in 0.10 and 1.0... The backtrace is interesting though, which exact release of GStreamer is this? 869917 11 b.long 2013-04-05 11:50:22 -0700 That patch was actually completely wrong. I saw that gchar** turned into const gchar * const and didn't notice that there was one more *. I think the real problem is that we're not null terminating the array. (In reply to comment #10) > Well the details argument is a list of strings in 0.10 and 1.0... The backtrace is interesting though, which exact release of GStreamer is this? The backtrace is from 1.0.6, but I think it occurs on 1.0.5 too (and probably 0.10 looking at the documentation). 869930 12 196662 b.long 2013-04-05 11:56:34 -0700 Created attachment 196662 Patch 869935 13 196663 b.long 2013-04-05 12:02:35 -0700 Created attachment 196663 Patch 869936 14 b.long 2013-04-05 12:04:01 -0700 (In reply to comment #13) > Created an attachment (id=196663) [details] > Patch This patch is because there was a style issue (detail_array instead of detailAray) and I didn't fix it correctly in the first patch. This patch fixes the problem for me. 869951 15 196663 pnormand 2013-04-05 12:28:10 -0700 Comment on attachment 196663 Patch Good catch Brendan! I wonder indeed how I didn't get this crash during the tests I did while writing the codec-installer patch. 869956 16 196663 commit-queue 2013-04-05 12:43:30 -0700 Comment on attachment 196663 Patch Clearing flags on attachment: 196663 Committed r147787: <http://trac.webkit.org/changeset/147787> 869957 17 commit-queue 2013-04-05 12:43:33 -0700 All reviewed patches have been landed. Closing bug. 196654 2013-04-05 11:07:01 -0700 2013-04-05 11:47:17 -0700 Patch bug-114046-20130405120647.patch text/plain 2034 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FmMWE4ZTYxYTdkNTY3 YTY1M2JlZjU1NzU1MjJmMTExZGVmZTRjYi4uM2ZhNDYxNzAxNDUzMzBmYzY5YTFiOGFiZGY2Zjcz NTdjMGQ5ZTQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTA1ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBT ZWdmYXVsdCB3aGVuIGF0dGVtcHRpbmcgdG8gaW5zdGFsbCBtaXNzaW5nIHBsdWdpbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA0NgorCisgICAg ICAgIEluIEdTdHJlYW1lciAxLjAsIGdzdF9pbnN0YWxsX3BsdWdpbnNfYXN5bmMgdGFrZXMgYSBw b2ludGVyIGluc3RlYWQgb2YgYSBwb2ludGVyCisgICAgICAgIHRvIGEgcG9pbnRlci4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMg YmVjYXVzZSB0aGlzIGp1c3QgZml4ZXMgYW4gaXNzdWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZSk6 CisKIDIwMTMtMDQtMDUgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgZGVhZCBDaHJvbWl1bSBjb2RlIGZyb20gV2ViQ29yZS93b3JrZXJzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDJl YTU2YmJmZjg1OGY4OTQ2MzUwZGJkMDUzNTRjMTU3ZjRhZjQ0MzkuLjMwYmQ0OGRhOTQ2ZWE0ZjBm OWI0NTc2ZjZlY2QxYjA4NjBjYTNmYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC03ODAsNyArNzgwLDExIEBAIGdib29sZWFuIE1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdl KQogICAgIGNhc2UgR1NUX01FU1NBR0VfRUxFTUVOVDoKICAgICAgICAgaWYgKGdzdF9pc19taXNz aW5nX3BsdWdpbl9tZXNzYWdlKG1lc3NhZ2UpKSB7CiAgICAgICAgICAgICBnY2hhciogZGV0YWls ID0gZ3N0X21pc3NpbmdfcGx1Z2luX21lc3NhZ2VfZ2V0X2luc3RhbGxlcl9kZXRhaWwobWVzc2Fn ZSk7CisjaWZkZWYgR1NUX0FQSV9WRVJTSU9OXzEKKyAgICAgICAgICAgIEdzdEluc3RhbGxQbHVn aW5zUmV0dXJuIHJlc3VsdCA9IGdzdF9pbnN0YWxsX3BsdWdpbnNfYXN5bmMoZGV0YWlsLCAwLCBt ZWRpYVBsYXllclByaXZhdGVQbHVnaW5JbnN0YWxsZXJSZXN1bHRGdW5jdGlvbiwgdGhpcyk7Cisj ZWxzZQogICAgICAgICAgICAgR3N0SW5zdGFsbFBsdWdpbnNSZXR1cm4gcmVzdWx0ID0gZ3N0X2lu c3RhbGxfcGx1Z2luc19hc3luYygmZGV0YWlsLCAwLCBtZWRpYVBsYXllclByaXZhdGVQbHVnaW5J bnN0YWxsZXJSZXN1bHRGdW5jdGlvbiwgdGhpcyk7CisjZW5kaWYKICAgICAgICAgICAgIG1fbWlz c2luZ1BsdWdpbnMgPSByZXN1bHQgPT0gR1NUX0lOU1RBTExfUExVR0lOU19TVEFSVEVEX09LOwog ICAgICAgICAgICAgZ19mcmVlKGRldGFpbCk7CiAgICAgICAgIH0K 196656 2013-04-05 11:36:27 -0700 2013-04-05 11:36:27 -0700 Backtrace backtrace.log text/x-log 3559 b.long IzAgIDB4MDAwMDAwMzBjMDUyZmJkYSBpbiBfX3N0cmNtcF9zc2U0MiAoKSBmcm9tIC9saWI2NC9s aWJjLnNvLjYKIzEgIDB4MDAwMDAwM2Y3ZTIxMTZjOCBpbiBwdHJfYXJyYXlfY29udGFpbnNfc3Ry aW5nIChhcnI9MHhhMmVjMDAsIHM9CiAgICAweDFlMGZmZmZkNDIwIDxBZGRyZXNzIDB4MWUwZmZm ZmQ0MjAgb3V0IG9mIGJvdW5kcz4pIGF0IGluc3RhbGwtcGx1Z2lucy5jOjQ4NQojMiAgZ3N0X2lu c3RhbGxfcGx1Z2luc19zcGF3bl9jaGlsZCAoZGV0YWlscz0weDdmZmZmZmZmZDNmMCwgZGV0YWls c0BlbnRyeT0weDdmZmZmZmZmZDNlOCwgCiAgICBjdHg9Y3R4QGVudHJ5PTB4MCwgY2hpbGRfcGlk PWNoaWxkX3BpZEBlbnRyeT0weDdmZmZmZmZmZDM3YywgZXhpdF9zdGF0dXM9ZXhpdF9zdGF0dXNA ZW50cnk9MHgwKQogICAgYXQgaW5zdGFsbC1wbHVnaW5zLmM6NTEzCiMzICAweDAwMDAwMDNmN2Uy MTFhMzUgaW4gZ3N0X2luc3RhbGxfcGx1Z2luc19hc3luYyAoZGV0YWlscz0weDdmZmZmZmZmZDNl OCwgY3R4PTB4MCwgZnVuYz0KICAgIDB4N2ZmZmY1NDg3MmM3IDxXZWJDb3JlOjptZWRpYVBsYXll clByaXZhdGVQbHVnaW5JbnN0YWxsZXJSZXN1bHRGdW5jdGlvbihHc3RJbnN0YWxsUGx1Z2luc1Jl dHVybiwgZ3BvaW50ZXIpPiwgdXNlcl9kYXRhPTB4N2Y0M2QwKSBhdCBpbnN0YWxsLXBsdWdpbnMu Yzo2MzkKIzQgIDB4MDAwMDdmZmZmNTQ4YWIzMyBpbiBXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6OmhhbmRsZU1lc3NhZ2UgKHRoaXM9MHg3ZjQzZDAsIG1lc3NhZ2U9CiAgICAw eDdmZmU4NDAwMjAzMCkKICAgIGF0IC9ob21lL2JyZW5kYW4vd29ya3NwYWNlL3dlYmtpdC9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcDo3ODMKIzUgIDB4MDAwMDdmZmZmNTQ4NzFkYSBpbiBXZWJDb3JlOjptZWRp YVBsYXllclByaXZhdGVNZXNzYWdlQ2FsbGJhY2sgKG1lc3NhZ2U9MHg3ZmZlODQwMDIwMzAsIHBs YXllcj0KICAgIDB4N2Y0M2QwKQogICAgYXQgL2hvbWUvYnJlbmRhbi93b3Jrc3BhY2Uvd2Via2l0 L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIuY3BwOjg4CiM2ICAweDAwMDAwMDNlMjY4MTJhOWUgaW4gZ19jY2xvc3Vy ZV9tYXJzaGFsX1ZPSURfX0JPWEVEdiAoY2xvc3VyZT0weGEwMGM1MCwgCiAgICByZXR1cm5fdmFs dWU9PG9wdGltaXplZCBvdXQ+LCBpbnN0YW5jZT0weDljNjU4MCwgYXJncz08b3B0aW1pemVkIG91 dD4sIAogICAgbWFyc2hhbF9kYXRhPTxvcHRpbWl6ZWQgb3V0Piwgbl9wYXJhbXM9PG9wdGltaXpl ZCBvdXQ+LCBwYXJhbV90eXBlcz0weDg1NjUwMCkgYXQgZ21hcnNoYWwuYzoxMTYwCiM3ICAweDAw MDAwMDNlMjY4MGZiZDcgaW4gX2dfY2xvc3VyZV9pbnZva2VfdmEgKGNsb3N1cmU9Y2xvc3VyZUBl bnRyeT0weGEwMGM1MCwgCiAgICByZXR1cm5fdmFsdWU9cmV0dXJuX3ZhbHVlQGVudHJ5PTB4MCwg aW5zdGFuY2U9aW5zdGFuY2VAZW50cnk9MHg5YzY1ODAsIGFyZ3M9YXJnc0BlbnRyeT0KICAgIDB4 N2ZmZmZmZmZkODA4LCBuX3BhcmFtcz0xLCBwYXJhbV90eXBlcz0weDg1NjUwMCkgYXQgZ2Nsb3N1 cmUuYzo4NDAKIzggIDB4MDAwMDAwM2UyNjgyODNhOCBpbiBnX3NpZ25hbF9lbWl0X3ZhbGlzdCAo aW5zdGFuY2U9MHg5YzY1ODAsIHNpZ25hbF9pZD08b3B0aW1pemVkIG91dD4sIGRldGFpbD0KICAg IDQwNiwgdmFyX2FyZ3M9dmFyX2FyZ3NAZW50cnk9MHg3ZmZmZmZmZmQ4MDgpIGF0IGdzaWduYWwu YzozMjExCiM5ICAweDAwMDAwMDNlMjY4MjhkZTIgaW4gZ19zaWduYWxfZW1pdCAoaW5zdGFuY2U9 aW5zdGFuY2VAZW50cnk9MHg5YzY1ODAsIHNpZ25hbF9pZD08b3B0aW1pemVkIG91dD4sIAogICAg ZGV0YWlsPTxvcHRpbWl6ZWQgb3V0PikgYXQgZ3NpZ25hbC5jOjMzNTYKIzEwIDB4MDAwMDAwM2Y3 Y2UzOGQ0MiBpbiBnc3RfYnVzX2FzeW5jX3NpZ25hbF9mdW5jIChidXM9MHg5YzY1ODAgW0dzdEJ1 c10sIG1lc3NhZ2U9MHg3ZmZlODQwMDIwMzAsIAogICAgZGF0YT08b3B0aW1pemVkIG91dD4pIGF0 IGdzdGJ1cy5jOjExMjYKIzExIDB4MDAwMDAwM2Y3Y2UzOTk1NyBpbiBnc3RfYnVzX3NvdXJjZV9k aXNwYXRjaCAoc291cmNlPXNvdXJjZUBlbnRyeT0weGEwMGI2MCwgY2FsbGJhY2s9CiAgICAweDNm N2NlMzhjYzAgPGdzdF9idXNfYXN5bmNfc2lnbmFsX2Z1bmM+LCB1c2VyX2RhdGE9MHgwKSBhdCBn c3RidXMuYzo3NzMKIzEyIDB4MDAwMDAwM2UyNjA0N2E1NSBpbiBnX21haW5fZGlzcGF0Y2ggKGNv bnRleHQ9MHg2NjE2MDApIGF0IGdtYWluLmM6MjcxNQojMTMgZ19tYWluX2NvbnRleHRfZGlzcGF0 Y2ggKGNvbnRleHQ9Y29udGV4dEBlbnRyeT0weDY2MTYwMCkgYXQgZ21haW4uYzozMjE5CiMxNCAw eDAwMDAwMDNlMjYwNDdkODggaW4gZ19tYWluX2NvbnRleHRfaXRlcmF0ZSAoY29udGV4dD1jb250 ZXh0QGVudHJ5PTB4NjYxNjAwLCBibG9jaz1ibG9ja0BlbnRyeT0xLCAKICAgIGRpc3BhdGNoPWRp c3BhdGNoQGVudHJ5PTEsIHNlbGY9PG9wdGltaXplZCBvdXQ+KSBhdCBnbWFpbi5jOjMyOTAKIzE1 IDB4MDAwMDAwM2UyNjA0N2U0NCBpbiBnX21haW5fY29udGV4dF9pdGVyYXRpb24gKGNvbnRleHQ9 MHg2NjE2MDAsIG1heV9ibG9jaz0xKSBhdCBnbWFpbi5jOjMzNTEKIzE2IDB4MDAwMDdmZmZlZGZh YzQ1YyBpbiBRRXZlbnREaXNwYXRjaGVyR2xpYjo6cHJvY2Vzc0V2ZW50cyhRRmxhZ3M8UUV2ZW50 TG9vcDo6UHJvY2Vzc0V2ZW50c0ZsYWc+KSAoKQogICBmcm9tIC9ob21lL2JyZW5kYW4vd29ya3Nw YWNlL3F0NS10b29scy9xdHNkay9xdGJhc2UvbGliL2xpYlF0NUNvcmUuc28uNQojMTcgMHgwMDAw N2ZmZmVkZjYzZmRiIGluIFFFdmVudExvb3A6OmV4ZWMoUUZsYWdzPFFFdmVudExvb3A6OlByb2Nl c3NFdmVudHNGbGFnPikgKCkKICAgZnJvbSAvaG9tZS9icmVuZGFuL3dvcmtzcGFjZS9xdDUtdG9v bHMvcXRzZGsvcXRiYXNlL2xpYi9saWJRdDVDb3JlLnNvLjUKIzE4IDB4MDAwMDdmZmZlZGY2Nzkw MCBpbiBRQ29yZUFwcGxpY2F0aW9uOjpleGVjKCkgKCkKICAgZnJvbSAvaG9tZS9icmVuZGFuL3dv cmtzcGFjZS9xdDUtdG9vbHMvcXRzZGsvcXRiYXNlL2xpYi9saWJRdDVDb3JlLnNvLjUKIzE5IDB4 MDAwMDAwMDAwMDQyNzNmZSBpbiBsYXVuY2hlck1haW4gKGFwcD0uLi4pCiAgICBhdCAvaG9tZS9i cmVuZGFuL3dvcmtzcGFjZS93ZWJraXQvVG9vbHMvUXRUZXN0QnJvd3Nlci9xdHRlc3Ricm93c2Vy LmNwcDo0OQojMjAgMHgwMDAwMDAwMDAwNDI5MDFmIGluIG1haW4gKGFyZ2M9MiwgYXJndj0weDdm ZmZmZmZmZGVhOCkKICAgIGF0IC9ob21lL2JyZW5kYW4vd29ya3NwYWNlL3dlYmtpdC9Ub29scy9R dFRlc3RCcm93c2VyL3F0dGVzdGJyb3dzZXIuY3BwOjMxOApxdWl0CkEgZGVidWdnaW5nIHNlc3Np b24gaXMgYWN0aXZlLgoKCUluZmVyaW9yIDEgW3Byb2Nlc3MgMjQwMDVdIHdpbGwgYmUga2lsbGVk LgoKUXVpdCBhbnl3YXk/ICh5IG9yIG4pIA== 196662 2013-04-05 11:56:34 -0700 2013-04-05 12:02:28 -0700 Patch bug-114046-20130405125621.patch text/plain 2083 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE0YWRmNDRhNzY3MWM5 MzMzOGU3MjNhZTkyNmZlZmZjYmNjMjY4Ny4uNWUwZTlhOWY5ZTFiNDc4ZWE5NDUwYTY4MGM2MTc3 Yjg2M2JhYTVlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTA1ICBCcmVu ZGFuIExvbmcgIDxzZWxmQGJyZW5kYW5sb25nLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBT ZWdmYXVsdCB3aGVuIGF0dGVtcHRpbmcgdG8gaW5zdGFsbCBtaXNzaW5nIHBsdWdpbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA0NgorICAgICAg ICAKKyAgICAgICAgZ3N0X2luc3RhbGxfcGx1Z2luc19hc3luYyBleHBlY3RzIGEgbnVsbCB0ZXJt aW5hdGVkIGxpc3QsIGJ1dCB3ZSB3ZXJlbid0CisgICAgICAgIGFkZGluZyBhIG51bGwgdGVybWlu YXRvci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMgc2luY2UgdGhpcyBqdXN0IGZpeGVzIGEgc2VnZmF1bHQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFu ZGxlTWVzc2FnZSk6CisKIDIwMTMtMDQtMDUgIE5vYW0gUm9zZW50aGFsICA8bm9hbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtUZXhtYXBdIGNzczMvZmlsdGVycy9maWx0ZXItYW5pbWF0aW9uLWZy b20tbm9uZS1ody5odG1sIGRvZXMgbm90IGFuaW1hdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMmVhNTZiYmZmODU4Zjg5NDYzNTBkYmQw NTM1NGMxNTdmNGFmNDQzOS4uNTg3M2ZkMWM3OTk5NDA0ODQyOTBlYmMwZjAwYmM0NGNmM2VkMGI3 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK QEAgLTc4MCw3ICs3ODAsOCBAQCBnYm9vbGVhbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6 OmhhbmRsZU1lc3NhZ2UoR3N0TWVzc2FnZSogbWVzc2FnZSkKICAgICBjYXNlIEdTVF9NRVNTQUdF X0VMRU1FTlQ6CiAgICAgICAgIGlmIChnc3RfaXNfbWlzc2luZ19wbHVnaW5fbWVzc2FnZShtZXNz YWdlKSkgewogICAgICAgICAgICAgZ2NoYXIqIGRldGFpbCA9IGdzdF9taXNzaW5nX3BsdWdpbl9t ZXNzYWdlX2dldF9pbnN0YWxsZXJfZGV0YWlsKG1lc3NhZ2UpOwotICAgICAgICAgICAgR3N0SW5z dGFsbFBsdWdpbnNSZXR1cm4gcmVzdWx0ID0gZ3N0X2luc3RhbGxfcGx1Z2luc19hc3luYygmZGV0 YWlsLCAwLCBtZWRpYVBsYXllclByaXZhdGVQbHVnaW5JbnN0YWxsZXJSZXN1bHRGdW5jdGlvbiwg dGhpcyk7CisgICAgICAgICAgICBnY2hhciogZGV0YWlsQXJyYXlbMl0gPSB7ZGV0YWlsLCAwfTsK KyAgICAgICAgICAgIEdzdEluc3RhbGxQbHVnaW5zUmV0dXJuIHJlc3VsdCA9IGdzdF9pbnN0YWxs X3BsdWdpbnNfYXN5bmMoZGV0YWlsX2FycmF5LCAwLCBtZWRpYVBsYXllclByaXZhdGVQbHVnaW5J bnN0YWxsZXJSZXN1bHRGdW5jdGlvbiwgdGhpcyk7CiAgICAgICAgICAgICBtX21pc3NpbmdQbHVn aW5zID0gcmVzdWx0ID09IEdTVF9JTlNUQUxMX1BMVUdJTlNfU1RBUlRFRF9PSzsKICAgICAgICAg ICAgIGdfZnJlZShkZXRhaWwpOwogICAgICAgICB9Cg== 196663 2013-04-05 12:02:35 -0700 2013-04-05 12:43:30 -0700 Patch bug-114046-20130405130222.patch text/plain 2082 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE0YWRmNDRhNzY3MWM5 MzMzOGU3MjNhZTkyNmZlZmZjYmNjMjY4Ny4uNWUwZTlhOWY5ZTFiNDc4ZWE5NDUwYTY4MGM2MTc3 Yjg2M2JhYTVlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA0LTA1ICBCcmVu ZGFuIExvbmcgIDxzZWxmQGJyZW5kYW5sb25nLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBT ZWdmYXVsdCB3aGVuIGF0dGVtcHRpbmcgdG8gaW5zdGFsbCBtaXNzaW5nIHBsdWdpbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDA0NgorICAgICAg ICAKKyAgICAgICAgZ3N0X2luc3RhbGxfcGx1Z2luc19hc3luYyBleHBlY3RzIGEgbnVsbCB0ZXJt aW5hdGVkIGxpc3QsIGJ1dCB3ZSB3ZXJlbid0CisgICAgICAgIGFkZGluZyBhIG51bGwgdGVybWlu YXRvci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMgc2luY2UgdGhpcyBqdXN0IGZpeGVzIGEgc2VnZmF1bHQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFu ZGxlTWVzc2FnZSk6CisKIDIwMTMtMDQtMDUgIE5vYW0gUm9zZW50aGFsICA8bm9hbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtUZXhtYXBdIGNzczMvZmlsdGVycy9maWx0ZXItYW5pbWF0aW9uLWZy b20tbm9uZS1ody5odG1sIGRvZXMgbm90IGFuaW1hdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMmVhNTZiYmZmODU4Zjg5NDYzNTBkYmQw NTM1NGMxNTdmNGFmNDQzOS4uOWQzOWFkNGMzZmRlM2I5MGFkYWUxM2RjMTQxYjUyMWIwMGY0OGM5 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK QEAgLTc4MCw3ICs3ODAsOCBAQCBnYm9vbGVhbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6 OmhhbmRsZU1lc3NhZ2UoR3N0TWVzc2FnZSogbWVzc2FnZSkKICAgICBjYXNlIEdTVF9NRVNTQUdF X0VMRU1FTlQ6CiAgICAgICAgIGlmIChnc3RfaXNfbWlzc2luZ19wbHVnaW5fbWVzc2FnZShtZXNz YWdlKSkgewogICAgICAgICAgICAgZ2NoYXIqIGRldGFpbCA9IGdzdF9taXNzaW5nX3BsdWdpbl9t ZXNzYWdlX2dldF9pbnN0YWxsZXJfZGV0YWlsKG1lc3NhZ2UpOwotICAgICAgICAgICAgR3N0SW5z dGFsbFBsdWdpbnNSZXR1cm4gcmVzdWx0ID0gZ3N0X2luc3RhbGxfcGx1Z2luc19hc3luYygmZGV0 YWlsLCAwLCBtZWRpYVBsYXllclByaXZhdGVQbHVnaW5JbnN0YWxsZXJSZXN1bHRGdW5jdGlvbiwg dGhpcyk7CisgICAgICAgICAgICBnY2hhciogZGV0YWlsQXJyYXlbMl0gPSB7ZGV0YWlsLCAwfTsK KyAgICAgICAgICAgIEdzdEluc3RhbGxQbHVnaW5zUmV0dXJuIHJlc3VsdCA9IGdzdF9pbnN0YWxs X3BsdWdpbnNfYXN5bmMoZGV0YWlsQXJyYXksIDAsIG1lZGlhUGxheWVyUHJpdmF0ZVBsdWdpbklu c3RhbGxlclJlc3VsdEZ1bmN0aW9uLCB0aGlzKTsKICAgICAgICAgICAgIG1fbWlzc2luZ1BsdWdp bnMgPSByZXN1bHQgPT0gR1NUX0lOU1RBTExfUExVR0lOU19TVEFSVEVEX09LOwogICAgICAgICAg ICAgZ19mcmVlKGRldGFpbCk7CiAgICAgICAgIH0K