114022 2013-04-05 04:35:44 -0700 [BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents() 2013-04-05 05:49:14 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia commit-queue mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 869699 0 berto 2013-04-05 04:35:44 -0700 These only produce annoying compiler warnings: Source/WebKit/blackberry/Api/WebPage_p.h:404:18: warning: unused parameter 'time' [-Wunused-parameter] Source/WebKit/blackberry/Api/WebPage_p.h:406:18: warning: unused parameter 'inClip' [-Wunused-parameter] 869701 1 196616 berto 2013-04-05 04:37:46 -0700 Created attachment 196616 Patch 869720 2 196616 commit-queue 2013-04-05 05:49:12 -0700 Comment on attachment 196616 Patch Clearing flags on attachment: 196616 Committed r147740: <http://trac.webkit.org/changeset/147740> 869721 3 commit-queue 2013-04-05 05:49:14 -0700 All reviewed patches have been landed. Closing bug. 196616 2013-04-05 04:37:46 -0700 2013-04-05 05:49:12 -0700 Patch 114022.diff text/plain 7264 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViT3ZlcmxheV9wLmgg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYk92ZXJsYXlfcC5oCmluZGV4IGJkNTll NjM5Li40NmNmOTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl Yk92ZXJsYXlfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViT3Zlcmxh eV9wLmgKQEAgLTE2Niw5ICsxNjYsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBXZWJDb3JlOjpH cmFwaGljc0xheWVyKiBncmFwaGljc0xheWVyKCkgY29uc3QgeyByZXR1cm4gbV9sYXllci5nZXQo KTsgfQogCiAgICAgLy8gR3JhcGhpY3NMYXllckNsaWVudAotICAgIHZpcnR1YWwgdm9pZCBub3Rp ZnlBbmltYXRpb25TdGFydGVkKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBkb3VibGUg dGltZSkgeyB9CisgICAgdmlydHVhbCB2b2lkIG5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQoY29uc3Qg V2ViQ29yZTo6R3JhcGhpY3NMYXllciosIGRvdWJsZSkgeyB9CiAgICAgdmlydHVhbCB2b2lkIG5v dGlmeUZsdXNoUmVxdWlyZWQoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopOwotICAgIHZp cnR1YWwgdm9pZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBX ZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQ aGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgaW5DbGlwKTsKKyAgICB2aXJ0dWFsIHZvaWQg cGFpbnRDb250ZW50cyhjb25zdCBXZWJDb3JlOjpHcmFwaGljc0xheWVyKiwgV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0JiwgV2ViQ29yZTo6R3JhcGhpY3NMYXllclBhaW50aW5nUGhhc2UsIGNvbnN0 IFdlYkNvcmU6OkludFJlY3QmKTsKIAogcHJpdmF0ZToKICAgICBPd25QdHI8V2ViQ29yZTo6R3Jh cGhpY3NMYXllcj4gbV9sYXllcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2Vf cC5oCmluZGV4IDFkYzU1MTQuLjNmODI3OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlX3AuaApAQCAtNDAxLDkgKzQwMSw5IEBAIHB1YmxpYzoKICAgICBXZWJDb3JlOjpH cmFwaGljc0xheWVyKiBvdmVybGF5TGF5ZXIoKTsKIAogICAgIC8vIEZhbGxiYWNrIEdyYXBoaWNz TGF5ZXJDbGllbnQgaW1wbGVtZW50YXRpb24sIHVzZWQgZm9yIHZhcmlvdXMgb3ZlcmxheSBsYXll cnMuCi0gICAgdmlydHVhbCB2b2lkIG5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQoY29uc3QgV2ViQ29y ZTo6R3JhcGhpY3NMYXllciosIGRvdWJsZSB0aW1lKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgbm90 aWZ5QW5pbWF0aW9uU3RhcnRlZChjb25zdCBXZWJDb3JlOjpHcmFwaGljc0xheWVyKiwgZG91Ymxl KSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5Rmx1c2hSZXF1aXJlZChjb25zdCBXZWJDb3Jl OjpHcmFwaGljc0xheWVyKik7Ci0gICAgdmlydHVhbCB2b2lkIHBhaW50Q29udGVudHMoY29uc3Qg V2ViQ29yZTo6R3JhcGhpY3NMYXllciosIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCYsIFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXJQYWludGluZ1BoYXNlLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBp bkNsaXApIHsgfQorICAgIHZpcnR1YWwgdm9pZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6 OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFw aGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpIHsgfQogCiAg ICAgLy8gV2ViS2l0IHRocmVhZCwgcGx1bWJlZCB0aHJvdWdoIGZyb20gQ2hyb21lQ2xpZW50Qmxh Y2tCZXJyeS4KICAgICB2b2lkIHNldFJvb3RMYXllcldlYktpdFRocmVhZChXZWJDb3JlOjpGcmFt ZSosIFdlYkNvcmU6OkxheWVyV2ViS2l0VGhyZWFkKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZwppbmRleCBjODUzNWZkLi5kMTI2YmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKQEAgLTEsNSArMSwzMSBAQAogMjAxMy0wNC0wNSAgQWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lh QGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSB1bnVzZWQgcGFyYW1l dGVycyBmcm9tIG5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQoKSBhbmQgcGFpbnRDb250ZW50cygpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQwMjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOYW1pbmcgdGhl ICd0aW1lJyBhbmQgJ2luQ2xpcCcgdW51c2VkIHBhcmFtZXRlcnMgb25seSBwcm9kdWNlcworICAg ICAgICBjb21waWxlciB3YXJuaW5ncy4KKworICAgICAgICAqIEFwaS9XZWJPdmVybGF5X3AuaDoK KyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViT3ZlcmxheVByaXZhdGVXZWJLaXRUaHJl YWQ6Om5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQpOgorICAgICAgICAoV2ViT3ZlcmxheVByaXZhdGVX ZWJLaXRUaHJlYWQpOgorICAgICAgICAqIEFwaS9XZWJQYWdlX3AuaDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6Om5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQpOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6cGFpbnRDb250ZW50 cyk6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0Lmg6CisgICAg ICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkRlZmF1bHRUYXBIaWdobGlnaHQ6Om5vdGlmeUFuaW1h dGlvblN0YXJ0ZWQpOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5zcGVjdG9yT3ZlcmxheUJs YWNrQmVycnkuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnNwZWN0b3JPdmVy bGF5OjpwYWludENvbnRlbnRzKToKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0luc3BlY3Rvck92 ZXJsYXlCbGFja0JlcnJ5Lmg6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6Okluc3BlY3Rv ck92ZXJsYXk6Om5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQpOgorICAgICAgICAoSW5zcGVjdG9yT3Zl cmxheSk6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25PdmVybGF5Lmg6CisgICAg ICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbk92ZXJsYXk6Om5vdGlmeUFuaW1hdGlv blN0YXJ0ZWQpOgorCisyMDEzLTA0LTA1ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlh LmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gV2ViT3ZlcmxheVByaXZhdGU6IHJlbW92ZSBz aG93RGVidWdCb3JkZXJzKCkgYW5kIHNob3dSZXBhaW50Q291bnRlcigpCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTQwMDkKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRGVmYXVsdFRhcEhpZ2hsaWdo dC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRGVmYXVsdFRhcEhp Z2hsaWdodC5oCmluZGV4IDdlZDdlYzkuLjc2ZWRlMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0RlZmF1bHRUYXBIaWdobGlnaHQuaAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9EZWZhdWx0VGFwSGlnaGxpZ2h0 LmgKQEAgLTU0LDcgKzU0LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRIaWRl QWZ0ZXJTY3JvbGwoKSBjb25zdCB7IHJldHVybiBtX3Nob3VsZEhpZGVBZnRlclNjcm9sbDsgfQog CiAgICAgLy8gR3JhcGhpY3NMYXllckNsaWVudAotICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBbmlt YXRpb25TdGFydGVkKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBkb3VibGUgdGltZSkg eyB9CisgICAgdmlydHVhbCB2b2lkIG5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQoY29uc3QgV2ViQ29y ZTo6R3JhcGhpY3NMYXllciosIGRvdWJsZSkgeyB9CiAgICAgdmlydHVhbCB2b2lkIG5vdGlmeUZs dXNoUmVxdWlyZWQoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopOwogICAgIHZpcnR1YWwg dm9pZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3Jl OjpHcmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwg Y29uc3QgV2ViQ29yZTo6SW50UmVjdCYgaW5DbGlwKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5zcGVjdG9yT3ZlcmxheUJsYWNrQmVycnku Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5zcGVjdG9yT3Zl cmxheUJsYWNrQmVycnkuY3BwCmluZGV4IDk1NWYzMmEuLmI4YmNiODUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0luc3BlY3Rvck92ZXJsYXlCbGFj a0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9J bnNwZWN0b3JPdmVybGF5QmxhY2tCZXJyeS5jcHAKQEAgLTQ3LDcgKzQ3LDcgQEAgdm9pZCBJbnNw ZWN0b3JPdmVybGF5Ojpub3RpZnlGbHVzaFJlcXVpcmVkKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXIqIGxheWVyKQogICAgIG1fd2ViUGFnZS0+bm90aWZ5Rmx1c2hSZXF1aXJlZChsYXllcik7 CiB9CiAKLXZvaWQgSW5zcGVjdG9yT3ZlcmxheTo6cGFpbnRDb250ZW50cyhjb25zdCBXZWJDb3Jl OjpHcmFwaGljc0xheWVyKiwgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBXZWJD b3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYg aW5DbGlwKQordm9pZCBJbnNwZWN0b3JPdmVybGF5OjpwYWludENvbnRlbnRzKGNvbnN0IFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIFdl YkNvcmU6OkdyYXBoaWNzTGF5ZXJQYWludGluZ1BoYXNlLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0 JikKIHsKICAgICBjb250ZXh0LnNhdmUoKTsKICAgICBXZWJDb3JlOjpJbnRQb2ludCBzY3JvbGxQ b3NpdGlvbiA9IG1fd2ViUGFnZS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCktPnZpZXcoKS0+c2Nyb2xs UG9zaXRpb24oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0luc3BlY3Rvck92ZXJsYXlCbGFja0JlcnJ5LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnNwZWN0b3JPdmVybGF5QmxhY2tCZXJyeS5oCmluZGV4IGYx ZjNmODMuLmQ5YzZiNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0luc3BlY3Rvck92ZXJsYXlCbGFja0JlcnJ5LmgKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5zcGVjdG9yT3ZlcmxheUJsYWNrQmVycnkuaApA QCAtNTEsOSArNTEsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCBwYWludFdlYkZyYW1lKFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dCYpOwogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQot ICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBbmltYXRpb25TdGFydGVkKGNvbnN0IFdlYkNvcmU6Okdy YXBoaWNzTGF5ZXIqLCBkb3VibGUgdGltZSkgeyB9CisgICAgdmlydHVhbCB2b2lkIG5vdGlmeUFu aW1hdGlvblN0YXJ0ZWQoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciosIGRvdWJsZSkgeyB9 CiAgICAgdmlydHVhbCB2b2lkIG5vdGlmeUZsdXNoUmVxdWlyZWQoY29uc3QgV2ViQ29yZTo6R3Jh cGhpY3NMYXllciopOwotICAgIHZpcnR1YWwgdm9pZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpH cmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29uc3QgV2ViQ29yZTo6SW50UmVjdCYgaW5DbGlw KTsKKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnRDb250ZW50cyhjb25zdCBXZWJDb3JlOjpHcmFwaGlj c0xheWVyKiwgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0JiwgV2ViQ29yZTo6R3JhcGhpY3NMYXll clBhaW50aW5nUGhhc2UsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsKICNlbmRpZgogCiBwcml2 YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv U2VsZWN0aW9uT3ZlcmxheS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvU2VsZWN0aW9uT3ZlcmxheS5oCmluZGV4IDJjNzI5NDIuLjc5ZjA3N2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbk92ZXJsYXku aAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25P dmVybGF5LmgKQEAgLTU0LDcgKzU0LDcgQEAgcHVibGljOgogICAgIHZvaWQgaGlkZSgpOwogCiAg ICAgLy8gR3JhcGhpY3NMYXllckNsaWVudAotICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBbmltYXRp b25TdGFydGVkKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBkb3VibGUgdGltZSkgeyB9 CisgICAgdmlydHVhbCB2b2lkIG5vdGlmeUFuaW1hdGlvblN0YXJ0ZWQoY29uc3QgV2ViQ29yZTo6 R3JhcGhpY3NMYXllciosIGRvdWJsZSkgeyB9CiAgICAgdmlydHVhbCB2b2lkIG5vdGlmeUZsdXNo UmVxdWlyZWQoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciopOwogICAgIHZpcnR1YWwgdm9p ZCBwYWludENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQmLCBXZWJDb3JlOjpHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSwgY29u c3QgV2ViQ29yZTo6SW50UmVjdCYpOwogCg==