11402 2006-10-24 09:28:59 -0700 REGRESSION: onChange does not work anymore for 1st item in popup 2006-11-05 00:44:57 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, InRadar, Regression P1 Normal --- 1 opendarwin webkit-unassigned ap dev+webkit mitz oldest_to_newest 50832 0 opendarwin 2006-10-24 09:28:59 -0700 Something broke and now my popup boxes that have an onChange are not executing the onChange when you switch to the first item in the popup. It still works with Safari and Firefox. 50828 1 mitz 2006-10-24 10:23:22 -0700 I couldn't reproduce with<select onchange="alert()"><option>1</option><option>2</option><option>3</option></select> i.e. the alert showed up every time. Can you provide a test case? 50033 2 dev+webkit 2006-10-24 18:18:51 -0700 Confirming this bug. It only happens when the first option is not the default. 50034 3 11198 dev+webkit 2006-10-24 18:22:28 -0700 Created attachment 11198 Testcase Testcase using Mitz's code from above. The second option is selected when the page loads, selecting 1 does not fire the alert on the first selection of 1, selecting 2 or 3 then selecting 1 again does fire the alert. 50018 4 ap 2006-10-24 21:31:19 -0700 Fixing keywords/component/priority/severity (blocker is for bugs that block WebKit development). 49036 5 dev+webkit 2006-10-27 18:07:22 -0700 Filed in radar as 4808112 46873 6 11378 ap 2006-11-04 05:09:38 -0800 Created attachment 11378 proposed fix I do not see how to make an automated test (AFAICT onchange only fires for mouse actions, and only when the popup menu is actually opened, and DRT doesn't seem to be able to simulate this) - and I'm not sure if adding a manual test is worth it in this case. 46795 7 11378 harrison 2006-11-04 13:59:45 -0800 Comment on attachment 11378 proposed fix r=me 46809 8 ap 2006-11-05 00:44:57 -0800 Committed revision 17603. 11198 2006-10-24 18:22:28 -0700 2006-10-24 18:22:28 -0700 Testcase 11402.html text/html 167 dev+webkit PGh0bWw+Cgo8Ym9keT4KICAgIDxzZWxlY3Qgb25jaGFuZ2U9ImFsZXJ0KCkiPgogICAgICAgIDxv cHRpb24+MTwvb3B0aW9uPgogICAgICAgIDxvcHRpb24gc2VsZWN0ZWQ+Mjwvb3B0aW9uPgogICAg ICAgIDxvcHRpb24+Mzwvb3B0aW9uPgogICAgPC9zZWxlY3Q+CjwvYm9keT4KCjwvaHRtbD4= 11378 2006-11-04 05:09:38 -0800 2006-11-04 13:59:45 -0800 proposed fix 11402r1_patch.txt text/plain 1488 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNzU5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDYtMTEtMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBv cC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0MDIKKyAgICAgICAgUkVH UkVTU0lPTjogb25DaGFuZ2UgZG9lcyBub3Qgd29yayBhbnltb3JlIGZvciAxc3QgaXRlbSBpbiBw b3B1cAorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6SFRNTFNlbGVjdEVsZW1lbnQpOgorICAgICAgICAo V2ViQ29yZTo6SFRNTFNlbGVjdEVsZW1lbnQ6OnJlc2V0KToKKyAgICAgICAgU2V0IG1fbGFzdE9u Q2hhbmdlSW5kZXggdG8gLTEuCisKIDIwMDYtMTEtMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBueXBvcC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqLgpJbmRleDogV2ViQ29y ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwv SFRNTFNlbGVjdEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNzU5MSkKKysrIFdlYkNvcmUvaHRtbC9I VE1MU2VsZWN0RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0LDcgKzY0LDcgQEAgSFRN TFNlbGVjdEVsZW1lbnQ6OkhUTUxTZWxlY3RFbGVtZW50KERvYwogICAgICwgbV9zaXplKDApCiAg ICAgLCBtX211bHRpcGxlKGZhbHNlKQogICAgICwgbV9yZWNhbGNMaXN0SXRlbXMoZmFsc2UpCi0g ICAgLCBtX2xhc3RPbkNoYW5nZUluZGV4KDApCisgICAgLCBtX2xhc3RPbkNoYW5nZUluZGV4KC0x KQogICAgICwgbV9hY3RpdmVTZWxlY3Rpb25BbmNob3JJbmRleCgtMSkKICAgICAsIG1fYWN0aXZl U2VsZWN0aW9uRW5kSW5kZXgoLTEpCiAgICAgLCBtX2FjdGl2ZVNlbGVjdGlvblN0YXRlKGZhbHNl KQpAQCAtNTA0LDYgKzUwNCw3IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnJlc2V0KCkKICAg ICBpZiAoIW9wdGlvblNlbGVjdGVkICYmIGZpcnN0T3B0aW9uKQogICAgICAgICBmaXJzdE9wdGlv bi0+c2V0U2VsZWN0ZWQodHJ1ZSk7CiAgICAgc2V0Q2hhbmdlZCh0cnVlKTsKKyAgICBtX2xhc3RP bkNoYW5nZUluZGV4ID0gLTE7CiB9CiAKIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6Om5vdGlmeU9w dGlvblNlbGVjdGVkKEhUTUxPcHRpb25FbGVtZW50ICpzZWxlY3RlZE9wdGlvbiwgYm9vbCBzZWxl Y3RlZCkK