113991 2013-04-04 20:18:59 -0700 Web Inspector: crash in InspectorDOMAgent::innerHighlightQuad after r147566 2013-04-05 02:27:04 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 seokju webkit-unassigned apavlov commit-queue graouts joepeck keishi loislo pfeldman pmuellr timothy vsevik web-inspector-bugs yurys oldest_to_newest 869531 0 seokju 2013-04-04 20:18:59 -0700 #0 0x00007ffff4ecbe81 in WebCore::InspectorDOMAgent::innerHighlightQuad(WTF::PassOwnPtr<WebCore::FloatQuad>, WTF::RefPtr<WebCore::InspectorObject> const*, WTF::RefPtr<WebCore::InspectorObject> const*, bool const*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #1 0x00007ffff4ecc2f5 in WebCore::InspectorDOMAgent::highlightQuad(WTF::String*, WTF::RefPtr<WebCore::InspectorArray> const&, WTF::RefPtr<WebCore::InspectorObject> const*, WTF::RefPtr<WebCore::InspectorObject> const*, bool const*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #2 0x00007ffff5ce1760 in WebCore::InspectorBackendDispatcherImpl::DOM_highlightQuad(long, WebCore::InspectorObject*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #3 0x00007ffff5d01832 in WebCore::InspectorBackendDispatcherImpl::dispatch(WTF::String const&) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #4 0x00007ffff4eef5b6 in WebCore::InspectorBackendDispatchTask::onTimer(WebCore::Timer<WebCore::InspectorBackendDispatchTask>*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #5 0x00007ffff50df962 in WebCore::ThreadTimers::sharedTimerFiredInternal() () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #6 0x00007ffff5c6e99d in WebCore::timerEvent(void*) () from /home/neocrash/git/WebKit/WebKitBuild/Release/lib/libwebcore_efl.so.0 #7 0x00007ffff763b3de in _ecore_call_task_cb (data=<optimized out>, func=<optimized out>) at ecore_private.h:267 #8 _ecore_timer_expired_call (when=<optimized out>) at ecore_timer.c:792 #9 0x00007ffff763b5ab in _ecore_timer_expired_timers_call (when=9640.3891623) at ecore_timer.c:746 #10 0x00007ffff76384b1 in _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:1813 #11 0x00007ffff7638b47 in ecore_main_loop_begin () at ecore_main.c:956 #12 0x0000000000403b85 in main () 869532 1 196571 seokju 2013-04-04 20:21:47 -0700 Created attachment 196571 Patch 869631 2 196571 joepeck 2013-04-05 01:24:09 -0700 Comment on attachment 196571 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196571&action=review This looked suspicious to me in earlier previous patch, but I wasn't the reviewer there. This looks good to me. r=me > Source/WebCore/ChangeLog:8 > + No new tests, covered by existing tests. Covered by existing tests? Which test is crashing? Call it out directly. If there is no test, remove this line. 869636 3 196598 seokju 2013-04-05 01:37:23 -0700 Created attachment 196598 Patch 869658 4 196598 commit-queue 2013-04-05 02:27:01 -0700 Comment on attachment 196598 Patch Clearing flags on attachment: 196598 Committed r147732: <http://trac.webkit.org/changeset/147732> 869659 5 commit-queue 2013-04-05 02:27:04 -0700 All reviewed patches have been landed. Closing bug. 196571 2013-04-04 20:21:47 -0700 2013-04-05 01:37:16 -0700 Patch bug-113991-20130405122135.patch text/plain 1630 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjM5YTFmODljM2NkZmM2 MDUzYTUyNGM3ODdkOWMzOTNiZTA2MjRmYi4uOGQ4MGQwOTllYzAxYWY5MjJmNjM3YmE1YWM3OWNi NjI1NmMxNjNkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA0LTA0ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBjcmFzaCBpbiBJbnNwZWN0b3JET01BZ2VudDo6aW5uZXJIaWdobGlnaHRRdWFkIGFmdGVyIHIx NDc1NjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx Mzk5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JE T01BZ2VudDo6aW5uZXJIaWdobGlnaHRRdWFkKToKKwogMjAxMy0wNC0wNCAgRGVhbiBKYWNrc29u ICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgZGlzcGF0Y2ggZGVsYXllZCBjbGlj ayBpZiBzbmFwc2hvdHRlZCBwbHVnaW4gd2FzIHRyaWdnZXJlZCBieSBhIGNsaWNrIG9uIHRoZSBs YWJlbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFn ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAK aW5kZXggZmYyZWQ2NWFkOGQ5MDlmMmZlNmQ2YjMxODQ1NjBmOWViZDY5NzJkNC4uNTkxMjU1NDEx Zjg3NGQ4MDQ1NWRlOWExOGQ5Y2E5NzY2MTJiNTgyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBAIC0xMTc2LDcgKzExNzYsNyBAQCB2b2lk IEluc3BlY3RvckRPTUFnZW50Ojppbm5lckhpZ2hsaWdodFF1YWQoUGFzc093blB0cjxGbG9hdFF1 YWQ+IHF1YWQsIGNvbnN0IFJlZgogICAgIE93blB0cjxIaWdobGlnaHRDb25maWc+IGhpZ2hsaWdo dENvbmZpZyA9IGFkb3B0UHRyKG5ldyBIaWdobGlnaHRDb25maWcoKSk7CiAgICAgaGlnaGxpZ2h0 Q29uZmlnLT5jb250ZW50ID0gcGFyc2VDb2xvcihjb2xvcik7CiAgICAgaGlnaGxpZ2h0Q29uZmln LT5jb250ZW50T3V0bGluZSA9IHBhcnNlQ29sb3Iob3V0bGluZUNvbG9yKTsKLSAgICBoaWdobGln aHRDb25maWctPnVzZVBhZ2VDb29yZGluYXRlcyA9ICp1c2VQYWdlQ29vcmRpbmF0ZXM7CisgICAg aGlnaGxpZ2h0Q29uZmlnLT51c2VQYWdlQ29vcmRpbmF0ZXMgPSB1c2VQYWdlQ29vcmRpbmF0ZXMg PyAqdXNlUGFnZUNvb3JkaW5hdGVzIDogZmFsc2U7CiAgICAgbV9vdmVybGF5LT5oaWdobGlnaHRR dWFkKHF1YWQsICpoaWdobGlnaHRDb25maWcpOwogfQogCg== 196598 2013-04-05 01:37:23 -0700 2013-04-05 02:27:01 -0700 Patch bug-113991-20130405173710.patch text/plain 1552 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ3NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmEzYWRkN2M3OWVhOGQ4 MTY3ZWRlNmNmYjcyNDdiN2RmN2I0NDVlYy4uZmYzZDM4NTRhZmFiMGRkNTUxNmM1MzY5OTEzYzgw YWEyYWE4NTljZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA0LTA1ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBjcmFzaCBpbiBJbnNwZWN0b3JET01BZ2VudDo6aW5uZXJIaWdobGlnaHRRdWFkIGFmdGVyIHIx NDc1NjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx Mzk5MQorCisgICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JET01BZ2VudDo6aW5uZXJIaWdobGlnaHRRdWFkKToKKwogMjAxMy0wNC0wNSAgQmVuamFt aW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBj aHJvbWl1bSBkaXJlY3RvcmllcyBmcm9tIFdlYkNvcmUvTW9kdWxlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggZmYyZWQ2NWFkOGQ5MDlm MmZlNmQ2YjMxODQ1NjBmOWViZDY5NzJkNC4uNTkxMjU1NDExZjg3NGQ4MDQ1NWRlOWExOGQ5Y2E5 NzY2MTJiNTgyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckRPTUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9N QWdlbnQuY3BwCkBAIC0xMTc2LDcgKzExNzYsNyBAQCB2b2lkIEluc3BlY3RvckRPTUFnZW50Ojpp bm5lckhpZ2hsaWdodFF1YWQoUGFzc093blB0cjxGbG9hdFF1YWQ+IHF1YWQsIGNvbnN0IFJlZgog ICAgIE93blB0cjxIaWdobGlnaHRDb25maWc+IGhpZ2hsaWdodENvbmZpZyA9IGFkb3B0UHRyKG5l dyBIaWdobGlnaHRDb25maWcoKSk7CiAgICAgaGlnaGxpZ2h0Q29uZmlnLT5jb250ZW50ID0gcGFy c2VDb2xvcihjb2xvcik7CiAgICAgaGlnaGxpZ2h0Q29uZmlnLT5jb250ZW50T3V0bGluZSA9IHBh cnNlQ29sb3Iob3V0bGluZUNvbG9yKTsKLSAgICBoaWdobGlnaHRDb25maWctPnVzZVBhZ2VDb29y ZGluYXRlcyA9ICp1c2VQYWdlQ29vcmRpbmF0ZXM7CisgICAgaGlnaGxpZ2h0Q29uZmlnLT51c2VQ YWdlQ29vcmRpbmF0ZXMgPSB1c2VQYWdlQ29vcmRpbmF0ZXMgPyAqdXNlUGFnZUNvb3JkaW5hdGVz IDogZmFsc2U7CiAgICAgbV9vdmVybGF5LT5oaWdobGlnaHRRdWFkKHF1YWQsICpoaWdobGlnaHRD b25maWcpOwogfQogCg==