113962 2013-04-04 14:41:00 -0700 GtkSelectionData length is off by one 2013-05-19 07:55:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 dwnarvaez mrobinson dwnarvaez mrobinson oldest_to_newest 869374 0 dwnarvaez 2013-04-04 14:41:00 -0700 If you drag a link from webkit to another gtk widget, which supports text/uri-list, the GtkSelectionData passed to the drag-data-received event will have the wrong length. In fact it will include the NULL termination. It looks like the issue might be here https://trac.webkit.org/browser/trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp#L175 The + 1 there seems wrong to me. Similar issue with TargetTypeMarkup. 869377 1 dwnarvaez 2013-04-04 14:44:03 -0700 Oh and TargetTypeNetscapeURL. 889110 2 mrobinson 2013-05-14 20:20:20 -0700 Thanks for reporting this bug. Is it causing any visible issues? I've been looking at the drag-and-drop atom contents for different browsers and it seems they are all differ. For instance, I ran the paste program from: http://www.edwardrosten.com/code/x11.html like so: ./paste -dnd text/uri-list After dragging a link 38 characters long, this is what I see in various browsers: * Chromium: Number of items: 40 * Epiphany: Number of items: 39 * Firefox: Number of items: 38 If all browsers do something different and this isn't causing issues, I'm tempted keep things as they are. If not, what widgets are showing issues and are they reproducible with Chromium? 889170 3 dwnarvaez 2013-05-15 00:33:06 -0700 If you drag a link from a webkitgtk widget to an application which uses pygobject Gtk.SelectionData.get_data, you will get uris with an extra \x00 at the end. In C applications I think it's normally not user visible because the string is null terminated anyway. 889283 4 mrobinson 2013-05-15 07:34:14 -0700 (In reply to comment #3) > If you drag a link from a webkitgtk widget to an application which uses pygobject Gtk.SelectionData.get_data, you will get uris with an extra \x00 at the end. In C applications I think it's normally not user visible because the string is null terminated anyway. Do you have an example somewhere that illustrates this problem? 889284 5 dwnarvaez 2013-05-15 07:37:47 -0700 I can write a testcase, give me a couple of days. 890717 6 202169 dwnarvaez 2013-05-17 16:07:18 -0700 Created attachment 202169 Testcase 890722 7 dwnarvaez 2013-05-17 16:11:49 -0700 If you run the testcase, drag a link from the web view to the empty window, the url with the final \x00 will printed out. I got different results than yours testing this with firefox and epiphany with this testcase. I dragged the planet link on webkitgtk.org and firefox worked as expected, epiphany failed in the same way as webkit. That's more in line with what I'd have expected. firefox 10.0.12 epiphany 3.4.2 webkit 1.8.1 890733 8 mrobinson 2013-05-17 16:31:49 -0700 (In reply to comment #7) > If you run the testcase, drag a link from the web view to the empty window, the url with the final \x00 will printed out. > > I got different results than yours testing this with firefox and epiphany with this testcase. I dragged the planet link on webkitgtk.org and firefox worked as expected, epiphany failed in the same way as webkit. That's more in line with what I'd have expected. > > firefox 10.0.12 > epiphany 3.4.2 > webkit 1.8.1 Thanks very much for the test case. Chromium's data is two characters longer because it includes a carriage return and a newline. Firefox includes neither. I'll try to have a fix today. 890981 9 202223 mrobinson 2013-05-18 17:32:12 -0700 Created attachment 202223 Patch 891024 10 202223 mrobinson 2013-05-19 07:55:37 -0700 Comment on attachment 202223 Patch Clearing flags on attachment: 202223 Committed r150350: <http://trac.webkit.org/changeset/150350> 891025 11 mrobinson 2013-05-19 07:55:40 -0700 All reviewed patches have been landed. Closing bug. 202169 2013-05-17 16:07:18 -0700 2013-05-17 16:07:18 -0700 Testcase test.py text/x-python 695 dwnarvaez aW1wb3J0IHN5cwoKZnJvbSBnaS5yZXBvc2l0b3J5IGltcG9ydCBXZWJLaXQKZnJvbSBnaS5yZXBv c2l0b3J5IGltcG9ydCBHdGsKZnJvbSBnaS5yZXBvc2l0b3J5IGltcG9ydCBHZGsKCndpbmRvdyA9 IEd0ay5XaW5kb3coKQp3ZWJfdmlldyA9IFdlYktpdC5XZWJWaWV3KCkKd2luZG93LmFkZCh3ZWJf dmlldykKd2luZG93LnNob3dfYWxsKCkKd2ViX3ZpZXcubG9hZF91cmkoImh0dHA6Ly93d3cud2Vi a2l0Z3RrLm9yZyIpCgpkZWYgZHJhZ19kYXRhX3JlY2VpdmVkX2NiKHdpZGdldCwgY29udGV4dCwg eCwgeSwgc2VsZWN0aW9uLCB0YXJnZXRUeXBlLCB0aW1lKToKICAgICMgTmVlZCB0byBlc2NhcGUg YmVjYXVzZSB0aGUgdGVybWluYWwgd2lsbCBub3QgcHJpbnQgdGhlIGZpbmFsIFx4MDAKICAgIHBy aW50IHNlbGVjdGlvbi5nZXRfZGF0YSgpLmVuY29kZSgic3RyaW5nLWVzY2FwZSIpLCBzZWxlY3Rp b24uZ2V0X2xlbmd0aCgpCgp3aW5kb3cyID0gR3RrLldpbmRvdygpCndpbmRvdzIuZHJhZ19kZXN0 X3NldChHdGsuRGVzdERlZmF1bHRzLkFMTCwgTm9uZSwgR2RrLkRyYWdBY3Rpb24uQ09QWSkKd2lu ZG93Mi5kcmFnX2Rlc3RfYWRkX3VyaV90YXJnZXRzKCkKd2luZG93Mi5jb25uZWN0KCJkcmFnX2Rh dGFfcmVjZWl2ZWQiLCBkcmFnX2RhdGFfcmVjZWl2ZWRfY2IpCndpbmRvdzIuc2hvd19hbGwoKQoK R3RrLm1haW4oKQo= 202223 2013-05-18 17:32:12 -0700 2013-05-19 07:55:37 -0700 Patch bug-113962-20130518173103.patch text/plain 2784 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBlZDJmNGMxMmQ3NjAw NDAxMGQyMzUwYzQzYmI5ZWRkMzNkNzY4MC4uNzJhNDZhMWYwYzZmMmU2ZGE5NzA2ZmMwMTVjOGNk MDdkNDRjMzgyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA1LTE4ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBHdGtTZWxlY3Rp b25EYXRhIGxlbmd0aCBpcyBvZmYgYnkgb25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFNpbmNlIGRyYWcgZGF0YSBpcyBpbnRl cnByZXRlZCBhcyBhIG51bGwtdGVybWluYXRlZCBzdHJpbmcKKyAgICAgICAgdGhpcyBpcyBkaWZm aWN1bHQgdG8gdGVzdCB3aXRoIGEgQyBwcm9ncmFtIGFuZCB3ZSBoYXZlIG5vIGluZnJhc3RydWN0 dXJlCisgICAgICAgIGJ1aWx0IGZvciB1c2luZyBHSVIgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJv YXJkSGVscGVyOjpmaWxsU2VsZWN0aW9uRGF0YSk6IEluc3RlYWQgb2YgaW5jbHVkaW5nIHRoZSBu dWxsCisgICAgICAgIGNoYXJhY3RlciBpbiB0aGUgcGFzdGUgZGF0YSBsZW5ndGgsIGp1c3QgaW5j bHVkZSB0aGUgc3RyaW5nLiBUaGlzIG1hdGNoZXMgdGhlIGJlaGF2aW9yCisgICAgICAgIG9mIEZp cmVmb3guCisKIDIwMTMtMDUtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNv bT4KIAogICAgICAgICBTaW1wbGlmeSBTdG9yYWdlQXJlYSBnZXR0ZXIgZnVuY3Rpb25zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEhlbHBlci5jcHAKaW5kZXgg NzMwNTZkNGJkMDJkY2VjNmIwMzBmNjY3MTE0Mjg5NWJiNjdjMzE0OC4uMTI2ZTg3YWVhYTIyYjc0 NTRmY2FiY2UyMzZhOTAyODFiMTdhNDU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1Bhc3RlYm9hcmRIZWxwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9QYXN0ZWJvYXJkSGVscGVyLmNwcApAQCAtMTY2LDEyICsxNjYsMTIgQEAgdm9pZCBQ YXN0ZWJvYXJkSGVscGVyOjpmaWxsU2VsZWN0aW9uRGF0YShHdGtTZWxlY3Rpb25EYXRhKiBzZWxl Y3Rpb25EYXRhLCBndWludAogICAgICAgICAvLyBwcmVmaXhlZCBieSBhIGNvbnRlbnQtdHlwZSBt ZXRhIHRhZy4KICAgICAgICAgQ1N0cmluZyBtYXJrdXAgPSBTdHJpbmcoZ01hcmt1cFByZWZpeCAr IGRhdGFPYmplY3QtPm1hcmt1cCgpKS51dGY4KCk7CiAgICAgICAgIGd0a19zZWxlY3Rpb25fZGF0 YV9zZXQoc2VsZWN0aW9uRGF0YSwgbWFya3VwQXRvbSwgOCwKLSAgICAgICAgICAgIHJlaW50ZXJw cmV0X2Nhc3Q8Y29uc3QgZ3VjaGFyKj4obWFya3VwLmRhdGEoKSksIG1hcmt1cC5sZW5ndGgoKSAr IDEpOworICAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBndWNoYXIqPihtYXJrdXAu ZGF0YSgpKSwgbWFya3VwLmxlbmd0aCgpKTsKIAogICAgIH0gZWxzZSBpZiAoaW5mbyA9PSBUYXJn ZXRUeXBlVVJJTGlzdCkgewogICAgICAgICBDU3RyaW5nIHVyaUxpc3QgPSBkYXRhT2JqZWN0LT51 cmlMaXN0KCkudXRmOCgpOwogICAgICAgICBndGtfc2VsZWN0aW9uX2RhdGFfc2V0KHNlbGVjdGlv bkRhdGEsIHVyaUxpc3RBdG9tLCA4LAotICAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25z dCBndWNoYXIqPih1cmlMaXN0LmRhdGEoKSksIHVyaUxpc3QubGVuZ3RoKCkgKyAxKTsKKyAgICAg ICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgZ3VjaGFyKj4odXJpTGlzdC5kYXRhKCkpLCB1 cmlMaXN0Lmxlbmd0aCgpKTsKIAogICAgIH0gZWxzZSBpZiAoaW5mbyA9PSBUYXJnZXRUeXBlTmV0 c2NhcGVVUkwgJiYgZGF0YU9iamVjdC0+aGFzVVJMKCkpIHsKICAgICAgICAgU3RyaW5nIHVybChk YXRhT2JqZWN0LT51cmwoKSk7CkBAIC0xODUsNyArMTg1LDcgQEAgdm9pZCBQYXN0ZWJvYXJkSGVs cGVyOjpmaWxsU2VsZWN0aW9uRGF0YShHdGtTZWxlY3Rpb25EYXRhKiBzZWxlY3Rpb25EYXRhLCBn dWludAogCiAgICAgICAgIEdPd25QdHI8Z2NoYXI+IHJlc3VsdERhdGEoZ19zdHJkdXAocmVzdWx0 LnV0ZjgoKS5kYXRhKCkpKTsKICAgICAgICAgZ3RrX3NlbGVjdGlvbl9kYXRhX3NldChzZWxlY3Rp b25EYXRhLCBuZXRzY2FwZVVSTEF0b20sIDgsCi0gICAgICAgICAgICByZWludGVycHJldF9jYXN0 PGNvbnN0IGd1Y2hhcio+KHJlc3VsdERhdGEuZ2V0KCkpLCBzdHJsZW4ocmVzdWx0RGF0YS5nZXQo KSkgKyAxKTsKKyAgICAgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgZ3VjaGFyKj4ocmVz dWx0RGF0YS5nZXQoKSksIHN0cmxlbihyZXN1bHREYXRhLmdldCgpKSk7CiAKICAgICB9IGVsc2Ug aWYgKGluZm8gPT0gVGFyZ2V0VHlwZUltYWdlKQogICAgICAgICBndGtfc2VsZWN0aW9uX2RhdGFf c2V0X3BpeGJ1ZihzZWxlY3Rpb25EYXRhLCBkYXRhT2JqZWN0LT5pbWFnZSgpKTsK