113958 2013-04-04 13:59:03 -0700 Add SPI to get a copy of the context menu at a given point. 2013-04-05 09:25:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson andersca ap sam oldest_to_newest 869340 0 beidson 2013-04-04 13:59:03 -0700 Add SPI to get a copy of the context menu at a given point. This is similar to [NSView menuForEvent:] in Cocoa/WebKit1 In radar as <rdar://problem/13450908> 869343 1 196525 beidson 2013-04-04 14:01:44 -0700 Created attachment 196525 Patch v1 - First swipe 869443 2 196525 aestes 2013-04-04 16:23:53 -0700 Comment on attachment 196525 Patch v1 - First swipe View in context: https://bugs.webkit.org/attachment.cgi?id=196525&action=review r=me with a comment > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:81 > +WK_EXPORT WKArrayRef WKBundlePageCopyContextMenuAtPoint(WKBundlePageRef, WKPoint); We should be clear what coordinate space we expect the point to be in, since your code in WebPage::contextMenuAtPoint() creates a mouse event assuming screen coordinate space. We decided on WKBundlePageCopyContextMenuAtPointOnScreen() over IRC. 869807 3 beidson 2013-04-05 09:25:12 -0700 http://trac.webkit.org/changeset/147752 196525 2013-04-04 14:01:44 -0700 2013-04-04 16:23:53 -0700 Patch v1 - First swipe patch text/plain 4123 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZTk3NjA5Li42Y2IwZmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDQtMDQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCBTUEkgdG8gZ2V0IGEgY29weSBvZiB0aGUgY29udGV4dCBtZW51IGF0IGEgZ2l2ZW4g cG9pbnQuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMzQ1MDkwOD4gYW5kIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTM5NTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIG5ldyBhY2Nlc3NvcjogCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlOjpjb250ZXh0TWVudUF0UG9pbnQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmg6CisKKyAgICAgICAgRXhwb3NlIHRoZSBuZXcgU1BJOgorICAgICAgICAqIFdl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmNwcDoKKyAgICAgICAg KFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0TWVudUF0UG9pbnQpOgorICAgICAgICAqIFdlYlByb2Nl c3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlUHJpdmF0ZS5oOgorCiAyMDEzLTA0 LTA0ICBTemUgSG93ZSBLb2ggIDxzemVob3dlLmtvaEBnbWFpbC5jb20+CiAKICAgICAgICAgW1F0 XSBkb2NzOiBGaXggbW9kdWxlIG5hbWUgZm9ybWF0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5j cHAKaW5kZXggYTUzZTIyNi4uYmE2NTcwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmNw cApAQCAtMTYzLDYgKzE2MywyNyBAQCBXS0FycmF5UmVmIFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0 TWVudUl0ZW1UaXRsZXMoV0tCdW5kbGVQYWdlUmVmIHBhZ2VSZWYpCiAjZW5kaWYKIH0KIAorV0tB cnJheVJlZiBXS0J1bmRsZVBhZ2VDb3B5Q29udGV4dE1lbnVBdFBvaW50KFdLQnVuZGxlUGFnZVJl ZiBwYWdlUmVmLCBXS1BvaW50IHBvaW50KQoreworI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQor ICAgIFdlYkNvbnRleHRNZW51KiBjb250ZXh0TWVudSA9IHRvSW1wbChwYWdlUmVmKS0+Y29udGV4 dE1lbnVBdFBvaW50KHRvSW50UG9pbnQocG9pbnQpKTsKKyAgICBpZiAoIWNvbnRleHRNZW51KQor ICAgICAgICByZXR1cm4gMDsKKworICAgIGNvbnN0IFZlY3RvcjxXZWJDb250ZXh0TWVudUl0ZW1E YXRhPiYgaXRlbXMgPSBjb250ZXh0TWVudS0+aXRlbXMoKTsKKyAgICBzaXplX3QgYXJyYXlMZW5n dGggPSBpdGVtcy5zaXplKCk7CisKKyAgICBSZWZQdHI8TXV0YWJsZUFycmF5PiBtZW51QXJyYXkg PSBNdXRhYmxlQXJyYXk6OmNyZWF0ZSgpOworICAgIG1lbnVBcnJheS0+cmVzZXJ2ZUNhcGFjaXR5 KGFycmF5TGVuZ3RoKTsKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYXJyYXlMZW5ndGg7 ICsraSkKKyAgICAgICAgbWVudUFycmF5LT5hcHBlbmQoV2ViQ29udGV4dE1lbnVJdGVtOjpjcmVh dGUoaXRlbXNbaV0pLmdldCgpKTsKKyAgICAKKyAgICByZXR1cm4gdG9BUEkobWVudUFycmF5LnJl bGVhc2UoKS5sZWFrUmVmKCkpOworI2Vsc2UKKyAgICByZXR1cm4gMDsKKyNlbmRpZgorfQorCiB2 b2lkKiBXS0FjY2Vzc2liaWxpdHlSb290T2JqZWN0KFdLQnVuZGxlUGFnZVJlZiBwYWdlUmVmKQog ewogI2lmIEhBVkUoQUNDRVNTSUJJTElUWSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlUHJpdmF0ZS5oIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2VQ cml2YXRlLmgKaW5kZXggMGY5NDA5MS4uOTYwMjVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2VQcml2YXRlLmgK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1 bmRsZVBhZ2VQcml2YXRlLmgKQEAgLTc4LDYgKzc4LDcgQEAgV0tfRVhQT1JUIHZvaWQqIFdLQWNj ZXNzaWJpbGl0eVJvb3RPYmplY3QoV0tCdW5kbGVQYWdlUmVmKTsKIFdLX0VYUE9SVCB2b2lkKiBX S0FjY2Vzc2liaWxpdHlGb2N1c2VkT2JqZWN0KFdLQnVuZGxlUGFnZVJlZik7CiAKIFdLX0VYUE9S VCBXS0FycmF5UmVmIFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0TWVudUl0ZW1UaXRsZXMoV0tCdW5k bGVQYWdlUmVmKTsKK1dLX0VYUE9SVCBXS0FycmF5UmVmIFdLQnVuZGxlUGFnZUNvcHlDb250ZXh0 TWVudUF0UG9pbnQoV0tCdW5kbGVQYWdlUmVmLCBXS1BvaW50KTsKIAogI2lmZGVmIF9fY3BsdXNw bHVzCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK aW5kZXggNWRmODU3Zi4uNmRiMDhlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMTQ1NCw2ICsxNDU0LDE5IEBAIFdlYkNvbnRleHRNZW51 KiBXZWJQYWdlOjpjb250ZXh0TWVudSgpCiAgICAgICAgIG1fY29udGV4dE1lbnUgPSBXZWJDb250 ZXh0TWVudTo6Y3JlYXRlKHRoaXMpOwogICAgIHJldHVybiBtX2NvbnRleHRNZW51LmdldCgpOwog fQorCitXZWJDb250ZXh0TWVudSogV2ViUGFnZTo6Y29udGV4dE1lbnVBdFBvaW50KGNvbnN0IElu dFBvaW50JiBwb2ludCkKK3sKKyAgICBjb3JlUGFnZSgpLT5jb250ZXh0TWVudUNvbnRyb2xsZXIo KS0+Y2xlYXJDb250ZXh0TWVudSgpOworICAgIAorICAgIC8vIFNpbXVsYXRlIGEgbW91c2UgY2xp Y2sgdG8gZ2VuZXJhdGUgdGhlIGNvcnJlY3QgbWVudS4KKyAgICBQbGF0Zm9ybU1vdXNlRXZlbnQg bW91c2VFdmVudChwb2ludCwgcG9pbnQsIFJpZ2h0QnV0dG9uLCBQbGF0Zm9ybUV2ZW50OjpNb3Vz ZVByZXNzZWQsIDEsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCBjdXJyZW50VGltZSgpKTsK KyAgICBib29sIGhhbmRsZWQgPSBjb3JlUGFnZSgpLT5tYWluRnJhbWUoKS0+ZXZlbnRIYW5kbGVy KCktPnNlbmRDb250ZXh0TWVudUV2ZW50KG1vdXNlRXZlbnQpOworICAgIGlmICghaGFuZGxlZCkK KyAgICAgICAgcmV0dXJuIDA7CisKKyAgICByZXR1cm4gY29udGV4dE1lbnUoKTsKK30KICNlbmRp ZgogCiAvLyBFdmVudHMgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuaAppbmRleCAzZGYwYmY1Li4wNGQwNGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTQwOCw2ICs0MDgsNyBAQCBwdWJsaWM6CiAKICNpZiBF TkFCTEUoQ09OVEVYVF9NRU5VUykKICAgICBXZWJDb250ZXh0TWVudSogY29udGV4dE1lbnUoKTsK KyAgICBXZWJDb250ZXh0TWVudSogY29udGV4dE1lbnVBdFBvaW50KGNvbnN0IFdlYkNvcmU6Oklu dFBvaW50Jik7CiAjZW5kaWYKICAgICAKICAgICBib29sIGhhc0xvY2FsRGF0YUZvclVSTChjb25z dCBXZWJDb3JlOjpLVVJMJik7Cg==